Commit Graph

83004 Commits

Author SHA1 Message Date
Jon Miranda ab0372e767 Clear overlay when swiping up to unstash taskbar.
Once taskbar is unstashed, the user cannot return back to the overlay. We can
clear it here to set the expected state once the user goes home.

Fixes: 359096594
Test: open -1, launch app, go home
Flag: EXEMPT bugfix
Change-Id: I8059c2c45f10d15701ff2961480aef002d273a06
2024-09-18 20:42:38 +00:00
Treehugger Robot 1880988d5f Merge "Make AllSetActivity IDP change-aware" into main 2024-09-18 19:21:18 +00:00
Sunny Goyal 2a359916ca Moving some utility class to IconCache to make it easier to use outside Launcher
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I7583ae162b652e73a33f1aee76714e292b707e39
2024-09-18 10:05:05 -07:00
Brandon Dayauon 77374930a7 Fix fastscroller not resetting when switching tabs.
Whenever fastscroller is binded, reset the scroll position so its at the top.

bug: 335520751
Test video manually:
before:https://drive.google.com/file/d/1MOE0LOL8G5pmhJYf61y9jw2nDVXIvaAs/view?usp=sharing
after: https://drive.google.com/file/d/14Yi6JRMvDhDZKNwusv75DtfeGk1A4W23/view?usp=sharing
Flag: NONE bugfix

Change-Id: I7aea9a7fe5582fbb61e979f375191980c8a7e0ad
2024-09-18 10:01:22 -07:00
Schneider Victor-Tulias e57c034554 Make AllSetActivity IDP change-aware
Flag: EXEMPT bug fix
Fixes: 366129654
Test: adb shell cmd overlay enable-exclusive --category com.android.internal.systemui.navbar.threebutton while in AllSetActivity
Change-Id: I42dec6a94bf445866828b7404ae5451d505fda02
2024-09-18 10:22:23 -04:00
Liran Binyamin c2c7913134 Merge "Create BubbleBarFlyoutView" into main 2024-09-18 14:21:26 +00:00
Treehugger Robot 10505cdb7e Merge "Revert^2 "Use ConcurrentHashMap to make private maps thread safe"" into main 2024-09-18 12:40:32 +00:00
Toshiki Kikuchi 6ddfe9b179 Allow to show pinned taskbar when Launcher is visible
This CL allows freeform-first devices to lock the taskbar in a pinned
state when Launcher is visible.

Bug: 361419732
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual

Change-Id: Ic0d2740e33fee19c676d88aa2bcf370eb64366e8
2024-09-18 10:49:52 +00:00
Alex Chau 0033148ef0 Only call reset() when transitioning to a State that doesn't have RecentView visible
- Changes to BaseRecentsViewStateController/FallbackRecentsStateController to avoid calling reset when canceling transitioniong to a RecentsView visible state (e.g. canceling Overivew -> OverivewModal)
- Changes to LauncherRecentsView/FallbackRecentsView to have a consistent check in deciding if we should reset on transition finished
- Note: With 3P Launcher, there is an existing issue that isn't fix by this change: While in Overview or Split select, tap empty space to dismiss Recentsview, then immediately swipe up, Overview tiles will be blank. This is because the swipe up isn't a "brand new" gesture and doesn't call onGestureAnimationStart, so it does not reload thumbnails after the reset in animation cancels.

Fix: 359872614
Test: Reproduction steps in b/246232494, b/243471493, b/242715097 and b/359872614
Test: Trasitionoing between Normal,Hint,Overview,OverivewModal,QuickSwitch etc., and which Home/Back gesture in between to cancel the transitions; repeat the test with 3P Launcher
Flag: EXEMPT BUG_FIX
Change-Id: I86dd0c070196c9a7ce3269599811b7537dd4da37
2024-09-18 10:23:03 +01:00
Uwais Ashraf 4c045988c1 Revert^2 "Use ConcurrentHashMap to make private maps thread safe"
This reverts commit f480cf371a.

Reason for revert: not the cause of b/367736714

Change-Id: If9b400c5474d9ec51f51f1de86c80b9337857fac
2024-09-18 05:47:29 +00:00
Mykola Podolian 13ffcc7242 Merge "Unstash hotseat immediately if go out of the launcher home." into main 2024-09-18 04:17:14 +00:00
Treehugger Robot 24594ce0af Merge "Add taskbar_quiet_mode_change_support flag to launcher.aconfig" into main 2024-09-18 01:17:25 +00:00
Android Build Coastguard Worker 63404ff75a Snap for 12378824 from 2a82a901c2 to 24Q4-release
Change-Id: I71770135517bf585555171ea32b0b8bf9b4e7044
2024-09-17 23:23:02 +00:00
Brandon Dayauon c5941bf802 Merge "Allow haptics to play when fastscrolling private space apps." into main 2024-09-17 23:06:22 +00:00
mpodolian bf7a4db0de Unstash hotseat immediately if go out of the launcher home.
When navigation mode is set to 3 buttons, it is possible for user to
click on recent apps button, so for such scenario taskbar should be
immediately un-stashed

Test: Manual
Set 3 buttons navigation mode. Go to Launcher home. Expand bubble bar.
Press recent apps button. Press the home button. Observe hotseat is
visible. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fX0gSp18Riw8mYYAw0wj8W

Bug: 367488218
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id65fd9add720125a340294311d470f2be50d43f8
2024-09-17 15:47:42 -07:00
Brian Isganitis e9d9f34265 Add taskbar_quiet_mode_change_support flag to launcher.aconfig
Change-Id: I04431e95ae7ed9d6be17f6a11cb4d963be2cb499
Test: go/testedequals
Bug: 345760034
Flag: com.android.launcher3.taskbar_quiet_mode_change_support
2024-09-17 22:19:00 +00:00
George Lin b72dc07489 Merge "Wait for device profile reload" into main 2024-09-17 21:30:18 +00:00
Priyanka Advani (xWF) 2a82a901c2 Merge "Revert "Use ConcurrentHashMap to make private maps thread safe"" into main 2024-09-17 20:00:08 +00:00
Priyanka Advani (xWF) f480cf371a Revert "Use ConcurrentHashMap to make private maps thread safe"
This reverts commit d511538361.

Reason for revert: Droidmonitor created revert due to b/367736714. Will be verifying through ABTD before submission.

Change-Id: I01281bd48c4ba7d07dc0308c504f21aad751ea44
2024-09-17 18:45:46 +00:00
Mykola Podolian bff3b73c8f Merge "Hide hotseat when bubble bar is expanded." into main 2024-09-17 17:38:33 +00:00
Treehugger Robot d60904d573 Merge "Add perfetto traces to LauncherInstrumentation" into main 2024-09-17 17:12:21 +00:00
Treehugger Robot 545440327d Merge "Update out-of-date TODO comment" into main 2024-09-17 16:25:49 +00:00
Liran Binyamin 36b5ef2271 Create BubbleBarFlyoutView
Initial version of the flyout view for displaying bubble bar
notification.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I5d0643fe5d2691ad2349b45eaaad6cd2660d9df0
2024-09-17 11:14:54 -04:00
helencheuk 5012640ab2 [Contextual Edu] Update Edu stats when going to overview and all apps from home
Update education stats when
- go overview and all apps by swiping up at homepage (AbstractStateChangeTouchController)
- go home from all apps by swiping down the all apps panel (AbstractStateChangeTouchController)
- go home from all apps or overview by swiping up from the bottom nav bar (NavBarToHomeTouchController)
- in 3 button navgiation mode (TaskbarNavButtonController)

NavBarToHomeTouchController does not inherit from AbstractStateChangeTouchController so logic are added separately.

Bug: 363480554
Test: TaskbarNavButtonControllerTest
Flag: com.android.systemui.keyboard_touchpad_contextual_education
Change-Id: I0662704a9093b9f5a4d2f086a8297429fbc49881
2024-09-17 16:00:24 +01:00
Uwais Ashraf 4cf24115ab Merge "Use ConcurrentHashMap to make private maps thread safe" into main 2024-09-17 14:54:48 +00:00
Uwais Ashraf d511538361 Use ConcurrentHashMap to make private maps thread safe
Also synchronize listener un/registering to prevent accumulation of listeners

Fix: 365068571
Test: presubmit crash detector not triggered
Test: TaskVisualsChangedDelegateTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ib15f44d8bca0e24173db3a16bc9184e73e30f4b4
2024-09-17 14:54:08 +00:00
George Lin b31f1452f1 Wait for device profile reload
Test: Manually tested the option updated after apply
Bug: 348664593
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I795b95407483a730ee22a184a6db96f64f6ee829
2024-09-17 14:15:21 +00:00
Schneider Victor-Tulias 0a815eae39 Update out-of-date TODO comment
These TODO comments will be adressed by b/342627272, so b/326565120 should be closed.

Flag: EXEMPT comment update
Bug: 326565120
Bug: 342627272
Test: none needed, comment update
Change-Id: I75637e1494a1abba5c542a292a8a1e8881cbedfc
2024-09-17 10:13:16 -04:00
Treehugger Robot 4f7ac81e3f Merge "Skipping testPrivateSpaceLockingBehaviour for LS devices." into main 2024-09-17 10:52:56 +00:00
Treehugger Robot 25d7972151 Merge "Reland "Separate desktop and fullscreen carousel"" into main 2024-09-17 10:04:51 +00:00
Himanshu Gupta edebee564f Skipping testPrivateSpaceLockingBehaviour for LS devices.
Skipping the test until we fix the root cause of failure
on LS devices.
Also removing ScreenRecord from now passing tests.

Bug: 355466672, 367258373
Fix: 334946529
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest#testPrivateSpaceLockingBehaviour
Flag: TEST_ONLY
Change-Id: Ia0d43386e70b8584b8c77d541abd16cbd5e64741
2024-09-17 09:19:58 +00:00
Nicolo' Mazzucato 2e3d304273 Add perfetto traces to LauncherInstrumentation
This will help understanding what's taking time in those tests, and optimize the runtime to add more perfromance tests to presubmits.

Bug: 332823157
Test: perfetto trace
Flag: NONE adding traces
Change-Id: I806c2cd103ff58a4467e48b3da5e95f7f51743f3
2024-09-17 08:06:38 +00:00
Sunny Goyal e14032d578 Merge "Cleaning up some enabled features" into main 2024-09-17 03:22:23 +00:00
Treehugger Robot 7b50f9189a Merge "Migrate ENABLE_ALL_APPS_BUTTON_IN_HOTSEAT to launcher.aconfig" into main 2024-09-17 02:44:18 +00:00
Treehugger Robot a2dd2d2b28 Merge "Fix an issue where the bubble bar was visible after theme change" into main 2024-09-17 02:02:21 +00:00
Mady Mellor e736b9c0c5 Fix an issue where the bubble bar was visible after theme change
Don't set the alpha to 1 in the drag reset method unless the bar
is actually expanded.

When theme changes, everything gets recreated... so the location of
the bubble bar gets set which triggers drag reset which would make
the bar visible when it shouldn't be.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - have bubbles in app (stashed), change theme, observe
               that bubbles are not visible
             - test dragging bubbles from left  to right via expanded
               view, individual bubble, and collapsed stack
Bug: 358304168 (not exact bug but noted in the video of comment#13)
Change-Id: I291cdb206532efe386684e36a78b9d66018f3cb1
2024-09-16 16:59:09 -07:00
Android Build Coastguard Worker 5573a87870 Snap for 12373988 from 9c749aaf2d to 24Q4-release
Change-Id: I3fce207ab87e1f637837f3c245f35b9e3aecef9e
2024-09-16 23:21:28 +00:00
Liran Binyamin 69f4974e24 Hide hotseat when bubble bar is expanded.
Added logic to stash the hotseat when on launcher home screen.

Bug: 280494203
Test: Manual:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fjfjUw296LRXUm9uYqXU4K
all tests in com.android.launcher3.taskbar
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I67b298831eaed9c549a2fae7dc5a0d9fae51f7c4
2024-09-16 15:50:28 -07:00
Jon Miranda aec1e05be5 Migrate ENABLE_ALL_APPS_BUTTON_IN_HOTSEAT to launcher.aconfig
Flag: com.android.launcher3.enable_all_apps_button_in_hotseat
Test: N/A
Bug: 270393897
Change-Id: Ib62a2f46a440d8f0d3f569c09c4f8754715db4ee
2024-09-16 22:00:39 +00:00
Treehugger Robot 98d85d6dc0 Merge "Revert "Add screenrecord to testDragIconToPage2"" into main 2024-09-16 21:50:40 +00:00
Mykola Podolian 56cda496c6 Merge "Update placement of the nav bar in persistent taskbar for 3 button nav" into main 2024-09-16 21:49:54 +00:00
Federico Baron 9045632654 Revert "Add screenrecord to testDragIconToPage2"
This reverts commit cf55a30dcf.

Reason for revert: no longer needed

Change-Id: I08a9a0c90e1298d7206c7544de08b557fd89b58e
2024-09-16 20:03:10 +00:00
Bill Yi 9c749aaf2d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-16 19:03:32 +00:00
Bill Yi 95ac9c17fa Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-16 19:03:32 +00:00
Brandon Dayauon 57c77eb4c6 Allow haptics to play when fastscrolling private space apps.
LinearSmoothScrolling only happens when there is a new section to scroll to. Instead of playing haptics
when sectionInfo changes, only play haptics during smooth scrolling.

bug: 359658099
Test: Manually tested, video wouldn't help since I am testing haptics
Flag: NONE bugfix
Change-Id: I96c911b4d2d201d0d953a9619a97979759a02427
2024-09-16 10:55:02 -07:00
Sunny Goyal 98001dd1dc Merge "Migrating prediction_undo to aconfig" into main 2024-09-16 17:26:58 +00:00
Ats Jenk 29496de39d Merge "Show bubble bar when hotseat icons are visible" into main 2024-09-16 15:41:03 +00:00
Charlie Anderson ccd58ab97b Merge "Add additonal logging around PackageUpdatedTask to detect app updates for User" into main 2024-09-16 13:39:59 +00:00
Liran Binyamin 34351f690e Merge "Fix bubble tx when the bar is collapsed" into main 2024-09-16 13:31:56 +00:00
Treehugger Robot 34b535c76d Merge "Don't wait for thumbnails to update if updatedThumbnails are empty" into main 2024-09-16 12:57:12 +00:00