Commit Graph

83004 Commits

Author SHA1 Message Date
Jagrut Desai a9095ca0c8 Merge "Fix launching app animation from launcher all apps." into main 2024-11-15 22:43:39 +00:00
Tony Wickham 5903216275 End icon alignment early when touching down during 3 button anim to home
This will allow Hotseat to handle the touch during the transition.

Test: manually touch Hotseat in pinned/transient/3-button taskbar during
the transition to home, ensure Hotseat handles it in all cases
Flag: EXEMPT bug fix
Fixes: 368419997

Change-Id: I3d998876ed4d8423bdb4fd48fa0d55f719da8d01
2024-11-15 22:17:50 +00:00
fbaron cdde399a00 Add new heuristic for deciding whether we should add extra rows on grid migration to the bottom or top of the grid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: GridSizeMigrationTest
Change-Id: I070ed1eddc2c7ab475267268ebdbb2e559ab6dda
2024-11-15 13:44:01 -08:00
Charlie Anderson 859c793b6b Clean up usage of FileLog, and some logging related to B&R
Bug: 378684472
Test: N/A just logs
Flag: EXEMPT just logs
Change-Id: Ie2de7b700862b1439adc0c44d684b3864469014a
2024-11-15 16:38:27 -05:00
Sunny Goyal 5f8e2d7c13 Migrating widgets tests off TAPL
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I6e9ffb3dee913617ca9ad897504e8457cfbdccd6
2024-11-15 12:45:27 -08:00
Brian Isganitis 01eb1e037b Add annotation to simulate RTL in tests.
Flag: TEST_ONLY
Bug: 230027385
Test: go/testedequals
Change-Id: Idc4ca404179359a6dc4fac160b7a865c5709f137
2024-11-15 15:09:37 -05:00
Ana Salazar Maldonado 3c44a029be Draw contrast tile around the text
If the BubbletTextView should have an app contrast tile, account for
some padding between the tile and the text when measuring the view, so
that the text is guaranteed to be inside of the bubble.  In a similar
way, recalculate the bounds of the tile to only surround the app title
as needed.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I9e8b149ade3fa4522e62b89c2332195f648b190f
2024-11-15 10:14:13 -08:00
Sebastián Franco 856b462160 Merge "The test IntegrationReorderWidgetsTest was using the oposite dimensions" into main 2024-11-15 17:20:06 +00:00
Marcelo Arteiro fede690863 Merge "Aligning Android color tokens with Material" into main 2024-11-15 14:50:53 +00:00
Johannes Gallmann c87d41f369 Never scale navbar scrim in all apps and widget picker
The navbar scrim is scaled during the predictive back animation. This should be prevented since the navbar itself does not change it's position or scale.

Bug: 373544911
Test: Manual, i.e. verifying that the navbar scrim remains in its original position during the predictive back animation (with 3-button-nav) on phones and tablets
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: Iaffd31de5493dea8c856ad3d5b441cca066bbad8
2024-11-15 11:00:30 +00:00
Saumya Prakash 52866fc596 Merge "Add Manage Windows option to Taskbar long press menu" into main 2024-11-15 08:57:49 +00:00
Saumya Prakash dbaf1028db Add Manage Windows option to Taskbar long press menu
This change adds an option to the long press menu on Taskbar apps to
view open instances of the calling apps. It will only show on apps that
support multi instance (ex. Chrome).

Bug: 315989246
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie1e001c4cec831c751bcbf448aaa68bb90fb24ca
2024-11-15 06:34:28 +00:00
Sebastian Franco 531a219ba7 The test IntegrationReorderWidgetsTest was using the oposite dimensions
The order of the columns shold be inversed, it hasn't been much of an
issue because most of the test cases where of equal size 5x5 and 4x4.

Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: IntegrationReorderWidgetsTest
Change-Id: I5de3f63edbb6b446352ce97226e39fb29cdb1439
2024-11-14 20:39:55 -08:00
Sebastian Franco 394a7e64f8 Changing name of RowCount to GridDimension to be more general
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I7ca46babf0c4ce647a4c98a7dd0326b35450479f
2024-11-14 18:58:16 -08:00
Sebastián Franco 3b62b22651 Merge "Dissable allow rotation when oneGridSpecs flag is on" into main 2024-11-15 00:47:12 +00:00
Android Build Coastguard Worker f1eaa1bd95 Snap for 12658558 from 5d438685eb to 25Q1-release
Change-Id: I616fcc4cb193dd7de9949bf2ac745c2cca1d26b6
2024-11-15 00:16:51 +00:00
Jagrut Desai b03d9393ce Merge "Fix TaskbarAllApps and TaskbarDivider contianer talkback annoucement" into main 2024-11-15 00:05:43 +00:00
Jagrut Desai 8a9e7a1dfd Merge "Fix 3-button Navigation Switch Access Long press" into main 2024-11-15 00:05:08 +00:00
Jagrut Desai 596594c684 Fix launching app animation from launcher all apps.
This cl includes
	- making pinned taskbar animate slide in/out animation from bottom of screen.
        - no icon aligment with hotseat when taksbar is pinned

The solution
	- upon state change applied on TaskbarLauncherStateController. offset taskbar background and icons to bottom of screeen and animate with slide in/out effects.

Test: manual, presubmit
Bug: 314279101
Flag: EXEMPT bugfix

Change-Id: Ife336ebd57eb2f60c2bc33ed6a4527c42111808f
2024-11-14 15:51:50 -08:00
Brandon Dayauon fc61ab973b Add perfetto traces to privateProfile CUJs
These traces cover onBind() and animation calls.

bug: 356777068
Test: screenshot of perfetto trace https://screenshot.googleplex.com/43tbo8fJrvTMUft
Flag: NONE adding traces
Change-Id: I06c322266ccb7ee9d940969f952aaaeb1b53c78b
2024-11-14 15:34:09 -08:00
Treehugger Robot 7bf8675679 Merge "Fixing LauncherAppCompoent not available for isolated context" into main 2024-11-14 22:24:00 +00:00
Treehugger Robot 90c4e9e62b Merge "Fix hotseat layout on device rotation." into main 2024-11-14 22:10:32 +00:00
Jagrut Desai 1ba1f7282b Fix TaskbarAllApps and TaskbarDivider contianer talkback annoucement
This cl includes
	- setting content description on new taskbar containers for all apps and divider line, so their announcement is clear to user and not unlabelled.

Test: Manual
Bug: 378855202
Bug: 378845796
Flag: EXEMPT bugfix
Change-Id: I4650d1960a6208189b08b16ff541b2af3ed94cb3
2024-11-14 14:00:57 -08:00
Sebastian Franco 52ae78d11b Dissable allow rotation when oneGridSpecs flag is on
Flag: com.android.launcher3.one_grid_specs
Test: IntegrationReorderWidgetsTest
Bug: 378956572
Change-Id: I41e591b6d8fa1f93e2034a784516d5a38e83cbd9
2024-11-14 21:53:38 +00:00
Sunny Goyal 1c5c137353 Merge "Separating TAPL functionality from AbstractLauncherUiTest into a separate base class" into main 2024-11-14 21:11:58 +00:00
Treehugger Robot b9cd487c86 Merge "Remove redundant a11y announcement upon removal of workspace item." into main 2024-11-14 21:04:04 +00:00
Sunny Goyal 5861ee437a Fixing LauncherAppCompoent not available for isolated context
In those cases, creating a new LauncherAppCompoent and storing it in
the application context

Bug: 372180905
Test: atest LauncherComponentProviderTest
Flag: EXEMPT bugfix
Change-Id: Ibf517a23801138b1fa18e8e4a7adbdedb994365b
2024-11-14 12:34:26 -08:00
William Leshner 5d438685eb Merge "Fix permission issue with START_WIDGET_PICKER_ACTIVITY" into main 2024-11-14 20:34:16 +00:00
Jagrut Desai a9b502b464 DesktopMode Entry/Exit Signals
This cl includes
	- adding callback support for entering/exiting DesktopMode on launcher side.

Test: Presubmit
Bug: 343882478
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib86746e6cca42dcdbb181d5323715a24c722f004
2024-11-14 12:02:13 -08:00
Schneider Victor-tulias a8dd1a90df Merge "Update RecentsWindowSwipeHandler to animate home->overview properly" into main 2024-11-14 19:44:13 +00:00
Jagrut Desai 48793e1fcd Fix 3-button Navigation Switch Access Long press
This cl includes
 - Make long press of back navigation button of 3 button navigation mode behave just like short press.

Test: Manual
Bug: 315723734
Flag: EXEMPT bugfix
Change-Id: Id897c84dcb33f73174ea907c5ab5655d2ac5ba10
2024-11-14 11:27:14 -08:00
Treehugger Robot 1297e9eb98 Merge "Change fallback closing animators for Desktop Mode." into main 2024-11-14 18:23:01 +00:00
Wen-chien Wang c88bf60259 Merge "Add a flag for the context menu to pin/unpin apps on taskbar." into main 2024-11-14 17:50:08 +00:00
Pinyao Ting 556db6df04 Remove redundant a11y announcement upon removal of workspace item.
When a workspace item is removed, launcher currently shows a Snackbar which contains a message saying "item removed". This renders the a11y announcement in DeleteDropTarget#onAccessibilityDrop redundant since it's saying exactly the same string.


Bug: 378032433
Change-Id: I6eda4bb449f1d1fd4441a68b3129b0ab2d2c19a3
Test: manual
Flag: EXEMPT bugfix
2024-11-14 17:29:26 +00:00
Liana Kazanova (xWF) 94f4f1bcf3 Merge "Revert "Listen to LauncherUserInfo config changes and hide/unhid..."" into main 2024-11-14 17:27:31 +00:00
Gustav Sennton 8e4cae1258 Change fallback closing animators for Desktop Mode.
The main changes are:
1. the amount to move the window horizontally (much less for Desktop
Mode), and
2. the timing for when the alpha animation is applied - we remove the
   25ms delay for freeform windows.

Bug: 378675987
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_exit_transitions
Change-Id: Ieeb6b827eee2e6314ea9c79213cdf401f48d3c85
2024-11-14 16:26:07 +00:00
Sebastián Franco 60f2aa328a Merge "Dissable fixed landscape on foldables until fixed b/378972567" into main 2024-11-14 16:25:51 +00:00
Treehugger Robot 55c2aca78e Merge "Updates layout when overflow button and alt-tab are both triggered." into main 2024-11-14 16:13:54 +00:00
Fengjiang Li 8fa1dcdc03 Revert "Revert AllAppsRecyclerViewPoolTest.kt"
This reverts commit 6554ab99e3.

Reason for revert: Since ag/28600866 was the real fix of b/354560500, we should restore the AllAppsRecyclerViewPoolTest.kt

Fix: 359247985
Test: Presubmit
Flag: NONE - released

Change-Id: I54c3a4d15ec5a9e96cd03c465d10898ef6ac2078
2024-11-14 16:21:07 +08:00
Pechetty Sravani (xWF) 41743bd0c7 Revert "Listen to LauncherUserInfo config changes and hide/unhid..."
Revert submission 29352757-update-usericoninfo

Reason for revert: <DroidMonitor created revert due to b/379000263. Will be verified through ABTD for standard investigation.>

Reverted changes: /q/submissionid:29352757-update-usericoninfo

Change-Id: I751536274ec9dcc4047bf9c76b3a5cab258da6e4
2024-11-14 06:11:15 +00:00
mpodolian b563271ff5 Fix hotseat layout on device rotation.
When rotating the device, a few issues were causing improper hotseat
layout:

- BubbleBarController receives an initial configuration before the UI
controller is set.
- The updated device profile, including the correct `isQsbInline` value,
arrives after all controllers are recreated, and the UI controller is
not informed of the device profile update.

Added logic to carry over the bubble bar bubble visibility state to the
new UI controller. Included a call to notify the UI controller of the
device profile update.

Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Have a Tangor device in landscape orientation with the
bubble bar. Rotate the device - observe hotseat and QSB are reduced in
width. Dismiss the bubble bar - observe hotseat and QSB extends to the
full width.
video: http://recall/-/gx8ASgewUeUS3QYohfrd1J/e8e1ZFRQlbHQtUlCXVJbFJ

Change-Id: If180b01c8cdb329cd45d084af63a986c08cf65a1
2024-11-13 17:41:17 -08:00
Sebastian Franco b83ea0203b Dissable fixed landscape on foldables until fixed b/378972567
Bug: 378972567
Flag: com.android.launcher3.one_grid_specs
Test: IntegrationReorderWidgetsTest
Change-Id: I1125d7d4a1dfba38fa8f05fe1cbc910ede24a1f5
2024-11-13 17:27:55 -08:00
Sunny Goyal cac373ce91 Separating TAPL functionality from AbstractLauncherUiTest into a separate base class
This will make it easier to get rid of AbstractLauncherUiTest by directly depending on the base class

Bug: 377772352
Test: Presubmit
Flag: EXEMPT test infra
Change-Id: I46ceb188ed4b64d4fb86236969ed0d3f23809000
2024-11-13 16:27:22 -08:00
Android Build Coastguard Worker b80bf3996c Snap for 12651823 from 6f10fb57a4 to 25Q1-release
Change-Id: I3a73d427a5922ef3882971fe55b72aa89662e2eb
2024-11-14 00:16:37 +00:00
Xin Li 31f5c3c5cd [automerger skipped] Merge 24Q4 (ab/12406339) into aosp-main-future am: 9a9e10609d -s ours
am skip reason: Merged-In Id70ceed141e2106f746d4a0e68a09675ba45dd28 with SHA-1 9c09196dfd is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/30283672

Change-Id: Ib83e9eb3b5c75912b329391a3aab99747efb6b0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-11-14 00:05:44 +00:00
Olivier Nshimiye 0b2cb4961c Merge "Listen to LauncherUserInfo config changes and hide/unhide private space entrypoint accordingly" into main 2024-11-14 00:03:34 +00:00
Treehugger Robot 85f34826f1 Merge "4b/ Migrate TopTaskTracker to use visible running tasks from Shell" into main 2024-11-13 23:47:27 +00:00
Treehugger Robot 8a0d3fd363 Merge "Test KQS gets dismissed in certain situations" into main 2024-11-13 23:26:46 +00:00
Shamali Patwa 780ce64f68 Merge "Don't bind scrollbar if current recycler view isn't changed." into main 2024-11-13 22:51:04 +00:00
Maryam Dehaini 1fbb98e057 Set task corner radius to match spec
The task bar sets the corner radius of maximized tasks in desktop
windowing. This change updates the corner radius to match the most
recent spec.

Bug: 369592605
Test: manual testing
Flag: EXEMPT bugfix
Change-Id: I87bbaaf262f30e95fe1760d2dad51a890efca4c1
2024-11-13 14:00:33 -08:00