Commit Graph

83004 Commits

Author SHA1 Message Date
Gustav Sennton c06d6845e4 Merge "Override desktop tasks corner radius during recents transition" into main 2025-01-09 03:33:29 -08:00
Alex Chau cb50273ad0 Merge changes Ic571a506,I0877cff7 into main
* changes:
  Reland "Introduce `mTaskViewCount` inside the RecentsView"
  Run the given callback only inside `runOnPageScrollsInitialized`
2025-01-09 02:49:23 -08:00
Alex Chau b4183ee9ce Merge "Add test to open Desktop with fullsreen live tile" into main 2025-01-09 02:47:56 -08:00
samcackett 318e9184c8 Don't use announceForAccessibility in RecentsView
According to accessibility guidelines, we shouldn't be using this API and definitely not for notifying a user a task has closed, so just removing this use case altogether.

Fix: 386001961
Test: Enable Talkback.
  Open some apps.
  Go to Overview and dismiss an app.
  Talkback shouldn't announce "Task closed".
Flag: EXEMPT bugfix

Change-Id: I1a55017cbd4825103b9a8b93532b06276f28aef6
2025-01-09 01:09:51 -08:00
Treehugger Robot 61b805709c Merge "Ensure split screen cancel label doesn't wrap" into main 2025-01-08 23:31:53 -08:00
Riddle Hsu a584c24493 Wait for launcher state before proceeding next test step
Otherwise if scrollToAppIcon is called immediately, it could
interrupt the state that causes the test to be unable to drag
the icon into workspace.

Fix: 388510107
Flag: TEST_ONLY
Test: atest Launcher3Tests:ThemeIconsTest#testIconWithoutTheme
Change-Id: Ied77b3f8d2f19de18d054a80643f3d13c5641ac4
2025-01-09 12:58:39 +08:00
Treehugger Robot c0db036ea8 Merge "Use system configured font weight" into main 2025-01-08 20:41:18 -08:00
Sebastián Franco 4d0f53b478 Merge "Promote ReorderAlgorithmUnitTest since it's not failing anymore" into main 2025-01-08 19:35:42 -08:00
Treehugger Robot dbbedf9e62 Merge "Add ScreenRecord to difficult to flaky test TaplDragTest.testDragToFolder" into main 2025-01-08 18:54:12 -08:00
mpodolian db7aa238a0 Fix bubbles animation when the new bubble added and old bubble removed.
The AddingAndRemoving animation now uses a newly selected bubble index
and added bubble index arguments.

Test: BubbleAnimatorTest
Test: Manual. Enable optional overflow bubble.
Create a bubble bar with overflow containing a single
bubble. Open the overflow menu and click an overflow bubble icon.
Observe that a new bubble is added and immediately expands while the
overflow bubble is collapsing. Observe that bubbles animation.
Test: Manual. Have few bubbles in the bubble bar. Collapse any bubble.
Observe bubbles are animated correctly.
Video: (slowed down 10 times)
http://recall/-/gx8ASgewUeUS3QYohfrd1J/emOREYETIeV5ktcNZLETYa

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359952121
Change-Id: If2366ec12cb196757ba6439c5c9306959d4191a9
2025-01-08 17:50:36 -08:00
mpodolian 631da72a2a Fix arrow animation when the new bubble added and old bubble removed.
The AddingAndRemoving animation now uses a newly selected bubble index
and added bubble index arguments.

Test: BubbleAnimatorTest
Test: Manual. Enable optional overflow bubble.
Create a bubble bar with overflow containing a single
bubble. Open the overflow menu and click an overflow bubble icon.
Observe that a new bubble is added and immediately expands while the
overflow bubble is collapsing. Observe that the arrow animates to the
new bubble's position.
Test: Manual. Have few bubbles in the bubble bar. Collapse any bubble.
Observe arrow animated correctly to the newly selected bubble position.
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 359952121

Change-Id: I8321e2f532189e7599b029083199e034e38080e3
2025-01-08 17:26:06 -08:00
Treehugger Robot b49023dc3b Merge "Move all db calls for grid migration inside a SQLiteTransaction" into main 2025-01-08 16:56:24 -08:00
Android Build Coastguard Worker 7d84677856 Merge cherrypicks of ['googleplex-android-review.googlesource.com/31175419'] into 25Q1-release.
Change-Id: I86151df4681cf712e7ccc75cd977c54c946b5b9c
2025-01-08 16:24:37 -08:00
Jordan Silva 09fb9c3743 Revert "Dismiss recents when device goes to sleep"
This reverts commit aed3b14abc.

Reason for revert: This fix introduced other issues, see b/386304079, b/384731940

Bug: 319365581
Bug: 386304079
Bug: 384731940
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:612b124b758dd99eba40efc6265c9b646fbbcab1)
Merged-In: Ib49975208888fe54dd8bfb8dc3815f8825c8b5e8
Change-Id: Ib49975208888fe54dd8bfb8dc3815f8825c8b5e8
2025-01-08 16:21:36 -08:00
Sihua Ma a5d096b922 Add debug logs to folder open anim
Bug: 383526431
Flag: EXEMPT logs only
Test: None
Change-Id: Ib18d63e7f8ab194f8fda74aa99d99c9aa27f5f19
2025-01-08 22:53:53 +00:00
Stefan Andonian 4a89d0ff9e Merge "Add ScreenRecord annotation to flaky test RequestPinItem" into main 2025-01-08 14:49:03 -08:00
Ats Jenk f67cfbe6ac Use bubble count for checking if bubble bar has bubbles
hasBubbles() was checking if there is a selected bubble. If there was one, it returned true.
Update it to return true when bubble bar has bubble views.
This aligns it with the name of the method and the javadoc.

Bug: 385928447
Change-Id: If3dafb7608f71b8600dbac064b08a7f7114a361f
Test: check that bubble bar is tappable
Test: check that bubble bar is shown next to QSB on foldable
Test: check bubble bar position with 3 button nav
Flag: com.android.wm.shell.enable_bubble_bar
2025-01-08 14:27:27 -08:00
Stefan Andonian 2c2e24f38d Add ScreenRecord to difficult to flaky test TaplDragTest.testDragToFolder
Bug: 383917141
Test: Passes Presubmit
Flag: EXEMPT flaky test investigation
Change-Id: Icf045821c42fdf9f8e60ae45d0d98ff2bc25e927
2025-01-08 14:17:02 -08:00
fbaron a94ecdfac0 Move all db calls for grid migration inside a SQLiteTransaction
Bug: 388564911
Flag: com.android.launcher3.one_grid_specs
Test: GridSizeMigrationTest
Change-Id: I22a373ea5b71a0713eeba37e8d09e09130eae525
2025-01-08 13:44:34 -08:00
Stefan Andonian 8295c92e8e Add ScreenRecord annotation to flaky test RequestPinItem
Bug: 386243192
Test: Test runs fine with annotation.
Flag: EXEMPT unit test bug investigation
Change-Id: I27f8dc0fb55521ed37b743a0149dbe2ac60ad7ff
2025-01-08 12:53:08 -08:00
Treehugger Robot 13cb405ff0 Merge "Remove no longer meaningful upstream: true flag." into main 2025-01-08 12:29:51 -08:00
Sebastian Franco a8e1984852 Promote ReorderAlgorithmUnitTest since it's not failing anymore
Fix: 332527963
Flag: TEST_ONLY
Test: ReorderAlgorithmUnitTest
Change-Id: I69257ff8a267f6f2e94f8d0c3c5e0c662ec5efb9
2025-01-08 12:20:13 -08:00
minch ef86780cda Reland "Introduce mTaskViewCount inside the RecentsView"
Manually reland ag/30692743 without the part of change inside
PagedView. The related crash has been handled by ag/31218694.

Flag: EXEMPT as relanding
Bug: 385612978
Test: Manual
Change-Id: Ic571a506bea025ff7d1f2e964300c27a935302a3
2025-01-08 18:59:05 +00:00
Treehugger Robot b3a6b8c33d Merge "Fixing local atest runs of Launcher tests" into main 2025-01-08 10:44:53 -08:00
minch a69673de08 Run the given callback only inside runOnPageScrollsInitialized
Let `PagedView.runOnPageScrollsInitialized` run the given callback only
instead of running all the current existing callbacks inside
`mOnPageScrollsInitializedCallbacks` once `mPageScrolls` has been
initialized.
All the existing callbacks will be run by
`PagedView.onPageScrollsInitialized` instead.
By doing this, we can avoid some unexpected crash while running
the pending callbacks in some scenarios. E.g., removeAllViews.

Flag: EXEMPT fix a regression
Bug: 385612978
Test: Manual
Change-Id: I0877cff752aabd1569dd54a9d04001687f90a5f6
2025-01-08 18:44:40 +00:00
Holly Jiuyu Sun 9d0cbfd689 Merge "Remove remaining "Item added to home screen" annoucement from talkback." into main 2025-01-08 10:15:49 -08:00
Rex Hoffman 74fa77e564 Removing Dead Flag
Test: CI
Bug: 386652866

Change-Id: I04537140ccd2526df4630c8cca6abbd327a7ca7f
Merged-In: If5065b2d25b5e5d8850f50dd4b25bd0ea7e3dd5c
2025-01-08 10:13:56 -08:00
Rex Hoffman 2c1c08a1ac Remove no longer meaningful upstream: true flag.
This used to direct robolectric tests to /external/robolectric rather than the older/unmaintained /external/robolectric-shadows, that has since been deleted.

Change-Id: If5065b2d25b5e5d8850f50dd4b25bd0ea7e3dd5c
Flag: TEST_ONLY
Test: CI
Bug: 386652866
2025-01-08 10:13:04 -08:00
Alex Chau a2857a9940 Add test to open Desktop with fullsreen live tile
Fix: 388266322
Test: TaplTestsOverviewDesktop#enterDesktopViaOverviewMenu
Flag: EXEMPT test only
Change-Id: I6d581671a81289abe362c42c8d4e826da59b7c70
2025-01-08 18:09:42 +00:00
Treehugger Robot 569e032b24 Merge "Add debug logs to SpringAnimationRunner.onUpdate" into main 2025-01-08 09:40:13 -08:00
George Lin a1037f63a7 Merge "Return list of one default option when shape not enabled (1/2)" into main 2025-01-08 09:13:47 -08:00
Treehugger Robot 6c45afc3d8 Merge "Migrate TopTaskTracker instance to DaggerSingletonObject" into main 2025-01-08 09:10:02 -08:00
Schneider Victor-tulias e6079bfa01 Merge "Fix test Dagger initialization deadlock in RecentsDisplayModel" into main 2025-01-08 07:16:41 -08:00
samcackett 288bdd9d56 Use system configured font weight
Fix: 379643698
Test: Enable Bold text (Settings > Accessibility > Display size and
text) and check the emoty recents view text is bold
Flag: EXEMPT bugfix

Change-Id: I8f4d2f61247b168c777b751a3b3dd12299e7011f
2025-01-08 15:05:06 +00:00
Will Osborn 68ef02ca44 Merge "Move recents dependency destruction to onDestroy from onDetachedWindow" into main 2025-01-08 06:57:23 -08:00
Alex Chau 679d6a5240 Merge "Revert "Introduce mTaskViewCount inside the RecentsView"" into main 2025-01-08 02:28:37 -08:00
samcackett bc3e644652 Migrate TopTaskTracker instance to DaggerSingletonObject
Fix: 371377451
Test: Manual
Flag: EXEMPT Dagger integration
Change-Id: I0b51fb7973a89e9d6f59d4c2c8544fdd0ccbf74e
2025-01-08 08:15:13 +00:00
Sunny Goyal 4016e11e58 Moving overview preloading to a separate utility class
Bug: 386288280
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I6779e22c1990b0a901a4190d9272066958e86331
2025-01-08 00:14:49 -08:00
Vadim Tryshev ef95aa29fa Fixing local atest runs of Launcher tests
When running tests locally on CF, installing test apk either fails or returns INSTALL_FAILED_VERIFICATION_FAILURE.

Somehow this doesn’t happen when running on ATP.

For local runs, fixing by disabling verification.

Bug: 378782502
Test: local atest; presubmit
Flag: NONE Test change
Change-Id: I31b6d14587dbfed129ae3ddeef5e86f3c60432e9
2025-01-07 19:07:01 -08:00
Android Build Coastguard Worker c90efa255a Merge cherrypicks of ['googleplex-android-review.googlesource.com/31156270'] into 25Q1-release.
Change-Id: Ib824b4ca7856560c829ea11fd71c1c6003fd62fe
2025-01-07 17:34:31 -08:00
Treehugger Robot 2dbb255975 Merge "Maintain Talkback / Voice Access / etc. focus after moving item in Workspace." into main 2025-01-07 17:32:54 -08:00
Hyunyoung Song 59781fe109 Prevent CtS invocation in fake landscape mode
Bug: 383421642
Test: manual, atest ContextualSearchInvokerTest
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:299576a77761e2a9db11ef50d7e0072d079e381c)
Merged-In: I71ff453c54ade4583494ae9a6b44560d59b010d8
Change-Id: I71ff453c54ade4583494ae9a6b44560d59b010d8
2025-01-07 17:29:53 -08:00
Stefan Andonian 8a0f9b7f15 Merge "Fix ConcurrentModificationException in Folder by not sorting. Already done elsewhere." into main 2025-01-07 16:22:10 -08:00
Treehugger Robot 6184be660e Merge "Correctly use areDesktopTasksVisibleAndNotInOverview() in DesktopVisibilityController" into main 2025-01-07 15:08:25 -08:00
minch 59440da093 Revert "Introduce mTaskViewCount inside the RecentsView"
Manually revert ag/30692743 because of a performance
regression tracking at b/385612978 .

Flag: EXEMPT as reverting
Bug: 385612978
Test: Manual
Change-Id: Iadcdc07588755ee47b6d6d37db08291aa707ecfe
2025-01-07 22:12:01 +00:00
Stefan Andonian 3593b6a9e2 Fix ConcurrentModificationException in Folder by not sorting. Already done elsewhere.
Bug: 385682296
Test: Verified locally that folder behavior remained identical to before.
Flag: EXEMPT bug fix
Change-Id: I9c3ca9aa456f0ac724f4f002a8ec0385f019ee0d
2025-01-07 13:43:41 -08:00
Sebastián Franco 707bf729c9 Merge "Using pixels instead of DPI for selecting the grid size" into main 2025-01-07 13:05:52 -08:00
Sunny Goyal 56297bcd4a Merge "Removing RotationTouchHelper state management from RecentsAnimationDeviceState" into main 2025-01-07 12:47:56 -08:00
George Lin c6bdd4b181 Return list of one default option when shape not enabled (1/2)
This is to return a list of one default option (circle) if the shape
cutstomization flag is not turned on.

It resolves the issue that the selected shape option never emits.

Test: Manually tested
Fixes: 388299893
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I328efa370c1a741e8461dd9b37e37c138eb7e09f
2025-01-07 20:21:25 +00:00
Schneider Victor-Tulias ef3e18715b Fix test Dagger initialization deadlock in RecentsDisplayModel
- Fixes a deadlock created when initializing RecentsDisplayModel
- Also fixes an IllegalStateException when initializing RecentsDisplayModel before the default display has initialized

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: I5d3e000d722c311e0d5431034b68635c402c8109
2025-01-07 12:19:50 -08:00