Commit Graph

83004 Commits

Author SHA1 Message Date
Uwais Ashraf e545182223 Add logging for RDeps lifecycle and ViewPool.initPool to help debugging.
Bug: 390156722
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: none - logging only change
Change-Id: I657194e79023598c17ca8b1885f98457f3d773a9
2025-01-21 08:03:54 +00:00
Treehugger Robot 5488f3571e Merge "Fix test Dagger initialization deadlock in RecentsDisplayModel" into main 2025-01-20 10:14:47 -08:00
Treehugger Robot d3267c0281 Merge "Fix incorrect ActiveGestureLog string" into main 2025-01-20 10:14:47 -08:00
Schneider Victor-Tulias f8fa42be84 Fix test Dagger initialization deadlock in RecentsDisplayModel
WallpaperColorHints is a MainThreadInitializedObject that was causing a deadlock in RecentsDisplayModel initialization. Converting WallpaperColorHints to a dagger singleton.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: Ib5b4eab27b4e28baf1208915fa7cf6dbd36bc1f5
2025-01-20 08:08:40 -08:00
Treehugger Robot 92a6a89f49 Merge "Provide reason for moving task to front." into main 2025-01-20 01:50:50 -08:00
Sergey Pinkevich 9b28d10a44 Merge "Add tracing for opening/unminimizing app in Desktop Windowing" into main 2025-01-20 01:08:59 -08:00
Winson Chung 8bcdfe2fe0 Merge "6b/ Group visible tasks into a single mixed grouped task" into main 2025-01-19 14:32:44 -08:00
Adam Cohen ea1c34bdcb Merge "Fix issue with AutoInstallsLayout Parser and user profile" into main 2025-01-18 11:56:09 -08:00
Sihua Ma 009c0971c4 Merge "Invalidate after changing ring path translation" into main 2025-01-17 19:55:27 -08:00
Winson Chung c166a6d95a 6b/ Group visible tasks into a single mixed grouped task
- Update to use mixed grouped tasks for visible tasks (if there are more
  than one).  This allows us to remove/reframe some existing assumptions
  about which task in the visible list is what the user is considering
  the base task in Overview

Bug: 346588978
Flag: com.android.wm.shell.enable_shell_top_task_tracking
Test: atest WMShellUnitTests
Change-Id: I283a342e623e7f7a4c5a4440c97867cbeec47f18
2025-01-17 15:44:10 -08:00
Adam Cohen dcc2e5d21f Fix issue with AutoInstallsLayout Parser and user profile
=> the profileId was only being added from the root workspace parser
=> instead, the profileId should be added at the individual item parser level

Flag: NONE small bug fix
Issue: 390674545
Test: manually verified using import / export

Change-Id: I76187b1210f282d1a0f8f4652a499d2472461d87
2025-01-17 13:27:00 -08:00
Jagrut Desai 6971afcd0b Merge "Fix Taskbar icon Accessibilty Focus on hovering" into main 2025-01-17 13:17:41 -08:00
Sihua Ma d8f421098c Invalidate after changing ring path translation
Additionally set ring path translation only when there is a change in
the icon size.
Also adding logs to print measured width and normalized icon size.

Test: Manual
Bug: 387844520
Flag: EXEMPT bug fix
Change-Id: I9fee51f4dc096d8c03076bd0787ec25b5e358edc
2025-01-17 21:01:59 +00:00
Liran Binyamin e96bd71f50 Merge "Pass the user id for intent app bubbles" into main 2025-01-17 12:29:50 -08:00
Treehugger Robot 6b6020da2d Merge "Add TaskViewModel to fetch and map Tasks data" into main 2025-01-17 11:00:32 -08:00
Jagrut Desai 625b78ae13 Fix Taskbar icon Accessibilty Focus on hovering
The problem: ArrowTipView was TypeAccessible hence taking a focus away from taksbar icon. The hover event was getting consumer by onHover of the listener and not getting passed to view. Upon passing the hover event we see icon scale up. We don't want both icon to scale up and show
tootip when hovering.

The Solution: pass motion event to onHoverEvent for icon view and mark ArrowTipView to be not included as Accessible View. For disabling hove
ring for taskbar icon we introduced new field to track if hovering is enabled for display type for that icon.

Test: Manual, Presubmit
Bug: 284081291
Flag: EXEMPT bugfix
Change-Id: Ie02d17856b26f82887fd178ccf0a7351416cc43e
2025-01-17 09:57:38 -08:00
Ahmed Fakhry 26a43abbe2 Remove some usages of GroupTask.task1
See go/refactor-group-task for details. This is another incremental
change towards deprecating `GroupTask.task1`.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: Ib9b38268374277f485c6856a012b5b7f02e37055
2025-01-17 17:47:26 +00:00
Jordan Silva be4ceb26c9 Add TaskViewModel to fetch and map Tasks data
This commit introduces a new `TaskViewModel` which retrieves task data using `GetTaskUseCase` and maps them to `TaskTileUiState`.
It also adds new files `TaskTileUiState` and `GetTaskUseCase` with their corresponding models.
- `TaskTileUiState` is used to represent the UI state of a single overview tile.
- Introduced `TaskData` sealed interface to encapsulate different states of a task.
- `GetTaskUseCase` is used to fetch a single task given an id from the repository.
- `TaskViewModel` fetches and maps tasks to `TaskUiState`.
- Added unit tests for `TaskViewModel` to ensure the correct data is being emitted.
- Added unit tests for `GetTaskUseCaseTest` for testing task retrieval logic.
- `TaskModel` is the new data model representing the data fetched by the repository.

Fix: 390578940
Fix: 390578937
Bug: 388486032
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: GetTaskUseCaseTest
Test: TaskViewModelTest
Change-Id: Ibf728eccc31270c0d0d8668a503e26d6d0e88f59
2025-01-17 16:44:56 +00:00
Gustav Sennton 5813304d96 Provide reason for moving task to front.
In WM Shell we want to be able to log the reason a task was unminimized,
with this CL we pass a reason from Launcher to WM Shell when bringing
the task to front.

Test: manual
Bug: 357985747
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I4a68f4d0d7eddb483a1473843b4cd91bd783d92f
2025-01-17 15:20:10 +00:00
Bill Yi b634ff623a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0eaf0ef2e1334b33bef7adb9594d02f6821a8f62
2025-01-16 23:26:42 -08:00
Justin Yun da76a66353 Revert "Replace system_ext container with system"
This reverts commit d80efafdc0.

A system partition cannot have the aconfigs of other partitions.
Revive the system_ext container for system_ext aconfigs.

Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
Change-Id: I92387e6d5764c750f83bd8d266f6da969e114a72
2025-01-17 15:04:41 +09:00
Treehugger Robot 2e2c11e49d Merge "Ignore the tests temporarily." into main 2025-01-16 21:10:23 -08:00
Treehugger Robot 948222d92a Merge "Add a tapl test for locked taskbar" into main 2025-01-16 21:08:23 -08:00
Treehugger Robot b43e90951f Merge "Move tests to multivalent" into main 2025-01-16 19:33:30 -08:00
Sihua Ma 0413cfc05c Merge "Fix work badge theme issue" into main 2025-01-16 19:16:59 -08:00
Toshiki Kikuchi 6df54399fb Add a tapl test for locked taskbar
This CL adds a new tapl test to verify the behavior of the “locked”
taskbar which is sticky even when the home is on top.

Bug: 388125007
Flag: EXEMPT add test
Test: TaplTestsLockedTaskbar

Change-Id: I80d8d565ac63c2e3a8c2f79c46809f89fadfd181
2025-01-17 12:11:29 +09:00
Treehugger Robot 47b4339df5 Merge "Fix Talkback Announcement for Workspace Pages" into main 2025-01-16 17:21:33 -08:00
Sihua Ma 4a3aa354b8 Fix work badge theme issue
The work badges are being themed even though themed icon is disabled

Test: Manual
Bug: 390031380
Flag: EXEMPT bug fix
Change-Id: Ia25a58631d416face0bd1ca2e5f086324b579834
2025-01-16 16:39:56 -08:00
Anushree Ganjam de0d4498c8 Ignore the tests temporarily.
This is to measure the impact of OOM issue
https://googleplex-android-review.git.corp.google.com/q/topic:%22launcher-clearMock-RunListener%22

The tests will be  re-enabled on Jan 22. Currently NexusLauncherTests are
100% failing due to b/385147987 and b/388258969 which blocks us from
measuring the OOM issue fix impact.

Bug: 385147987
Bug: 388258969
Bug: 378520480
Test: Manual
Flag: TEST_ONLY
Change-Id: I1d804c7fcba3b48943025408a530981ff808d511
2025-01-16 16:26:51 -08:00
Sihua Ma 8fc266d063 Move tests to multivalent
Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: EXEMPT test migration
Change-Id: Idd9e52f281d955e87f6db638ebfd8218a4dcb77f
2025-01-17 00:04:27 +00:00
Adnan Begovic 3c4c268b4c Merge "launcher3: Add one grid edu to floating view." into main 2025-01-16 15:27:01 -08:00
Stefan Andonian e73541c30c Fix Talkback Announcement for Workspace Pages
Bug: 379649357
Test: Verified manually that the fixes work for announcements.
Flag: EXEMPT bug fix
Change-Id: I0a2e989eb34adbd975a7211d8334d264d64b3933
2025-01-16 15:19:04 -08:00
Merissa Mitchell 90125d0f3b Merge "Pass displayId to startSwipePipToHome" into main 2025-01-16 14:32:02 -08:00
Mady Mellor f7f4c3c7ac Merge "Update code guarded by bubble anything flag to use the helper method" into main 2025-01-16 13:36:38 -08:00
Anushree Ganjam 25717836e1 Merge "Use RunListener to Clear inline mocks at the end of each test class." into main 2025-01-16 13:28:04 -08:00
Merissa Mitchell ac97f98e7c Pass displayId to startSwipePipToHome
so that PiP can calculate bounds for the correct display in multidisplay
case.

Bug: 390042201
Test: Manual and Presubmits
Flag: com.android.window.flags.enable_connected_displays_pip
Change-Id: I1dbecc36d287a9b64e614cf9c4621aef3c57b284
2025-01-16 11:37:48 -08:00
Anushree Ganjam 0a29e73ffb Use RunListener to Clear inline mocks at the end of each test class.
Inline mocks are leaking activity contexts and accumulation of these activity contexts led to OOM that resulted in test failure.

See https://github.com/mockito/mockito/issues/1614 for details on mockito caused memory leaks

This change works for both soong and gradle builds.

Bug: 378520480
Test: atest and android studio builds
Flag: TEST_ONLY
Change-Id: I4a50993621ea416a02a41dd2f9c330d1599f065c
2025-01-16 11:19:52 -08:00
Vinit Nayak 3456fcbe03 Remove and cleanup AppPairs flag
Test: Launcher compiles and runs
Bug: 274835596
Flag: EXEMPT cleanup
Change-Id: Iab8f17d444753df303ed1a09d6547917545e66f5
2025-01-16 14:02:55 -05:00
Treehugger Robot 31522e8797 Merge "Add logging for TasksRepository to help with debugging." into main 2025-01-16 10:57:03 -08:00
Sukesh Ram 7ad500b716 Merge "[CD Taskbar] Refactor to Listen to Display Ready/Removed Signals" into main 2025-01-16 10:03:34 -08:00
Uwais Ashraf 477275ff97 Add logging for TasksRepository to help with debugging.
Bug: 390325294
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: none - logging
Change-Id: I8f771e06851261e027caf178a08e6d47b5af7cba
2025-01-16 16:56:40 +00:00
Sergey Pinkevich 00fe697e92 Add tracing for opening/unminimizing app in Desktop Windowing
Bug: 370682144, 351763156, 339582783
Test: record perfetto trace while performing opening apps
Flag: NONE new perfetto instrumentation

Change-Id: I06e7bff21cf5dfb5b6601aded07bbb7d6f90225f
2025-01-16 14:11:47 +00:00
vinayjoglekar 81db038977 Consume callback sent from shell when overview task is entered desktop mode from desktop menu
Bug: 387471509
Test: EnterDeskTopViaMenuOfLiveOverviewTaskTest, EnterDeskTopViaMenuOfStaticOverviewTaskTest
Flag: EXEMPT bug fix
Change-Id: If1d6604b7e331cc4bdb8a3fac3804b6772e8be7a
2025-01-16 03:12:32 -08:00
Treehugger Robot 94ebc5400d Merge "Add SysUiProxy method to start transition on desktop task launch." into main 2025-01-16 01:06:22 -08:00
Treehugger Robot 22df0f9d20 Merge "Adding some source hints when generating theme icons" into main 2025-01-16 00:11:10 -08:00
Vania Desmonda 5d50fbb6c9 Add SysUiProxy method to start transition on desktop task launch.
This forces the task to correctly start the TRANSIT_OPEN transiiton in
Desktop mode when launching an intent from the taskbar and prevent it
from opening in full screen.

Fixes: 361366053
Test: manual test
Flag: EXEMPT bugfix
Change-Id: I6d59705aa55745c3425266dacbb012dd4e2b1b03
2025-01-15 18:54:04 -08:00
Liran Binyamin 96dc022401 Pass the user id for intent app bubbles
When creating a new app bubble by long pressing on launcher icons,
pass the user id to wm shell so the bubble is created for the correct
user context.

Bug: 361173339
Flag: com.android.wm.shell.enable_bubble_anything
Test: atest BubbleAnythingTest
Test: manual
       - create work profile
       - long press on a work profile app icon -> Bubble
       - observe new bubble opens in the work profile context
Change-Id: Idb980bc6f74e85e85a9777f0d39e772b84feeb9c
2025-01-15 21:35:54 -05:00
Mady Mellor 7d97e96550 Update code guarded by bubble anything flag to use the helper method
Also adds a dependency on shared shell lib so launcher can use this.

Flag: com.android.wm.shell.enable_create_any_bubble
Test: manual - enable the create flag and check that bubble anything still
               works; same with bubble anything flag
Bug: 389737359
Change-Id: I18322512c9d9883ee5cf473b72df565adea85879
2025-01-15 17:04:10 -08:00
Treehugger Robot 508112dc94 Merge "[Leak] Clear all of TaskbarView's FolderIcons' listeners upon activity onDestroy" into main 2025-01-15 16:54:23 -08:00
Treehugger Robot d255cbdfd7 Merge "Initial implementation of the AddDesktopButton" into main 2025-01-15 15:40:07 -08:00