There are test failures when using ConstraintLayout without a known solution, see https://chat.google.com/room/AAAACwktJi8/2OogGWfbLvI. Switching back to a relativelayout to resolve those issues.
Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I004c2d77ca308d85b29217d4f1e548067126556f
This issue happens when restoring the data from a phone to a tablet or vice-versa. When Launcher is restoring the data, it allows the device to load a disabled or invalid grid temporarly for the migration. This leads to a crash when the responsive grid is enabled.
The hotseat spec has only WIDTH or HEIGHT specs in a certain posture. When the user restores the data from a phone to a tablet, the Launcher loads a handheld spec that doesn't have HEIGHT specs for the hotseat in landscape (spec_handheld_hotseat_[grid].xml). However, the tablet, in landscape, tries to retrieve the hotseat HEIGHT spec.
It also prevent crash when responsive grid is used with multi window mode. isVerticalBarLayout becomes false. Then, the responsive grid tries to load a hotseat spec that doesn't exist (using DimensionType.HEIGHT). Phones have hotseat specs only for DimensionType.WIDTH.
Bug: 315548992
Fix: 315069300
Fix: 315377544
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: v2/android-crystalball-eng/health/microbench/systemui/main/systemui-notification-3-jank-suite
Test: atest CtsWindowManagerDeviceDisplay:android.server.wm.display.MultiDisplaySystemDecorationTests#testSendPrimaryHomeIntentActivityOnDisplayWithDecorations -- --abi x86_64
Change-Id: Ibd6537e0528868da9a1b7672c43b5455fa6a8184
TYPE_ACCESSIBLE no longer works for certain cases (see bug). This also
simplifies TouchControllers that would otherwise add or remove from
TYPE_ACCESSIBLE (such as ALL_APPS_EDU and TASKBAR_OVERLAYS).
Fix: 315507902
Test: Manual
Flag: N/A
Change-Id: I6f5d218dab87a8bcc8e7805d0ced9a6678f09c8e
Sometimes, the context is null in TutorialController which leads to an
NPE when relying on context specific functions. This change checks that
context is null and if so, defers the context specific functions that are
called until after onAttach() is called.
Fix: 307781152
Test: Set context to null in onResume() and check that the tutorial
continues like normal
Flag: None
Change-Id: I66e345f8361315787534bb88b9c1d12278708d78
- Using the refactoring that took place in ag/25414154
Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
- Verified QL highlight still works
- video: https://drive.google.com/file/d/15yjBWofebn6m7VgEnLK6kEYqhC_adJQ3/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation DEVELOPMENT
Change-Id: Ib6229b404b48616966f3e6ab6884099b6e4b4023
- Create base SectionDecorationInfo.java and RecyclerViewAnimationController.java
- SearchTransitionController now inherits from RecyclerViewAnimationController where RecyclerViewAnimationController will control
animation for private space
Bug: 299294792
Test: Verified SearchTransitionController didn't regress by turning off BACKGROUND_DRAWABLES flag.
- Verified QL highlight still works
- video: https://drive.google.com/file/d/15yjBWofebn6m7VgEnLK6kEYqhC_adJQ3/view?usp=sharing
Flag: None
Change-Id: If34f4bb199be0e113485279931d2927cb9fad397
In order to properly animate task on the vertical axis we need to update `taskSecondaryTranslation`.
Bug: 304782953
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual
Change-Id: I1afe78d4eb1575e9c967ff594cffedd7d3620541