Commit Graph

83004 Commits

Author SHA1 Message Date
Sebastian Franco c794aca69f Refactoring FolderPagedView to make it more testable
Bug: 353588686
Test: Compiles
Flag: NONE refactor
Change-Id: I612523282a57beac90b14a890a333a1670ab0d48
2024-07-17 23:32:17 +00:00
Android Build Coastguard Worker dc8108ffc1 Snap for 12104175 from 5d4587f04d to 24Q4-release
Change-Id: Idfccc9208177b35feb0ddfe79da378ff68f674f0
2024-07-17 23:21:14 +00:00
Andy Wickham e6b43c86ba Merge "Invert the 2 stage LPNH logic to lower false positive triggers." into main 2024-07-17 23:11:51 +00:00
Kevin Lim 0c7079ece0 [UniversalSearchInput] Support search box dynamic height adjustment in
ActivityAllAppsContainerView

Previously, ActivityAllAppsContainerView assumed a static height for the
search box and relied only on FloatingHeaderView's height calculation.
With multi-line search bar, we need to add to the FloatingHeaderView's
mMaxTranslation to update the clipping position for the recycler views
belowe

Bug: b/341795751
Flag: com.android.launcher3.multiline_search_bar
Test: http://recall/clips/32f64e77-3522-4873-bc7b-86d844912724
Change-Id: I67aab186e96d7bdecbba454f660d73f0f4408a98
2024-07-17 23:07:58 +00:00
Shamali P 6211e86009 Consider the widget option menu choice in search results
Makes the search related code separate from popup provider.

Bug: 347288851
Flag: EXEMPT flag in sysui
Test: Unit tests
Change-Id: I4534d5f70876ec0cf4e2d78030864f78a8bfabb9
2024-07-17 22:56:58 +00:00
Shamali P 9aabb9a9cb Show only filtered / default widgets in standalone activity by default
Bug: 347288851
Flag: EXEMPT flag in sysui
Test: b/339716822 to set it up
Change-Id: I71baac8897ce600f3c588eb3d48b9677e507145b
2024-07-17 22:56:49 +00:00
Shamali P 2e2d4ff603 Add a 3 dot vertical menu and styles (child cl makes it functional)
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I99985098034f6336f683b1ff3a47dce2aa8e596a
2024-07-17 22:56:41 +00:00
Shamali P 8654ff0116 Set default widgets and all widgets separately from standalone activity
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I4eaeb7cb44b8b9c4187f7cf8fdc1b80143bb322e
2024-07-17 22:56:30 +00:00
Shamali P 2d7a6b0fee Update the widget picker activity theme for popup menus styling
The earlier version didn't inherit in-built popup styles and launcher
inherits from these too.

Bug: 347288851
Flag: EXEMPT standalone picker
Test: standalone picker will be covered in b/339716822
Change-Id: Ic33afbcea3838a608385e3f94cb864f66cef9e8a
2024-07-17 22:56:22 +00:00
Shamali Patwa 45b5acef28 Merge "Cleanup widgetsModel and add tests" into main 2024-07-17 22:55:01 +00:00
Andrew Cole 940917b92e Merge "Test Week - Deleting NexusTestInformationHandler" into main 2024-07-17 22:33:47 +00:00
Sihua Ma 71a48d9ac5 Add unit test for CustomWidgetManager
Number of methods covered: 5

Test: atest NexusLauncherRoboTests:CustomWidgetManagerTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I69c9567391d3a874c7b2abcd473887194ec2dcfc
2024-07-17 22:21:40 +00:00
mpodolian baf0307494 Added scrim visibility check.
Scrim view was not shown because the TaskbarScrimViewController did not
check taskbar visibility on initialization. Added the check to fix the
issue.

Fixes: 353583417
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
Switch task bar to transient mode on overview screen or inside an
application. Expand bubble bar.

Change-Id: Ia8a05802a779a4bac70906e7e52ac6650308c85c
2024-07-17 22:32:54 +01:00
Treehugger Robot 2397ffd437 Merge "Disable model loading in Taskbar unit tests." into main 2024-07-17 21:14:10 +00:00
Tracy Zhou fe5c3fb5eb Fix missing taskbar scrim in folded state when swiping up from immersive mode
TaskbarTransitions is needed for gesture nav too

Also updated the TaskbarTransitions check so that foldables are included (instead of just phones with the unification for phones flag on

Fixes: 353620747
Test: Scrim shows in Youtube immerisve mode
Flag: EXEMPT bugfix
Change-Id: I9990ef8f793e28b3af2f42b0a5a117fdfbdd4081
2024-07-17 14:04:13 -07:00
Treehugger Robot 5d4587f04d Merge "Update comment to remove todo" into main 2024-07-17 20:28:05 +00:00
Andrew Cole f0bdb71e38 Merge "Test Week - FolderAccessibilityHelperTest" into main 2024-07-17 20:16:39 +00:00
Tracy Zhou ae637b60e0 Merge "Fix double task bar" into main 2024-07-17 20:14:51 +00:00
Ikram Gabiyev a393f2b678 Pass empty srcRectHint if overlay is present
Launcher should pass an empty srcRectHint to Shell
via stopSwipePipToHome if overlay is present, so
that Shell know that srcRectHint is being "simulated"
for the enter PiP animation with an app icon overlay.

Shell will recalculate the simulated src-rect based on
appBounds and aspect ratio of the destination bounds.

Bug: 352773027
Flag: EXEMPT bugfix
Test: swipe PiP to home from Maps with fixed rotation (90 and 270)
Change-Id: I5f89c5af9d6b8a66725e346d09e7b3d84044bb4c
2024-07-17 12:38:23 -07:00
Winson Chung abdbc75801 Update comment to remove todo
Fixes: 197326121
Flag: EXEMPT bugfix
Test: N/a
Change-Id: I66c07a29dda128e14a0e6ff1755546bbda48ba55
2024-07-17 18:50:44 +00:00
Jorge Gil b9a0766dde Re-enable FREEFORM task shortcut when DW is unsupported
The freeform shortcut was previously changed to only show if the desktop
windowing flag was disabled, which is incorrect since it's not a
reliable indicator about whether desktop windowing is supported or not.
When the flag is enabled as the feature progresses, it causes the button
to be hidden on devices that support freeform windows but don't support
desktop windowing, such as phones or tablets when freeform is enabled in
developer options.

To properly check that DW is not enabled, this CL changes the flag check
to DesktopModeStatus#canEnterDesktopMode.

Bug: 353740331
Test: enable freeform in dev options, disable desktop windowing - check
"freeform" button is available through long-press of the app icon in
overview/recents.
Flag: EXEMPT bugfix

Change-Id: I0ea5073e5570838acf49a27f54546fd97e6739cd
2024-07-17 18:37:39 +00:00
Sebastian Franco 3780e096d6 Adding testin for Utilities.java
Happy testing week.

Bug: 353588686
Test: LauncherUtilitiesUnitTest
Flag: TEST_ONLY
Change-Id: I321aa9197a53801282591198aef0229d44da60d3
2024-07-17 11:28:24 -07:00
Sebastian Franco 9a3dd3de64 Adding unit test for pointToCellExact
Unit test added as part of the testing week.

Bug: 353588686
Test: CellLayoutMethodsTest
Flag: TEST_ONLY
Change-Id: Ibd796b4b6c354846c7e5ba432f4dca80d9aed4f2
2024-07-17 11:23:09 -07:00
Charlie Anderson 7dc0ce4019 Merge "[Test Week] Add tests for each operation in PackageUpdatedTask" into main 2024-07-17 17:55:45 +00:00
Brandon Dayauon 0e5640376e Remove enableLayoutTransitions for private space.
Get rid of layoutTransitions as they are not reliable, see here: https://docs.google.com/document/d/1ExSemBvzzVv-I9tUCVzdLeN-lDb2hTSOM886UYSH-Qk/edit?usp=sharing&resourcekey=0-aBCCLnrB7KtkhIeyUOkKyw
Instead use actual animatorSet to do the animating.
- This also fixes the timings so that the pill transition happens at the same time of the icon alpha animation.
Made member variable for lockText and settingButton.

bug:346298256
Test:
before: See bug
after manually- video: https://drive.google.com/file/d/1B7PIgrGWMJTphc1b5CvCkyg-QYx3TTN3/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I049b84dbe1279a0becb090db8660975dc5c5961e
2024-07-17 10:35:53 -07:00
Vadim Tryshev 300ca3422f Merge "Adding screen record for the bug where we can't find a folder after dragging" into main 2024-07-17 17:00:25 +00:00
Fengjiang Li a92b80f357 Merge "[Test Week] Move ViewCacheTest.kt to multivalentTests folder" into main 2024-07-17 16:55:38 +00:00
Andrew Cole 6ce5c66356 Test Week - FolderAccessibilityHelperTest
Adding unit tests for FolderAccessibilityHelper. In order to write these tests we have also included a refactor of DragAndDropAccessibilityDelegate to get mDragLayer and the accessibility delegate from ActivityContext instead of Launcher. This allows us to pull that from test context in ActivityContextWrapper during testing.

* Tests 1 class previously untested
* Tests 3 methods
* Includes 1 class refactor

Bug: 353303621
Test: FolderAccessibilityHelperTest
Flag: TEST_ONLY

Change-Id: I8d13113fc09d3ee902faecc426deb80bcbae0b0d
2024-07-17 09:48:30 -07:00
Treehugger Robot fd7499bb82 Merge "Update IME switcher icon in taskbar" into main 2024-07-17 15:37:50 +00:00
Charlie Anderson 98c3cafcaf [Test Week] Add tests for each operation in PackageUpdatedTask
Bug:353303621
Test: unit test
Flag: TEST_ONLY

Change-Id: Ic2194fd1506c4ff5a542eac62a492f395d12886e
2024-07-17 11:06:38 -04:00
Shamali P 3ae39c72de Cleanup widgetsModel and add tests
1. Removes unused method `getAllWidgetComponentsWithoutShortcuts`
2. Exposes widgets either as component map or package item map - to
eliminate the duplicate logic around widget sections.
3. Add tests that validate that each package is unique - to help
cover the redirect issue seen in past.
4. In follow up cls, other methods that deal with picker specific data
types like WidgetsListBaseEntry will also be moved out - leaving the
model to only be responsible for providing all widgets map or widgets
by package.

Bug: 341611976
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Ife70874d312b51c66025a6ec678480f2b5c41793
2024-07-17 14:29:31 +00:00
Treehugger Robot 4997c14218 Merge "Adding screen record for the bug where com.google.android.apps.nexuslauncher:id/popup_container is not present" into main 2024-07-17 14:10:16 +00:00
Charlie Anderson db7b6a0104 Merge "Add new Cloud archived app icon and support for inline icons for BubbleTextView" into main 2024-07-17 13:57:38 +00:00
Treehugger Robot c2a36a6fcd Merge "Add Repository for RecentOrientedState and DeviceProfile" into main 2024-07-17 12:25:09 +00:00
Treehugger Robot f834c2c881 Merge "Adjust scope for TaskOverlayHelper" into main 2024-07-17 11:10:17 +00:00
Alex Chau 5837a4628c Add Repository for RecentOrientedState and DeviceProfile
- DeviceProfile have java fields that cannot be mocked, nor can be freely instantiated, so I've to use FakeInvariantDeviceProfileTest to give me some predefined DeviceProfile for testing

Bug: 343101424
Test: RecentsOrientedStateRepositoryTest
Test: RecentsDeviceProfileRepositoryTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Iaa34ef60a418eb336859d260f5808b263de6b4f7
2024-07-17 11:29:20 +01:00
Uwais Ashraf 7fb7ac21a2 Adjust scope for TaskOverlayHelper
Fix: 335396935
Test: Manual - start stop overlay multiple times
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I615e43eddc896f52f9718ccef3a09f39b1ed7569
2024-07-17 09:09:33 +00:00
Fengjiang Li 7f81733666 Merge "[Test Week] Add RunnableListTest" into main 2024-07-17 07:10:24 +00:00
Tracy Zhou 100d8b3ec0 Fix double task bar
I was too excited when I finally got the repro on my device. After some debugging, I found it (ag/27947503)

Fixes: 350790048
Test: with the change, double task bar is gone.
Flag: EXEMPT bugfix
Change-Id: I969dbf5e9d2c5cc277dfb366858023e6eeff14e2
2024-07-16 23:43:38 -07:00
Treehugger Robot 984ea0b9d8 Merge "Adding screen record for the bug where Play Store is not present on the workspace" into main 2024-07-17 03:33:12 +00:00
Sebastian Franco c275326e40 Remove unused methods
Bug: 353303621
Test: compiles
Flag: NONE Removing code
Change-Id: Ibfdc983c5d29d8e928e4277dac285d4e62bdc1fd
2024-07-16 19:10:32 -07:00
Vadim Tryshev 1b540e7a99 Adding screen record for the bug where Play Store is not present on the workspace
Bug: 330232490
Test: presubmit
Flag: TEST_ONLY
Change-Id: I147cd0b45298a9b34c3dfb331af80e1253c013c4
2024-07-16 18:45:05 -07:00
Treehugger Robot 52f7fc5ef6 Merge "Unit tests for ListenableHostView" into main 2024-07-17 01:17:57 +00:00
Vadim Tryshev 243650e2cb Adding screen record for the bug where we can't find a folder after dragging
Bug: 353600888
Test: presubmit
Flag: TEST_ONLY
Change-Id: Idc26dc294aa05a88ce590f9466e60adf2d2f4898
2024-07-16 17:40:17 -07:00
Charlie Anderson d5acd6a016 Add new Cloud archived app icon and support for inline icons for BubbleTextView
- Can now set start drawable for BubbleTextView title with setTextWithStartIcon()
 - App Archiving cloud overlay icon will be disabled when flag on

Bug: 350758155
Test: locally tested B&R with pre-archiving
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I4d395a7ea7dc5ee11259f897d45b83eabdabb766
2024-07-16 19:39:03 -04:00
Stefan Andonian 3e28e9c829 Merge "[Test Week] Unit test for WidgetAddFlowHandlerTest." into main 2024-07-16 23:25:57 +00:00
Android Build Coastguard Worker ff801ad2f5 Snap for 12098010 from b0e0e00660 to 24Q4-release
Change-Id: Id3a94186d8b6384d0b6e67eba2935869b8ec0472
2024-07-16 23:21:40 +00:00
Stefan Andonian f50dca1138 Merge "[Test Week] Unit test for WidgetManagerHelperTest." into main 2024-07-16 23:07:40 +00:00
Jagrut Desai c6c95c8381 Merge "Remove getWorkspaceIconsPositions()" into main 2024-07-16 22:37:29 +00:00
Brian Isganitis 2477f89fd2 Disable model loading in Taskbar unit tests.
We do not need this for now and it is making development more difficult on macs.

Test: Taskbar unit tests
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I2e74e91e21aa650544d8264fab7b336b97b52547
2024-07-16 18:37:28 -04:00