Commit Graph

83004 Commits

Author SHA1 Message Date
Charlie Anderson edc93ed7fe Merge "Handle when archiving icon flag is turned off by setting overlay back on" into main 2024-07-24 17:55:53 +00:00
Liran Binyamin 2a47a4a68d Fix squished hotseat due to bubbles
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
  1. When Hotseat's layout is reset, it checks for whether bubbles
     are showing.
  2. When Bubble Bar visibility changes it notifies hotseat so that
     it can update itself.

Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.

This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.

This change also updates the way QSB adjusts itself for bubbles.
Previously it always animated from the same start value to a target
value. Now the animation starts from its current width to the target,
so that if the current width is already equal to the target width,
there is no visible change.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
       - unfold the device
       - create bubbles
       - observe hotseat adjusts itself for the bubble bar
       - fold the device
       - observe bubble bar is gone and hotseat shows correctly
Test: manual
       - start a youtube video in full screen
       - swipe from the edge of the screen to show the gesture nav
       - swipe on the gesture nav to go home
       - observe that the QSB does not animate
Change-Id: Ia0267ec518d6af9c3c3b68f17bb20ea67a49e5fd
2024-07-24 12:49:17 -04:00
Kevin Lim 5ca6219003 Merge "[UniversalSearchInput] Support search box dynamic height adjustment in ActivityAllAppsContainerView" into main 2024-07-24 16:10:16 +00:00
Alina Zaidi bd3bb00593 Merge "[Dev options][More flags] Update all usages of some flags to use DesktopModeFlags." into main 2024-07-24 10:26:17 +00:00
Sebastián Franco 0c852e6bdd Merge "Ignoring flaky tests" into main 2024-07-24 06:31:35 +00:00
Treehugger Robot 0a757073e8 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-24 05:15:14 +00:00
Treehugger Robot 562e93afac Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-24 05:15:14 +00:00
Sebastian Franco 6d1728bbdd Ignoring flaky tests
Bug: 353965234
Test: CellLayoutMethodsTest
Flag: TEST_ONLY
Change-Id: I831861febe78f5eda873cc924d2dde8a09e49518
2024-07-24 02:46:29 +00:00
Treehugger Robot 5ace16c7b8 Merge "Only register RecentTasksChangedListener if flag is enabled" into main 2024-07-24 01:17:35 +00:00
Andy Wickham 75ce1a2cd6 Move TestExtensions.kt to quickstep for DeviceConfig overrides.
Fix: 353740808
Test: Run existing tests using this class
Flag: TEST_ONLY
Change-Id: Ie72fb86ea4d451e90a6629554dc717126db0b24c
2024-07-24 00:15:05 +00:00
Charlie Anderson 241fba24d0 Handle when archiving icon flag is turned off by setting overlay back on
Bug: 350758155
Test: locally
Flag: com.android.launcher3.enable_new_archiving_icon
Change-Id: Ied5c1a3c0674aa14556cbc225b157ad309b93db4
2024-07-23 19:38:33 -04:00
Tony Wickham bbfa9fc181 Only register RecentTasksChangedListener if flag is enabled
Also unregister it if the feature becomes disabled (currently
this is only done in tests but in the future there will be a
user setting as well).

Added tests to verify getTasks() is not called while both
canShowRunningApps and canShowRecentApps are false.

Bug: 354087794
Test: TaskbarRecentAppsControllerTest
Flag: com.android.launcher3.enable_recents_in_taskbar
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Change-Id: I3123501e7584ad7f877e13294454556501d2dbc8
2024-07-23 23:24:10 +00:00
Treehugger Robot 33a237e447 Merge "Fix ConcurrentModificationException in OmniInvokerTest" into main 2024-07-23 23:23:27 +00:00
Android Build Coastguard Worker 023b99313c Snap for 12129055 from 72054af897 to 24Q4-release
Change-Id: Ia49f83819d4568729ba35092805013548c937a31
2024-07-23 23:21:25 +00:00
Treehugger Robot ea4373c060 Merge "Add NavHandleLongPressInputConsumerTest." into main 2024-07-23 23:20:47 +00:00
Treehugger Robot f3e8844b8c Merge "Revert "Fix squished hotseat due to bubbles"" into main 2024-07-23 23:16:48 +00:00
Treehugger Robot e3078707a0 Merge "Move more tests to deviceless" into main 2024-07-23 23:16:08 +00:00
Anushree Ganjam 16f2206f24 Format dump logs so each of apps info prints in new line.
Bug: 353510823
Test: Manual
Flag: NONE BugFix
Change-Id: Id5b0deca68e7af3c63422206db21ce3eba5b0f3a
2024-07-23 15:21:42 -07:00
Liam Lee Pong Lam dfaaa4a258 Merge "[Launcher3] Hides AllApps education view for trackpad" into main 2024-07-23 22:04:04 +00:00
Mykola Podolian 126be5629b Merge "Added BubbleStashController interface" into main 2024-07-23 21:37:31 +00:00
Liam Lee Pong Lam c1d3fa453f Merge "Fixes SettingsChangeLoggerTest failures" into main 2024-07-23 21:35:41 +00:00
Sihua Ma ee4877f67d Fix ConcurrentModificationException in OmniInvokerTest
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I31402443426e055fe470e11d98b52d07d64e9ca2
2024-07-23 21:24:52 +00:00
Ats Jenk 17f9e70a49 Merge "Announce when bubble bar expands or collapses" into main 2024-07-23 21:22:38 +00:00
Ats Jenk 354d367c47 Merge "Create a11y menu for a bubble in bubble bar" into main 2024-07-23 21:12:23 +00:00
Anushree Ganjam 7c32ae9acf Move more tests to deviceless
Bug: 353339741
Test: Manual
Flag: TEST_ONLY
Change-Id: Ib43d5a17feb812b08d9749b1bf6dcacabf205d47
2024-07-23 13:57:28 -07:00
Shamali P ecf35935d5 Delete the unused code from popup provider
Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: Iff81e5dc46542da2d59dfa4f54bd8fc06851a9c1
2024-07-23 20:16:50 +00:00
Shamali P 5a1b372536 Update references that read popup data provider to use picker provider
Covers the UI references related to widget picker or its shortcut.

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: Ifed1b7600ca9836df147949f3740ca1e89acd04a
2024-07-23 20:16:50 +00:00
Liran Binyamin f9650bd236 Revert "Fix squished hotseat due to bubbles"
This reverts commit a7821390e2.

Reason for revert: b/354648445

Fixes: 354648445

Change-Id: I069d6d72a59ec273e8b7776512ef9015bdb862c0
2024-07-23 19:56:52 +00:00
Brandon Dayauon 72054af897 Merge "Adding more information to logs like content description to help with debugging." into main 2024-07-23 19:54:18 +00:00
Liam, Lee Pong Lam a457b0e016 [Launcher3] Hides AllApps education view for trackpad
Added an indicator `mShowAllAppsEducationView` to check if AllApps
education view should show.

Flag: EXEMPT bugfix
Bug: 342369675
Test: Manual with/without trackpad
Change-Id: Ib995c80467143dd73fe2cac0504dbe6d03834f25
2024-07-23 19:41:18 +00:00
Liam, Lee Pong Lam 80ffa83957 Fixes SettingsChangeLoggerTest failures
To revert the preference change on PreviewItemManagerTest for on-device
test.

Bug: 354157494
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: I966cbd7bf85b0336e131c6e9e4bb306b3700a928
2024-07-23 19:33:27 +00:00
Charlie Anderson e17788e9b8 Merge "[Test Week] add unit tests for InstallSessionTracker" into main 2024-07-23 18:55:55 +00:00
mpodolian 08e98a2c3e Added BubbleStashController interface
Added common BubbleStashController interface and implementation for the
PersistentTaskBarStashController. Added tests for the implementation.

Bug: 346391377
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentTaskBarStashControllerTest
Change-Id: I353e5a2cfa2d39e83b0e94980938aee8a1002fd9
2024-07-23 19:32:08 +01:00
Ats Jenk 8034c414c3 Announce when bubble bar expands or collapses
Add a talkback announcement that tells the user when bubble bar expands
or collapses. The announcement includes the bubble name.

Bug: 344670486
Flag: com.android.wm.shell.enable_bubble_bar
Test: expand bubble bar by tapping on it, hear the announcement
Test: collapse bubble bar by tapping on it, hear the announcement
Test: expand/collapse bubble bar from action menu, hear the announcement
Test: use action menu to move expanded bubble bar from one side to the
    other, make sure there is no announcement

Change-Id: I3908bda3eb9e3eb201067fb2c465c3a883ce73d4
2024-07-23 11:01:43 -07:00
Charlie Anderson 528c716182 [Test Week] add unit tests for InstallSessionTracker
6 public methods tested, 8 unit tests total
no previous test class

Bug: 353303621
Test: unit tests
Flag: TEST_ONLY
Change-Id: Ie2b5c88566c1a512e534654ccc7db1ec6b277a83
2024-07-23 13:05:28 -04:00
Anushree Ganjam bad6ce487a Merge "Add SEARCH_TARGET_UTIL_LOG for debugging searchtargetutil logs" into main 2024-07-23 16:58:28 +00:00
Charlie Anderson 2abb3eb582 Merge "[Test Week] Add unit tests for UserCache" into main 2024-07-23 16:34:39 +00:00
Alina Zaidi 7c75e25f56 [Dev options][More flags] Update all usages of some flags to use
DesktopModeFlags.

Test: Current tests pass
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: Ie418f511c3b5d21cb2b4e485d30249b853a463af
2024-07-23 13:41:41 +00:00
Treehugger Robot b407014993 Merge "Fix an issue in SimpleBroadcastReceiverTest" into main 2024-07-23 13:25:51 +00:00
Alina Zaidi 65794ef777 [Dev options][Wallpaper flag] Update all usage of enableDesktopWindowingWallpaperActivity
flag to use DesktopModeFlags

Test: Current tests pass
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: Ib1b1b01f6a94b4d9c49019a31d0e2269246c301b
2024-07-23 10:18:15 +00:00
Alina Zaidi 6bf1a01ff8 Merge "[Dev options][DW flag] Update all usage of enable_desktop_windowing_mode flag to use DesktopModeFlags" into main 2024-07-23 10:06:47 +00:00
Andy Wickham 8e4faffd0e Add NavHandleLongPressInputConsumerTest.
Tests LPNH for the standard conditions (no flags or AGA configs).

Specifically tests:
 - Delegate stealing focus
 - Long press triggers with steady hold or slight slop
 - Up, cancel, or excessive slop cancels the long press
 - Touch ignored if outside the nav handle (not centered)

Things behind flags / AGA config which are not yet tested:
 - 2 stage detection (double timeout after small slop)
 - Deep press
 - Custom timeout from AGA

Fix: 353613291
Test: NavHandleLongPressInputConsumerTest
Flag: TEST_ONLY
Change-Id: I5ada3a07ccec9062ac22fa21b00d5a030f6d134a
2024-07-23 01:23:45 +00:00
Sebastián Franco 7d780ce71d Merge "Revert change to rotateBounds" into main 2024-07-23 00:49:14 +00:00
Shamali P 66614049eb Update references that wrote widget data to popup data provider
Migrates to write to widget picker data provider instead

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: I1735151e133db0358dfd4f7fa824c6bc7d792307
2024-07-22 23:58:04 +00:00
Shamali P 00d4e05072 Move widget related listeners to widget picker data provider
The change listener on popup provider was for listening to widget
updates. With the widget now updated in widgets picker data provider,
 this moves over the listeners to it.

Test: Existing tests
Flag: EXEMPT minor refactoring
Bug: 353347512
Change-Id: I163529d207ea65044f8e3d6e77e87e0e674b82be
2024-07-22 23:58:04 +00:00
Shamali P 74d9fbd635 Define widget picker data provider separate from popup provider
Separate provider in ActivityContext and relevant implementations that
open widget picker

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: I55df3d9ce6ae9b7d0a310a8686b188618d229065
2024-07-22 23:58:04 +00:00
Shamali P 9e7d288f67 Create a separate class for widget related methods from popup provider
Child cl removes those methods from popup provider and updates its
references

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Id559e8c8d32a40adab961e7c710ec835d5a92184
2024-07-22 23:58:04 +00:00
Brandon Dayauon 6c5a875927 Adding more information to logs like content description to help with debugging.
Using appTitle doesn't seem to work and instead returns null. Content description seems to work
better anyways and show what user type (work/private)

bug: 353796175
Test: after: https://screenshot.googleplex.com/8ysLRHc9cRPg3JF
Flag: NONE adding logs
Change-Id: I4ddab1c02d795d87190592471f84faa6c98f0bfd
2024-07-22 16:27:19 -07:00
Android Build Coastguard Worker 681dd6a39b Snap for 12122529 from 76a048d072 to 24Q4-release
Change-Id: I75be789c63ba6ca4bbb75b65a63422b37569426d
2024-07-22 23:21:20 +00:00
Sihua Ma 587aa05f04 Fix an issue in SimpleBroadcastReceiverTest
Main thread tasks should be idled before verification

Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I6db696c73be2e9689dd290fd1a8c4deffa17ff01
2024-07-22 23:09:17 +00:00