The expanded view was misplaced due to a race condition. This occurred
because the BubbleBarController.onBubbleBarBoundsChanged() method was
invoked while
LauncherTaskbarUIController.onTaskbarInAppDisplayProgressUpdate() was in
progress (e.g. inAppDisplayOverrideProgress value was slightly higher
than 0). The latter method is also used to shift the three navigation
buttons for IME open/collapse events.
This concurrent execution led to an incorrect bubbleBarTranslationY
value being used in the BubbleBarView.getTopToScreenBottom() method,
ultimately causing the misplacement of the expanded view.
Fixes: 416158567
Flag: EXEMPT bugfix
Test: Manual.
- Long Press Chrome icon select "bubble" adds
- Press search bar inside Chrome app bubble to show IME
- Hide IME
- Press Chrome bubble
- Press search bar inside Chrome app bubble to show IME
- Hide IME
Change-Id: I44431f0eb47c3e9e0bea0274624e5b1db0aa15c9
See attached bug, we don't have good transition between lockscreen and
picker, so, we decided to dismiss it, given that this CUJ is less
common.
Additionally,
1. switch over to dagger dependencies instead of LauncherAppState
2. Remove unused flags for show_wallpaper / show_when_unlocked
Bug: 405068076
Flag: EXEMPT BUGFIX
Test: Manual (see demo in comments)
Change-Id: I8d0d5ebdbcca806e7fa24c57f80f1cad518bd035
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles
Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate
Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix
Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
I think this animation was broken, and my previous CL accidentally
fixed it, so that blur was actually applied during app launch. This
caused some app launch performance regressions, so we will at least
disable it whenever the All Apps blur flag is enabled.
Test: presubmit, forrest
Bug: 416476673
Flag: com.android.launcher3.all_apps_blur
Change-Id: I4c7001dc84f67dbef02fbc255613b94347df91b8
This event helps us monitor via logcat when a login (after a screen unlock)
event ends.
Bug: 417839016
Test: manually unlock screen and verify the log shows up when ready
Change-Id: I051bf3d5e77b363bcfe37f995146a82e6db69a94
Flag: EXEMPT log only update
Fixes an issue where leaving All Apps did not reverse interpolators,
causing blur to disappear too quickly.
In addition, the logic in BaseDepthController is updated to ensure
100% blur is applied upon reaching max depth. Previously we were
multiplying the depth by 3, but the intention was to reach 1 when
depth reached 0.3. So the blur was only at 90% the intended value in
All Apps (which has a depth of 0.3).
Finally, related to the 100% blur, we correctly end early wakeup
when that is reached, which means we also start it again when the
blur starts changing back towards 0 again. This spins up the GPU,
CPU, and SurfaceFlinger and should help avoid missed frames.
In order to avoid negative performance hits, reducing the max blur
radius from 34dp to 30dp, so that it matches what we were hitting
previously. (The full 34dp unfortunately does cause some regressions).
Bug: 415247657
Test: Open all apps, drag back down, view animation. Also try other
Launcher state transitions.
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia5daa07525ac96c0597a25bb4320348f27a4ee56
The reason is that there is extra translation applied to account for the all apps moving. Rather we should only offset any translation when -windowInsets.bottom < 0.
bug: 416323265
Test: videos in bug
Flag: EXEMPT bug fix
Change-Id: I3565d3a2ee09f545c0d01aa0ce3da8f80a017308
- Only IDP is updated when displayInfo changes but DPs of CD don't. As
a result taskbars on CD end up reusing the old config DPs. For
example, when user changes display size, displayInfo updates but
taskbars on CD continue using old DP resources.
- So, update DP for CD when DisplayInfo changes.
- Also added using supplied context with dpToPx for calculating radius
for taskbar roundedness at the ends.
Fix: 414933860
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I7d8ed3c5ba69b755a58d3462a5da9ed7fd404198
That test can continue running in the "Time-limited test" thread,
and we don't know whether it makes sense to wait for its completion.
Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: I3bdd6e5b07f109124f938766b7f2e427d2e39b01
TaskbarRecentAppsController#reloadRecentTasksIfNeeded() triggers a call
to fetch Recents tasks, that call is expensive as it goes through WM
Shell and the system server. If we trigger reloadRecentTasksIfNeeded()
multiple times we're queueing up multiple calls to fetch Recents tasks.
With this CL we avoid queueing up multiple calls, and instead just make
one new call when the old one finishes. That way we can only ever have
one call getRecentTasks() call triggered through
reloadRecentTasksIfNeeded() posted at any one time.
Bug: 415090968
Flag: com.android.window.flags.enable_taskbar_recent_tasks_throttle_bugfix
Test: TaskbarRecentAppsControllerTest
Change-Id: I58b66e4564af4e64837317a9de7be398395d8568
When previewing grid, actual widgets are updated. Revert grid changes
when preview binder dies to restore original widget layout in Launcher.
Flag: com.android.systemui.shared.new_customization_picker_ui
Bug: 408934352
Test: manually verified
Change-Id: I18f63fd1760b1188306defd2a8315fe5765dab01
Revert submission 33554447-b/414789280
Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.
Fix: 417614196
Reverted changes: /q/submissionid:33554447-b/414789280
Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
Root clause: In connected displays, the recents windows are rendered in a separated window instead of in Launcher / QuickStepLauncher. And thus, Launcher#onScreenOnChanged doesn't clean up the recents windows upon screen off.
This CL also updates RecentsState#toString to make it easier to differentiate RecentsState from LauncherState in the logs.
Flag: com.android.launcher3.enable_overview_on_connected_displays
Test: Manually verified that the recents windows UI shown on a connected display is cleaned up after screen
Bug: 415040428
Change-Id: Iac602237943f341f1ce46d651c5b98003f3914c9
Bug: 417347351
Flag: EXEMPT wrapping the call with try/catch, no flag needed
Test: NA wrapping the call with try/catch, no test needed
Change-Id: I65725697593530d33282f5cdd8d150a80152ab6a
This change simplifies the TaskViewIcon interface by inheriting directly from View, removing redundant method declarations like `getWidth()`, `getHeight()`, `setOnClickListener()`, etc.
Affected classes are updated to use the new interface, primarily by calling `asView()` to access the underlying View methods where necessary.
Bug: 415265678
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual.
Change-Id: I281f495116a841338075d0ff35effd19316aaeec
Fixes an issue where the live tile would flicker and briefly show the
background, then switch to screenshot and animate
Fix: 399847132
Flag: EXEMPT. Bugfix
Test: Manual. See bug
Change-Id: I373e052f32af1b7fade4cce509c820d29deafe97
Added controller that would handles drags of launcher icons to the
bubble bar, displaying drop targets and creating application bubbles.
Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: build launcher
Change-Id: I593222d86f50248ceb2909ae73ccc021ef515e28
Bug: 416766306
Test: atest WMShellUnitTests:com.android.wm.shell.pip2.phone
Test: Manual - swipe up after tiling YT with video playing in Desktop,
verify PiP is not entered and there is no crash
Flag: com.android.window.flags.enable_desktop_windowing_pip
Change-Id: Ib8b1fc3979c7e2151e7c7184499334501503afb4
Reset in-app display override progress when transitioning from home -1
page. In order to come back to the -1 page user has to swipe left from
home again so in-app display override progress will be updated again.
Fixes: 416163737
Flag: EXEMPT - bugfix
Test: Manual. enable 3 buttons navigation mode. Have bubble bar with
bubbles. Swipe to -1 page. Click recent apps button. Click home.
Change-Id: Ibc67f6e024f5c89efb7f80f420fc859aaa9d3e33
mpodolian
Schneider Victor-Tulias
Shamali P
Charlie Anderson
Alex Chau
Sergey Pinkevich
Treehugger Robot
Andy Wickham
Matthew Mourgos
Brandon Dayauon
Federico 'Morg' Pareschi
Ajinkya Chalke
Vadim Tryshev
Gustav Sennton
Sunny Goyal
Catherine Liang
Priyanka Advani (xWF)
Steven Ng
Surbhi Kadam
Ebru Kurnaz
Jordan Silva
Sebastián Franco
Tony Wickham
Sam Cackett
Merissa Mitchell