Commit Graph

4763 Commits

Author SHA1 Message Date
Thales Lima 07c6b8d96d Use DeviceProfile numFolderRows and numFolderColumns
Invariant hold values that are not related to current DP in use. This is a change needed for IDP to hold more values in the future akin to iconSize.

Bug: 309800141
Change-Id: Iefb388a5f6590d7da3452d2c388c02bd5e9d32bb
Flag: N/A
Test: NexusLauncherTests
2023-11-21 11:47:21 +00:00
Vadim Tryshev 615b744930 Demoting testUninstallFromWorkspace, which is a 4% presubmit blocker
Bug: 311099513
Flag: N/A
Test: presubmit
Change-Id: I699e3198eaa632f3977e89498c62ecb8e6956255
2023-11-20 18:48:54 -08:00
Vadim Tryshev a75fd790ea Merge "Avoiding unconditional 5 sec wait in the beginning of inproc tests" into main 2023-11-21 01:59:09 +00:00
Sebastian Franco d30100eaa9 Move classes inside of CellLayoutBoard to their own file
Previous step for adding unit testing for MultipageCellLayout.

Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Test: ReorderAlgorithmUnitTest
Change-Id: Ia5ca0b10481d7a21883594434b3406fb3a5ccf0b
2023-11-20 17:58:24 -06:00
Tony Wickham e1f770df2f Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: I48b4c809025a9bab0a37ada1317adee823b1a8f9
2023-11-20 23:41:01 +00:00
Himanshu Gupta 23876959e5 Merge "Fixing Launcher crases due to methods being called on Ui Threads." into main 2023-11-20 23:02:46 +00:00
Vadim Tryshev 3f7e82e81d Avoiding unconditional 5 sec wait in the beginning of inproc tests
Also merging waiting after enabling test provider for the inproc and OOP
cases.

Bug: 311023703
Test: presubmit
Flag: N/A
Change-Id: I417111d984bb0b0d79bada61595e46a6b924ea7c
2023-11-20 13:55:13 -08:00
Himanshu Gupta 2b5620b295 Fixing Launcher crases due to methods being called on Ui Threads.
This CL fixes the following two issues:
1. Launcher crashing while calling `addPrivateSpaceSettingsButton` from
   BaseAllAppsAdapter as the thread is UI
2. Decorator is not removed from Private Space Header during reset to
   paused state. https://screenshot.googleplex.com/BZdLqaZQwdDApfV

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 311337961, 311342946
Test: Ran Launcher3 tests
Change-Id: I2763338ebf0f5468ad38f61a781e8a8334194c5c
2023-11-20 18:59:13 +00:00
Jagrut Desai 1a16edea37 Logging for ActivityLeak - Launcher
Test: Presubmit
Bug: 273347463
Flag: NONE
Change-Id: I9825fd18a89354bff2bedf1c43f0d3170a3b4795
2023-11-20 10:44:16 -08:00
Alex Chau 940fbe1e2d Merge "Avoid instantiating unnecessary OverviewTask in getCurrentTask loop" into main 2023-11-20 18:28:40 +00:00
Alex Chau 7d237cd83a Avoid instantiating unnecessary OverviewTask in getCurrentTask loop
- Replaced with moving each size getting methods to a lambda in getCurrentTask

Bug: 309820115
Test: presubmit
Flag: None
Change-Id: Ic625e30bd42f4289bbb1768c2ceeb95e98f51a15
2023-11-20 13:13:44 +00:00
Fengjiang Li e5f91a4c7a Only log COLD_DEVICE_REBOOTING startup latency logs
Fix: 305391017
Test: Unit test
Flag: NA
Change-Id: I976add25ea14d49e2ea84e395985edb9f559370c
2023-11-17 14:00:51 -08:00
Vinit Nayak 7056e2d2e4 Merge "Add logs for move pointer" into main 2023-11-16 20:16:44 +00:00
Vadim Tryshev 02a9f44ae1 Merge "Demoting testAllAppsExitSearchAndFocusSearchResults from presubmit" into main 2023-11-16 19:37:36 +00:00
Vadim Tryshev 620a826e40 Demoting testAllAppsExitSearchAndFocusSearchResults from presubmit
It's a 35% presubmit blocker

Bug: 295939967
Test: presubmit
Flag: N/A
Change-Id: I004112093d830bdf8586d0f10327355400d08103
2023-11-16 10:14:18 -08:00
Sebastián Franco da18b9e435 Merge "Use the number of shown hotseat icons instead of database items to store into the DB" into main 2023-11-16 15:33:51 +00:00
Sergey Pinkevich 172eb5896b Merge "Show split screen action for each task" into main 2023-11-16 10:03:44 +00:00
Sebastian Franco 2d023e26c6 Use the number of shown hotseat icons instead of database items to store into the DB
It seems this issue was originated from ag/14129534 and we should no
longer use numDatabaseHotseatIcons form IDP and use numShownHotseatIcons
from the DP.

Fix: 305119735
Flag: NA
Test: manuall testing, we don't have this test for landscape
Change-Id: Ie530748f9b77d89ac3298c187ae767643d505cb3
2023-11-15 21:34:38 -06:00
Vinit Nayak b39abc99cd Add logs for move pointer
* Appears in the flaky case we're getting a
long-press instead of a move.
Suspect performance might be an issue? Hopefully
the log between ACTION_DOWN and subsequent move can
show how long that is taking

Flag: None
Test: None
Bug: 311099513
Change-Id: I305dfdf7c6b64ef24ee5fec34a3f827ce6fbe2af
2023-11-15 16:42:40 -08:00
Hyunyoung Song 647be66c38 Merge "Enabling Private Space Container in Launcher." into main 2023-11-15 23:14:34 +00:00
Vadim Tryshev ebf08d8b75 Having longer period of waiting for Launcher restart only in Launcher test suites
This will help to avoid breaking other test suites by this increase.

Bug: 311023703
Test: presubmit
Flag: N/A
Change-Id: Ia91b03b72fa6592684e7a1673b9b56448f637dd4
2023-11-15 13:00:37 -08:00
Vadim Tryshev d940da38be Merge "Revert "Increasing wait time for Launcher restart after enabling test provider"" into main 2023-11-15 18:08:15 +00:00
Sergey Pinkevich ead5259f9a Show split screen action for each task
Remove previous condition:
1. `taskView.containsMultipleTasks()` - there is already a check to filter out "Split screen" item: https://googleplex-android.googlesource.com/platform/packages/apps/Launcher3/+/refs/heads/main/quickstep/src/com/android/quickstep/TaskOverlayFactory.java#68

Edit previous condition:
2. `notEnoughTasksToSplit` - condition saying if there is less than 2 recent tasks. We still should give the possibility to split the screen if Taskbar is not presented

Bug: 305958994
Flag: NONE
Test: manual - took a photo (https://screenshot.googleplex.com/7doU5z9AjxxETUo)

Change-Id: I3fdfea987c426d557a91b0a25af368069e8af3f8
2023-11-15 15:14:50 +00:00
Himanshu Gupta 739b3c9f22 Enabling Private Space Container in Launcher.
This CL adds the following:
1. Adds filtering and addition of Private Profile apps in main user
all apps recycler view
2. Enables decoration of Private Profile apps
3. Enables hiding Private Space container based upon a settings entry.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I33dc55a3a39e75d3fc336ca6a488b282e2dd322c
2023-11-15 15:08:59 +00:00
Alex Chau 013af87a10 Merge "Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile" into main 2023-11-15 10:06:53 +00:00
Vadim Tryshev 98a0efd2dc Revert "Increasing wait time for Launcher restart after enabling test provider"
This reverts commit 47bcb2b6c5.

Reason for revert: b/311023703

Change-Id: Ib0fea7682c8499c1e900c04e818db67363af311b
2023-11-14 22:16:00 +00:00
Vadim Tryshev 8ed8d67d63 Merge "Increasing wait time for Launcher restart after enabling test provider" into main 2023-11-14 19:48:39 +00:00
Alex Chau c09a98a87d Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile
- Also fix WindowBounds.isLandscape to use full display bounds to determine isLandscape, otherwise both orientation will be treated as isLandscape when using availableSize

Bug: 309801705
Test: manual and presubmit
Flag: NONE
Change-Id: Ic7f4235e620d4760a9af356f23066fe5b23304e6
2023-11-14 18:38:51 +00:00
Himanshu Gupta 775f5ca9c6 Merge "Adding Private Space views to Launcher." into main 2023-11-14 18:33:42 +00:00
Vadim Tryshev 47bcb2b6c5 Increasing wait time for Launcher restart after enabling test provider
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.

Perhaps restart take longer than usual because the system is still busy
killing setup wizard.

This is the second attempt to land this CL; the first one was reverted
because the revert author believed this breaks their tests.

This time I'm icreasing the wait from 10 to 30 (not 60) secs.

Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: I18cff219cf6ec2732ed181c970cb5315bf568cab
2023-11-14 10:16:05 -08:00
Himanshu Gupta 08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Vadim Tryshev 18c1038ddf Merge "Making killing setup wizard a permanent solution" into main 2023-11-13 20:20:07 +00:00
Jordan Silva 1fb00ea561 Merge "Responsive grid cleanup" into main 2023-11-13 15:03:29 +00:00
Mike Schneider a9e73583bc Merge "Revert "Increasing wait time for Launcher restart after enabling test provider"" into main 2023-11-13 14:57:49 +00:00
Mike Schneider 27f0b77357 Revert "Increasing wait time for Launcher restart after enabling test provider"
This reverts commit a333756f0c.

Reason for revert: Seems to permanently break flickr tests with a timeout (https://android-build.corp.google.com/test_investigate/?invocationId=I84700010216659574&testResultId=TR17229044551287787)

Bug: 310269045
Change-Id: I49631dc10111e7bcd4b663ec5b26ee79885da246
2023-11-13 13:25:48 +00:00
Vadim Tryshev aecbc650fc Merge "Disabling strict activity leak check more aggressively than in ag/25340909" into main 2023-11-11 02:26:06 +00:00
Vadim Tryshev 4c2bf22c8d Merge "Demoting a couple of presubmit blocker tests" into main 2023-11-11 00:53:21 +00:00
Vadim Tryshev 94cb915d38 Disabling strict activity leak check more aggressively than in ag/25340909
That CL wasn't sufficient, still seeing:
https://android-build.corp.google.com/test_investigate/?blocking=warning&invocationId=I37300010216048087&status=none&testResultId=TR78329041431354974

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I36979a8929ccb996b81e8d41ec75b9713258c1c3
2023-11-10 16:41:42 -08:00
Vadim Tryshev 761b735728 Demoting a couple of presubmit blocker tests
Bug: 310242894
Test: presubmit
Flag: N/A
Change-Id: Ifd4dd430dbb645b5ab066742dd3ec861de3dfffa
2023-11-10 15:14:04 -08:00
Kevin Lim c3909d970b Merge "[Tiger] Re-adding PlatinumTest annotation" into main 2023-11-10 21:56:12 +00:00
Vadim Tryshev 1f8ff66235 Making killing setup wizard a permanent solution
It will be killed only in presubmit. In postsubmit, we want to be a true
e2e test exposed to all actual problems, including setup wizard that
doesn't go away.

Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I2e877eade060e75e277eb3603d90b659207b5a47
2023-11-10 12:20:45 -08:00
Vadim Tryshev d315ffcb8f Merge "Increasing wait time for Launcher restart after enabling test provider" into main 2023-11-10 19:58:20 +00:00
Vadim Tryshev a333756f0c Increasing wait time for Launcher restart after enabling test provider
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.

Perhaps restart take longer than usual because the system is still busy
killing setup wizard.

Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: Idd576cacc300bce071bb40743209b4a111f18473
2023-11-10 10:31:14 -08:00
Pat Manning da5baa981a Merge "Fix focus nav of AllApps when Searching." into main 2023-11-10 18:20:01 +00:00
Pat Manning e7cb65009e Fix focus nav of AllApps when Searching.
- Do not focus the Icon in Small Icon Result Rows
- Use FocusIndicatorHelper when focusing search result icons

Flag: NONE
Bug: 296844600
Fix: 310173226
Test: Test: TaplKeyboardFocusTest
Change-Id: Icfc82ae41ffc8ef7c7ad42950f98f3d2dc805795
2023-11-10 16:48:21 +00:00
Kevin Lim 9bb62ee9c1 [Tiger] Re-adding PlatinumTest annotation
This undoes ag/24559527 as this test is no longer flaky.

Actual PlatinumTest presubmit restoration is done in cl/581071347

Bug: b/293944634
Flag: N/A
Test: Test only change
Change-Id: I605f8911fa3a3658c49642efee8d6166545ae89b
2023-11-10 01:37:15 +00:00
Jordan Silva 8f7986abae Responsive grid cleanup
This CL renames some of the variables to keep it consistent across the code. It removes workarounds that were made to facilitate easy code reviews without breaking the tests.
It is a cleanup of the responsive grid feature.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I198fadfbcfc0d1b32a62a3076949b42ee1fbcf33
2023-11-09 22:06:03 +00:00
Uwais Ashraf 8e1e2a5155 Merge "Use instrumentation arg to prevent unnecessary delays in unit tests" into main 2023-11-09 16:03:20 +00:00
Uwais Ashraf b5d08b246e Use instrumentation arg to prevent unnecessary delays in unit tests
Bug: 308792359
Flag: NA
Test: presubmits passing
Change-Id: Ib38db86057998fcf859a44fa190e6cc4d82263dd
2023-11-09 12:07:18 +00:00
Vadim Tryshev 572b5b09fd Merge "Allowing ACTION_CANCEL events to come from device 0" into main 2023-11-09 01:42:16 +00:00