Commit Graph

4763 Commits

Author SHA1 Message Date
Sunny Goyal 98001dd1dc Merge "Migrating prediction_undo to aconfig" into main 2024-09-16 17:26:58 +00:00
Alex Chau 03aa04d45b Revert "Adds new log constant to track overview select tooltip misalignment"
This reverts commit cbc8bf0443.

Reason for revert: b/332485341 is fixed, revert logging constant previous added

Change-Id: I970a3af9905037a51bd9748324f35ac80de9b06b
2024-09-16 10:37:50 +00:00
Sunny Goyal d94100a223 Migrating prediction_undo to aconfig
Flag: com.android.launcher3.enable_dismiss_prediction_undo
Test: atest SystemShortcutTest
Bug: 270394476
Change-Id: I5daef5d168c301115d860a1ae1d3c96f70a0f18f
2024-09-13 20:21:32 -07:00
Treehugger Robot e738e4bf07 Merge "Revert "Add screenrecord for testDragAppIcon"" into main 2024-09-14 02:21:30 +00:00
Treehugger Robot 2ff010dfbe Merge "Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"" into main 2024-09-14 02:18:53 +00:00
Federico Baron c4bb97b64e Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"
This reverts commit 2b724ec00d.

Reason for revert: cleanup

Change-Id: I59140f34ac86ef1d25e707509bd52ddeb3ddf061
2024-09-14 00:13:59 +00:00
Federico Baron 375c88b05e Revert "Add screenrecord for testDragAppIcon"
This reverts commit 701eef07ab.

Reason for revert: cleanup

Change-Id: I489e8e79924c402ed5228781af4bd4065daca42e
2024-09-14 00:13:22 +00:00
Treehugger Robot 925edf7906 Merge "Add tapl test for isTablet" into main 2024-09-14 00:12:27 +00:00
fbaron 6a65aebcc6 Add tapl test for isTablet
Bug: 366237798
Test: TaplIsTabletTest
Flag: EXEMPT TEST_ONLY
Change-Id: I806caa5e98b39fc6475c8807003646540f32b509
2024-09-13 11:11:06 -07:00
Kevin Lim f1b5855af7 [Testing] Renamed incorrectly named FloatingHeaderViewTest
FloatingHeaderviewTest was named with ...Tests (plural), preventing it from
being excluded from launcher-testing-helpers-robo and getting included
in some unintended tests.

Bug: b/341795751
Flag: EXEMPT test renaming.
Test: Running FloatingHeaderViewTest
Change-Id: I8149f0a5548e77674bb2a23a34bd7671e0a3b371
2024-09-12 20:57:14 +00:00
Treehugger Robot c912c8fb8b Merge "Improving regex for detecting a local platform build" into main 2024-09-11 19:48:47 +00:00
Vadim Tryshev 460192588f Improving regex for detecting a local platform build
Platform build can now have versions line "eng.himans"

Bug: 187761685
Test: online regex verifier
Flag: NONE test change
Change-Id: I86b9324dfbbc36272215eae58af836e9a3741d70
2024-09-11 10:39:31 -07:00
Sunny Goyal f2e2532e62 Merge "Remove obsolete features" into main 2024-09-09 22:43:14 +00:00
Mykola Podolian 5feb4a969a Merge "Fix falling tapl tests" into main 2024-09-09 17:19:12 +00:00
Nick Chameyev 02cc26f055 Merge "Capture Launcher icon positions by reusing UiObject2" into main 2024-09-09 10:43:10 +00:00
mpodolian 39383dd5b3 Fix falling tapl tests
Fix the root cause of falling tests.

Bug: 359277238
Flag: TEST_ONLY
Test: TaplTestsQuickstep,TaplTestPersistentTaskbar
Change-Id: I1e3138e26d0ab253dff7a64cbb3253c220a7db1a
2024-09-07 09:13:53 -07:00
Nick Chameyev 11c0ebcd57 Capture Launcher icon positions by reusing UiObject2
Reuse the same UiObject2/HomeAppIcon objects
when capturing Launcher icon positions.

When invoking 'launcher.workspace.allWorkspaceIcons'
we wait for the animation to finish which makes
the test fail as we expect to capture icon positions
midway through the animation.

Test: atest LauncherFoldAnimationTest
Bug: 315163608
Bug: 296991492
Flag: EXEMPT bugfix
Change-Id: I668d15165e4c777b3be24d66ad3f7888eaca2fea
2024-09-06 14:13:36 +00:00
Sebastian Franco 4e65f94200 Removing screen record from TaplWorkProfileTest
Fix: 322823478
Test: TaplWorkProfileTest
Flag: TEST_ONLY
Change-Id: I4f5b2da8e1909b90146025654d100b9eadd0e577
2024-09-05 11:00:10 -07:00
Sebastian Franco 750e8496ef Reducing the wait time for events for less than the Test timeout
The test timeout is the time the test infraestructure allows a test
to be idle for. Because of it, we don't get the event tiemout error
so reducing the timeout wait will allow us to get the event error.

Bug: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: Ic43210a3ca5b5239b1156753bdf8253cd738bdec
2024-09-03 12:55:38 -07:00
vinayjoglekar 3359fa7f32 Fix talkback in split mode
1. Announce description of both snapshot in GroupedTaskView.
2. Announce them in correct order.

After setting right content description for both the apps in split mode, announcement order was reverse. Seems that order of the node tree which android sees was wrong. Also order did not change even in RTL mode.

see here https://paste.googleplex.com/6492038621298688.

The correct order is manually set using addChildrenForAccessibility in GroupedTaskView. (similarly being used in RecentsView since we use reverse order for overview). Also considered RTL.
See order after fix here
https://paste.googleplex.com/6492038621298688

https://drive.google.com/file/d/1BA1YKkcNsovEu4us9cvq5xOdXviTR1OV/view?usp=drive_link

Other alternatives tried were fixing order using android:accessibilityTraversalAfter and android:accessibilityTraversalBefore, both in layout and programatically which doesn't seem to work.

Test: Manual - Using Node tree debugging of talkback developer options.(Print and filter by tag TreeDebug)
BUG: 330424779
Flag: EXEMPT bugfix
Change-Id: If3c360277bd951d2d2b223bab7844e078e9c7d27
2024-09-03 15:22:30 +01:00
Jihoon Kang a2dc65a2a1 Merge "Make java_sdk_library dependencies explicit" into main am: 10f0f9a93b am: 612b153591
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3250185

Change-Id: I37d8a779985f820befa52be51df8101f53ed12bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-30 20:41:29 +00:00
Jihoon Kang 612b153591 Merge "Make java_sdk_library dependencies explicit" into main am: 10f0f9a93b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3250185

Change-Id: Ic156ed0a774b6d6a40af20a1852846503e229b77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-30 20:11:39 +00:00
Sunny Goyal 7a548377eb Remove obsolete features
Flag: EXEMPT legacy ENABLE_TWOLINE_DEVICESEARCH, ENABLE_ICON_IN_TEXT_HEADER, ENABLE_PREMIUM_HAPTICS_ALL_APPS
Bug: 270396358
Bug: 201388851
Bug: 270395143
Test: Verified manually
Change-Id: I88ca7b255d2ae4eba393c1aee52153ef0a459140
2024-08-30 13:04:08 -07:00
Jihoon Kang 9f8e4b6b62 Make java_sdk_library dependencies explicit
modules should specify the submodule of java_sdk_library that the module
actually depends on

Test: CI
Bug: 358613520
Change-Id: If1b96a7ffa7ddde50c44817e0d96257ae2967a0e
2024-08-30 00:29:41 +00:00
Jagrut Desai a68e4fe0de Merge "Promote TaplAddWidgetTest#testResizeWidget" into main 2024-08-29 22:43:30 +00:00
Jagrut Desai 728096835a Promote TaplAddWidgetTest#testResizeWidget
Test: Presubmit
Bug: 316910614
Flag: TEST_ONLY
Change-Id: Ic4b927f523df7ac531fdbd88670adb12fc43df13
2024-08-29 09:27:57 -07:00
Treehugger Robot a587ea691e Merge "Promote testUninstallFromWorkspace to presubmit" into main 2024-08-29 00:27:34 +00:00
Vinit Nayak d42af4b55e Promote testUninstallFromWorkspace to presubmit
Bug: 311099513
Test: None
Flag: EXEMPT bugfix
Change-Id: I28731c173e4cdb473e4fc9fb954a82a5f57c02f5
2024-08-28 15:15:15 -07:00
Sebastián Franco b9ce69db9e Merge "Correctly map the drag view position to the Workspace" into main 2024-08-26 21:13:06 +00:00
Sebastian Franco 4bedb18466 Correctly map the drag view position to the Workspace
The drag view needs to be mapped to the drop target which in this
case is the Workspace instead of the CellLayout

Fix: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I233c2b3bf0b8637f80d74d201189b2290ef59c94
2024-08-25 20:41:00 -07:00
Sihua Ma a9e4324bd5 Rename test helper filegroup to robo
Test: N/A
Flag: EXEMPT filegroup rename
Change-Id: I8afeccc69fbca8e317c6b74a051d6b94239b8c52
2024-08-23 22:13:33 +00:00
Tony Wickham 3a47759619 Merge "Fix Taskbar being visible over Hotseat when recreated in Overview" into main 2024-08-22 18:51:55 +00:00
Sebastián Franco 6edce2ad75 Merge "Remove test to postsubmit while they are flaky" into main 2024-08-22 17:08:45 +00:00
Treehugger Robot 7369348ba8 Merge "Delete dead test SettingsActivityTest" into main 2024-08-22 10:01:55 +00:00
Alex Chau eececf272e Merge "Reset mTopRowIdSet in applyLoadPlan" into main 2024-08-22 09:49:27 +00:00
Sebastian Franco f989210f5b Remove test to postsubmit while they are flaky
Bug: 332527963
Test: ReorderAlgorithmUnitTest
Flag: TEST_ONLY
Change-Id: I29d631ba7dfe7f2c3a5323bfb414cb4da5b3321b
2024-08-21 15:20:18 -07:00
Tony Wickham 5c32af7e5b Fix Taskbar being visible over Hotseat when recreated in Overview
Debugging locally, it seems there were a couple of state changes
and the last one (which is correct) was getting clobbered by a
previously destroyed instance of TaskbarLauncherStateController.
Fixed this by updating the isDestroyed() call which previously
only checked TaskbarActivityContext to now check
TaskbarLauncherStateController's destroyed state directly. This
is needed because TaskbarLauncherStateController is part of
LauncherTaskbarUIController which can be destroyed independently
of the other Taskbar controllers when Launcher is destroyed.

Also fix a debug log that was not updated long ago in ag/21122190

Flag: EXEMPT bugfix
Test: Go to overview, change Font Scale or Dark Theme from Quick
settings, ensure Taskbar is not visible over Hotseat
Fixes: 302923055

Change-Id: I1299462955b51a2bf931f022177045b1cec039c5
2024-08-21 21:43:54 +00:00
Alex Chau 9109b81a95 Reset mTopRowIdSet in applyLoadPlan
- All taskViewIds become obsolete after removing and re-adding, so we'll need to reset mTopRowIdSet when removing all taskViews
- OverviewActionsView.updateActionButtonsVisibility can be called before updateDimension (where mDp is set), so a null check is necessary
- Fixed TestStaibilityRule failing when running FallbackRecentsTest alone. FallbackRecentsTest runs with 3P Launcher, in that case launcherPackageName is our test activity, and launcherVersion can be null. This can only occur in a local run, thus return LOCAL in this case.

Fix: 355042336
Test: FallbackRecentsTest and manually testing dismiss
Flag: EXEMPT BUG_FIX
Change-Id: I9125ea38a567deb0d3028e7d7407397d1dc06ade
2024-08-21 12:37:14 +01:00
Alex Chau 1eebacf636 Merge "Clean-up debug logs" into main 2024-08-21 10:53:21 +00:00
Uwais Ashraf 06ffcf8c61 Merge "Migrate model tests to multivalent" into main 2024-08-21 10:05:40 +00:00
Anushree Ganjam 77aed7422a Dismiss the setup wizard for both presubmit and post submit tests.
In the past we have faced setup wizard not dismissed issue but eng prod
team has not fixed this issue. See b/309008042 for more details.

Bug: 359658695
Bug: 359658158
Bug: 356695093
Bug: 355718051
Flag: TEST_ONLY
Test: Manual
Change-Id: Ief020483fa167946193875f9d6c089d1cfd55124
2024-08-20 17:07:30 -07:00
Alex Chau fdbfd3410b Clean-up debug logs
Fix: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ie66a34134881e4333f610d8979b2ac443d54a1cb
2024-08-20 19:01:19 +01:00
Alex Chau 6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Sihua Ma 58e8573085 Migrate model tests to multivalent
Also migrating some other tests that have been verified

Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I072201b8e7b98945ca88657fe813fef4727f16e4
2024-08-20 07:28:35 +00:00
Alex Chau d326e17fe2 Add logs for getFocusedTaskHeightForTablet
Bug: 336660988
Bug: 360724626
Test: presubmit
Flag: TEST_ONLY
Change-Id: I67d4fc8211f24b77566bd24525d23054dfdded6e
2024-08-19 20:39:41 +01:00
Shamali Patwa accd0f68c8 Merge "Update the scale on corner radii on scaled image drawable." into main 2024-08-16 20:37:57 +00:00
Treehugger Robot a21058eb88 Merge "Move TouchEventGenerator to multivalent" into main 2024-08-16 06:04:22 +00:00
Shamali P c7e1b5c975 Update the scale on corner radii on scaled image drawable.
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.

This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.

Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
2024-08-15 02:54:17 +00:00
Andrew Cole d61fbd4140 IconCacheUpdateHandlerTest
This is the unit testing for the updates to IconCacheUpdateHandler

Bug: 357725795
Test: SELF
Flag: TEST_ONLY
Change-Id: I159f5ef70fcc9a5aae7bb319f06a3ff935f28246
2024-08-14 15:57:42 -07:00
Sihua Ma 97ed80634d Move TouchEventGenerator to multivalent
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I6603b4764de6708cb0c3d7c2a52c0ffb81607771
2024-08-14 21:17:44 +00:00