Commit Graph

20057 Commits

Author SHA1 Message Date
Inseob Kim 6081b583f8 Merge "Revert "Make AllAppsRecyclerViewContainer GONE when hidden"" into udc-qpr-dev am: 40a44e08b9 am: 1f2a4d7c25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24317936

Change-Id: I97b6eb5deb44bd20f7d6379cac0ce8bdc50415d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-04 05:27:42 +00:00
Inseob Kim 40a44e08b9 Merge "Revert "Make AllAppsRecyclerViewContainer GONE when hidden"" into udc-qpr-dev 2023-08-04 04:13:28 +00:00
Inseob Kim a163646c7a Revert "Make AllAppsRecyclerViewContainer GONE when hidden"
This reverts commit df59c2e535.

Reason for revert: b/293944420

Change-Id: I0ae830e1a5ba8affb6815c9e96ffee1b20c6e8d0
2023-08-04 02:18:44 +00:00
Sebastian Franco a99e1d2a14 Ensure the reorder test runs on the foldable devices
It moves some classes form the Nexus package into the launcher package
so it can be used in both projects.

It also adds more test for foldables and test multiple
grids for each test.

Bug: 289584301
Fix: 291346193
Test: ReorderWidgets
Change-Id: I04db5f685d0344b8a3f3d42b429bbde061b3d8ea
2023-08-03 16:35:29 -07:00
Alex Chau 98ba3fd7d0 Fix return condition in getWorkspacePageTranslationProvider am: c325c686c7 am: e7cfae1a26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24308816

Change-Id: I1384528f2dcc5011198233fe85cc5a20699202b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-03 17:29:24 +00:00
Holly Sun 19f6525546 Refresh mNumAppsPerRowAllApps when device profile changes.
The return value of SrollableLayoutManager#getItemsHeight is wrong, which is caused by the return value of `incrementTotalHeight` (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/util/ScrollableLayoutManager.java;l=151-163). In AllAppsGridAdapter#incrementTotalHeight (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/allapps/AllAppsGridAdapter.java;l=172), `item.rowAppIndex` is still the staled value after app grid change / device fold & unfold. This value is calculated in AlphabeticalAppsList (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/allapps/AlphabeticalAppsList.java;l=276-280). The mod `mNumAppsPerRowAllApps` is staled. So add an setter in `AlphabeticalAppsList` to update `mNumAppsPerRowAllApps`.

Bug: 262003765
Bug: 284940820
Test: manual
Flag: N/A
Change-Id: I74a99a3dc58ee45f066bcefb3e9c56be02b62f82
2023-08-03 09:39:18 -07:00
Alex Chau c325c686c7 Fix return condition in getWorkspacePageTranslationProvider
- When EDIT_MODE was introduced, it added a wrong condition to make it always return DEFAULT_PAGE_TRANSLATION_PROVIDER

Bug: 294228521
Test: manual
Change-Id: If970949c8ab55bc67f98f987a7654ec2db89cdfb
2023-08-03 14:38:33 +00:00
Jeremy Sim 94fd07e5da App Pairs: Implement save, inflate, launch, and delete
This is the third of several patches implementing the App Pairs feature behind a flag.

This patch includes:
- AppPairIcon and associated XML. Actual icon asset is placeholder for now
- Ability to launch split pair on click
- Icon can be moved around, incl. to Taskbar
- App pair can be deleted by dragging to "Remove" drop zone
- Icon persists on Launcher reload

Change-Id: I88aec6fbc814be98f9ef048bbc5af889d0797970
Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274835596
Test: Not included in this CL, but will follow
2023-08-02 12:08:41 -07:00
Alex Chau f00f9bc163 Merge "Skip iconScale logic in responsive grid" into udc-qpr-dev am: baf96f7487 am: 97c9bc4160
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24281931

Change-Id: Ie0411396d0ce05deafd2d50d6b917eb02c648091
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-01 18:49:38 +00:00
Alex Chau 5225e83d71 Skip iconScale logic in responsive grid
Fix: 289198168
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileResponsiveDumpTest, DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: Iefe9ab3986a6d50ac920ba7bf417c0a8f254d878
2023-08-01 16:34:09 +01:00
Brian Isganitis b9e80352a6 Merge "Back open-close animation with an AnimatorSet." into udc-qpr-dev am: 3067ec6632 am: c45827b8d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24247111

Change-Id: I23d05068ed252269ad26430cb75fb2d7fb911b66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-31 23:07:21 +00:00
Fengjiang Li cd1029ca70 Merge "Make AllAppsRecyclerViewContainer GONE when hidden" into udc-qpr-dev am: 068df4c1ca am: 01cce1cf68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24107285

Change-Id: Ia11d4d7d9b30511404c6ab4772a11de51fd53df4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-31 22:01:29 +00:00
Brian Isganitis 3067ec6632 Merge "Back open-close animation with an AnimatorSet." into udc-qpr-dev 2023-07-31 22:01:07 +00:00
Luca Zuccarini 0066ec441b Merge "Update default value for container launch animations to TEAMFOOD." into udc-qpr-dev am: 36e7df0d47 am: dd7a915c45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24150096

Change-Id: I270b9deaf0797800a425bdfb4e0d568078d7795e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-31 20:36:04 +00:00
Fengjiang Li 068df4c1ca Merge "Make AllAppsRecyclerViewContainer GONE when hidden" into udc-qpr-dev 2023-07-31 20:27:21 +00:00
Brian Isganitis d280c2f946 Back open-close animation with an AnimatorSet.
Subclasses can add more animations to the set to animate other
components in sync with themselves.

Test: Manual
Bug: 289290185
Flag: No
Change-Id: I96d9afe166e243bb0d2a9cecb8158e2e7d431a6c
2023-07-31 19:47:26 +00:00
Luca Zuccarini 36e7df0d47 Merge "Update default value for container launch animations to TEAMFOOD." into udc-qpr-dev 2023-07-31 19:21:03 +00:00
Fengjiang Li df59c2e535 Make AllAppsRecyclerViewContainer GONE when hidden
Test: N/A
Flags: ALL_APPS_GONE_VISIBILITY
Bug: 264341825
Change-Id: I28933c08e80b95bcd5031da9869b37f34f6408b2
2023-07-31 10:41:58 -07:00
Johannes Gallmann 382c89019b Merge "Extract Launcher resource interpolators to Animation Library" into udc-qpr-dev am: 19721d5e28 am: dc102e97d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24160396

Change-Id: I9111bd5e67ced980a30a42cdb9f70b6d9de1a478
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-31 13:49:14 +00:00
Johannes Gallmann 19721d5e28 Merge "Extract Launcher resource interpolators to Animation Library" into udc-qpr-dev 2023-07-31 12:36:43 +00:00
Andy Wickham eed6d85c4b Merge "Revert^2 "Change Overview Actions to round buttons."" into udc-qpr-dev am: fd35baa3f8 am: aadf1c6ce8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24195750

Change-Id: I374cadf571992e0620c20bd3fbea5e2f09c79a34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-28 23:31:07 +00:00
Andy Wickham fd35baa3f8 Merge "Revert^2 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-28 21:57:54 +00:00
Brandon Dayauon 8bd8819796 Remove unused onboardingPrefs
bug: 285890538
Flag: false- ENABLE_SHOW_IME_SNACKBAR_AGAIN
test: manual
Change-Id: Ib84133d47d9cbadeb65f3b28a9e4a1558bca8258
2023-07-28 12:15:44 -07:00
Sebastián Franco e64c8effd3 Disable FOLDABLE_SINGLE_PAGE
The functionality should go back to the same as with phones.
There shouldn't be issues with the reorder or similar behavior since we
are switching form using the MultipageCellLayout to the regular
CellLayout.

The things we need to pay attention to is the the behavior of having two
panels like adding the right number of panels when loading (folding, unfolding and rotating).

Bug: 291822492
Change-Id: I903873e32f35c5ee9e0f3da8581a37d4087d021f
Test: ReorderWidgets
Meged-In: I903873e32f35c5ee9e0f3da8581a37d4087d021f
2023-07-27 23:07:38 +00:00
Anushree Ganjam f0b28e03a1 Merge "Post the mSearchUiManager.resetSearch() to next frame." into udc-qpr-dev am: 3c2a696391 am: 5637eb5958
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24198780

Change-Id: I5a2447d77e18dd3052ade61ca4f93771dcbf88fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-27 22:05:38 +00:00
Anushree Ganjam 3c2a696391 Merge "Post the mSearchUiManager.resetSearch() to next frame." into udc-qpr-dev 2023-07-27 20:59:47 +00:00
Brandon Dayauon d28f3ad2bb Merge "enable flags: ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH" into udc-qpr-dev am: d6c00c7114 am: 446453603f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24163382

Change-Id: Ida795595d1c09e2d0e5c8a8d80278fbe47a0fa1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-27 00:35:00 +00:00
Brandon Dayauon d6c00c7114 Merge "enable flags: ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH" into udc-qpr-dev 2023-07-26 22:51:55 +00:00
Schneider Victor-tulias 9dfffc7df1 Merge "Fix flaky RuntimeException in CellLayout." into udc-qpr-dev am: 06ca4d9c6e am: 12c0933c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24212787

Change-Id: Ibfce519ee888b3652e76eac6ac1b60d75c92867b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 22:17:24 +00:00
Andy Wickham be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Schneider Victor-tulias 06ca4d9c6e Merge "Fix flaky RuntimeException in CellLayout." into udc-qpr-dev 2023-07-26 20:35:15 +00:00
Schneider Victor-tulias 750c5af2da Fix flaky RuntimeException in CellLayout.
Changing the grid while a previous loader is running (more likely to happen in test) can cause a saved item info to have a cell position outside the bounds of the new grid. This should just be handled the same way as other item infos being loaded in an occupied space.

Flag: not needed
Fixes: 233989158
Test: changed grid sizes multiple times
Change-Id: Ibba337c224e7a08533331a87b1369ebf96e3c9a3
2023-07-26 10:20:24 -07:00
Vinit Nayak 841d577849 Merge "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD" into udc-qpr-dev am: dc53fdc717 am: 7b35f7a3e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24152622

Change-Id: I07318e5e4cb72074f016e2a458714b375ee2b3dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-26 02:07:51 +00:00
Vinit Nayak dc53fdc717 Merge "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD" into udc-qpr-dev 2023-07-26 00:50:33 +00:00
Anushree Ganjam 135eee0410 Post the mSearchUiManager.resetSearch() to next frame.
SearchBox gets cleared in the current frame even before we read the
input entered by the user. So clear the searchbox in next frame after
onAllAppsTransitionEnd is completed.

See ag/22266746 where this change was introduced and I want to move the resetSearch() call to next frame.

Bug: 287693114
Test: Manual . Tested with both Floating search box on and off.
Flag: NA

Change-Id: I11509cf652f96847ad3c54f20a76f2a728775fe3
2023-07-25 22:34:54 +00:00
Schneider Victor-tulias ba31fc7917 Merge "Fix home animation jank when quickly pressing home button" into udc-qpr-dev am: c73b653e1d am: e07ea9d25c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24180027

Change-Id: I064a701cb7c72af53113cffbdb10bf586926ae9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 21:55:49 +00:00
Schneider Victor-tulias c73b653e1d Merge "Fix home animation jank when quickly pressing home button" into udc-qpr-dev 2023-07-25 21:01:47 +00:00
Greg Kaiser 2a2e30ed88 Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev am: b095594afd am: d4ed91551d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24191951

Change-Id: Ie0d08c25f1c5db107df84204713ed390b7533d42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:23:06 +00:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Thales Lima 90b8b9f5fe Merge "Add twoPanelId attribute for responsive grid in device profile" into udc-qpr-dev am: d9f4d93cbf am: a23bf8144b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24160393

Change-Id: I3ee9ccbeabeb3ddec44ed1ff304d4992acb63a8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 22:14:21 +00:00
Thales Lima d9f4d93cbf Merge "Add twoPanelId attribute for responsive grid in device profile" into udc-qpr-dev 2023-07-24 21:24:00 +00:00
Andy Wickham 2000264559 Merge "Change Overview Actions to round buttons." into udc-qpr-dev am: 03b5f8b1d1 am: 48445a5fb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783599

Change-Id: I5e5ffed6f3eee007dffb60a56f9a1cd4c0dfd8d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 21:05:43 +00:00
Andy Wickham 03b5f8b1d1 Merge "Change Overview Actions to round buttons." into udc-qpr-dev 2023-07-24 19:56:23 +00:00
Charlie Anderson 7c3ed1ddc6 Merge "When unpausing work profile after reboot, we should do a single reload of the workspace." into udc-qpr-dev am: a1bcd4b146 am: 36f71229e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154771

Change-Id: Ibc3aae32003b2d6ddcee723971d4652c7f1b386c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 17:49:11 +00:00
Schneider Victor-tulias 3913e297e9 Fix home animation jank when quickly pressing home button
Pressing the home button a second time while the app icon is animating cancels the animation. The listener view's AFV doesn't need to be explicitly closed since it will be cleaned up.

Flag: not needed
Fixes: 291807246
Test: manually pressed the home button twice quickly
Change-Id: Ia963e06da78742eade91a6174c3d5f5328368bc5
2023-07-24 10:44:41 -07:00
Brandon Dayauon 19a380095e enable flags: ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH
PM said we can enable ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH flags.

bug:287307252
Flag: turning to true
test: presubmit (updated tests in previous CL ag/23835677)

Change-Id: I89ede9807205a72108f25ca3b962f8d67384f7ae
2023-07-24 07:38:38 -07:00
Johannes Gallmann a82eebd286 Extract Launcher resource interpolators to Animation Library
Bug: 292080029
Test: atest InterpolatorResourcesTest
Change-Id: I65dba4eb3f96844d4f9a4d0af608c0bd8e77ccc2
2023-07-22 09:52:53 +02:00
Andy Wickham f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Charlie Anderson 673a81be1e When unpausing work profile after reboot, we should do a single reload of the workspace.
Prevents greyed out work items from persisting that are not actually paused.

Bug: 290870690
Test: manually tested pausing work profile, rebooting, unpausing work profile. Also tested just pausing/unpausing work profile.
Change-Id: Iab6d51c9bf47b1732b9cc4278bec5119e7c6afbf
2023-07-22 02:29:50 +00:00