Commit Graph

20057 Commits

Author SHA1 Message Date
Sebastian Franco bd43b9344f Removing all restored backups except one so we don't have old backups
Adding test to make sure this is the case.

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I84c3a92f40598137d5c5c52d34af7583b384122c
2024-03-07 11:23:55 -06:00
Himanshu Gupta e2ae040e35 Merge "Revert Accidental tweak of work profile behaviour" into main 2024-03-07 13:54:11 +00:00
Brandon Dayauon 5b5110a782 Change collapse to use adapterItems instead of getting the childCount()
Using childCount() doesn't work since it only shows what is visible on the screen.
This is an issue because if the header was somewhat slightly off screen, it wouldn't scroll up upon
clicking the button.

bug: 299294792
Test:
before: https://drive.google.com/file/d/1T4rvfR3_rNmR8tRZheBXNbYjCrSubmy7/view?usp=sharing
after: https://drive.google.com/file/d/1T4UdddM7MH4onEfNdyhDM-RowKHfvjop/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD
Change-Id: I209e3ec707bfbdc2ef5e98034149459286903854
2024-03-06 18:13:16 -08:00
Brandon Dayauon d0bec45d37 Upon expanding, expand just enough so the header shows.
This issue only happens when there is a lot of private space apps that scrolling to the bottom
will not sure the private space header.

Formula to calculate how many rows to scroll to =
	(appListHeight - privateHeaderHeight - headerProtectionHeight) / cellHeight.

bug: 299294792
Test:
manually - https://screenshot.googleplex.com/76UJPT2Jnpnp2Ab
before: it just scrolls all the way to the bottom
after: https://drive.google.com/file/d/1AbprxFm1RWTQKvpt7M4khbUfc1o6-XGF/view?usp=sharing
after PHONE WITH TABS:
2x2- https://drive.google.com/file/d/1SLPsWPHenCuZuisiS7HeEy5JwtNPeONs/view?usp=sharing
3x3- https://drive.google.com/file/d/1SK82jeNZMzFJK2odIuHnfTNLYfppne83/view?usp=sharing
4x4- https://drive.google.com/file/d/1T7EhFRq2tDv2zYIvs_FMsTKcFZXwGUaD/view?usp=sharing
4x5- https://drive.google.com/file/d/1SMUPuKjO1Yg36U6P6cDOb6dTkHn6Bh7D/view?usp=sharing
5x5- https://drive.google.com/file/d/1SJCQn1O_Yq5P7C__VUfZHc5I67CEdIpb/view?usp=sharing

AFTER PHONE NO TABS:
2x2: https://drive.google.com/file/d/1THU2xrAIt0hTmN5_GwBrgN9Lqj-W4Kfr/view?usp=sharing
3x3: https://drive.google.com/file/d/1TPTUx7PcHW3GsVwVAg_L5rCcn0QYoiY2/view?usp=sharing
4x4: https://drive.google.com/file/d/1TWVWpAX6bZp_JfFKtmXYO0askl4e5qKO/view?usp=sharing
4x5: https://drive.google.com/file/d/1TDJK-swmY3Y3C4ARH_2eljqUkBGEnD3e/view?usp=sharing
5x5- https://drive.google.com/file/d/1TBJtAynwvZrGyOc-29f637wyrJZpMXBJ/view?usp=sharing

Tablet:
landscape: https://drive.google.com/file/d/1SfyPdoUnCV7e7BWLnpxXWN2HiBOQkRo2/view?usp=sharing
portrait: https://drive.google.com/file/d/1SgZq0iE9WMvIFtc8mBb577nYlS9jBa_g/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: If70df1299572f8f2edc6376dd2a6df5d74287264
2024-03-06 18:04:09 -08:00
Fengjiang Li c6ae88f904 Use Matrix.setRectToRect() replace RectUtils.letterBox()
Bug: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: Ia83f3415442c2359bffb1efcfd1ee96bf17ab9ff
2024-03-06 17:04:02 -08:00
Jeremy Sim 46aa4a58f8 Merge "Fix bug with app pairs appearing in wrong orientation in pinned Taskbar" into main 2024-03-06 21:56:34 +00:00
Vinit Nayak d1fb97ae64 Merge "On disabled app pairs, set color tint instead of changing alpha" into main 2024-03-06 18:39:19 +00:00
Jakob Schneider 343d99781f Improve "isActiveArchive" check by moving it a bit earlier into the
method.

Apply progress level doesn't need to be called unless the app is
actively being unarchived.

Previously this was fixed by adding a check directly in
"setIsDisabled()" which is not quite the right place (we can exit
earlier).

Bug: 326218355
Test: manual
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving TRUNKFOOD
Change-Id: Ia12013dbcec2d40413a6cf819f8d1787b815adc1
2024-03-06 18:12:53 +00:00
Catherine Liang d56332892d Merge "Fix Launcher preview crash" into main 2024-03-06 16:57:16 +00:00
Rohit Goyal 877da31569 Bugfix: Remove widgets and deep shortcuts of app which gets archived.
* Once app is archived, remove widgets and deep shortcuts corresponding to the app from the home screen.
* However during backup & restore, widgets should not be removed if they are being restored.

Test: verified bugfix locally.
Bug: 326567866
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:bef2930f5a29655f6c403f2d5eefd4e99a733b04)
Merged-In: Ib3a112aadc7bd901fd6a0ba86f472ec6acf8d626
Change-Id: Ib3a112aadc7bd901fd6a0ba86f472ec6acf8d626
2024-03-06 14:48:09 +00:00
Jeremy Sim 999ab5215a Fix bug with app pairs appearing in wrong orientation in pinned Taskbar
This CL makes it so that app pairs do an orientation check in dispatchDraw() instead of only on init().

Previously we only checked orientation on AppPairIcon.inflateIcon(), and the issue was that orientation was not re-checked when pinned Taskbar was rotated to different sides of the screen. Added a DeviceProfileListener to update orientation when DP changes.

Fixes: 323288812
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, app pair icon always has correct otientation on pinned taskbar
Change-Id: If2de1a4c7334fef1ba4c2edcca09bef9338bc73f
2024-03-05 22:32:36 -08:00
Jeremy Sim 09fe96b95a On disabled app pairs, set color tint instead of changing alpha
This CL changes the way disabled app pair icons are drawn: instead of setting alpha, it sets a color filter to indicate disabled status. This brings it in line with other apps icons and V's design specs.

Fixes: 326665140
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
2024-03-05 21:45:00 -08:00
Fengjiang Li 7dea7f0b42 Merge "[2/n] Avoid flicker to drop a widget that needs a config activity" into main 2024-03-06 02:03:48 +00:00
Fengjiang Li f114ec5b26 Merge changes Iab1de455,I0c6585e6,I125670d1 into main
* changes:
  [Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
  [Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
  [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
2024-03-06 01:32:17 +00:00
Holly Sun 20c30c9cdc [PS] Do not use AppInfo and use PrivateSpaceInstallAppButtonInfo instead.
BaseAllAppsAdapter.AdapterItem's itemInfo needs to be an AppInfo. Create PrivateSpaceInstallAppButtonInfo extending from AppInfo and use different itemType (AppInfo has default itemType ITEM_TYPE_APPLICATION). In this case, shortcuts is disabled in ShortcutUtil#supportsShortcuts because `isApp` is false (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/util/ShortcutUtil.java;l=30?q=shortcututil&sq=repo:googleplex-android%2Fplatform%2Fsuperproject%2Fmain%20b:main).

After the fix, long click on Install button quits Toast, which is the same with drag action on the button.

Since we have a specific itemType for PS install button now, the previous `FLAG_PRIVATE_SPACE_INSTALL_APP` is no longer needed. Remove it.

Bug: 324211283
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.private_space_app_installer_button trunkfood
Change-Id: Ic5d4284afb93cef77f2ad8f0c1588523e0ed3ae3
2024-03-05 17:13:35 -08:00
Fengjiang Li fb16517fea [2/n] Avoid flicker to drop a widget that needs a config activity
1. Don't show background in PendingAppWidgetHostView if we are showing preview bitmap
2. Extract bitmap from DropView instead of LauncherAppHostView
3. Letterbox bitmap into PendingAppWidgetHostView's canvas if canvas has different aspect ratio

Fix: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: I76de215186b96ffe65c909b28155fb19ac90d4f1
2024-03-05 14:49:09 -08:00
Federico Baron 944ed16981 Merge "Page resets when scrolling slowly fix" into main 2024-03-05 22:43:01 +00:00
Fengjiang Li cad1f13d27 [Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
For taskbar all apps, the background scrim is child view of AbstractSlideInView, thus scaling AbstracSlideInView during PB swipe will scale down background scrim. There is no need to re-apply scale effect on background scrim separately.

Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I125670d14bc788664a1371008589e4106496ae2e
2024-03-05 14:02:45 -08:00
Catherine Liang 0089efe18a Remove createWindowContext in Launcher preview renderer
The line causes an error in Window Manager. When removed, it doesn't
seem to have an effect for the Wallpaper Picker use case. The preview
render still shows correctly after config changes including rotation
and dark/light theme because the picker restarts and re-requests a
preview.

Flag: NA
Bug: 328089367
Test: manually tested with config changes and different lifecycle cases
Test: manually tested with multi crop flag on and off
Change-Id: Id1bd30c7ab4c50d29622b647bd368aafbd5c043f
2024-03-05 20:32:45 +00:00
fbaron cae498032f Page resets when scrolling slowly fix
Fix: 324071635
Flag: NONE
Test: Verified manually on RTL and non-RTL
Change-Id: Id778a0a01505d30bca4f216322f3ef3b951e63a7
2024-03-05 10:06:14 -08:00
Rohit Goyal d87f02f609 Merge "Bugfix: Remove widgets and deep shortcuts of app which gets archived." into main 2024-03-05 14:49:28 +00:00
Rohit Goyal bef2930f5a Bugfix: Remove widgets and deep shortcuts of app which gets archived.
* Once app is archived, remove widgets and deep shortcuts corresponding to the app from the home screen.
* However during backup & restore, widgets should not be removed if they are being restored.

Test: verified bugfix locally.
Bug: 326567866
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Ib3a112aadc7bd901fd6a0ba86f472ec6acf8d626
2024-03-05 11:25:46 +00:00
Vinit Nayak b0f37b73ff Merge "Revert "Revert "Implements the "Save App Pair" button in Overvie..."" into main 2024-03-05 01:49:25 +00:00
Sebastián Franco e4649b0ff4 Merge "Refactor migrateGridIfNeeded to pass the grid states and make it easier for unit testing" into main 2024-03-04 23:43:12 +00:00
Andy Wickham 929005440e Merge "Add custom extra width to trigger LPNH" into main 2024-03-04 22:46:22 +00:00
Vinit Nayak 91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Sebastian Franco c3ffd41ff0 Refactor migrateGridIfNeeded to pass the grid states and make it easier for unit testing
No-op change

Bug: 325286145
Flag: NA
Test: compiling
Change-Id: I703c08059b81e20111c17a142dc54335f18a5a87
2024-03-04 13:46:07 -06:00
Andy Wickham e92f25d7cb Add custom extra width to trigger LPNH
This is defined in dp from the edge of the nav handle. So if you
set it to 48, you can invoke 48dp from the left or right of the
handle (which is roughly the size of an average fingertip).

You can also set it to a negative value to make the invocation
region smaller. This applies to both navbar and stashed taskbar,
and the minimum touch target is always 48dp.

For reference, the navbar width is 108dp and taskbar is 220dp.

Defaults to 0, i.e. you can only invoke within the visible navbar.

Bug: 325118077
Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: I904a484a99ac4af05de13573fac610b84fd7f0f1
2024-03-04 10:56:16 -08:00
Priyanka Advani 2ade8f2050 Merge "Revert "Remove cyclical dependency from LauncherPrefs."" into main 2024-03-04 18:52:18 +00:00
Priyanka Advani 3e64dabb46 Revert "Remove cyclical dependency from LauncherPrefs."
This reverts commit 526f8a0099.

Reason for revert: culprit for b/328063858. Will be running through ABTD for verification and before submitting the revert.

Change-Id: Ie439b2d661617f10bbc31afada187a313dd52af7
2024-03-04 18:07:59 +00:00
Stefan Andonian 544e4d510b Merge "Remove cyclical dependency from LauncherPrefs." into main 2024-03-04 15:45:06 +00:00
Himanshu Gupta 771cec99b9 Revert Accidental tweak of work profile behaviour
Context: In ag/25247534, while setting the `STATE_TRANSITION`, `updateCurrentState` was replaced accidentaly with `setCurrentState`.
As a result, View is not updated to show work apps in paused mode, immediately after the click (as `AlphabeticalAppsList#updateAdapterItems()` is no longer called .

This change fixes the same.

Bug: 327950935
Change-Id: I263129ff35f45cb5dc6f95db4ed51335f15dbf6f
Test: Manual flash and work profile creation.
2024-03-03 21:56:23 +00:00
Himanshu Gupta b3cd9802e8 Clearing All Apps Search For ALL_APPS Intent
Currently, if ALL_APPS intent is executed while All Apps
QSB is highlighted, user is left on the search sub-view of
the All Apps view.
To fix this, we add a runner to check the search view and
exit from it after State Transition has happened.

Before: https://photos.app.goo.gl/c5WeUnAzowxRWW1m7
After: https://photos.app.goo.gl/dxvb23wzwPfKqi3o6

Bug: 324516950
Flag: NA
Test: Manual flash and running intent via cmd
Change-Id: Icc291f792545b0c515535857f578bc2e01fef7f7
2024-03-02 18:42:33 +00:00
PODISHETTY KUMAR b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Vinit Nayak 5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Stefan Andonian 526f8a0099 Remove cyclical dependency from LauncherPrefs.
ag/26260351 was a much larger CL that removed more pieces of
LauncherPrefs that were related to this flag and were unused.
Unfortunately, that CL caused a test regression, and so I am publishing
this much smaller change in an effort to resolve the underlying issue in
a timely manner.

Bug: 324670265
Test: Installed this on a device and tested that nothing was broken.
Flag: NA
Change-Id: I10be75a1278fdffe7cc01beecf37b967526c4bc4
2024-03-01 00:37:55 +00:00
Zak Cohen e3e00c6e26 Merge "Widget Picker - show app icon next to recommended app label." into main 2024-02-29 21:55:37 +00:00
Jeremy Sim 8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Vadim Tryshev 0fa523bb32 Merge "Removing logging for verifying internal Launcher state from tests" into main 2024-02-29 19:18:04 +00:00
Federico Baron 835b9610bc Merge "Update some dimens for portrait edit state" into main 2024-02-29 17:17:19 +00:00
Jakob Schneider a9338897a4 Merge "Add dedicated a11y label for archived apps." into main 2024-02-29 10:54:31 +00:00
Jeremy Sim 41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Treehugger Robot bdd76bed63 Merge "Add toString() dump for Launcher SplitBounds" into main 2024-02-29 00:43:17 +00:00
Brandon Dayauon 343ecb7cf8 Merge "Don't show fastScrollBar when collapsing" into main 2024-02-29 00:41:11 +00:00
Eghosa Ewansiha-Vlachavas 7cc75c6a43 Merge changes from topics "removeDesktopMode2", "replaceDesktopWindowingFlag" into main
* changes:
  [2/n] Remove use of `persist.wm.debug.desktop_mode_2`
  [2/n] Replace read-only desktop windowing flag with runtime flag
2024-02-28 14:24:09 +00:00
Vinit Nayak 75306186e0 Add toString() dump for Launcher SplitBounds
Bug: 286509643
Change-Id: I57e04c571678dbb553c7d35128d8e63700a2f382
2024-02-27 17:07:44 -08:00
Zak Cohen 26c26fe837 Widget Picker - show app icon next to recommended app label.
https://screenshot.googleplex.com/42gUGuSADdrW2CS

Bug: 323887132
Test: Manual, no test for widget cell yet.
Flag: NA
Change-Id: I95e7a645b3664361222d5045114224b17d8fdf34
2024-02-27 13:34:15 -08:00
Vadim Tryshev dae8b65dea Removing logging for verifying internal Launcher state from tests
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I25afcc30446d429171445f8e1b6033b277166725
2024-02-27 20:23:49 +00:00
Shamali Patwa b5c0044a82 Merge "Fix issue that sometimes the widget list table occupies more space." into main 2024-02-27 16:43:02 +00:00
Himanshu Gupta dcf394535a Merge "Making Settings Cog open PS Settings page." into main 2024-02-27 15:46:34 +00:00