PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
83,004 Commits 1 Branch 0 Tags
f8d94de717303505d0a41b8b5ce156cfa4e18aa6
Commit Graph
20057 Commits
Author SHA1 Message Date
Winson ChungandAndroid (Google) Code Review a9ccb34d1c Merge "Migrate PackageManagerHelper to MainThreadInitializedObject" into main 2024-04-23 18:10:56 +00:00
Sunny GoyalandAndroid (Google) Code Review edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Himanshu Gupta ae4631e6a3 Move PreInstalled App List to UserCache. 
Bug: 333543006
Test: atest PrivateSpaceHeaderViewTest, AlphabeticalAppsListTest
Flag: NA
Change-Id: I84233c5a6406325d9e641b72ea8455911b46f65f
 2024-04-23 15:28:01 +01:00
Fengjiang LiandAndroid (Google) Code Review fa0a4c1c11 Merge "[Predictive Back] Swipe back within workspace all apps should only scale down content view, rather than whole all apps sheet" into main 2024-04-23 03:45:32 +00:00
Sebastián FrancoandAndroid (Google) Code Review a67a53eeed Merge "Make getWidgetProviderInfoByProviderName return the correct WidgetItem for Pixel own widgets." into main 2024-04-23 02:11:50 +00:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject 
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
 2024-04-22 17:04:33 -07:00
Treehugger RobotandAndroid (Google) Code Review e5bffd4c48 Merge "Show add button when WidgetCell text is tapped" into main 2024-04-22 22:27:38 +00:00
Sebastian Franco b41d4b4e7a Make getWidgetProviderInfoByProviderName return the correct WidgetItem 
for Pixel own widgets.

The pixel own widgets can have categories and getWidgetProviderInfoByProviderName
might not find the right widget if the widget has a category.

Flag: NA
Test: Manaul testing =(
Test: Make sure the placement in the widget picker is correct.
Test: All widgets in widget_section.xml with alsoKeepInApp set to false will previously dissapear on the preview.
Fix: 331628371
Change-Id: I1e4c8ae3dd21f8aef3e4aac99ce6ce6701e94760
 2024-04-22 10:47:50 -07:00
Treehugger RobotandAndroid (Google) Code Review 774d05e970 Merge "Remove debug tracing for b/321775748" into main 2024-04-22 16:35:32 +00:00
Mykola PodolianandAndroid (Google) Code Review 1f40fa0e7f Merge "Updated pointer to match visual specification." into main 2024-04-22 16:06:39 +00:00
Schneider Victor-tulias 3f8eea99e3 Remove debug tracing for b/321775748 
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
 2024-04-22 09:55:49 -04:00
Winson Chung bb32b7e0de Migrate PackageManagerHelper to MainThreadInitializedObject 
- This is in preparation for other things that can be loaded with
  PMH initialization and prevents duplicate temporary helpers from
  loading this many times.
- Most calls in PMH can use the app context, but one call requires
  starting activities/showing toasts so that one needs to take the
  context and can be made static instead.

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: Id11c780955880cf49c022cbf2744c41e1b696355
 2024-04-22 12:35:03 +00:00
Shamali PatwaandAndroid (Google) Code Review a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Stefan AndonianandAndroid (Google) Code Review f22011a51c Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into main 2024-04-19 21:13:11 +00:00
Shamali PatwaandAndroid (Google) Code Review 4ee10f33ee Merge "Use same margins for widgets bottom sheet as all apps." into main 2024-04-19 21:08:24 +00:00
Anushree GanjamandAndroid (Google) Code Review 093ef5fa30 Merge "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard." into main 2024-04-19 19:59:44 +00:00
Stefan Andonian 86d3c8814b Use ItemInfo with correct position when adding to Workspace via Accessibility. 
Bug: 332651703
Flag: NA
Test: Verified that the issue isn't reproducible with the fix. The issue
was 100% reproducible before.
Change-Id: I01207396e19b4f7d14d6a147e5e5fb98bae9ea99

Change-Id: I81aad9758ee33b8acc2d6a1242e54f2a47124374
 2024-04-19 16:22:39 +00:00
Fengjiang LiandAndroid (Google) Code Review 7d80f801b1 Merge "[Predictive Back] AbstractSlideInView#mViewToAnimateInSwipeToDismiss can be private" into main 2024-04-19 16:22:30 +00:00
Charlie AndersonandAndroid (Google) Code Review 299e42cf8d Merge "Fix NPE for where intent.package is null but targetpkg is not." into main 2024-04-19 15:10:20 +00:00
mpodolian 73b07e2024 Updated pointer to match visual specification. 
Updated bubble bar view pointer to have rounded tip.

Test: BubbleBarViewAnimatorTest
Fixes: 333546362
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I7875426b06a330bc355a833c51849335f831317e
 2024-04-19 15:32:26 +01:00
Brandon DayauonandAndroid (Google) Code Review 715059a1e3 Merge "Make settings cog animate back to original button" into main 2024-04-19 10:07:36 +00:00
Brandon DayauonandAndroid (Google) Code Review 24db282ed4 Merge changes Ied2efcf6,I07579635 into main 
* changes:
  Polish workFAB with updated spec.
  Fix workFAB alignment.
 2024-04-19 00:59:19 +00:00
Anushree Ganjam d169cb3667 When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard. 
The searchEditText has focusableInTouchMode = true, See https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:vendor/unbundled_google/packages/NexusLauncher/res/layout/typeahead_search_input.xml;l=47;drc=199723c3c6db539cce4c03b5b612015fe040b202

See https://developer.android.com/reference/android/view/View#attr_android:focusableInTouchMode which says "Boolean that controls whether a view can take focus while in touch mode. If this is true for a view, that view can gain focus when clicked on, and can keep focus if another view is clicked on that doesn't have this attribute set to true."

So when external keyboard is connected and we come out of all apps in touch mode, the edit text still has focus in touch mode and continues to keep focus even though clearFocus() is called. So we hide the keyboard so that input connection is not established with edit text anymore.

Before: https://b.corp.google.com/issues/317742889#comment22

After: https://b.corp.google.com/issues/317742889#comment23

Bug: 317742889
Flag: NA
Test: Manual
Change-Id: Ib297b4cdf376d41e244d2b798a101e4255de5108
 2024-04-18 15:32:48 -07:00
Shamali P 5f7eb1f2ee Keep rounded corners while scrolling in right pane & fix scrollbar size. 
[demo](http://screencast/api/gif/NDU4MTQ5ODE3Mzc4NDA2NHxhYmUzMDcxNy04MA/image)

Bug: 333734241
Test: screencast
Flag: N/A
Change-Id: Ifb522ca2c0a1092bf41c630e336b19c81d504c26
 2024-04-18 22:32:30 +00:00
Shamali PatwaandAndroid (Google) Code Review 1b8fcf4371 Merge "Revert "When getting a widget provider by name, check all categories"" into main 2024-04-18 22:14:29 +00:00
Charlie Anderson ce255ff6fd Fix NPE for where intent.package is null but targetpkg is not. 
- Also update WorkspaceItemProcessorTest with a new test and to use real intent instead of mock

Bug: 330250727
Test: unit tests
Flag: N/A
Change-Id: I77e17901f4754c301ca20b3c6f93bbe29bead59b
 2024-04-18 17:48:27 -04:00
Brandon DayauonandAndroid (Google) Code Review 20a6ffd04b Merge "Fix install apps button" into main 2024-04-18 21:42:59 +00:00
Brandon Dayauon baf5f6ec3d Polish workFAB with updated spec. 
Updating the workFAB to the new spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2c8f3ae8e02_0_0
Have the background endPadding to be 4 and icon have an endMargin of 12 and the text endMargin of 16.
So that when the text is disappeared, the space between the icon and the right bound is 16dp to spec.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: Ied2efcf6b1bd19c191d80e47bae4f8f6e3794803
 2024-04-18 14:40:42 -07:00
Brandon Dayauon 4e68d3992d Fix workFAB alignment. 
The calculation to find how much the FAB should shift is outdated as using the
method from deviceProfile#getAllAppsIconStartMargin() gives a better value.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: I07579635d6176553d27497cb73b81799648fb014
 2024-04-18 14:40:41 -07:00
Brandon Dayauon 120838b04d Make settings cog animate back to original button 
Provide the appropriate itemInfo so that launcherBackAnimation would play correctly.

bug:324569690
Test manual video: https://drive.google.com/file/d/1GfjL4PhdGOxs2KfDpieTNiFiKQ61aCgh/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space trunkfood

Change-Id: I1a9458643e932b279bf4ba4ea33e3dc0a2c121c2
 2024-04-18 14:32:33 -07:00
Fengjiang Li aa64c04ed8 [Predictive Back] AbstractSlideInView#mViewToAnimateInSwipeToDismiss can be private 
Bug: 335467443
Test: presubmit
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TRUNKFOOD
Change-Id: Ibf4b6f04d829daa6a109724c927bf466c25160d5
 2024-04-18 13:37:34 -07:00
Shamali PatwaandAndroid (Google) Code Review 7e5ed568b9 Revert "When getting a widget provider by name, check all categories" 
This reverts commit 1f69351310.

Reason for revert: Testing odd behavior between google app and pixel weather and duplicate items issue

Change-Id: If181aa3e86969e8821b7e1cc765c3801f04489d2
 2024-04-18 18:16:38 +00:00
Brandon Dayauon fe791d11aa Fix install apps button 
- Setting the button's user via iteminfo to the privateprofile user
doesn't let the user to go into the play store. This was initially done so that
we can check the itemInfo to see if item is private space instead of just checking
if the item has a decorationInfo for collapse animation.
- The itemInfo change is reverted and we can check that case by checking with instanceOf PrivateSpaceInstallAppButtonInfo

bug:335600922
Test manually video: https://drive.google.com/file/d/1N2zOHvPmBptBaBf8SCqjBAM6UhV0lQBI/view?usp=sharing
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD

Change-Id: I09f22c9df5b4f9408eea6995eafea83e30c93a0d
 2024-04-18 16:59:49 +00:00
Shamali P 50bf021b02 Use same margins for widgets bottom sheet as all apps. 
* Per UX discussion with jane and david, the full width looks too large
for the app info -> long press -> widgets bottom sheet.
* Earlier during POR, we decided to match them all, but after trying it out, we think smaller is better for the app specific bottom sheet.

* http://screencast/cast/NTg1Njk1MDUxOTU5NTAwOHxiMDU0YWJhMi04MQ
* http://screencast/cast/NjU0NjQyODgwMDI3MDMzNnw4NDNhMGVjMy0yMg


Bug: 328812171
Test: screencast
Flag: N/A
Change-Id: I9b0a996f80bac2639bcadf85480468ac886c7093
 2024-04-18 16:58:39 +00:00
Sunny GoyalandAndroid (Google) Code Review a82ce1feda Merge "Making moving getDisplayType to DisplayController so that it can be accessed without IDP" into main 2024-04-18 05:51:58 +00:00
Fengjiang LiandAndroid (Google) Code Review 240dbab022 Merge "[Predictive Back] Swipe back within taskbar all apps should only scale down content view, rather than whole all apps sheet" into main 2024-04-18 03:20:59 +00:00
Fengjiang Li 1529052dcf [Predictive Back] Swipe back within taskbar all apps should only scale down content view, rather than whole all apps sheet 
Bug: 335467443
Test: manual - took a video
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TRUNKFOOD
Change-Id: I45980329f70ac1a8a8fc0e84be007f3385e40f58
 2024-04-17 16:09:21 -07:00
Brandon DayauonandAndroid (Google) Code Review ef051ce98d Merge "Instead of popup to show letters, show private space icon on fast scrolling" into main 2024-04-17 22:32:59 +00:00
Fengjiang Li af20dc761c [Predictive Back] Swipe back within workspace all apps should only scale down content view, rather than whole all apps sheet 
Fix: 335467443
Test: manual - took a video
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TRUNKFOOD
Change-Id: I97f2bfa47dbb7d4866c5d2864ee9cd059a94ca5c
 2024-04-17 15:03:58 -07:00
Brandon Dayauon a1af2cee1c Instead of popup to show letters, show private space icon on fast scrolling 
Use spannableString to show the icon instead of regular letters for the private space icons.

bug:304752744
Test manual: https://drive.google.com/file/d/1LFy4-bu69Kuo8eV4erjJOsbkiQJs09kC/view?usp=sharing
Flag: None

Change-Id: I149d7aba6b0a4fdafacd2684e56827c7e1b9d724
 2024-04-17 12:37:38 -07:00
Sunny Goyal 25c4276ba9 Making moving getDisplayType to DisplayController so that it can be accessed without IDP 
Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: Ib1ef3c970a56044c81e36c4af67981715fe50a9e
 2024-04-17 10:39:50 -07:00
Fengjiang LiandAndroid (Google) Code Review 34f2c92e39 Merge "[Predictive Back] If back swipe while widget picker is in search mode, we should scale down the content view, rather than the bottom sheet" into main 2024-04-17 16:53:54 +00:00
Sebastián FrancoandAndroid (Google) Code Review f0c030380a Merge "When getting a widget provider by name, check all categories" into main 2024-04-17 16:24:21 +00:00
Fengjiang Li 85a495f066 [Predictive Back] If back swipe while widget picker is in search mode, we should scale down the content view, rather than the bottom sheet 
This will help indicate that we will be navigating within widget picker's bottom sheet.

Fix: 333524244
Test: manual - took a video
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: If29806a474d35c0fdd5789cb67fa62dfbb313313
 2024-04-16 17:13:22 -07:00
Sunny GoyalandAndroid (Google) Code Review f15a96608a Merge "Moving developer settings to xml overrides instead of code swap" into main 2024-04-16 21:27:04 +00:00
Willie KoomsonandAndroid (Google) Code Review f01687ab5a Merge "Scroll to show WidgetCell when it is tapped." into main 2024-04-16 20:42:12 +00:00
Federico BaronandAndroid (Google) Code Review 6188ec4157 Merge "Make hotseat column span responsive" into main 2024-04-16 17:17:55 +00:00
Winson ChungandAndroid (Google) Code Review ad82df4d37 Merge "Migrate WorkspaceItemInfo non-resizeable flag to runtime status flag" into main 2024-04-16 16:41:42 +00:00
Brandon DayauonandAndroid (Google) Code Review 31e713ee4c Merge changes If93e3975,Ifed45f06 into main 
* changes:
  Fix views being visible after closing private space.
  Set attach consumer after animation finished
 2024-04-16 15:14:26 +00:00
fbaron e4b0b71faa Make hotseat column span responsive 
Flag: NONE
Test: DeviceProfileDumpTest, DeviceProfileAlternativeDumpTest, HomeScreenImageTest
Bug: 325084912
Change-Id: Ifa9e8066662a1ab053f66b8800b739d813d2dab8
 2024-04-16 06:19:16 +00:00