Commit Graph

20057 Commits

Author SHA1 Message Date
Toshiki Kikuchi f9ae7178cf Merge "Allow to show pinned taskbar when Launcher is visible" into main 2024-09-18 23:16:57 +00:00
Brandon Dayauon a9a90a5850 Merge "Fix fastscroller not resetting when switching tabs." into main 2024-09-18 22:56:53 +00:00
Sunny Goyal 96591a3644 Merge "Moving some utility class to IconCache to make it easier to use outside Launcher" into main 2024-09-18 22:27:29 +00:00
Sunny Goyal 2a359916ca Moving some utility class to IconCache to make it easier to use outside Launcher
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I7583ae162b652e73a33f1aee76714e292b707e39
2024-09-18 10:05:05 -07:00
Brandon Dayauon 77374930a7 Fix fastscroller not resetting when switching tabs.
Whenever fastscroller is binded, reset the scroll position so its at the top.

bug: 335520751
Test video manually:
before:https://drive.google.com/file/d/1MOE0LOL8G5pmhJYf61y9jw2nDVXIvaAs/view?usp=sharing
after: https://drive.google.com/file/d/14Yi6JRMvDhDZKNwusv75DtfeGk1A4W23/view?usp=sharing
Flag: NONE bugfix

Change-Id: I7aea9a7fe5582fbb61e979f375191980c8a7e0ad
2024-09-18 10:01:22 -07:00
Toshiki Kikuchi 6ddfe9b179 Allow to show pinned taskbar when Launcher is visible
This CL allows freeform-first devices to lock the taskbar in a pinned
state when Launcher is visible.

Bug: 361419732
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual

Change-Id: Ic0d2740e33fee19c676d88aa2bcf370eb64366e8
2024-09-18 10:49:52 +00:00
Brandon Dayauon c5941bf802 Merge "Allow haptics to play when fastscrolling private space apps." into main 2024-09-17 23:06:22 +00:00
George Lin b72dc07489 Merge "Wait for device profile reload" into main 2024-09-17 21:30:18 +00:00
Mykola Podolian bff3b73c8f Merge "Hide hotseat when bubble bar is expanded." into main 2024-09-17 17:38:33 +00:00
helencheuk 5012640ab2 [Contextual Edu] Update Edu stats when going to overview and all apps from home
Update education stats when
- go overview and all apps by swiping up at homepage (AbstractStateChangeTouchController)
- go home from all apps by swiping down the all apps panel (AbstractStateChangeTouchController)
- go home from all apps or overview by swiping up from the bottom nav bar (NavBarToHomeTouchController)
- in 3 button navgiation mode (TaskbarNavButtonController)

NavBarToHomeTouchController does not inherit from AbstractStateChangeTouchController so logic are added separately.

Bug: 363480554
Test: TaskbarNavButtonControllerTest
Flag: com.android.systemui.keyboard_touchpad_contextual_education
Change-Id: I0662704a9093b9f5a4d2f086a8297429fbc49881
2024-09-17 16:00:24 +01:00
George Lin b31f1452f1 Wait for device profile reload
Test: Manually tested the option updated after apply
Bug: 348664593
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I795b95407483a730ee22a184a6db96f64f6ee829
2024-09-17 14:15:21 +00:00
Sunny Goyal e14032d578 Merge "Cleaning up some enabled features" into main 2024-09-17 03:22:23 +00:00
Liran Binyamin 69f4974e24 Hide hotseat when bubble bar is expanded.
Added logic to stash the hotseat when on launcher home screen.

Bug: 280494203
Test: Manual:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fjfjUw296LRXUm9uYqXU4K
all tests in com.android.launcher3.taskbar
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I67b298831eaed9c549a2fae7dc5a0d9fae51f7c4
2024-09-16 15:50:28 -07:00
Jon Miranda aec1e05be5 Migrate ENABLE_ALL_APPS_BUTTON_IN_HOTSEAT to launcher.aconfig
Flag: com.android.launcher3.enable_all_apps_button_in_hotseat
Test: N/A
Bug: 270393897
Change-Id: Ib62a2f46a440d8f0d3f569c09c4f8754715db4ee
2024-09-16 22:00:39 +00:00
Mykola Podolian 56cda496c6 Merge "Update placement of the nav bar in persistent taskbar for 3 button nav" into main 2024-09-16 21:49:54 +00:00
Brandon Dayauon 57c77eb4c6 Allow haptics to play when fastscrolling private space apps.
LinearSmoothScrolling only happens when there is a new section to scroll to. Instead of playing haptics
when sectionInfo changes, only play haptics during smooth scrolling.

bug: 359658099
Test: Manually tested, video wouldn't help since I am testing haptics
Flag: NONE bugfix
Change-Id: I96c911b4d2d201d0d953a9619a97979759a02427
2024-09-16 10:55:02 -07:00
Sunny Goyal 98001dd1dc Merge "Migrating prediction_undo to aconfig" into main 2024-09-16 17:26:58 +00:00
Charlie Anderson ccd58ab97b Merge "Add additonal logging around PackageUpdatedTask to detect app updates for User" into main 2024-09-16 13:39:59 +00:00
Sunny Goyal d94100a223 Migrating prediction_undo to aconfig
Flag: com.android.launcher3.enable_dismiss_prediction_undo
Test: atest SystemShortcutTest
Bug: 270394476
Change-Id: I5daef5d168c301115d860a1ae1d3c96f70a0f18f
2024-09-13 20:21:32 -07:00
Sunny Goyal 4f9ba255a4 Cleaning up some enabled features
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
        ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
        ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
        ENABLE_DEVICE_SEARCH
        ENABLE_HIDE_HEADER
        ENABLE_TWOLINE_ALLAPPS
        IME_STICKY_SNACKBAR_EDU
        FOLDER_NAME_MAJORITY_RANKING
        SCROLL_TOP_TO_RESET
        ENABLE_SEARCH_UNINSTALLED_APPS
        ENABLE_HOME_TRANSITION_LISTENER

Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Anushree Ganjam b41def0366 Merge "Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)" into main 2024-09-13 00:45:28 +00:00
mpodolian 04088ebef7 Update placement of the nav bar in persistent taskbar for 3 button nav
Implemented nav bar placement update to be located opposite to the
bubble bar.
When bubble bar is moved to the other side of the bar, 3 button nav will
swap sides (without animation).
If taskbar has to be repositioned it does that with the animation.

Test: TaskbarViewControllerTest
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id031706183c60cbd9c67537b01530acb43bae614
2024-09-12 16:42:15 -07:00
Sunny Goyal 5ee3d98641 Cleaning up some enabled features
Flag: EXEMPT LEGACY
		CONTINUOUS_VIEW_TREE_CAPTURE
		ALL_APPS_GONE_VISIBILITY
		ENABLE_BACK_SWIPE_HOME_ANIMATION
		ENABLE_DYNAMIC_TASKBAR_THRESHOLDS
		PREEMPTIVE_UNFOLD_ANIMATION_START
		ENABLE_NEW_GESTURE_NAV_TUTORIAL
		ENABLE_ENFORCED_ROUNDED_CORNERS
		ENABLE_TRACKPAD_GESTURE
		ENABLE_KEYBOARD_QUICK_SWITCH
		ENABLE_KEYBOARD_TASKBAR_TOGGLE
		ENABLE_ALL_APPS_RV_PREINFLATION
Test: Presubmit
Bug: 270395171, 291651514, 270393426, 294252473,
     270397209, 270396257, 270393258, 271010401,
     270396844, 281726846, 288161355

Change-Id: I6ef1e12dfc2203a4cca8e91aa291485f1ff24c42
2024-09-12 15:12:08 -07:00
Treehugger Robot f60ebdfa9d Merge "Add logs for 4x4 to 4x5 missing row bug" into main 2024-09-12 06:34:37 +00:00
Treehugger Robot 206e15b286 Merge "Move DesktopVisibilityController to TouchInteractionService" into main 2024-09-12 02:32:00 +00:00
fbaron 3c4c975d74 Add logs for 4x4 to 4x5 missing row bug
Flag: EXEMPT adding logs
Test: EXEMPT adding logs
Bug: 360462379
Change-Id: Icb56209a4a12c935dd97bd01d53b8fb6e4371c34
2024-09-11 15:52:01 -07:00
Anushree Ganjam fbc0f97410 Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)
* Add ApplicationContext qualifier and binding the application context instance so
that this context is available across dagger graph.

* Add QuickStepModule and LoggingModule
* Provide SettingsChangeLogger in dagger way. We are depending on
  MainThreadInitializedObject for cleanup. We need to define a way
  explicitly see how we can destroy singleton objects.

Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: Ia10cc500edb1d88adcca540119651f59b9bc8dc8
2024-09-11 13:56:23 -07:00
Sunny Goyal 8f8932b0f8 Merge "Adding open/close animartion when launching app-info target" into main 2024-09-11 20:31:34 +00:00
Toni Barzic 667fe050ff Make widget sheet layout container not focusable
SpringRelativeLayout views in widgets sheets UI are non-actionable
containers, and as such they would ideally not receive focus. They were
made focusable as a workaround for an issue where back action was no-op
when widget search text box was focused, and there were no other
focusable elements in the UI b/197129170.
WidgetSearchBarController handles back action by clearing
focus, which ends up refocusing the search text box. This CL, removes
this back action override, and let's back action through - it will end
up being handled by `WidgetsFullSheet.onBackInvoked` which resets the
search.

Bug: 365120544
Test: Manual - verified back action with widget search active (and in
      case with no results) in emulator
Flag: EXEMPT bugfix

Change-Id: I1fed37372521947b7d4644047807dc451b0119a4
2024-09-11 18:50:56 +00:00
Schneider Victor-Tulias 2b46c945a7 Move DesktopVisibilityController to TouchInteractionService
Moved DesktopVisibilityController to TIS for 3P launcher support.

Flag: EXEMPT bug fix
Fixes: 338063030
Fixes: 357859025
Test: Launched overview and resumed desktop task from desktop mode on 1P and 3P launchers
Change-Id: I64e99a32ed13bcb6e4a81a18c29df2643373dc35
2024-09-11 09:56:35 -07:00
Sunny Goyal 65342edc89 Removing obsolete flags
Flag: EXEMPT legacy ENABLE_PARAMETRIZE_REORDER, KEYGUARD_ANIMATION, ENABLE_SCRIM_FOR_APP_LAUNCH
Bug: 289420844
Bug: 270390904
Bug: 270393276
Test: Verified manually
Change-Id: I0eb166168100419fdf4d264f7ccddeeba86524b7
2024-09-10 21:24:47 +00:00
Sunny Goyal cb98fb26b8 Adding open/close animartion when launching app-info target
Bug: 356914468
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I3a4e48363728153a96c75466824fb03de44c0ad9
2024-09-10 13:35:46 -07:00
Fengjiang Li 97db09dbd8 Merge "[-1] Show toast when user trys to swipe to -1 on extreme battery saver mode" into main 2024-09-10 16:41:21 +00:00
Treehugger Robot a926663c46 Merge "Removing obsolete flags" into main 2024-09-10 09:25:51 +00:00
Sunny Goyal b60b5bd594 Merge "Adding more properties in LaunchCookie, instead of just itemId This allows better matching of items who do not have a fixed id" into main 2024-09-10 07:33:41 +00:00
Fengjiang Li a7e357e339 [-1] Show toast when user trys to swipe to -1 on extreme battery saver mode
Fix: 355485335
Flag: com.android.launcher3.use_activity_overlay
Test: manual - record a video
Change-Id: I79a3ece2fb2c0d1eddac0e4f91274ffe222e317f
2024-09-09 19:06:17 -07:00
Sunny Goyal f2e2532e62 Merge "Remove obsolete features" into main 2024-09-09 22:43:14 +00:00
Sunny Goyal f158286c34 Adding more properties in LaunchCookie, instead of just itemId
This allows better matching of items who do not have a fixed id

Bug: 364363493
Flag: EXEMPT bug fix
Test: Manual- Verified app launch and back animation
Change-Id: I4f9deba89399b89974686b64226b99f91a3d46be
2024-09-09 12:11:36 -07:00
Charlie Anderson 0c44432d06 Add additonal logging around PackageUpdatedTask to detect app updates for User
Bug: 350144057
Flag: EXEMPT just logging
Test: local debugging
Change-Id: I317bee94342ad5022025ec52c992c5eeb906efa5
2024-09-06 15:24:51 -04:00
Treehugger Robot 359fb55a26 Merge "Send message to launcher renderer to update grid (3/3)" into main 2024-09-05 21:45:44 +00:00
George Lin de4d7457a8 Send message to launcher renderer to update grid (3/3)
This CL supports external surface view callbacks to send messages to
update the launcher's preview grid.

Bug: 348664593
Test: Manually tested. See bug.
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I8108ae2c49af6b4fc1a207c6ece23e82616baa61
2024-09-05 16:49:15 +00:00
Treehugger Robot 40de6c4c12 Merge "Fix Overview crash with 3 button navigation when animation is disabled" into main 2024-09-05 16:41:00 +00:00
Jordan Silva 64ad4e34ab Fix Overview crash with 3 button navigation when animation is disabled
The OverviewCommandHelper conversion to kotlin introduced a bug when using 3-button-navigation to go to Overview when the animation is disabled. A NullPointerException happens in the AnimatorListenerAdapter implementation in OverviewCommandHelper when StateManager.goToState calls onAnimationEnd providing a null argument to a function that shouldn't allow a null value.

The abstract class AnimatorListenerAdapter implements AnimatorListener functions containing @NonNull Animator. However, AnimatorListenerAdapter overrides the interface functions without adding a @NonNull annotation in the arguments. In Java, this is allowed, causing only a warning. In Kotlin, due to the null safety nature, the compiler forces a null check for nullable types and doesn't allow the implementation of a @NonNull argument to become nullable.

To fix this issue we created a empty AnimatorSet to provide to onAnimationEnd instead of null.

For more context when @NonNull was added:
- The @NonNull annotation was added to fix b/206801689, however it was never updated for AnimatorListenerAdapterImproved Commit Message

Fix: 364860731
Bug: 352046797
Flag: EXEMPT bugfix
Test: Manual. Instructions in the bug.
Change-Id: I120af3d75e614581d6ac0f867a8c6f9419ee1bd3
2024-09-05 15:19:32 +01:00
Treehugger Robot 9982cf96d0 Merge "Fixing UI leaks when using inline-subclass" into main 2024-09-05 00:21:36 +00:00
Sunny Goyal 46d2cc6edf Fixing UI leaks when using inline-subclass
Bug: 364363493
Flag: EXEMPT bug fix
Test: Presubmit
Change-Id: I8881569b021ab3737130d6d07ff3383dfab8df35
2024-09-04 20:47:14 +00:00
Marcelo Arteiro 13d9588f88 Merge "Updates many launcher color to new dynamic tokens" into main 2024-09-04 11:27:16 +00:00
Sebastián Franco 6d508c702a Merge "Remove event signaling logic from Launcher to the tests" into main 2024-09-03 20:43:55 +00:00
Sebastian Franco 899656a2a7 Remove event signaling logic from Launcher to the tests
Instead of throwing the event on the Launcher, now the test listens
to changes in the view tree and when the condition is meet it stops the
waiter.

Bug: 352569050
Bug: 324261526
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I94596429cb79af6b298281bd5cd4558e919736e2
2024-08-30 22:46:45 +00:00
Schneider Victor-tulias a4ce092bea Merge "Add a test base for AbsSwipeUpHandler and its subclasses" into main 2024-08-30 20:48:09 +00:00
Sunny Goyal 7a548377eb Remove obsolete features
Flag: EXEMPT legacy ENABLE_TWOLINE_DEVICESEARCH, ENABLE_ICON_IN_TEXT_HEADER, ENABLE_PREMIUM_HAPTICS_ALL_APPS
Bug: 270396358
Bug: 201388851
Bug: 270395143
Test: Verified manually
Change-Id: I88ca7b255d2ae4eba393c1aee52153ef0a459140
2024-08-30 13:04:08 -07:00