Commit Graph

20057 Commits

Author SHA1 Message Date
Charlie Anderson 219371c4ef Prevent archived apps content description from being overridden unexpectedly
Bug: 372035896
Test: manually tested archiving/unarchiving with Talkback
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:91a2aad67f2f5a9b8773d49daaf8c634884867e3)
Merged-In: Ief7f7d176c6ed23a8d7798cf31506e0a9c8921ed
Change-Id: Ief7f7d176c6ed23a8d7798cf31506e0a9c8921ed
2024-10-25 23:02:18 +00:00
Shamali P 656a026488 Fix issue that expanding only search result led to weird scroll
This piece of code was making list scroll for last item, which doesn't
really resolve problem or help for expanding items at end of visible
 list. As such scrolling only to get last time into visible area doesn't
 benefit anything (but creates inconsistency).

Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: I7ca519edfbb3a18c10fa518e28183da365f740e4
2024-10-25 23:00:57 +00:00
Shamali P be18ff2b7d Fix issue that items were invisible in 2-pane picker with talkback.
Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: Id8419e51bf20a38f203ce2422bae6290babcd63e
2024-10-25 23:00:36 +00:00
Stefan Andonian bb85110a0d Delete Unused Flag related to Altering how the workspace is loaded.
This flagged feature was never released, and instead was thought to be too
complicated compared to the benefits in decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: I672708e26cb37d1e2b22c4510f9c3500edd4f959
2024-10-25 22:28:55 +00:00
Stefan Andonian e87ca267b3 Cleaning up unused flag.
This feature was never released, but was meant to speed up the launcher's loading time.
It wasn't released because we ended up simply showing a Loading screen for long launch
times, and the extra complexity of this change was not deemed worth the decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: Ice0d8cbdc75ad69e80570d31d45c73f307fbf8b8
2024-10-25 22:28:29 +00:00
Mykola Podolian 3889bbc068 Merge "Fixed icons overlapping issue." into main 2024-10-25 19:37:38 +00:00
Anushree Ganjam ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Sunny Goyal c5c619b657 Merge "Keeping the custom widget placeholder even when the plugin is not corrected" into main 2024-10-25 16:47:38 +00:00
Fengjiang Li dd7d854c3a [PostBoot] Fix bug where post boot shader has a flicker
Pass correct default value -1 when getting RUNTIME_STATE_PENDING_REQUEST_CODE when it is not set.

This will avoid accidentally starting ProxyActivityStarter from Launcher#onCreate(), which will cause a flicker for post boot animation

Fix: 375308654
Flag: NONE - xml flag not supported
Test: manual
Change-Id: Ic3888508657b5b7aab37f6022768d53007bf9c00
2024-10-25 03:59:47 +00:00
Fengjiang Li edb2741c97 [PostBoot] Don't destroy loader because of config change, not just because of theme change
Follow up of ag/30026330

Bug: 298231234
Test: manual
Flag: NONE - xml flag not supported
Change-Id: I28caebbcb9f22c671dd64cfe56763a1f8b4c3f5a
2024-10-25 06:08:16 +08:00
Holly Sun 818608a2d2 Catch exception to prevent Launcher crash.
It happens on the line to get content description, which finally goes to `UserManager#getProfileType` (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:frameworks/base/core/java/android/os/UserManager.java;l=3390;drc=6fa95973e4c654ccd2b9c17b5e23ecf094875c5a). Catch the SecurityException to prevent Launcher crash.

Bug: 355793052
Test: manual
Flag: EXEMPT bug fix
Change-Id: I5ff83a50506e851362f190b5ab4c72ad7681f060
2024-10-24 14:47:04 -07:00
Sunny Goyal 6bbd805e77 Keeping the custom widget placeholder even when the plugin is not corrected
Custom widget plugin can take some time to load, which causes already added
custom widgets to get removed during reboot. Instead keeping the placeHolder
while the plugin loads

Bug: 375444632
Flag: EXEMPT bugfix
Test: Manually verified using a custom plugin
Change-Id: Ibdf14f6d24adc194a716b29bb75a22220384e730
2024-10-24 12:40:13 -07:00
Brandon Dayauon 838a5e9d23 Merge "Add trace logs in Launcher for perfetto to investigate two line issue" into main 2024-10-24 19:35:15 +00:00
Anushree Ganjam ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
Treehugger Robot c7b078d7a2 Merge "Refactor grid migration" into main 2024-10-24 19:00:22 +00:00
mpodolian 9fc4fad24f Fixed icons overlapping issue.
Removed early return condition from the Hotseat view

Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Unfold foldable device and have bubble. Fold the device.
Hotseat icons are not overlapped.
Fixes: 375240372

Change-Id: I576c893896c98d2a0dcb25f64396f4e9fe62f61c
2024-10-24 11:24:07 -07:00
Brandon Dayauon aebe733849 Merge "Set twoline toggle to false when not in english language." into main 2024-10-24 15:09:08 +00:00
Fengjiang Li c8bd4bd3d3 Merge "[PostBoot] Do not destroy post boot loader because of theme change" into main 2024-10-24 07:59:24 +00:00
Brandon Dayauon 51db65ee49 Add trace logs in Launcher for perfetto to investigate two line issue
bug:375267130
Test manually screenshot:
onIdpChange: https://screenshot.googleplex.com/ASbyGFoAhTXgnWK
statefulActivityOnConfigChange: https://screenshot.googleplex.com/gLqxeJN7TzUURCy
Flag: NONE adding traces to perfetto

Change-Id: Ib2ac49fb8668fdfc91c8e38b91a4afd10127a4c5
2024-10-23 22:59:58 -07:00
Mykola Podolian 4dc6617988 Merge "Updated bubble bar position to be center aligned with the hotseat" into main 2024-10-24 02:10:43 +00:00
Fengjiang Li db897c4fe9 [PostBoot] Do not destroy post boot loader because of theme change
Bug: 298231234
Test: manual
Flag: NONE - xml flag not supported
Change-Id: I7ee9de3bddaac8578b639f091d6bbbf3ae458fd1
2024-10-24 09:09:44 +08:00
Holly Sun cf5fbe7816 [clean-up] Clean up Quick Launch V2 and V1.
Bug: 282830271
Test: manual
Flag: EXEMPT old flag enable_quick_launch_v2
Change-Id: Ibcd8938a021b5f558a807e85c44fe6c161aa572a
2024-10-23 16:05:16 -07:00
fbaron a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
mpodolian f230eee2ff Updated bubble bar position to be center aligned with the hotseat
Added a method to the device profile to calculate the vertical center of
the hotseat icons. Simplified the logic for positioning the bubble bar.

Test: TransientBubbleStashControllerTest
Test: PersistentBubbleStashControllerTest
Test: Visual. Go to home page, check that bubble bar is vertically
center aligned with the hotseat
Bug: 345491493
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I52f1b94de79f6c912f43a88fcc5c884e20e56310
2024-10-23 14:44:40 -07:00
Treehugger Robot 8e7ab8d282 Merge "Differentiate failed restores from failed grid migrations." into main 2024-10-23 21:03:17 +00:00
Stefan Andonian 8c0a78727c Differentiate failed restores from failed grid migrations.
Bug: 353505773
Test: Verified logs on my device. Behavior was correct.
Flag: EXEMPT logging
Change-Id: Id0b3dcaae8640c8dd0fac4f8fb42c41dc2eb1385
2024-10-23 11:32:53 -07:00
Brandon Dayauon 8cc4cd1d86 Merge "Call invalidate() during updateView() for updating the header." into main 2024-10-23 15:27:49 +00:00
Shamali Patwa d6f39e3f45 Merge "Enforce system radius instead of separate value for widgets in launcher" into main 2024-10-23 00:04:50 +00:00
Brandon Dayauon d633368465 Call invalidate() during updateView() for updating the header.
This issue is triggered due to onAppsUpdated() randomly due to app installing/uninstalling/updating/archiving. Eventually
onBind() is called but logs shows evidence that the state is correct (even though it doesn't reflect that), hence invalidating will fix this issue.
We can't call notifyItemChange() in updateView() since updateView() can be part of onBind() in which case means this is part of a scrolling gesture. notifyItemChange()
via adapter index will also not work in reset() since doing so will mess up upon animation.

bug: 373345958
Test: manual/presubmit
Flag: NONE invalidating when updateView() is called
Change-Id: Ibc99cc70562575cadf035136e50e9e5eec1e70ea
2024-10-22 17:02:50 -07:00
Treehugger Robot 08007068d4 Merge "Generalize ActivityTracker to support RecentsWindowManager" into main 2024-10-22 21:26:58 +00:00
Brian Isganitis 8018dcad35 Merge "Update recent indicators to match spec." into main 2024-10-22 19:31:48 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
Shamali Patwa 2fc32dc2d8 Enforce system radius instead of separate value for widgets in launcher
The change is behind a flag. This is to get to the stage of having
consistent corner radius across rectangular widgets.

Bug: 373351337
Test: Unit test and manual
Flag: com.android.launcher3.enforce_system_radius_for_app_widgets
Change-Id: I23d8d3bb2561b4fc3f780fc4ddce62e8b9293192
2024-10-22 18:03:07 +00:00
Brandon Dayauon 9c65174760 Set twoline toggle to false when not in english language.
Set toggle preference in deviceProfile as this is the first step after the locale change before any binding/inflation happens.
Otherwise the toggle will be stale if we set this false during "apply"/bind which can cause complexities.

bug:373670311
Test manually vid: https://drive.google.com/file/d/1WXl_fMU8eynwlxdwYBamEnqP1tU_q0kb/view?usp=sharing
Flag: NONE bugfix

Change-Id: Iaf9e88ef76ebda6b62942b7bc3f4e39b4ced5116
2024-10-22 09:57:23 -07:00
Anushree Ganjam 266554fe58 Merge "Make RefreshRateTracker to be injected by Dagger (11/n)" into main 2024-10-22 16:27:28 +00:00
Brandon Dayauon 9cd3aae49a Merge "Instead of checking for locale, check language specifically." into main 2024-10-22 15:28:31 +00:00
Anushree Ganjam bb996d1304 Make RefreshRateTracker to be injected by Dagger (11/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: Ice5dc3364f90d2b9b99a0837702ae1d49a356f88
2024-10-21 17:20:38 -07:00
Brian Isganitis 27e05992f6 Update recent indicators to match spec.
Does not implement any animations.

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Fix: 356394053
Test: go/testedequals
Change-Id: If8e319b605beedd0e9b14dc37da1b5ffa12f3c9f
2024-10-21 15:04:03 -04:00
Brandon Dayauon 13b964f91d Instead of checking for locale, check language specifically.
Should be checking for english language as seen here: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:libcore/ojluni/src/main/java/java/util/Locale.java;l=1374?q=locale%20getLanguage&sq=repo:googleplex-android%2Fplatform%2Fsuperproject%2Fmain%20b:main

This gives the language code which is what we should be checking against according to https://yaqs.corp.google.com/eng/q/4542431059247104.

bug: 373670311
Test: Manually - tried with various other "ENGLISH" languages besides US. Including Bermuda/UK and non english languages
Flag: NONE locale checking
Change-Id: Ib2eff4c9a13b74ede8575ee8d5280bbf9b9b8729
2024-10-21 11:32:13 -07:00
Sunny Goyal 0b7f4cf1e2 Fixing deadlock in dagger singletons
Bug: 373557167
Flag: EXEMPT dagger
Test: atest DaggerSingletonDeadlockTest

Change-Id: I2304237bfd818c99b82bbfceea8a81ddb136b5a1
2024-10-21 18:09:37 +00:00
Brandon Dayauon c1c1c873b9 Merge changes from topic "fastScrollerPrivateSpaceDrawableToLetters" into main
* changes:
  Update letter list textview background color to spec.
  Remove color animations when scrolling.
2024-10-18 23:07:09 +00:00
Winson Chung fd91b7be4e Merge "Remove user TIS unlocked runnable when a TIS instance is destroyed" into main 2024-10-18 17:03:55 +00:00
Winson Chung a9355d4dba Remove user TIS unlocked runnable when a TIS instance is destroyed
- If the TIS instance is destroyed, then we should remove any queued
  user-unlocked runnables to ensure that they do not attempt to run
  again

Flag: EXEMPT bugfix
Bug: 373671447
Test: atest NexusLauncherTests
Change-Id: I8ca3cdfa6f849bce5d347f14038e1ebd6bc6ff06
2024-10-18 04:26:37 +00:00
Treehugger Robot 71c3d1f089 Merge "Handle enter key as editor action in search bar" into main 2024-10-18 01:18:40 +00:00
Charlie Anderson 7f50e9c66a Merge "Prevent archived apps content description from being overridden unexpectedly" into main 2024-10-18 00:24:49 +00:00
Mykola Podolian 42e6127c2b Merge "Refactored hotseat translation X logic" into main 2024-10-17 23:23:08 +00:00
Sunny Goyal 4eaf3df1fe Merge "Moving PluginManager to dagger" into main 2024-10-17 21:47:28 +00:00
Charlie Anderson 91a2aad67f Prevent archived apps content description from being overridden unexpectedly
Bug: 372035896
Test: manually tested archiving/unarchiving with Talkback
Flag: EXEMPT bugfix
Change-Id: Ief7f7d176c6ed23a8d7798cf31506e0a9c8921ed
2024-10-17 17:39:59 -04:00
Sunny Goyal 9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Brandon Dayauon 134bd12153 Merge "Set psDivider to gone in collapse due to updateAdapterItem suppression in test." into main 2024-10-17 17:09:12 +00:00