Moving widget filtering to UI layer as it changes with surface
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
This cl inlcudes: while user is in desktop mode, we will add state description(active, minimized) of each app icon to it's content description.
Test: Manual
Bug: 397555157
Flag: EXEMPT bugfix
Change-Id: Iaec18e7099108e8b076b76c637a41e29ed837265
TODOs have been added for verifying and updating the Outline, right to left mode,
and the entry animation. This CL is complex, and those have been left out on purpose.
Bug: 394355070
Test: Verified this behavior looks good in LTR on the workspace.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I8f0192f461d344360572411e1a62921fd65ba600
This cl adds the unpin option by tracking the hotseat/taskbar state. The
option shown is determined by the following conditions:
1. If the target non-predicted item is on the taskbar, shows
"Unpin from taskbar"
2. If the taskbar is not full, that is, reaching the limit of the
available spaces, and the target item is anywhere outside of the
taskbar, including All apps, shows "Pin to taskbar".
3. If the taskbar is full, simply don't show any shortcut option.
This cl also removes the option that will be shown on Launcher
homescreen or hotseat, as further UX alignment is needed.
One note about why the pin shortcut is not implemented in the
getShortcuts(). The reason is that getShortcuts does not have the
ItemInfo of the triggered item, while the SystemShortcut.Factory doesn't
have the hotseat/taskbar information. The simplest way at this point is
to check all the conditions in the controller and then manually add the
shortcut into the list.
Bug: 375648361
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I7d048bcb1b00f78651e909fbfcd911052a4cd4ef
Rather than register a StateListener for each LauncherAppWidgetHostView, just register one StateListener which, upon launcher state is changed to NORMAL, iterate over all child views under Workspace and perform a11y action if view tag is set.
Fix: 397978703
Test: presubmit
Flag: EXEMPT bug fix
Change-Id: I044d012b74eaa5356196c5503318fa8ab389ec46
XL and large grid icons were showing up with the flag off
Bug: 395139926
Test: ValidGridOptionsTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: If6b077ce854341563d8c2fbefd741b598b77a7a8
With new grid, David suggested reducing padding on widget cell to be
able to show side by side widgets as before. Widget sizes are slightly
larger in new grid.
Bug: N/A
Test: Screenshot tests
Flag: EXEMPT bugfix
Change-Id: I3b3b55930b9e4ad9064151ccfe77ba27d8289860
- With the introduction of Desktop windowing, we'll need to supprot grid task and large tile (desktop tile) coexisting
- The previous gridOnlyOverview aimed to have taskSize matches actual grid task size, and introduced another carouselTaskSize for scaling in swipe up carousel
- Now I'm reverting to pre-gridOnlyOverview implementation of having taskSize as both large tile size and carousel task size, and gridTaskSize as only task size in grid
TaskViewSimualtor
- Removed no longer needed carousel translation and related calculations
- mIsGridTask is now determined with DeviceProfile, so when swipeing to Desktop task it won't use grid task size
TaskView
- Removed no longer used nonGridPivotTranslationX
RecentsView
- Make getSelectedTaskBounds / getTaskBounds picks the correct taskSize
Fix: 359573248
Fix: 321697299
Fix: 325606690
Bug: 322816508
Test: Swipe up, quick switch, task launching with grid task and desktop tasks; repeat with RTL, three button, phone
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I14648c6682c53a4d06f9c9585d53f28dddef4f8f
Based on https://b.corp.google.com/issues/383457529#comment5, we should remove all app annouced confirmation.
Bug: 386247991
Test: build
Flag: EXEMPT a11y bug fix
Change-Id: I0ba2e282a42c0785c8bdad1be23adf2bf90a44b3
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.
Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
In b/297952359 we are seeing that widgets with clipped outline
elements end up showing shadows below their drag view. Which
due to not maintaining clipping looks further bad.
It seems like, we don't really need the elevation for drag
view anymore - and presumably it was added for older android
versions for shadow for folders. But, they don't have them
anymore, so, removing elevation now.
Note: The issue that during drag and drop, the dragged preview
not showing clip to outline or shadows within widget's views is
a separate issue related to the Picture API usage during drag
and drop.
Bug: 297952359
Test: Screen record in comments
Flag: EXEMPT Bugfix
Change-Id: If31a0275938afe374d269a46cc950970033323f9
- Per android design folks, "outline" is the right token to use
- They've also verified with material design folks that its the
recommended value.
Bug: 378424549
Test: WIM contrast checker
Flag: EXEMPT BUGFIX
Change-Id: I3b45860da9405469600771d6ff5d1adea1e4ea4c
With tap to add feature, tapping widget cell reveals add button.
So, clarify the intent with ACTION_CLICK
Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds. Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.
Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.
Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
Sebastián Franco
Ana Salazar Maldonado
Brian Isganitis
Brandon Dayauon
Treehugger Robot
Pat Manning
Sunny Goyal
Wen-chien Wang
Jagrut Desai
Stefan Andonian
Fengjiang Li
Federico Baron
Shamali Patwa
Alex Chau
Holly Jiuyu Sun
Anushree Ganjam
Marcelo Arteiro
Pinyao Ting