Lawnchair

PawletOS/Lawnchair

Fork 0

Commit Graph

Author	SHA1	Message	Date
Marcelo Arteiro	bc02103a6a	Migrate materialColor* attributes into colors TLDR: * This change should not break anything or change any color. * Simplifies theming and styling while improving developer experience. * With this developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides. Bug: 374273611 Test: presubmit Flag: EXEMPT bugfix Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2	2024-11-21 13:08:11 +00:00
Brandon Dayauon	df5e51ce34	Fix work tab accessbility issues. The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead. bug: 379222957 Test manually, photos: beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing Flag: NONE bug fix changing dp Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a	2024-11-18 15:16:41 -08:00
Liam, Lee Pong Lam	d4488bfd72	Implement focus state on personal/work tab button figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0 result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5 hsv: https://hsv.googleplex.com/4794951907934208 Bug: 327430110 Flag: EXEMPT bugfix Test: Manual Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369	2024-09-25 20:34:49 +00:00

Author

SHA1

Message

Date

Marcelo Arteiro

bc02103a6a

Migrate materialColor* attributes into colors

TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2

2024-11-21 13:08:11 +00:00

Brandon Dayauon

df5e51ce34

Fix work tab accessbility issues.

The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.

bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp

Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a

2024-11-18 15:16:41 -08:00

Liam, Lee Pong Lam

d4488bfd72

Implement focus state on personal/work tab button

figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208

Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369

2024-09-25 20:34:49 +00:00

3 Commits