Commit Graph

23356 Commits

Author SHA1 Message Date
Jagrut Desai 5e8b535af6 Initialize TaskbarFeatureEvaluator and SpecsEvaluator onlyu if customization is on
Test: presubmit
Bug: 353841430
Flag: com.android.launcher3.enable_taskbar_customization
Change-Id: I5699e99eee0817327ca66598bfccb622801762ab
2024-07-29 15:14:55 -07:00
Liran Binyamin 612263104b Animate the bubble badge
The bubble badge now scales together with the expand and collapse
animation of the bubble bar. The badge for the selected bubble is
always kept at full scale.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349826874
Test: manual
       - create some bubbles in the bubble bar
       - expand and collapse the bar
       - observe badge icons scale accordingly
Change-Id: I04e9174f4a921e404cb3162337f594c16478b16c
2024-07-29 08:06:55 -04:00
Alex Chau 2a640c61a7 Don't show splash when thumbnail is null in SplashAlphaUseCaseTest
- thumbnail is always null to begin with, and we don't want the splash icon to ever shown in Overview, so it should default to hidden

Fix: 356079562
Test: SplashAlphaUseCaseTestTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I2a010f911814fda2bbcf0ca7ebc7192580772076
2024-07-29 11:28:19 +01:00
Liran Binyamin 4b4122d02e Initial view screenshot tests for BubbleView
Flag: EXEMPT test only
Bug: 355454021
Test: atest NexusLauncherViewScreenshotTests

Change-Id: I32c2a190333143c1ec2fe977efef43b4c04fd469
2024-07-29 04:39:28 -04:00
Treehugger Robot 453734f09e Merge "Support switch to screenshot for TTV" into main 2024-07-27 00:14:26 +00:00
Jagrut Desai 65b5eb472e Merge "Unit Testing for TaskbarEduTooltipController" into main 2024-07-26 22:44:16 +00:00
Alex Chau 378622c907 Support switch to screenshot for TTV
- Moved live tile decision to TaskThumbnailViewModel, and added RecentsViewData for runningTask information
- Implemented a ThumbnailData override mechanism to override screenshot from TaskThunmbnailCache, the override will be added during switchToScreenshot and cleared when user exit recents (RecentsView.reset)
- During the thumbnail override, we wait until the new ThumbnailData propagates, before finsihing Recents animation to avoid a frame of flash

Bug: 343364498
Test: TaskThumbnailViewModelTest, TaskRepositoryTest, RecentsViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I776943ecdfa0d65d94b054692297b42686f59f8a
2024-07-26 21:25:58 +01:00
Andy Wickham 369a5e749b Merge "Add 2 stage LPNH tests." into main 2024-07-26 19:38:27 +00:00
Schneider Victor-tulias c8a533d542 Revert "Add debug logs to TopTaskTracker"
This reverts commit 86b9ad4ff7.

Reason for revert: debug logs no longer needed

Change-Id: Ia64f9e50934ac685f75f5109fc694720a07f17ac
2024-07-26 19:25:36 +00:00
Jagrut Desai 5af1bfbf52 Unit Testing for TaskbarEduTooltipController
This CL includes
	- TaskbarEduTooltipController Unit Test for all edu logic and hide tooltip
	- Test util class for taskbar controller test to run the test on main thread.
	- Refactored other controller test to use the new util function to run test on main thread.
	- Ability to disable running test in test harness mode.

Test: Presubmit
Bug: 346394824
Flag: TEST_ONLY
Change-Id: Ic623df8e7a58ac48d260e592ffab61d1f0658aef
2024-07-26 12:14:50 -07:00
Mykola Podolian 550927be44 Merge "Added TransientTaskbarStashController implementation." into main 2024-07-26 16:59:46 +00:00
Perry Wu f1e7136cce Merge "Fix launcher KCA updates when entering -1 screen" into main 2024-07-26 16:14:42 +00:00
Jon Miranda 5dc07d786f Add support for taskbar background to wrap around hotseat
Currently only enabled for app launch animation

Future work is planned:
- Overview to home
- App dismiss
- When QSB is drawn inline

Bug: 345768019
Test: Launch an app, taskbar background and stashed handle will
      first wrap around hotseat before transforming into the
      stashed handle.
      Verified by locally forcing taskbar background and
      stashed handle to always draw.
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I9ab1870f87247b6a1b53a352ac3eb0183b7a1a1d
2024-07-26 08:10:50 -07:00
Treehugger Robot b7b48bbbd3 Merge "Revert "Handle uiMode changes in QuickstepLauncher"" into main 2024-07-26 12:08:53 +00:00
Vinay Joglekar 084fe14c50 Merge "Remove todo to Support sysUiStatusNavFlags" into main 2024-07-26 11:52:35 +00:00
Alex Chau 2676385eb8 Revert "Handle uiMode changes in QuickstepLauncher"
Revert submission 27627108-b/339747262

Reason for revert: b/353914086
Fix: 353450667
Fix: 353914086
Bug: 339747262

Reverted changes: /q/submissionid:27627108-b/339747262

Change-Id: I9a71ee0fa4062b15e68eff41951f42d46ace19d3
2024-07-26 10:18:20 +00:00
vinayjoglekar 9f9cea38aa Remove todo to Support sysUiStatusNavFlags
Bug: 350743460
Test: NA
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie61ffc6ef7876f2907cf3d223eb7ed11d72e28c4
2024-07-26 10:03:14 +00:00
mpodolian a5cd1a0dbb Added TransientTaskbarStashController implementation.
Added TransientTaskbarStashController implementation of
BubbleStashController interface. Added tests for the implementation.

Bug: 346391377
Flag: com.android.wm.shell.enable_bubble_bar
Test: TransientTaskbarStashController
Change-Id: Ie302086d6b4aac48a948473908b68c2c436e4b30
2024-07-26 02:19:00 +01:00
Tracy Zhou 7617787c80 Merge "Allow trackpad to tune RAPID_DECELERATION_FACTOR for gesture nav" into main 2024-07-26 00:35:02 +00:00
Andy Wickham e935438787 Add 2 stage LPNH tests.
Fix: 353613649
Test: NavHandleLongPressInputConsumerTest
Flag: TEST_ONLY

Change-Id: I99f4eb5f999d2769cc2d9e1eb1d04ae6c5ff27db
2024-07-25 23:21:16 +00:00
Evan Rosky e56cb3dbf5 Merge "Skip launcher return for custom task transitions" into main 2024-07-25 22:13:53 +00:00
Tracy Zhou 8e56fe3912 Allow trackpad to tune RAPID_DECELERATION_FACTOR for gesture nav
- RAPID_DECELERATION_FACTOR determines whether swipe up from app takes the user to overview vs. home

Bug: 355457714
Test: adb shell setprop trackpad_in_app_swipe_up_deceleration_factor 0.6f
Flag: EXEMPT bugfix

Change-Id: I205e72c82dc08b9e542420ca1adc8f7c0eb0953d
2024-07-25 12:52:03 -07:00
Mykola Podolian c4ae2f65b6 Merge "Improvement for the Bubble Bar Bubbles' Shadows" into main 2024-07-25 18:35:22 +00:00
Ats Jenk c11fd79ec4 Merge "Include bubble bar location in taskbar announcement" into main 2024-07-25 17:43:43 +00:00
Treehugger Robot 4a6c90d552 Merge "Add unit tests for MultiStateCallback" into main 2024-07-25 17:43:24 +00:00
Liam, Lee Pong Lam 85f3476943 Fixes SettingsChangeLoggerTest failures
The mLoggablePrefs was created on constructor, so move the system under test out of setup because the preference change needs to be made before it.
For details: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/quickstep/logging/SettingsChangeLogger.java;drc=c56711c6691e7957ed98a9de6b3acb79103abb66;l=95

Bug: 354157494
Test: Unit tests
Flag: EXEMPT bugfix

Change-Id: I2fd5eec5b10d7463c663df03cfefefb11bcefecc
2024-07-25 17:18:15 +00:00
Perry Wu 603f408bf8 Fix launcher KCA updates when entering -1 screen
Fix an issue where launcher incorrectly sets KCA as visible when
entering the -1 screen. This adds a check for whether we are on the
-1 screen.

Note that there is still a another callback that happens when
interacting or exiting the -1 screen, could be worth investigating
further.

Flag: EXEMPT bugfix
Test: enter -1 screen > verify pip moves down and KCA visible=false
Test: exit -1 screen > verify pip moves up and KCA visible=true
Bug: b/354080363
Change-Id: I1b8c05af21eca5a2accc8e94ab016f6c50c74c7c
2024-07-25 17:00:17 +00:00
Uwais Ashraf 06dd94c66a Add splash state to new TTV
Bug: 334826842
Test: test classes added in CL
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ia7c2de18b5ff932430946df6b4c27929d715e79c
2024-07-25 14:35:00 +00:00
Schneider Victor-tulias dfeb22f7ab Add unit tests for MultiStateCallback
Flag: EXEMPT adding tests
Fixes: 355003429
Test: MultiStateCallbackTest
Change-Id: Id617ca79c44dcfa6226e47d574b9e3bfe6cfb140
2024-07-25 10:11:17 -04:00
Treehugger Robot acc4a81a97 Merge "Fix NPE when activity launch options are created before taskbaer init" into main 2024-07-25 14:03:30 +00:00
Vinay Joglekar fe7878c144 Merge "Dim TaskThumbnailView on Foreground scrim" into main 2024-07-25 13:03:49 +00:00
vinayjoglekar 36ef7bf6e7 Dim TaskThumbnailView on Foreground scrim
Bug: 349601769
Test: TaskThumbnailViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3a9fa21d8a4c28ffe40279243030f0e47c957513
2024-07-25 11:18:20 +01:00
Jon Miranda 310e4c8038 Fix NPE when activity launch options are created before taskbaer init
Change-Id: Ibb8cf96ad4e528754aeb98ff0a702af2412e1052
Test: init
Fixes: 355231499
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
2024-07-25 05:53:45 +00:00
mpodolian 6ba541642e Improvement for the Bubble Bar Bubbles' Shadows
The issue was caused by the alpha animation applied to the bubble bar.
Added code to check if the alpha applied to the bubble bar is less than
1 and instruct child bubble views not to provide a shadow outline in
such cases. While this is not a full fix, but rather an improvement,
b/345490679 should introduce a proper fix.

Bug: 345484712
Test: visual - go to any application and stash/unstash bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Icb6bdb009f4d5998ec1638f97de89f7a4c9feccf
2024-07-25 05:31:55 +01:00
Anushree Ganjam 7640b08ea3 Merge "Format dump logs so each of apps info prints in new line." into main 2024-07-24 23:43:54 +00:00
Treehugger Robot de1a7e067f Merge "Move TestExtensions.kt to quickstep for DeviceConfig overrides." into main 2024-07-24 22:42:00 +00:00
Ats Jenk 4e4b8a8402 Include bubble bar location in taskbar announcement
When bubble bar has bubbles, it will be expanded together with taskbar.
Include information about bubble bar appearing together with the taskbar
announcement. During expand include the location of the bubble bar,
whether it is on the left or right.

Bug: 344675357
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, enable talkback and check that taskbar expand announcement
  includes information about bubble bar, check that when bar is on left,
  announcement includes left and bar is right, announcement says right
Change-Id: I116ed531fe7032940478451508b37f4fd0bc98ff
2024-07-24 13:50:08 -07:00
Robin Lee 004849d2ec Skip launcher return for custom task transitions
Overriding the task exit transition requires a permission that indicates the exiting task already knows more than the launcher about what its exit is supposed to look like, so we
will let it play the animation it likes instead of the default return-to-launcher one.

Change-Id: I8f4b7292ae0863d378ec6319816e1b9cc7735c24
Test: atest transition-hotlaunch-phone
Flag: EXEMPT bugfix
Bug: 350712843
2024-07-24 20:49:39 +00:00
Liran Binyamin f93199cbe3 Merge "Fix squished hotseat due to bubbles" into main 2024-07-24 19:13:02 +00:00
Shamali Patwa b4d185e3cc Merge changes from topic "popup-refactor" into main
* changes:
  Delete the unused code from popup provider
  Update references that read popup data provider to use picker provider
  Update references that wrote widget data to popup data provider
  Move widget related listeners to widget picker data provider
  Define widget picker data provider separate from popup provider
  Create a separate class for widget related methods from popup provider
2024-07-24 18:46:35 +00:00
Liran Binyamin 2a47a4a68d Fix squished hotseat due to bubbles
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
  1. When Hotseat's layout is reset, it checks for whether bubbles
     are showing.
  2. When Bubble Bar visibility changes it notifies hotseat so that
     it can update itself.

Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.

This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.

This change also updates the way QSB adjusts itself for bubbles.
Previously it always animated from the same start value to a target
value. Now the animation starts from its current width to the target,
so that if the current width is already equal to the target width,
there is no visible change.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
       - unfold the device
       - create bubbles
       - observe hotseat adjusts itself for the bubble bar
       - fold the device
       - observe bubble bar is gone and hotseat shows correctly
Test: manual
       - start a youtube video in full screen
       - swipe from the edge of the screen to show the gesture nav
       - swipe on the gesture nav to go home
       - observe that the QSB does not animate
Change-Id: Ia0267ec518d6af9c3c3b68f17bb20ea67a49e5fd
2024-07-24 12:49:17 -04:00
Alina Zaidi bd3bb00593 Merge "[Dev options][More flags] Update all usages of some flags to use DesktopModeFlags." into main 2024-07-24 10:26:17 +00:00
Treehugger Robot 562e93afac Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-24 05:15:14 +00:00
Treehugger Robot 5ace16c7b8 Merge "Only register RecentTasksChangedListener if flag is enabled" into main 2024-07-24 01:17:35 +00:00
Andy Wickham 75ce1a2cd6 Move TestExtensions.kt to quickstep for DeviceConfig overrides.
Fix: 353740808
Test: Run existing tests using this class
Flag: TEST_ONLY
Change-Id: Ie72fb86ea4d451e90a6629554dc717126db0b24c
2024-07-24 00:15:05 +00:00
Tony Wickham bbfa9fc181 Only register RecentTasksChangedListener if flag is enabled
Also unregister it if the feature becomes disabled (currently
this is only done in tests but in the future there will be a
user setting as well).

Added tests to verify getTasks() is not called while both
canShowRunningApps and canShowRecentApps are false.

Bug: 354087794
Test: TaskbarRecentAppsControllerTest
Flag: com.android.launcher3.enable_recents_in_taskbar
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Change-Id: I3123501e7584ad7f877e13294454556501d2dbc8
2024-07-23 23:24:10 +00:00
Treehugger Robot 33a237e447 Merge "Fix ConcurrentModificationException in OmniInvokerTest" into main 2024-07-23 23:23:27 +00:00
Treehugger Robot ea4373c060 Merge "Add NavHandleLongPressInputConsumerTest." into main 2024-07-23 23:20:47 +00:00
Treehugger Robot f3e8844b8c Merge "Revert "Fix squished hotseat due to bubbles"" into main 2024-07-23 23:16:48 +00:00
Treehugger Robot e3078707a0 Merge "Move more tests to deviceless" into main 2024-07-23 23:16:08 +00:00