Commit Graph

23356 Commits

Author SHA1 Message Date
Liran Binyamin 138dd0bc5f Fix bubble bar visibility issue
Update the bubble bar visibility for the initial bubble if the animation
is suppressed, e.g. if we're creating the bubble when the shade is open.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 382693837
Test: manual
       - enable bubbles
       - remove all conversations from the list of allowed to bubble
       - create notification
       - open shade and click on the bubble button to bubble the notification
       - observe bubble bar becomes visible

Change-Id: If771c28998b2b091f4f1ab38001e9485ed1ed849
2024-12-12 15:36:29 -08:00
Sunny Goyal daf46a09b2 Merge "Moving WMProxy to dagger" into main 2024-12-12 15:27:19 -08:00
Schneider Victor-Tulias 7fb1d6d53b Update ProtoLogProxy classes to only log to protolog when protolog has been initialized
Flag: com.android.launcher3.enable_active_gesture_proto_log
Flag: com.android.launcher3.enable_recents_window_proto_log
Flag: com.android.launcher3.enable_state_manager_proto_log
Fixes: 381846204
Test: ran launcher and checked logs
Change-Id: I807326bd6c65b8e51f5302ba58eed841c23216f6
2024-12-12 15:03:56 -05:00
Brandon Dayauon 1d1bffbf0b Merge "Fix unintended scroll in all apps when using external mouse." into main 2024-12-12 11:37:31 -08:00
minch b344bc1fb6 Migrate to TaskViewsIterable & TaskViewsIterator - [2/n]
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I9bd1bad7a9eb8a3cc8333f37e3b535975a5ce0b6
2024-12-12 11:29:48 -08:00
Ats Jenk 49319240dd Merge "Handle suppressed bubbles" into main 2024-12-12 10:12:45 -08:00
Johannes Gallmann c8fd3f23fe Play workspace reveal animation for predictive back-to-home
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: com.android.launcher3.predictive_back_to_home_polish
Change-Id: I092a74ab2340828e18067ca15c7019c44d30f40b
2024-12-12 14:18:03 +00:00
Alex Chau 74ff7af5e2 Merge "Migrating the remaining getTaskViewAt(0)" into main 2024-12-12 04:01:59 -08:00
Alex Chau f3013954a3 Merge "Introduce hasTaskViews() to RecentsView" into main 2024-12-12 04:01:07 -08:00
Treehugger Robot 41d5494a4e Merge "Fix for split animation" into main 2024-12-12 01:55:55 -08:00
Treehugger Robot 24218845df Merge "Introduce TaskViewsIterator and TaskViewsIterable" into main 2024-12-11 17:53:47 -08:00
Brandon Dayauon 1fb2d7815f Fix unintended scroll in all apps when using external mouse.
The reason is because when ag/29152694 was introduced, the accessibilityEvent that would
trigger is TYPE_VIEW_HOVER_ENTER that would eventually always have the list scrolling depending
on where the mouse would be. Gating it to TYPE_VIEW_ACCESSIBILITY_FOCUSED would be fix this as
this should still work for talkback when traversing the A-Z list as TYPE_VIEW_ACCESSIBILITY_FOCUSED is whats is always used
during this case.

bug: 372965379
Test: manually
Flag: EXEMPT bug fix
Change-Id: I249cee8036216f93aab53efc3d77fad047f7e408
2024-12-11 16:53:16 -08:00
Ats Jenk bcc12470b7 Handle suppressed bubbles
Hide or show bubble based on suppression signals from shell.
If this is the only bubble, hides or shows the bubble bar.

Bug: 273316505
Test: have a single bubble in the bubble bar, suppress the bubble,
  observe that bubble is hidden and bubble bar is not shown,
  unsuppress the bubble, check that bubble bar and bubble is shown
  again, perform check with transient and persistent taskbar
Test: have multiple bubbles, suppress one bubble, check that this bubble
  is not shown, but the bubble bar remains visible with other bubbles,
  perform the check with transient and persistent taskbar
Test: have a single bubble in bubble bar that is suppressed, receive
  notifications to trigger new bubbles, observe bubble bar is shown for
  new bubbles, check that after unsuppressing bubble, it is added back,
  perform the checks with tranient and persistent taskbar
Test: suppress a bubble and rotate the device to trigger launcher
  recreation, check that after unsuppress, the bubble is added back

Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I17e5cec750a2666feecc62213a3e8fc204ee510a
2024-12-11 16:02:32 -08:00
minch c7a66bd4af Migrating the remaining getTaskViewAt(0)
Migrating the remaining `getTaskViewAt(0)` to `getFirstTaskView()`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I083626b0ca62b88d06f508dfc15d9f64112f1a6a
2024-12-11 23:50:53 +00:00
minch 3695c7a64c Introduce hasTaskViews() to RecentsView
- This function is going to replace all the call sites that compares
  `getTaskVieCount()` and `0`.
- This is based on the fact that this count can not be a negative
  number.
- Introduce `getLastTaskView()` to get the last TaskView inside the
  RecentsView.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: Iefb107d1aba61549a870f14c18e025c34b19a1b5
2024-12-11 23:44:16 +00:00
Bill Yi ab76a45616 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-11 14:44:09 -08:00
minch 37ed08215d Introduce TaskViewsIterator and TaskViewsIterable
- Create TaskViewsIterator to iterate all the current TaskViews inside
  RecentsView.
- Create TaskViewsIterable with TaskViewsIterator as its iterator.
- Create `mTaskViewsIterable`, an instance of TaskViewsIterable that
  used to make the TaskViews iterable.
- Current `getTaskViews()` return `mTaskViewsIterable` directly.
- Change `getTaskViews()` to be a public function, thus it can be
  used outside of the RecentsView.

Some follow-up work includes:
- Replace all the call sites of `getTaskViewAt(0)` with
  `getFirstTaskView()`
- Replace `0` as the index of the first TaskView  with
  `getFirstTaskViewIndex()`
- Audit all the call sites of iterating the TaskViews, let them use
  `getTaskViews()` or IterableTaskViews.iterator() if index is needed.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure the TaskViews required are correct in the following
      scrnarios:
      1. Swiping up from home screen to enter overview with empty or
         multiple tasks
      2. Swiping up from a fullscreen app to enter overview with
         one or multiple tasks
      3. Dimissing one or multiple tasks, exit and enter overview w/o
         newly opened tasks
      4. Remvoing all the tasks, reenter overview w/o newly opened
         tasks
Change-Id: I930ce92b7e0bc37005af74a58fd4c0ce3013e5cb
2024-12-11 21:48:34 +00:00
Sunny Goyal 41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00
Treehugger Robot 4d4eb7d685 Merge "Introduce mTaskViewCount inside the RecentsView" into main 2024-12-11 12:36:00 -08:00
minch 58abc8b0a6 Introduce mTaskViewCount inside the RecentsView
Add a member property `mTaskViewCount` inside the RecentsView to track
the number of TaskView inside it. Its value will be increased
`onViewAdded` and decreased `onViewRemoved`.
- Then `getTaskViewCount()` can just return this variable directly.
- Invalidate the `PagedView.mPageScrolls` on a view addition and
  removal util they have been updated on next `onLayout`. This is done
  to guarantee that `mOnPageScrollsInitializedCallbacks` is run with
  up to date `mPageScrolls`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Tested on Tangor, ensure `mTaskViewCount` is correct in the
      following scenarios:
      1. Adding more tasks and enter overview
      2. Dismissing one and more tasks
      3. Dismissing all tasks
Change-Id: I32407e77dd2a9b3d8200efc334c1eadea1336b31
2024-12-11 10:43:31 -08:00
vinayjoglekar ff076f85d6 Fix for split animation
While splitting focus task, there is a timing issue of focus task being animated first and then small tiles.
This CL fixes that makes animation smooth i.e. animate stage task(focus task) and other small tiles together.

 Also refactored animationStartProgress and animationEndProgress initialisation by adding "if/else" for readability.

Test: Manual.Split focus task.(RTL as well)
Fix: 383417963
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I7b8c651d91168802b930fdeac62e762a2be9dbe9
2024-12-11 18:42:21 +00:00
Mykola Podolian 29ccf8703b Merge "Remove usage of the enableBubbleBarInPersistentTaskBar flag." into main 2024-12-11 09:24:25 -08:00
Treehugger Robot 9632253a4a Merge "Revert "Play workspace reveal animation for predictive back-to-home"" into main 2024-12-11 08:07:22 -08:00
Schneider Victor-tulias 72fe47d329 Merge "Update OWNERS files to include the sysnav team" into main 2024-12-11 07:01:50 -08:00
Schneider Victor-Tulias 55500094e8 Update OWNERS files to include the sysnav team
Flag: EXEMPT updating OWNERS
Fixes: 383379046
Test: not needed
Change-Id: Ia1c95d6953bfddc9a4cbc7238cf1f9a2e4ee18cf
2024-12-11 09:59:16 -05:00
Johannes Gallmann 6b1272ad9f Revert "Play workspace reveal animation for predictive back-to-home"
This reverts commit 09603bfb39.

Reason for revert: Launcher icons are sometimes not visible during the back-to-home animation when immediately swiping back after opening the app.

Change-Id: I13869cf755160986e323365a460f6ebe128008a9
2024-12-11 06:05:39 -08:00
Johannes Gallmann b2683aa902 Merge "Play workspace reveal animation for predictive back-to-home" into main 2024-12-11 01:33:53 -08:00
Treehugger Robot 8bba339d80 Merge changes Ifd8f10f5,I14f66628 into main
* changes:
  Update LauncherSwipeUpHandlerV2Test setup to account for RecentsWindowFactory
  Update TaplTestsQuickstep to expect recents window states when enabled
2024-12-11 02:40:01 +00:00
Treehugger Robot 3c3c96f66c Merge "Adding MSDL Feedback when swiping up to reveal overview." into main 2024-12-11 01:50:01 +00:00
Treehugger Robot 60b53b3f00 Merge "Adding MSDL long-click feedback to IconView." into main 2024-12-11 01:48:02 +00:00
Brian Isganitis a481af5779 Split up tests by actual hardware keyboard status.
Flag: TEST_ONLY
Bug: 230027385
Test: TaskbarStashControllerTest
Change-Id: I63fc433810af3993db5655571a11887eb2c68422
2024-12-10 19:08:36 -05:00
Juan Sebastian Martinez a159e667e3 Adding MSDL long-click feedback to IconView.
Test: manual. Verified haptics play when MSDL flag is on.
Test: manual. Verified haptics played from the history of the
  MSDLWrapper via adb dumpsys
Flag: com.android.launcher3.msdl_feedback
Bug: 376283547
Change-Id: I66c9c712141a7b618cc8b4ca995e1475e21b377b
2024-12-10 15:59:24 -08:00
Juan Sebastian Martinez ce427bfe16 Adding MSDL Feedback when swiping up to reveal overview.
Test: AbsSwipeUpHandlerTestCase
Flag: com.android.launcher3.msdl_feedback
Bug: 376282841

Change-Id: I90a76ea72f87066b9f9d33dda055f99d25249e77
2024-12-10 15:57:07 -08:00
Treehugger Robot 11537828ad Merge "Fising some tests bugs, assuming primary user is user 0" into main 2024-12-10 23:50:28 +00:00
Treehugger Robot 4d8f0d5a8f Merge "Add Aster logging for entering and exiting desktop mode via quick switch" into main 2024-12-10 23:31:50 +00:00
Brian Isganitis 002ef1f550 Disable model loading with Sandbox check instead of static boolean.
The static boolean also affects Taskbar within the Launcher process. We
only want this disabled for the Taskbar test Sandbox.

Flag: TEST_ONLY
Bug: 230027385
Test: NexusLauncherTests:com.android.launcher3.taskbar
Change-Id: Ife12e95ab34755d1aec42d79188c15232d8da092
2024-12-10 23:31:36 +00:00
mpodolian 3e419ebbf1 Remove usage of the enableBubbleBarInPersistentTaskBar flag.
Remove and merge the usage of the enableBubbleBarInPersistentTaskBar
flag to the enableBubbleBar flag.

Bug: 383181643
Flag: com.android.wm.shell.enable_bubble_bar
Test: NONE - removed and merged flag usage.
Change-Id: I4f131e1ddf8367425b91c8fb597857ee222b75d8
2024-12-10 15:10:49 -08:00
Treehugger Robot cedfde549e Merge "Update QuickstepTestInformationHandler.getWindowInsets to support recents window" into main 2024-12-10 23:02:27 +00:00
Bill Yi a4b92fc641 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7594928bfaf00ae47e4e03398e6570a36cb2dfad
2024-12-10 15:01:26 -08:00
Jeremy Sim 41cdb7ffee Merge "App Groups: Allow app pairs to take more than 2 members" into main 2024-12-10 22:37:31 +00:00
Artsiom Mitrokhin 2e0d122ed1 Add haptics for opening taskbar pinning popup view from anywhere
The divider's listener is implemented via `View.OnLongClickListener`,
which automatically handles haptics. While the taskbar view uses a
custom gesture detector (to get the associated event and its x/y
coordinates), which doesn't have the same logic out of the box. This CL
adds a manual call to perform haptic feedback for long press events
(this also corresponds to the implementation in a similar gesture
detector - `WorkspaceTouchListener`).

Bug: 382056013
Flag: com.android.launcher3.show_taskbar_pinning_popup_from_anywhere
Test: manual on a fold
Change-Id: I3887e0f9839a7992ccd8b6786bdf1268bfafd09e
2024-12-10 22:05:24 +00:00
Schneider Victor-Tulias 35c7dae0ef Update LauncherSwipeUpHandlerV2Test setup to account for RecentsWindowFactory
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 383375436
Test: LauncherSwipeHandlerV2Test
Change-Id: Ifd8f10f55a6c1e43ce7e5e410f77d47d845b216d
2024-12-10 16:18:07 -05:00
Schneider Victor-Tulias 76e1676c7f Update TaplTestsQuickstep to expect recents window states when enabled
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 382527932
Test: TaplTestsQuickstep
Change-Id: I14f66628105fab5d8c39ae7f9fd9ebfa61a268b7
2024-12-10 16:17:57 -05:00
Schneider Victor-Tulias 37deb21bd4 Update QuickstepTestInformationHandler.getWindowInsets to support recents window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 382252723
Fixes: 378158368
Test: TaplDragTest
Change-Id: I272a9e50f2209d3b7959bb9abc834546c9b845e8
2024-12-10 16:17:48 -05:00
Sunny Goyal 89551b71be Fising some tests bugs, assuming primary user is user 0
Bug: 383091872
Bug: 383183795
Bug: 383088668
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: I551f13fc3d51bf1c2718f0582f8ee76d51067896
2024-12-10 12:09:33 -08:00
Uwais Ashraf 1f09cd720d Don't use flow for one-off get of ThumbnailData
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TasksRepositoryTest
Test: Performance tests
Change-Id: I1990ad1972beea8c81b44cdd50c7f674f225c69d
2024-12-10 17:28:55 +00:00
Vania Desmonda 7fd479c454 Add Aster logging for entering and exiting desktop mode via quick switch
Fixes: 360874817
Fixes: 381214742
Flag: com.android.window.flags.enable_desktop_windowing_quick_switch
Test: manual test
Change-Id: I7bae2aaff614a5590fa107d0c102c520b14b85d9
2024-12-10 13:35:15 +00:00
Johannes Gallmann 9899283045 Merge "Don't cancel or commit predictive back on multi touch in 3-button-nav" into main 2024-12-10 13:33:00 +00:00
Johannes Gallmann 200ee94279 Don't cancel or commit predictive back on multi touch in 3-button-nav
Bug: 381054861
Test: Manual, i.e. verify that tapping the taskbar while predictive back is in progress does not cancel or commit it
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I4117aca74216849519a0cabcbd3cb14f7fc5b38f
2024-12-10 13:28:36 +00:00
Johannes Gallmann 09603bfb39 Play workspace reveal animation for predictive back-to-home
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: EXEMPT bugfix
Change-Id: Iece001b6b9edd9ca7a909e3ccbe8ebdff2e71d9f
2024-12-10 12:42:12 +00:00