Instead of requiring that a valid display ID is given to
the APIs in `DesktopVisibilityController` and crashing the Launcher,
this CL lets the code handle invalid IDs gracefully, and adds a test
that fails without the fix.
Bug: 392986431
Test: atest NexusLauncherTests:com.android.launcher3.statehandlers.DesktopVisibilityControllerTest
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Id1bc7876ce654b96191c85089557b9279963acd8
Handle new bubble notification while drag is in progress. Updated logic
to react to new bubble notifications arriving during drag operations
before a drop occurs.
Bug: 388894910
Flag: com.android.wm.shell.enable_create_any_bubble
Test: BubbleBarViewAnimatorTest
Test: Manual. Go to some application and have no bubbles. Start
dragging the taskbar icon over the bubble bar drop zone. Trigger new
bubble with the bubbles test application. Observe drop target is
hidden and new bubble is animated in, followed by flyout. When flyout
disappears, bubble bar remains on the screen. Release icon over the
bubble bar. Observe newly added application bubble is expanded. Repeat
same test, but drag the taskbar icon to the opposite side.
Test: Manual. Go to some application, but have bubbles. Start
dragging the taskbar icon over the bubble bar drop zone. Trigger new
bubble with the bubbles test application. Observe new bubble is added
and the flyout is shown. When flyout disappears, bubble bar remains on
the screen. Release icon over the bubble bar. Observe newly added
application bubble is expanded. Repeat same test, but drag the taskbar
icon to the opposite side.
Change-Id: I6fe1139ef56f4ad40d36a804016d23a9b34abf5f
Audit all the functions inside RecentsView with the TaskView index as
a parameter. Make sure the AddDesktopButton is considered while
setting the value of these parameters.
Flag: EXEMPT refactor
Bug: 379942019
Test: m
alt+tab to the "# more apps" button insde KQS view, the first
hidden TaskView inside the RecentsView will be focused.
Change-Id: I92cd3e38700e83e72d362dc47d3adae538695b60
- Add separate property for grid translation in TaskViewSimulator, so it doesn't get reset when other translations (e.g. dismiss) is applied to live tile
- In createAdjacentPageAnimForTaskLaunch, use onAnimationStart without isReverse parameter, so it's actually called when the PendingAniamtion starts
- Also reset pivot if we have overriden it during createAdjacentPageAnimForTaskLaunch
- Also avoid applying addOverviewToAppAnim on live tile if it's not launching, otherwise recentsViewScale will be applied twice with addOverviewToAppAnim applying wrong value
- Use pivot instead of recentsViewScroll to bring non scroll position live tiel to fullscreen, to avoid a trajectory that will otherwise travel left and then right
Fix: 391146807
Fix: 321013528
Test: launching via swipe down with non-launching live tile
Test: dismissing live tile
Test: launching live tile in non scroll position
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I24ee85399b09b25e157a8986103658bb4803a87e
Bug: 378096575
Flag: NONE test fix, not actual code editing
Test: DesktopAppLaunchTransitionManagerTest
Change-Id: I6dc335fea156f4e830e9c2cadf3c98ff01fb7c4f
Previously taskbar would only set/remove the FLAG_NOT_FOCUSABLE, which
also made it IME focusable. This was toggled when a tasbkar folder was
opened/closed, as well as opening the popup by long pressing an app in
the taskbar. Folders do require IME focusability, as the folder name can
be edited. However, the popup does not require IME focusability, and
this lead to the IME suddenly disappearing when the popup is shown.
This fixes the issue by also setting FLAG_ALT_FOCUSABLE_IM as needed,
only when the taskbar is also focusable. This follows the same logic
as in NotificationShadeWindowControllerImpl.
Flag: EXEMPT bugfix
Test: switch to gesture nav, show IME in app, show popup and verify
IME is still visible
open folder in either taskbar or launcher and verify IME can be shown
Bug: 361046041
Change-Id: Idb9b4503d5622222e99735f0f6981a17add12360
Release the animation leash after back_to_home animation done.
Flag: EXEMPT bugfix
Bug: 395035430
Test: Use the back gesture to trigger the back_to_home animation
multiple times and perform multiple random transitions, dumping the
Surface Flinger to check the predict_back leashes not remain in the
offscreen layer.
Change-Id: I7ed9dfd510e38bed28b51762df9976d33c4a5644
Added logic to show and hide the bubble bar drop target on Shell
drag-and-drop events.
Test: Manual. Drag a shortcut or an application icon from the taskbar to
the bubble bar drop zone. Observe that if the bubble bar is showing
bubbles, the background stroke color becomes non-transparent; if there
are no bubbles, the drop zone appears. Drag the app icon to the opposite
side and observe that the bubble bar location is animated or the drop
zone appears on the dragged side. Drop the application icon or shortcut
on any side and observe that a new bubble is added and immediately
expanded. Additionally, the bubble bar remains at the drop location.
expanded.
Bug: 388894910
Flag: com.android.wm.shell.enable_create_any_bubble
Change-Id: I581dddf2c76ac982a5c78bc32d94b79bf63fd2b9
Mark all tasks on launcher as perceptible tasks.
Flag enablement is for desktop devices only.
Bug: 370890207
Test: Manual
Flag: com.android.server.am.perceptible_tasks
Change-Id: Ic9022dcb07f2fc2d1bd1277bc1a83233ebc5626e
This change applies the new expressive font style if the expressive
theme is enabled. Screenshots are available in the bug
Fix: 393610004
Test: Check that the fonts change when the expresssive theme is enabled
Flag: com.android.launcher3.expressive_theme_in_taskbar_and_navigation
Change-Id: I5fa34ab08486c7fdeb37ccd9afeda77b577a9404
Theory: We are now rendering the wallpaper and workspace while All
Apps is open. This is causing additional rendering to be done,
leading to dropped frames and other regressions.
Here I remove workspace/hotseat on phones where the panel will
fully cover them anyway. I also remove the depth controller
during the all apps transition.
Using the "debug overdraw" developer setting, I verified that
Workspace and Hotseat are not drawn below the All Apps panel on
handheld.
I ran ABTD on this change and verified the p95 dropped frames
went back to 0.
Bug: 393188362
Bug: 393088056
Test: abtd commands in the bug
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Change-Id: I47287f3356d401a3bd4202e61fd44199855a4a3c
* Check for bubble bar on phone being enabled in most places
tiny taskbar was checking
* Forces taskbar to always be stashed when bubble bar is enabled
* There are a couple of visual issues with the flag enabled:
- extra space in overview
- the hotseat is a lil squished on home when bubbles are there
Flag: com.android.wm.shell.enable_bubble_bar_on_phones
Test: manual - enable bubble bar on phones observe that bubble bar
is enabled and kind of works
Bug: 394869612
Change-Id: I56d3045c78c6c31dcacf16744033b34c9aa5f6e0
The base TaskbarUIController returns null for recents view.This makes icons on external display's taskbar unable to launch on external displays.
Test: m
Bug: 395954042
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I389a0fa102f63ab93b8a29de722cce0a446a2ea1
Flag: com.android.launcher3.expressive_theme_in_taskbar_and_navigation
Fixes: 393615634
Test: opened KQS, be before/after in bug
Change-Id: Ia953e2b927b6e69c0c150df01925436b6247d751
Moving most of the logic from DesktopAppLaunchTransition to DesktopAppLaunchAnimatorHelper to make it more testable
Bug: 391548553
Flag: com.android.window.flags.enable_desktop_trampoline_close_animation_bugfix
Test: DesktopAppLaunchAnimatorHelperTest
Change-Id: I606fc3fc25250ea4128f3089b701a1ae153dc47a
The order of initialization for IconShape is closely tied to ThemeManager
which makes it difficult for change listeners to work. Merging these keeps
all the theming information at one place
Bug: 381897614
Test: Updated tests
Flag: EXEMPT refactor
Change-Id: Ie29efa20c3308a24be3e284c1c93ed7444b68d58
Fengjiang Li
Wei Sheng Shih
Treehugger Robot
Mykola Podolian
Ahmed Fakhry
Bill Yi
Saumya Prakash
Uwais Ashraf
minch
Mady Mellor
Alex Chau
Schneider Victor-Tulias
Pat Manning
Sergey Pinkevich
Jordan Silva
Cosmin Băieș
David Stevens
Sukesh Ram
Andy Wickham
Sunny Goyal