Commit Graph

23356 Commits

Author SHA1 Message Date
Tony Wickham 1588bb1a57 Merge changes I1b67d065,Ib2e7f859 into main
* changes:
  Don't show hover tooltip while an app popup is open
  Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
2025-03-18 11:38:05 -07:00
Treehugger Robot 1c0d0fa376 Merge "Remove FLAG_SPLIT_TOUCH from launcher code" into main 2025-03-18 11:37:17 -07:00
Pat Manning 81b6d25bb8 Merge "Prevent jumping to last grid task when not visible." into main 2025-03-18 11:22:34 -07:00
Jordan Silva d2e930bbb7 Fix Chip menu expanding outside the screen
This CL removes isLandscape condition from menu translation that
prevents Comet to translate the menu with split app. The menu needs to
be translated when in split screen mode, regardless of orientation.

Fix: 404549940
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: I5e4d07a9f1d2e36b847808aec9ae348a7ef78f59
2025-03-18 11:18:55 -07:00
Pat Manning 337b3ea7b0 Merge "Play haptic after dismissal even if no neighbors spring into place." into main 2025-03-18 11:10:16 -07:00
Pat Manning f3ef4e9961 Merge "Prevent multiple competing dismissals." into main 2025-03-18 11:04:47 -07:00
Liana Kazanova (xWF) defa140c20 Merge "Revert "Inflate TaskThumbnailViewDeprecated as TaskContentView"" into main 2025-03-18 10:04:13 -07:00
minch 683c68af39 Correct the call of getExpectedCurrentTask
Bug: 401582344
Flag: EXEMPT bug fix
Test: m
Change-Id: I683be73a6632ba719396d44454a8650bbee7267d
2025-03-18 09:57:52 -07:00
Liana Kazanova (xWF) 1048b2711c Revert "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bba7e8af37.

Reason for revert: DroidMonitor: Potential culprit for http://b/404515699 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Iadb65f37b9712c3d6e5943847520ca3bd76624c7
2025-03-18 09:26:32 -07:00
Will Osborn 1f5a92ed1a Small fixes for per-display TaskAnimationManager
Test: locally tested on Tangor
Flag: EXEMPT bugfix
Bug: 402362875
Change-Id: I37d3f563c30b019de8b43896b94a599c836f0dac
2025-03-18 16:15:28 +00:00
Jordan Silva f41ec597ef Set the elevation for TaskMenuView when overview icon menu is enabled.
Bug: 317007147
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Change-Id: I7c8b0a181e39bdf2d2048b87d6ceecf2b95e3265
2025-03-18 15:13:38 +00:00
Pat Manning 9fdc7032ba Play haptic after dismissal even if no neighbors spring into place.
Currently haptics will play as the neighbors reflow into place, but if none reflow, we also want a haptic to fire.

Fix: 398198796
Test: Manual. Dismiss end task so none move, feel haptic play.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I467a45472992722bcd05ef31cbaeb157441c4931
2025-03-18 15:10:53 +00:00
Jordan Silva 6c25c4dce3 Refactor: Use AppChipStatus enum instead of isExpanded boolean
- Replaced the boolean `isExpanded` flag in `IconAppChipView` with an enum `AppChipStatus` for better state management.
- Added `AppChipStatus` enum with `Expanded` and `Collapsed` states.

Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ibbf8ccd963e540f5bd766569a1df01ad1bafd4c0
2025-03-18 14:51:45 +00:00
Treehugger Robot 1f500d3cd3 Merge "Inflate TaskThumbnailViewDeprecated as TaskContentView" into main 2025-03-18 05:35:14 -07:00
Pat Manning 832f178138 Prevent jumping to last grid task when not visible.
Fix: 404203362
Test: Manual. Open 9 apps, dismiss all bottom grid tasks, dismiss first top task, observe no jump.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I11058b90b7d8c90256329849554886d652624926
2025-03-18 12:26:41 +00:00
Treehugger Robot e5cebbd9ca Merge "Do not notify desk mode changes on visible desk tasks count changes" into main 2025-03-17 18:29:02 -07:00
Tony Wickham 88a9e18f7c Don't show hover tooltip while an app popup is open
Flag: EXEMPT bugfix
Test: TaskbarHoverToolTipControllerTest
Fixes: 397243128
Change-Id: I1b67d065e9e79e13a5a341a5d133da700ef5f40c
2025-03-17 22:36:27 +00:00
Tony Wickham 131c68b11b Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
This means we are now testing real objects instead of mocks

Test: TaskbarHoverToolTipControllerTest
Fixes: 346394827
Flag: EXEMPT bugfix
Change-Id: Ib2e7f859432e84eb18c985dd71adaaaf9a513620
2025-03-17 22:34:32 +00:00
Sunny Goyal ff41a8bf66 Only accessing mListeningHolders on main thread
Bug: 402648481
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I037fff805be0b52407ed020e33aeb9db45616dd9
2025-03-17 14:32:04 -07:00
Alex Chau 4a60b862e2 Merge "Update scale on TaskView instead for select mode" into main 2025-03-17 13:12:09 -07:00
Treehugger Robot ab933e6098 Merge "[CD Taskbar] Move DisplayController method calls to BaseTaskbarContext" into main 2025-03-17 12:11:06 -07:00
Siarhei Vishniakou 8dd9181a3d Remove FLAG_SPLIT_TOUCH from launcher code
The splitting behaviour is now permanent, so this flag is deprecated and
it's no longer necessary to set it.

Bug: 239934827
Test: TEST=inputflinger_tests; m $TEST && $ANDROID_HOST_OUT/nativetest64/$TEST/$TEST
Flag: NONE removing flag
Change-Id: Ie7dafaeffdb6f5854a61e6ece0217d8bf5e496af
2025-03-17 11:59:05 -07:00
Shamali Patwa fedb2319af Merge "Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call" into main 2025-03-17 11:19:13 -07:00
Sam Cackett bba7e8af37 Inflate TaskThumbnailViewDeprecated as TaskContentView
If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug
Change-Id: Ie62d4d83d0a16d965820d2a218a44478b660a806
2025-03-17 17:45:34 +00:00
Sunny Goyal d7a1c17988 Merge "Moving LauncherAppWidgetHolder to dagger" into main 2025-03-17 10:42:15 -07:00
Jon Miranda a3f54bae16 Merge "Relayer taskbar to application_overlay when shade is opened" into main 2025-03-17 09:15:29 -07:00
Orhan Uysal afd0b905e2 Merge "Temporarily add a null intent check." into main 2025-03-17 09:04:45 -07:00
Shamali P 56dd87a584 Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call
It is now injected via a factory so a new instance is used each time.

Bug: 399641570
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Iee703f0c954c95599c07ceb788edabb0d808abb2
2025-03-17 14:41:53 +00:00
Alex Chau 843a881e7c Update scale on TaskView instead for select mode
- Avoid zooming in RecentsView in Select mode, instead zoom in the selected TaskView only to avoid changing RecentsView's scale and pivot, otherwise when doing home gesture in Select mode RecentseView zoom will be distorted
- Set taskModalness on all TaskViews, so they can fade out while entering Select mode, this avoid janky transitionig of non-selected TaskView appearing during hoem gesture
- Keep overviewGridEnabled true until transitioning out of a RecentsView visible state, so showAsGrid() remains true and the Overview grid won't deform midway through animating
- When leaving Select mode to RecentsView invisible state (e.g. Home), leave taskModalness 1 until the last frame so selected TaskView remains zoomed in until RecentsView is invisible

Fix: 322818393
Test: OverviewTaskSelectImageTest
Test: Repeat with combination of default/fallback, live/static tile, handheld/tablet
1) Swipe up from Overview
2) Swipe up from Select to go Home
3) Backc/cross button to exit Select to Overview
Flag: com.android.launcher3.enable_grid_only_overview

Change-Id: I8fec62315cbd404502852654772edb1d695f1ec6
2025-03-17 14:39:40 +00:00
Sukesh Ram 16e04e84eb [CD Taskbar] Move DisplayController method calls to BaseTaskbarContext
To ensure consistent, controllable Taskbar in Connected Displays Behavior, move all independent calls to the singleton DisplayController's various methods into one place in BaseTaskbarContext, where we have access to the parent context and can override default behaviors of these methods throughout taskbar if in external display.

Flag: EXEMPT not adding new behavior
Bug: 401553128
Test: m
Change-Id: If9efc0cfc18bac3ee75bb64bf5280ea979d1faa2
2025-03-17 03:15:45 -07:00
Massimo Carli e58dac962c Merge "Add missing Rule for Flags" into main 2025-03-17 03:01:26 -07:00
Treehugger Robot 4772ba9cba Merge "Disabled bubble bar for the connected display." into main 2025-03-16 23:16:39 -07:00
Jon Miranda 1b62b50a9b Relayer taskbar to application_overlay when shade is opened
When we get the sysui flag for shade expanding, take a
snapshot of the TaskbarDragLayer (after hiding three navigation
buttons), and add a View of that snapshot to the TaskbarOverlay
layer, while simultaneously hiding the real Taskbar.

Bug: 343194358
Test: have pinned taskbar, open shade, note taskbar stays behind shade
Flag: com.android.launcher3.enable_taskbar_behind_shade
Change-Id: I0ad9506f34dd4f3aec3796d94cd3d4a914ff67e5
2025-03-16 11:07:21 -07:00
Mady Mellor 3894947741 Merge "Update dragged elevation to use shared value (at 3dp)" into main 2025-03-14 16:10:01 -07:00
Evan Rosky d057a2a636 Crop based on real-time insets
This crops above taskbar unless app is immersive

Bug: 336511494
Test: Enable pinned taskbar, launch app, note correct bounds
Flag: com.android.wm.shell.enable_dynamic_insets_for_app_launch

Change-Id: Ie8124ae18176d167986f9861876d426ec2c6097f
2025-03-14 15:29:40 -07:00
Randy Pfohl b1a0a5706f Merge "Removing displaymanager listener in favor of displayAddSystemDecorations for testing/sysui consistency" into main 2025-03-14 15:18:51 -07:00
Jagrut Desai 56a8bf548f Merge "Taskbar Icon changes" into main 2025-03-14 14:29:08 -07:00
Sunny Goyal 66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Mady Mellor 609f2b3143 Update dragged elevation to use shared value (at 3dp)
- Had to bump elevation of drop target so need to bumpe elevation
  of dragged views

Flag: com.android.wm.shell.enable_bubble_anything
Test: manual / visual - drag a bubble or drag expanded view and observe
                        the drop targets
Bug: 403276099
Change-Id: I15a1deb055c590b1f46261fcc307120fcb685c08
2025-03-14 13:56:29 -07:00
Johannes Gallmann e7b099efee Merge "Add 200 ms delay for predictive back animation in 3-button-nav" into main 2025-03-14 13:37:37 -07:00
Hongwei Wang 965a1f5f7f Merge "[2/N] Check destination against src aspect ratio" into main 2025-03-14 13:33:26 -07:00
Treehugger Robot dee6dd8bb7 Merge "Make OverviewCommandHelper commands and OverviewCommandHelperTest display-aware" into main 2025-03-14 13:18:28 -07:00
Jon Miranda 0c762ac84f Merge "Synchronize the app launch and taskbar stash animations." into main 2025-03-14 11:05:08 -07:00
Will Osborn 69a9346b07 Make OverviewCommandHelper commands and OverviewCommandHelperTest display-aware
Test: locally tested on Tangor
Flag: EXEMPT refactor
Bug: 397942185
Change-Id: Ib2c3b2662413d15926215c18421168e93ce2b117
2025-03-14 17:55:20 +00:00
Massimo Carli 61a66dddea Add missing Rule for Flags
The SetFlagsRule was missing in tests.

Flag: EXEMPT Test fix
Fix: 402452969
Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest

Change-Id: I80e4fc311b173e32e2d85849656b837deb903aeb
2025-03-14 17:05:35 +00:00
Treehugger Robot d78c8c41b7 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-03-14 09:49:43 -07:00
Jagrut Desai 4fe0b79fde Taskbar Icon changes
Test: Manual
Bug: 379158656
Flag: com.android.wm.shell.enable_gsf
Change-Id: Ic4ec9a7c634231c2592cfcd6ba6c8f8252c2dd98
2025-03-14 09:26:32 -07:00
Pat Manning cc973dfdce Prevent multiple competing dismissals.
This brings into line with existing UX prior to the feature.

Fix: 400727071
Test: Manual. Dismiss as quickly as possible.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ie3f6f82c3ed4626829f3a61307e73cbdb8a31ceb
2025-03-14 16:11:19 +00:00
Treehugger Robot 0af5880d28 Merge "Revert "Remove DepartingAnimationTarget from BackMotionEvent(2/2)"" into main 2025-03-14 08:59:01 -07:00
Randy Pfohl b6df25a0e6 Removing displaymanager listener in favor of displayAddSystemDecorations for testing/sysui consistency
Test: built and tested events while connecting disconnect external
display

Flag: com.android.launcher3.enable_launcher_overview_in_window

Bug: 292269949

Change-Id: I5b0b180e47eb62d8cc963076a2ad22a649c1c9cf
2025-03-14 15:42:37 +00:00