Commit Graph

2610 Commits

Author SHA1 Message Date
Alex Chau 9c85596111 Support both grid and large tile with gridOnlyOverivew
- With the introduction of Desktop windowing, we'll need to supprot grid task and large tile (desktop tile) coexisting
- The previous gridOnlyOverview aimed to have taskSize matches actual grid task size, and introduced another carouselTaskSize for scaling in swipe up carousel
- Now I'm reverting to pre-gridOnlyOverview implementation of having taskSize as both large tile size and carousel task size, and gridTaskSize as only task size in grid

TaskViewSimualtor
- Removed no longer needed carousel translation and related calculations
- mIsGridTask is now determined with DeviceProfile, so when swipeing to Desktop task it won't use grid task size

TaskView
- Removed no longer used nonGridPivotTranslationX

RecentsView
- Make getSelectedTaskBounds / getTaskBounds picks the correct taskSize

Fix: 359573248
Fix: 321697299
Fix: 325606690
Bug: 322816508
Test: Swipe up, quick switch, task launching with grid task and desktop tasks; repeat with RTL, three button, phone
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I14648c6682c53a4d06f9c9585d53f28dddef4f8f
2025-01-13 13:31:29 +00:00
Michele Fan 89b039da83 desktop-exploded-view: Add header to individual windows.
The header has an app icon, app title and a close button. Currently
clicking on the close button does nothing. Will address it in a
following CL.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353965691

Change-Id: I5e0303a02d5f8afd16a5f5f0335a8fa489ff98f2
2025-01-10 22:25:43 +00:00
Treehugger Robot 753229687e Merge "Don't use announceForAccessibility in RecentsView" into main 2025-01-09 05:31:57 -08:00
samcackett 318e9184c8 Don't use announceForAccessibility in RecentsView
According to accessibility guidelines, we shouldn't be using this API and definitely not for notifying a user a task has closed, so just removing this use case altogether.

Fix: 386001961
Test: Enable Talkback.
  Open some apps.
  Go to Overview and dismiss an app.
  Talkback shouldn't announce "Task closed".
Flag: EXEMPT bugfix

Change-Id: I1a55017cbd4825103b9a8b93532b06276f28aef6
2025-01-09 01:09:51 -08:00
samcackett 9e1b1cd5fa Ensure split screen cancel label doesn't wrap
Fix: 379811238
Bug: 328577545
Bug: 345128488
Test: Visual inspection of instructions view in different languages/form
factors and display densities
Flag: EXEMPT bugfix

Change-Id: Iabdb76b7a02957e1918475b8a00f395f64e96301
2025-01-07 17:27:40 +00:00
Bill Yi 4aab1552c9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia8e7529645c0daeb6b2d6d5bd612e305b86604f2
2024-12-20 20:15:58 -08:00
Mykola Podolian 73553774c2 Merge "Update drag close drop target properties." into main 2024-12-19 16:50:02 -08:00
mpodolian 7991a4489c Update drag close drop target properties.
Updated the colors and adjusted the close icon size of the drop target.

Fixes: 376687679
Test: Manual. Drag bubble bar and observe updated drop target.
Test: Manual. Disable bubble bar. Drag overflow bubble and observe
updated drop target.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I04a11d8a868ff06fae008f42a591b66e5254f4cd
2024-12-19 10:36:09 -08:00
Treehugger Robot ee2e3ba257 Merge "Use DeviceProfile in NavBarGestureHandler and EdgeBackGestureHandler for the display size" into main 2024-12-18 16:09:36 -08:00
mpodolian 226ed8143d Shift transient taskbar to ensure 12dp distance with the bubble bar.
Shift the taskbar to fulfill the 12dp distance if the distance between
the taskbar and the bubble bar is below this threshold.

Fixes: 376929094
Test: TaskbarViewControllerTest
Test: Manual. Test that the transient taskbar shifts properly.
Increased the minimum distance to 120 dp and verified that the taskbar
shifts correctly. Moved bubbles side to side, confirming the taskbar
follows. The return-to-home-screen animation to the hotseat plays as
expected from either side.
Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/bJZ8PclmltZu7IupvBFrLn
Test: Manual. Test that the transient taskbar stashes properly.
Increased the minimum distance to 120 dp and verified that the taskbar
shifts correctly. Go to any application. Stash and un-stash the taskbar.
Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/hCGRhUgIqvcehOrTQ2Ulvj
Test: Manual. Test that the transient taskbar pin/unpin properly.
Increased the minimum distance to 120 dp and verified that the taskbar
shifts correctly. Pin/unpin the taskbar.
Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/f3fy5JKVZAk4wLCpVra4DK
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: Id4bd713da93053f90d9c2be8503dc93531a03b29
2024-12-18 15:51:37 -08:00
Anushree Ganjam 59137e44e2 Merge "Update the All apps label to "Apps list"" into main 2024-12-18 14:07:36 -08:00
Schneider Victor-Tulias 0b2c37ed72 Use DeviceProfile in NavBarGestureHandler and EdgeBackGestureHandler for the display size
DisplayController caches the display size, so when the user unfolds a foldable, the screen size is incorrect, which messes with the touch handling. Using DeviceProfile instead.

Flag: EXEMPT bug fix
Fixes: 361694048
Test: fold/unfold device during home/back/overview tutorial steps
Change-Id: Ie49f677f97ea5ddb0f91d2e662677edaaa81860a
2024-12-18 10:03:50 -05:00
Anushree Ganjam 8dae1be563 Update the All apps label to "Apps list"
Set the AccessibilityNodeInfo containerTitle to improve a11y for users
in predictionRow.

See expected behavior suggestion in  https://b.corp.google.com/issues/379640673#comment1

Video
Quickstep launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/eugH3ID7eenOuLwTszaLHk

Pixel launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/fftzwMRCy6N3o7OcwiGMdk

Bug: 379640673
Test: Manual
Flag: EXEMPT a11y bugfix
Change-Id: I23a8a142afb213c0801402a56bc134bc14f0f97d
2024-12-17 16:39:45 -08:00
Sunny Goyal daf46a09b2 Merge "Moving WMProxy to dagger" into main 2024-12-12 15:27:19 -08:00
Sunny Goyal 41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00
Bill Yi a4b92fc641 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7594928bfaf00ae47e4e03398e6570a36cb2dfad
2024-12-10 15:01:26 -08:00
Uwais Ashraf ca8a53911a Use ViewStub for TTV creation to prevent double inflation (TTVDeprecated then TTV).
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Test: Open single, split and desktop tasks with flag combinations for TTV refactor and app chip.
Change-Id: Ie43955ddf6c9fac162974077a37e8448c5ef1781
2024-12-10 08:19:22 +00:00
Treehugger Robot 9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
minch 7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
Treehugger Robot add782b869 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-30 21:27:38 +00:00
Bill Yi 02925dcda5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id3dd3f3a10edac962c71d7695073179515feceec
2024-11-27 17:34:56 -08:00
Andy Wickham 28d920ef05 Merge changes from topic "rm-lph-flag" into main
* changes:
  Make ContextualSearchInvoker not a ResourceBasedOverride.
  End live tile when invoking Circle to Search over Overview.
2024-11-27 23:32:29 +00:00
Andy Wickham 2ae01adf71 Make ContextualSearchInvoker not a ResourceBasedOverride.
This was previously only used to honor the INVOKE_OMNI_LPH flag
which has been enabled for a long time. So this is part of that
cleanup.

Bug: 297561673
Test: Manual
Flag: EXEMPT deleting legacy flag
Change-Id: Ife9f14faa2099f579f631da2aadaa6a56cbba51d
2024-11-27 13:03:18 -08:00
Marcelo Arteiro 8b63ee3420 Merge "Migrate materialColor* attributes into colors" into main 2024-11-27 14:55:47 +00:00
Bill Yi b24914be8d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idfd8628134eef581c45e3c0582e1173653f5767f
2024-11-21 21:17:39 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Alex Chau 6ce105c269 Merge "Update corner radius calculation in TaskView" into main 2024-11-20 16:18:51 +00:00
Alex Chau a2c1dbc611 Update corner radius calculation in TaskView
TaskThumbnailView
- Set cornerRadius directly from TaskView instead of calulating and listening from ViewModel
- Use onSizeChagned/width/height for OutlineProvider bounds, to be consistent with DesktopTaskContentView

DesktopTaskView
- Moved backgroundView inside DesktopTaskContentView, so its outline can be determiend by OutlineProvider in DesktopTaskContentView
- Update DesktopTaskContentView's cornerRadius when it changes in TaskView

Model/Data chagnes
- Removed TaskViewModel/TaskViewData and scale from RecentsViewData

TaskView
- Add a onBind method to be called after bind, for common post bind handling (e.g. update cornerRadius)

TaskViewSimualtor
- Use DesktopFullscreenDrawParams for desktop task, and moved setIsDesktopTask to CTOR so related fields can be final

Bug: 372237039
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: TaskThumbnailViewScreenshotTest, OverviewDesktopTaskImageTest
Test: DesktopFullscreenDrawParamsTest, FullscreenDrawParamsTest, TaskThumbnailViewModelImplTest
Change-Id: If3d195ef6596aa28fce4d4875cf45423cb71811c
2024-11-20 13:55:32 +00:00
Treehugger Robot 30d06bba2d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-19 21:49:29 +00:00
Marcelo Arteiro 7cc2483b47 Merge "Fix home screen briefly flashes after setup." into main 2024-11-19 08:39:26 +00:00
Bill Yi 089d2deb3c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I15be96ff4c9728db28f0de164d5cae51a20beb81
2024-11-18 20:00:12 -08:00
Artsiom Mitrokhin ddb0546277 Merge "Use dynamic/relative sizes for taskbar overflow button" into main 2024-11-18 23:47:38 +00:00
Artsiom Mitrokhin ef05519982 Use dynamic/relative sizes for taskbar overflow button
Bug: 376281549
Flag: com.android.launcher3.taskbar_overflow
Test: manual, press the overflow button, dismiss KQS
Change-Id: I7cf023cd0df34d898ee1949c5c6de930268e37cb
2024-11-18 15:45:50 -05:00
Saumya Prakash 52866fc596 Merge "Add Manage Windows option to Taskbar long press menu" into main 2024-11-15 08:57:49 +00:00
Saumya Prakash dbaf1028db Add Manage Windows option to Taskbar long press menu
This change adds an option to the long press menu on Taskbar apps to
view open instances of the calling apps. It will only show on apps that
support multi instance (ex. Chrome).

Bug: 315989246
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie1e001c4cec831c751bcbf448aaa68bb90fb24ca
2024-11-15 06:34:28 +00:00
Treehugger Robot 1297e9eb98 Merge "Change fallback closing animators for Desktop Mode." into main 2024-11-14 18:23:01 +00:00
Gustav Sennton 8e4cae1258 Change fallback closing animators for Desktop Mode.
The main changes are:
1. the amount to move the window horizontally (much less for Desktop
Mode), and
2. the timing for when the alpha animation is applied - we remove the
   25ms delay for freeform windows.

Bug: 378675987
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_exit_transitions
Change-Id: Ieeb6b827eee2e6314ea9c79213cdf401f48d3c85
2024-11-14 16:26:07 +00:00
Treehugger Robot 55c2aca78e Merge "Updates layout when overflow button and alt-tab are both triggered." into main 2024-11-14 16:13:54 +00:00
Wen-Chien Wang ca95004403 Updates layout when overflow button and alt-tab are both triggered.
Before this cl, the KQS view is closed and reopened when the
overflow button and alt-tab key are triggered one after the other.
This cl changes the behavior so that instead of reopening, the
list of task is updated and the KQS container layout is toggled
between "wrap content" and "match parent".

Bug: 368119679
Test: open KQS via taskbar and observe the layout change
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I05ea4c66727daa206ff1d7906500dc8f9cc81982
2024-11-13 20:48:07 +00:00
Artsiom Mitrokhin f0b80dadb2 Merge "Implement app icons <-> leave behind animation" into main 2024-11-13 19:42:54 +00:00
Artsiom Mitrokhin d370b4d5f4 Implement app icons <-> leave behind animation
Bug: 376281549
Flag: com.android.launcher3.taskbar_overflow
Test: manual, press the overflow button, dismiss KQS
Change-Id: Ifae1455785d028f58072068f25e52a5e58ed1c72
2024-11-12 14:56:21 -05:00
Bill Yi 9aaed58603 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4438710e56e84f765d7878549bd18e420ba03f49
2024-11-10 16:23:14 -08:00
Shamali P 531c227c45 Update widget predictor to apply prediction filter
When enough widgets are not passing the filter, additional randomly
 selected widgets are added.

The count to decide whether to add more is a configuration, so that,
if some OEMs don't want any suggestions, can override the value to 0.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Unit tests
Change-Id: Iffa8619149a1a4b468d367fc7bbee381be59469d
2024-11-07 14:01:52 +00:00
Bill Yi 4697f0c1ca Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-06 22:52:30 +00:00
Brandon Dayauon 270e1c3dc4 Merge changes from topic "implementWorkSchedulerViewAndUpdateColorsOfFab" into main
* changes:
  Make sure work button is collapsed when keyboard is up upon going to app drawer
  Implement the work scheduler view and update colors of FAB
2024-11-06 19:57:26 +00:00
Brandon Dayauon bfd02bb36a Implement the work scheduler view and update colors of FAB
Update colors of the FAB to spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=3784-112229&node-type=instance&m=dev
Exported the brief case icon from figma since it is not available on go/icons.
Color of the brief case icon is onPrimary.
Have place holder string in launcher but implement the actual string in NL.

bug:361589193
Test - manual: video: https://drive.google.com/file/d/1CIs8qdtV1jUvbq57CcgAXDBPPHHX5CKJ/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: Ia98e9c4394f6ddfa7009653034929f9afbfeac8c
2024-11-06 09:48:26 -08:00
Bill Yi b2201ad15c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I82780f0c34bc6a5a5a84cb3534cdebd5d37bc321
2024-11-06 02:31:38 -08:00
Anushree Ganjam 2d55010135 Make ContextualEduStatsManager injected by Dagger (13/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I0150ad8edeac1746e27b7d919891d02e648413be
2024-11-05 14:53:01 -08:00
Treehugger Robot 9cafa2f8e2 Merge "Revert "Revert "Don't allow Desktop tasks to go outside Overview..."" into main 2024-11-04 15:34:43 +00:00
Sam Cackett 1ecdc2d712 Revert "Revert "Don't allow Desktop tasks to go outside Overview..."
Reland submission "Don't allow Desktop tasks to go outside Overview task bounds"

Reverted changes: /q/submissionid:30210454-revert-30114356-desktop-task-view-corner-clipping-KXYKHZHSWL

Change-Id: Ia263edcc876f9f72ca7f70733e96b0823dbd750e
Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest, TaplTestsOverviewDesktop
2024-11-04 10:40:57 +00:00