Commit Graph

2610 Commits

Author SHA1 Message Date
Bill Yi b72796db31 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8827e64a1ba84eb28febabd33f591faf7113f362
2023-11-29 12:47:12 -08:00
Alex Chau 4745e95ea7 Merge "Adjust app chip menu top margin." into main 2023-11-29 14:40:12 +00:00
Vinit Nayak eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Pat Manning ad6b044412 Adjust app chip menu top margin.
Include adjusting gap of menu when expanding app chip.

Fix: 313648444
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iea8ea76873ac008b90b6a8f183dc99cba9237041
2023-11-28 22:38:22 +00:00
Vinit Nayak d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Saumya Prakash 5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Pat Manning 0f395e8a11 Update text style for icon app chip menu.
Bug: 311657856
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Ied1c5fddb94e3093729846cacfef9b257aad8df7
2023-11-25 11:24:45 +00:00
Bill Yi 66f0200e50 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie7f789feff97a375ab542ea6fc7fd841c66dc15e
2023-11-21 16:55:56 -08:00
Pat Manning 37edf2ed08 Merge "Add background to app chip menu so elevation shadow renders." into main 2023-11-21 18:09:32 +00:00
Sanatt Abrol a6b4e1bc43 Bug: b/307278302
Fix clipping of DesktopTaskView border on focus/ hover

Hover border: https://screenshot.googleplex.com/B9CUW49q6inMW75
Focus border: https://screenshot.googleplex.com/36uLJ4jC295t7PZ

`android:clipToOutline` prevents drawing outside view bounds and results in the focus/ hover border getting clipped, instead we can use `android:clipToPadding` with a small non-zero padding to clip children and allow drawing a border outside the bounds

Change-Id: I7e763f7ee8c7fd1090c7778c2c000d2b792bef06
2023-11-21 10:48:08 +00:00
Saumya Prakash 15bbd17775 Merge "Update Gesture nav edu animations for overview gesture" into main 2023-11-20 18:07:23 +00:00
Pat Manning c5b7cf9e4e Add background to app chip menu so elevation shadow renders.
Fix: 312146447
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest.
Change-Id: I43113acd0eaafac2955cd4bbebafc103bdba6d98
2023-11-20 15:15:54 +00:00
Jagrut Desai a2825e011c Merge "New Meta Action Icon for Taskbar" into main 2023-11-17 17:59:45 +00:00
Pat Manning d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Pat Manning 43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Jagrut Desai deb22d9e78 New Meta Action Icon for Taskbar
Test: Presubmit, Manual
Bug: 310942087
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Change-Id: Ia1783a1afa92181efded4cfdbd5e7ae3d4e081e8
2023-11-16 08:33:03 -08:00
Bill Yi 66e843c8d0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2bf597eaf2c3fc4abb5b701974cc95b1e1d2ec6d
2023-11-14 19:31:01 -08:00
Saumya Prakash 4ee354f20a Update Gesture nav edu animations for overview gesture
Change the lottie files used to demonstrate the overview gesture for
mobile, foldable, and tablet.

Test: Went through overview gesture tutorial on mobile, foldable, and
tablet and ensured the animation played smoothly.
Fix: 283765711
Flag: N/A

Change-Id: I567eece9348d4c88b6f02fd267416ae155bcaf86
2023-11-14 19:04:36 +00:00
Uwais Ashraf 6dfa8521e5 Merge "Revert "Refactor/clean up Overview Actions buttons"" into main 2023-11-14 10:25:11 +00:00
Uwais Ashraf 60a2d85b68 Revert "Refactor/clean up Overview Actions buttons"
Revert submission 25292769-cleanup-action-buttons

Reason for revert: Causes a 100% failure of OverviewImageTest

Reverted changes: /q/submissionid:25292769-cleanup-action-buttons

Change-Id: Iedd51290e2d6fb7efafc814f1d3d51863b3d3ab7
2023-11-14 09:45:55 +00:00
Jeremy Sim ed56be4fbc Merge "Refactor/clean up Overview Actions buttons" into main 2023-11-13 22:20:47 +00:00
Vinit Nayak a20e964cbd Merge "Prevent widgets from entering split" into main 2023-11-13 06:06:41 +00:00
Jagrut Desai 56c85bbbc1 Merge "Fix RTL issue with TaskbarDividerPopupMenu" into main 2023-11-11 16:25:45 +00:00
Vinit Nayak 1d3035e024 Prevent widgets from entering split
Bug: 296502210
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Change-Id: I1a166f6ca0fe5fd2fa1d29b97b8856e52985e0c1
2023-11-10 12:17:12 -08:00
Jagrut Desai dc165fcf90 Fix RTL issue with TaskbarDividerPopupMenu
Test: Presubmit, Manual
Bug: 310217447
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I00a9088274ee6716250da7f6c79caf6820955803
2023-11-10 09:50:25 -08:00
Bill Yi 4dec607fec Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idf14fea5b132a4871252134e07263e7dd51feccd
2023-11-09 16:38:08 -08:00
Jeremy Sim 7030216f48 Refactor/clean up Overview Actions buttons
Since the number of Overview actions is growing, this patch factors out the button hiding logic so it's not all handled in OverviewActionsView.

Also, since splitscreen can now be carried out on Taskbar targets, the split button is no longer ever disabled (only hidden), so removed unused code for that.

Bug: 274835596
Test: Manual
Flag: NA
Change-Id: Icacdee6d0e6071ccb400dfc25a84572e7e9ce772
2023-11-08 13:43:19 -08:00
Jagrut Desai 61526a7413 Merge "Improvements to TaskbarDividerPopupView" into main 2023-11-03 02:02:28 +00:00
Jagrut Desai 9af2084a56 Improvements to TaskbarDividerPopupView
- Close Animation improvement for popup.
- Popup location changed to  16dp above the taskbar view.
- Support for disabled state when user is in 3-button mode. (design changes to come in separate cl)

Test: Manual
Bug: 265170176
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I9c91e6eb2b29c85433ba1c3d34505f0519448a6f
2023-11-02 17:24:50 -07:00
Jagrut Desai c554d5fa46 Fix TaskbarDividerPopupMenu Switch Style
we recently added support for settings app style switches to Launcher. Use that style for TaskbarDividerPopupMenu Switch

Test: Manual
Bug: 308682758
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: If61a426e4051ebce67601055942667ed93928d15
2023-11-02 14:23:48 -07:00
Bill Yi bb8419b8f9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2e57af4db51bc722d5fe7560c92b371ab61cfcf9
2023-10-30 19:58:19 -07:00
Uwais Ashraf aa7fa886d6 Add margins to top and bottom when grid only overview enabled
Fix: 299100244
Test: OverviewImageTest and dump tests
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I22ebced5bf1e27974036d6e2ef72d2b8d63df824
2023-10-24 16:15:39 +00:00
Tracy Zhou 33132dc48c Dynamically adjust the paddings of the contextual buttons
- Dynamically adjust the paddings of both start and end contextual containers in different layouts

Test: manual
Bug: 230395757

Change-Id: I2c6a1350e0dab36f6d5100b8d4e2012d8a97cd9b
2023-10-13 20:10:44 -07:00
Bill Yi 50f8bed76f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I188b2bc905489318760cbe5869deef836d2e04b2
2023-10-06 13:16:06 -07:00
Pat Manning 1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Helen Cheuk 5ab9a57ec0 Merge "Fixed delay of thumbnail loading when going to overview from home" into main 2023-09-27 20:29:00 +00:00
helencheuk 9e142d3998 Fixed delay of thumbnail loading when going to overview from home
Some thumbnail snapshots show up slowly when GRID_ONLY_OVERVIEW is enabled because more thumbnails are displayed than before and some cache related code needs to be changed. This issue should be fixed for smooth user experience so all thumbnails could be shown quickly and at the same time.
Root causes and corresponding solution are as below:
1. No high resolution thumbnails are in cache when entering overview. It is either no cache at all or just low resolution cache
Solution: Preload when high resolution is enabled
2. The cache size is 3 which is not enough for tablet
Solution: Update cache size to 8 when it is tablet, and preload more if cache size increases. Remove least recent ones when cache size decreases

Fix: 271570416
Test: RecentsModelTest
Test: TaskKeyByLastActiveTimeCache
Test: TaskThumbnailCacheTest
Change-Id: I60003ca20942c256a0a1047678ea4368cd2520eb
2023-09-27 16:57:27 +01:00
Bill Yi bef73824d4 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-09-25 20:17:46 +00:00
Becky Qiu 42a06b0476 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1 am: f545328f56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ic62100a1f4ca6aa2a0a0c1a1962cedff070f7e70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 07:45:25 +00:00
Becky Qiu f545328f56 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ifd35410d27765efc7896dac8e002ce3f1690a8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 06:48:19 +00:00
Becky Qiu 86b6a887d1 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP.
Bug: 300101221
Test: manually tested dump, see the NL change for samples.
Flag: INVOKE_OMNI_LPH, DISABLED; ENABLE_LONG_PRESS_NAV_HANDLE, TEAMFOOD.
Change-Id: I1fb03779775cd0c9353abd4f796e9cc7c42f0f96
2023-09-23 02:29:54 +00:00
Schneider Victor-tulias e95326dfdd Update KeyboardQuickSwitch for TAPL testing
- Added a res id to KeyboardQuickSwitchView for TAPL testing
- Updated KeyboardQuickSwitch focus and scroll initialization
- Logging KeyEvents for TAPL testing
- Updated scrolling logic to wait for initial layout
- Fixed activity leak in KeyboardQuickSwitchViewController

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I1d45d948c0e185504d994f7ef1d34f173c2243a9
2023-09-22 11:04:43 -04:00
Bill Yi 66b127877e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5b8009a2bcba4f9ebcaf9fe5190121e5bd3951a7
2023-09-21 20:15:55 -07:00
Pat Manning 66c1051e7e Merge "Remove taskbar tooltip hover delay." into main 2023-09-18 15:37:34 +00:00
Liran Binyamin 070be25853 Merge "Adjust the hotseat when the bubble bar becomes visible" into main 2023-09-15 17:48:41 +00:00
Pat Manning 2db8ce7e94 Remove taskbar tooltip hover delay.
Fix issue when setting fullscreen drag layer causes hover exit/enter events.

Update ArrowTipView paddings to match spec.

Update ArrowTipView to check on each time it is shown if it should point up or down, not only the first time.

Fix: 295851126
Fix: 295315397
Test: TaskbarHoverToolTipControllerTest
Change-Id: I314c65cb9fce3fb8d6002d8917bd5c97301d9dbc
2023-09-15 12:24:51 +01:00
Liran Binyamin a833af316b Adjust the hotseat when the bubble bar becomes visible
When the bubble bar becomes visible the space between icons in the
hotseat is now adjusted. This change only does it when the QSB is
above the icons, but this will be changed in the future to be based
on the amount of space between the hotseat and the edge of the screen.

When the hotseat is adjusted, the new width is smaller by the size of
2 icons. The icons are then translated to be evenly spaced within the
boundaries of the new width.

Since the adjustment is only applied when the QSB is above the icons,
it is resized accordingly to the new width.

All visual updates currently snap to the new position, but will be animated
in a follow up.

Demo: https://recall.googleplex.com/projects/3391fc5c-599d-4827-b6f8-d2deb160aa99/sessions/fad1a5c5-e9cf-4586-92e4-1e92df3b002e

Bug: 280494203
Test: Manual (on tangor)
      - Set device to landscape
      - Make the bubble bar visible by adding a bubble
      - Rotate to portrait mode
      - Observe that the hotseat is adjusted
      - Rotate to landscape
      - Observe that the hotseat adjustment is removed
      - Rotate back to portrait
      - Observe that the hotseat is adjusted again
      - Dismiss the bubble to hide he bubble bar
      - Observe the hotseat adjustment is removed

Change-Id: I5b02a60b6cb301ffa2507a6d825c748a782cca18
2023-09-13 17:08:42 -04:00
Bill Yi 91869bb5fc Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If357cbbd2d233f466c706a21e45e829bffe95633
2023-09-12 21:18:29 -07:00
Brian Isganitis 0b9c0589b7 Add All Apps search icon variant behind flag.
Bug: 265170176
Test: https://b.corp.google.com/issues/265170176#comment15
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I0f5fa4fbbab687d92435d299656b9c27d93525b4
2023-09-07 18:29:46 +00:00
Bill Yi fce9627f8b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I98ba3bc9e380b26b739f8ff7f8ba8f33df4a92fc
2023-09-07 04:01:55 -07:00