Commit Graph

1650 Commits

Author SHA1 Message Date
Pat Manning 89d0073c08 Merge "Add DeviceProfile tests on all attributes across different configurations." into tm-qpr-dev am: e700efde22 am: 980bbf0f3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19197012

Change-Id: I5e9e8117bd6546e3485318853899cbfc8bd166b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-13 11:38:54 +00:00
Pat Manning e700efde22 Merge "Add DeviceProfile tests on all attributes across different configurations." into tm-qpr-dev 2022-07-13 10:45:50 +00:00
Sunny Goyal dea1af0c3e Merge "Generalizing the PredicitonScroll view so that in can be used in all-apps" into tm-qpr-dev am: eb966492f7 am: e16fc5c878
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19089102

Change-Id: I25d7b3a854acd67bf674331d4ed64528f4a5f054
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 22:04:58 +00:00
Sunny Goyal eb966492f7 Merge "Generalizing the PredicitonScroll view so that in can be used in all-apps" into tm-qpr-dev 2022-07-12 21:33:17 +00:00
Alex Chau 2f98748b1b Merge "Make workspace and hotseat scale down in widgets picker" into tm-qpr-dev am: fbd9ebd0a0 am: 252ab19883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19222026

Change-Id: Ia06c9e56e9676b91c31fe8311381c0fc8e7b0e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 13:20:05 +00:00
Pat Manning 26f70f777e Add DeviceProfile tests on all attributes across different configurations.
Fix: 237542518
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I1596dcd1fb8c9b353cdfcab224d7670d88bed716
2022-07-12 14:17:18 +01:00
Alex Chau 0c4e11b479 Make workspace and hotseat scale down in widgets picker
- Also centralized workspace content scale percentage to DeviceProfile

Test: manual
Fix: 231699666
Change-Id: I3f8dcb9921e0cd93ad391d51120b189005ad07df
2022-07-08 19:03:48 +01:00
Sunny Goyal 9b458a0012 Generalizing the PredicitonScroll view so that in can be used in all-apps
Bug: 234008165
Test: Verified no-functionality-change on device
Change-Id: Ie17d58148b9bdcb08847beb24114b0494437b30e
2022-07-06 12:29:01 -07:00
Thales Lima 92a1e7f1de Add new hotseat bottom margin options am: b8c0595d42 am: a70b07d04c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605485

Change-Id: I42e901c26b8b34f52e2ba5c8b0edfc8cfcd3ac9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-06 11:05:01 +00:00
Thales Lima b8c0595d42 Add new hotseat bottom margin options
This changes how the hotseat height is calculated and by consequence how spaces are distributed in the workspace as well. This is the first of a series of changes that will improve and streamline workspace calculations.

Bug: 228998463
Fix: 234023782
Fix: 230191631
Fix: 232914299
Fix: 236238226
Test: manual, HSV and comparing to mocks
Change-Id: If021e8ba2c7c24c0bf9f27a1aa7aa946792ed04f
2022-07-05 15:33:47 +01:00
Sebastián Franco 13d5b412cb Merge "Make Talkback anounce which page is the icon being move on." into tm-qpr-dev am: 578fbee848 am: 563d85ea48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18918709

Change-Id: I16a78c864d2073812921939b4c63b6f2bb721a59
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-24 07:39:44 +00:00
Sebastian Franco 930531f669 Make Talkback anounce which page is the icon being move on.
Adding a third argument for the talkback string.

Fix: 230593493
Test: Move an item using Talkback and it should mention the row,
column and page where you can drop the item.

Change-Id: Id3d4435e9ef3348278643e6e2a1cd1e8bf5157b7
2022-06-22 17:17:38 -07:00
TreeHugger Robot 2d674d6f03 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev am: 5069964ea2 am: 67d79af886
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18763224

Change-Id: Ic9c5e84835e0c7c714540d8c914486255dbe9dee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 03:54:09 +00:00
TreeHugger Robot 5069964ea2 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev 2022-06-22 03:23:07 +00:00
Sunny Goyal bbad97e273 Unifying scroll calculation logic for both widgets and apps recycler view
Also using itemType instead of item object for widget size cache

Bug: 234008165
Test: Verified on device
Change-Id: Ia4b4a00a11627c0c454e4a699570e8ab1667a390
2022-06-16 16:03:37 -07:00
Sukesh Ram 9e5fe63a22 Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-06-16 22:44:24 +00:00
Brian Isganitis 4aab0fdafc Merge "Update download app icon treatment to latest mocks." into tm-qpr-dev 2022-06-09 22:44:10 +00:00
Brandon Dayauon 7a8a9ed170 Fix issue where allAppsCellWidth is 0
when using secondary display on non-scalable grids causing allApps to be squished.
Bug: 234748862
Test: Manual

Change-Id: I2e92bce69438a17eccb0e4b2b2e3f2bdbfa7600e
2022-06-06 14:32:22 -07:00
Brian Isganitis cd7cc294b8 Update download app icon treatment to latest mocks.
Demo: https://screenshot.googleplex.com/BfTvY2EaByJXwdw.png
Test: Manually using "start install session helper" in SupportApp.
Fix: 205714358
Change-Id: I3ec2fb776cbad974ae36f34b29f3081b3d073c83
2022-06-02 11:53:47 -07:00
James O'Leary 0ac64cba0f Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf am: b2919ce557
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: I9f92216f1db5331b450b750855213cc9fd642335
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 01:52:33 +00:00
James O'Leary 202ac414bf Merge "Revert "Update app icon shadows"" into tm-dev 2022-06-01 01:29:34 +00:00
James O'Leary dac75aef3b Revert "Update app icon shadows"
Revert submission 17935777-lightDarkDetection

Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow

Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
2022-05-31 21:12:38 +00:00
James O'Leary ef64789d0a Merge "Update app icon shadows" into tm-dev am: 2b6700a94c am: 5131a1a203
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: I16cb7b30a5219d196427bedbbe0c3adbb66c1360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 20:29:31 +00:00
James O'Leary 2b6700a94c Merge "Update app icon shadows" into tm-dev 2022-05-27 19:44:39 +00:00
Alex Chau 6329b20f43 Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c am: 7ca1b38d7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: I57dd855387257a8704f8529f14ea176562e63549
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:02 +00:00
Alex Chau 179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Stefan Andonian 058c88bfce Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313 am: 2e8f2e192b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I30e4c6c0884721519ecf5167f0b8c6aa68c18911
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:30 +00:00
Stefan Andonian af8b7d3313 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev 2022-05-24 18:19:03 +00:00
Alex Chau 5b0193026a Center drop target button alignment across devices
- Partial re-land of http://ag/18520765

Fix: 229789612
Fix: 231711806
Test: manual
Change-Id: I0630c19901435a30379596378e9c0cd4beb2e764
2022-05-24 18:31:57 +01:00
Stefan Andonian 28f61b5177 Fix folder app icon truncation after rotating to landscape.
The folder bubble text views were being recycled after the launcher's
cache was cleared. This caused the new orientation's folders to re-use
the old views with their stale configuration. After this change, the
cache won't recycle views whose cache entry has been recreated,
implying that their environment might have changed and new setup is
required.

Bug: 230304658
Test: Verified erroneous UX on device was no longer reproducible after fix.
Change-Id: Ib01cf5792d83df752e05534e5aa08ab8e8763bdc
2022-05-23 23:42:04 +00:00
Jeremy Sim b0cce86385 Implement non-disappearing View for split staging instructions
The instructions for how to perform a splitscreen operation, previously conveyed through a disappearing Toast, are now conveyed through a custom View object.

Fixes: 219987907
Test: Manual
Change-Id: Iff2bb6e334e0325e8a091d76a5f9b8767071365f
2022-05-23 21:23:22 +00:00
Alex Chau 906d882f91 Update drop target button alignment across devices
- Partial re-land of http://ag/18520765
- Layout the buttons from center of screen for two panels, or from center of workspace for all other cases

Bug: 229789612
Fix: 231706480
Fix: 232063941
Fix: 232283628
Test: manual
Change-Id: Icbc9e2a19140ce3127d5dfe9f798a8ada336cea8
2022-05-23 15:08:52 +00:00
Pat Manning b29dabce18 Revert "Update drop target button alignment across devices."
This reverts commit 27bfcaa651.

Reason for revert: b/232636570

Bug: 229789612
Bug: 231711806
Bug: 231706480
Bug: 232063941
Bug: 232283628
Change-Id: Ic83515173f4a64228a80f63d75db938243cbf625
2022-05-20 18:20:26 +00:00
Brandon Dayauon 303b4e8aae Fix issue when preference screen title won't change depending on the device..
previously it defaults to just "Search your phone"
Now it correctly displays Phone/Tablet

Before: https://screenshot.googleplex.com/3PJrsP9mGvwMr98
After: https://screenshot.googleplex.com/B2nnUQHeHmEXXPd

Bug: 231611501
Change-Id: I49eab7e827ce4bb31a2722fbf21c244f98145907
2022-05-16 10:25:12 -07:00
Hyunyoung Song 8536fb78c7 Merge "App row padding is now consistent for all grid sizes. Also fix when 2x2 allApp icons get super big." into tm-dev 2022-05-15 06:08:18 +00:00
Brandon Dayauon 07ca884eea App row padding is now consistent for all grid sizes. Also fix when 2x2 allApp icons get super big.
Added consistent padding to each app row.

Bug: 229789736
Bug: 229791507
Bug: 228320417
Bug: 230870213
Test: Manual on Raven

Change-Id: Ice1c8be361f009994a8e0960a30da04fc1c0c218
2022-05-13 17:10:15 -07:00
Alex Chau 8a7617f168 Merge "Fix slow page animations on large devices" into tm-dev 2022-05-12 19:08:41 +00:00
Pat Manning 8909fc2dcb Merge "Update drop target button alignment across devices." into tm-dev 2022-05-12 18:41:54 +00:00
James O'Leary fe435ad44e Update app icon shadows
Allow use of white shadow, set radius to 1.0 and offset to 0.
Use 100% and 20% alpha, instead of 70% and 50%.
(nets out to same effect)
Make ambient and key shadows equivalent: there are deterministic
formulas for what contrast a shadow will create, and those formulas
were used for the spec. Ad-hoc attempts to try to increase visibility
are no longer needed and don't align with design intent

Bug: 213314628
Test: Manual inspection at runtime
Change-Id: Ie12d3d05488e16fea94e91be16c25448f450a44d
2022-05-12 18:28:39 +00:00
TreeHugger Robot 566c676dda Merge "Add Developer Options string to xml." into tm-dev 2022-05-12 14:49:49 +00:00
Pat Manning 27bfcaa651 Update drop target button alignment across devices.
Fix: 229789612
Fix: 231711806
Fix: 231706480
Fix: 232063941
Fix: 232283628
Test: manual.
Change-Id: I75d649b953ad1607dbba87a8f758884ff938b6dc
2022-05-12 13:49:58 +00:00
Andras Kloczl c2bd15fd2a Fix slow page animations on large devices
- Change non-fling page snap animation duration
- Change fling gesture related minVelocity

Test: Scroll between home pages, allapps, folder pages
Bug: 229073876
Change-Id: Ib39187ec9c832e65dd0b71f8f4a00e1b636423a4
Merge "Hide web settings, if web suggestions is disabled" into tm-dev

Change-Id: Ib39187ec9c832e65dd0b71f8f4a00e1b636423a4
2022-05-12 12:56:41 +01:00
Thales Lima 425f6828f1 Fix hotseat width to span a number of columns
Fix: 227344807
Fix: 231283023
Test: manual
Change-Id: Iad0f38c2323be6d9752a8e509fc7e1164edbcf4e
2022-05-11 10:09:03 -03:00
Luca Zuccarini e75b1c8a19 Merge "Update the NORMAL->ALL_APPS transition when tapping on QSB on phones." into tm-dev 2022-05-10 22:35:02 +00:00
Sunny Goyal 8ca6e815bd Merge "Fixing wrong alpha for disbled icon" into tm-dev 2022-05-10 15:51:59 +00:00
Sunny Goyal b0416cc478 Merge changes from topic "revert-17983445-hotseat_span-WQWWPUHOTD" into tm-dev
* changes:
  Revert "Fix hotseat width to span a number of columns"
  Revert "Update workspace, cell layout, shortcut and widget, and cell size calculations."
2022-05-09 23:14:38 +00:00
Sunny Goyal d333091d79 Fixing wrong alpha for disbled icon
Bug: 230852221
Test: Verified manually
Change-Id: I73fb1ac73ff374cd67b3f26367814ea5b0b49a3b
2022-05-09 16:12:06 -07:00
Sunny Goyal 89a89d63a4 Revert "Fix hotseat width to span a number of columns"
Revert submission 17983445-hotseat_span

Reason for revert: b/231283023
Reverted Changes:
Ice4e37929:Fix hotseat width to span a number of columns
I9ed508490:Fix hotseat width to span a number of columns

Change-Id: Iabf67c5efd8155131a0c8a88192ddd671a43747b
2022-05-09 19:32:07 +00:00
Brandon Dayauon 5a726787db Merge "changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon.." into tm-dev 2022-05-06 21:00:08 +00:00
Brandon Dayauon e5142c5c53 changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon..
Fixed padding issue (tightness) between Personal/WorkTabs/EduDialog
Aligned Work Toggle button to be the same with the workTabs/eduCard
raised button up 20dp to align with specs

Fixed issue where allApps apps invade the tabs. Fixed RTL issues where it wasn't going RTL.
Fixed RTL issue for the workfab button where there was no margin on the left side of the button
Added DeviceProfile to constructor

Bug: 200810328
Bug: 224731300
Test:
	Before: https://screenshot.googleplex.com/6sRgNZQz4wKYn5n
	After: https://screenshot.googleplex.com/8hBLyDiMbMH9tn2
	After(showingLayoutBounds): https://screenshot.googleplex.com/MuVUXCegukAMzSr

Change-Id: Ibac3f5b8fe7d877c2f54a2c87f4393c1a91dc806
2022-05-06 09:52:05 -07:00