Commit Graph

2206 Commits

Author SHA1 Message Date
Sebastián Franco b8614e298c Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I274f6eae4cda80ea45ee48328b6d2a5abfb1e648
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 19:47:55 +00:00
Sebastián Franco 4122868216 Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev 2023-03-10 19:19:42 +00:00
Brandon Dayauon e0bddb5b42 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: Ibf5cb36dc8e5ec0def0012b17b14e848a33d9d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:58:48 +00:00
Brandon Dayauon cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Sebastian Franco 239ae0a995 Making sure there is a propper Chrome icon for the test to long press
In some cases, the test was long pressing on a recommendation for
google chrome and not a regular chrome icon and the events didn't
match. I don't think is good to relly on chrome getting recommended
so I'm making sure there is always a chrome app icon on the hotseat

Fix: 269163620
Test: atest TaplTestsLauncher3:testWorkspace (run on pixel 7 pro)
Change-Id: Ic8ee744a9af18d60de9bbedd42043f5abbbd7356
2023-03-09 14:59:21 -08:00
TreeHugger Robot 9fbd4b9c4e Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev am: 19c0877745
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21806280

Change-Id: I1c37aee0caa430161761f2bdddc89669be6f553c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 20:18:52 +00:00
TreeHugger Robot 19c0877745 Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev 2023-03-08 20:04:50 +00:00
Schneider Victor-tulias f15fc66db2 Merge "Fix flaky RequestPinItemTests" into tm-qpr-dev am: bd98aef4a4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21733879

Change-Id: I3926c1f9862f7856ed2cb578af59afb9ec5d3da0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 23:52:38 +00:00
Schneider Victor-tulias bd98aef4a4 Merge "Fix flaky RequestPinItemTests" into tm-qpr-dev 2023-03-07 23:36:10 +00:00
Brandon Dayauon 6a1f4f0ddb Merge "Add logging to testDragAppIconToWorkspaceCell()" into tm-qpr-dev am: 9de1c05cbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21532182

Change-Id: I01961910daa717ea911e1df8d4f0407882456cd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 19:46:03 +00:00
Brandon Dayauon 9de1c05cbf Merge "Add logging to testDragAppIconToWorkspaceCell()" into tm-qpr-dev 2023-03-07 19:37:44 +00:00
Sihua Ma 8fa10370ef Merge "Update widget picker row logic to resolve cropping" into tm-qpr-dev am: a245873fed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20696781

Change-Id: Ied0a8552fa8bf21c7c7b599d7ba3a21beaa8ea3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 19:27:55 +00:00
Sihua Ma a245873fed Merge "Update widget picker row logic to resolve cropping" into tm-qpr-dev 2023-03-07 18:42:46 +00:00
Schneider Victor-tulias c3281a42a8 Fix flaky RequestPinItemTests
RequestPinItemTest is flaking because launcher hasn't started yet before the tests try to complete gestures. Waiting for launcher to intitialize before running tests.

Fixes: 267201968
Test: RequestPinItemTest
Change-Id: Ib52e00a1ce68fba5d9af9d1c875078f2f60ea248
2023-03-07 10:36:02 -08:00
Vinit Nayak 313a44039f Revert "Create TAPL test suite for splitscreen"
This reverts commit 03815e6c79.

Reason for revert: b/271852893

Change-Id: I165a15b29e41ce1114f6b7d92d22cdd8e0dfb5b0
2023-03-06 23:47:20 +00:00
Sihua Ma 16180801e8 Update widget picker row logic to resolve cropping
Using pixels instead of cell spans for calculating the widget picker row
binding logic.

Before: https://screenshot.googleplex.com/3uXX2m7xWh3om5t
Now: https://screenshot.googleplex.com/C593mrQfqTahNrQ

Test: Manual
Fix: 269790954
Change-Id: Ib591a6f6d3cf8b72766e0714b9bc8ceb86b2ba4f
2023-03-06 13:41:24 -08:00
Vadim Tryshev bcd0f209db Merge "Making Launcher3Tests "abtd atest"-compatible" into tm-qpr-dev am: 8f7ca126b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21730826

Change-Id: If847e164eed8784b9f9f830298dadf54f7dc98bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 20:44:50 +00:00
Vadim Tryshev 8f7ca126b0 Merge "Making Launcher3Tests "abtd atest"-compatible" into tm-qpr-dev 2023-03-06 19:59:03 +00:00
Jeremy Sim 2a81b79a3c Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev am: ad9bdcfd2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21221178

Change-Id: I14e25affb3d204cd2fcf0f693fd53ce502e576f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:46:09 +00:00
Jeremy Sim ad9bdcfd2d Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev 2023-03-04 01:10:47 +00:00
Sunny Goyal c2cc5c57c4 Merge "Adding support for overriding flag values in test" into tm-qpr-dev am: f450476c7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21733882

Change-Id: I2504ead8caa9c2db320872899167a4cef0b21e9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:44:09 +00:00
Sunny Goyal b138ec9fc6 Adding support for overriding flag values in test
Bug: 270386012
Test: Verified on device
Change-Id: Ic1af9ca369c0cd2ec49d98875f7b97e90a0050ca
2023-03-03 09:29:42 -08:00
Jeremy Sim 03815e6c79 Create TAPL test suite for splitscreen
This patch creates a new file, TaplTestsSplitscreen.java, containing one TAPL test sequence.

testSplitAppFromHomeWithItself() tests the user flow of splitting from home using an app that is already running, and then selecting the app itself again as a split target from the Taskbar. The expected result is that Launcher shows an error message gracefully and does not crash.

Fixes: 267554450
Test: Ran test file locally and verified that it passes.
Change-Id: I98a1e3a4143d10a6572175711059b3a77aa5dcd0
2023-03-02 16:35:54 -08:00
Vadim Tryshev 990a32e7cf Making Launcher3Tests "abtd atest"-compatible
Test: labtest
Bug: 187761685

Change-Id: I3e7ed63eb8cfa0d634d720a692e050deb8736906
2023-03-02 23:06:37 +00:00
Stefan Andonian b341f31fc7 Merge "Preload expensive objects before user is unlocked." into tm-qpr-dev am: 86d8db485f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391179

Change-Id: I41b2afd3616f2f8fb92e6b9a1bb31359e0d4e258
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 07:30:52 +00:00
Stefan Andonian 5bd9a225a8 Preload expensive objects before user is unlocked.
This change includes migrating data required for starting the launcher
from encrypted storage into device protected storage. All of the data
being moved has already been approved by the correct authorities.

Bug: 251502424
Test: Performed latency testing using logs from user unlock until first
workspace screen loaded.

Change-Id: I58b0cd1c7bad260c2252f9e172ef85ab885c7fe9
2023-03-01 23:09:07 +00:00
Schneider Victor-tulias 7ce9057840 Merge "Add debug logs to help investigate view and activity leak test failures." into tm-qpr-dev am: e09fecc272
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21427699

Change-Id: Ida6653cda1ca3940bf3c5f9418a73290d377cc48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 17:44:01 +00:00
Schneider Victor-tulias e09fecc272 Merge "Add debug logs to help investigate view and activity leak test failures." into tm-qpr-dev 2023-03-01 17:14:27 +00:00
Jordan Demeulenaere 652ec4997a Format files with the upcoming version of ktfmt am: be82bc661c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21565649

Change-Id: Icd28fd41925b49d0f8c4318365a244e3fa43f637
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 13:22:07 +00:00
Jordan Demeulenaere be82bc661c Format files with the upcoming version of ktfmt
This CL was generated automatically from the following command:

$ external/ktfmt/prepare_upgrade.py --repo=packages/apps/Launcher3/ --build_id=9645412 --bug_id=266197805

This CL formats all files already correctly formatted with the upcoming
version of ktfmt.

Bug: 266197805
Test: Presubmits
Change-Id: Ide7d63a75fed98aabe348821355356c77f00a9ec
Merged-In: Ide7d63a75fed98aabe348821355356c77f00a9ec
2023-03-01 09:11:48 +00:00
Sunny Goyal e7fe6b57ff Merge "Moving flag creation to a separate file" into tm-qpr-dev am: 1297f400bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21586607

Change-Id: I0b50d9286e8abab8b3d5f54853f8bfc74141cbb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 19:48:41 +00:00
Sunny Goyal 1297f400bc Merge "Moving flag creation to a separate file" into tm-qpr-dev 2023-02-28 19:18:25 +00:00
Sunny Goyal 98204add71 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
Merged-In: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-28 18:05:42 +00:00
Schneider Victor-tulias 5c817a7fdb Add debug logs to help investigate view and activity leak test failures.
Test: MemoryTests
Bug: 260260325
Change-Id: I510d9bb3a5a8a273fd0e5fb09de05354c959fbde
2023-02-27 11:00:10 -08:00
Helen Cheuk e129994b8b Merge "Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid" into tm-qpr-dev am: a695986d56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549709

Change-Id: Ief8665d9d3f48f4d356830bb386f0c13f3f68ce2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 18:34:19 +00:00
Helen Cheuk a695986d56 Merge "Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid" into tm-qpr-dev 2023-02-27 17:55:42 +00:00
Sebastián Franco df3741cb62 Merge "Binding tests to TouchInteractionService to preventing it from getting destroyed" into tm-qpr-dev am: 2e1524ec2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21186951

Change-Id: I00ec06d94c55eacbb4aee745f1e7882cc4e77d84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 00:59:04 +00:00
Sebastián Franco 2e1524ec2f Merge "Binding tests to TouchInteractionService to preventing it from getting destroyed" into tm-qpr-dev 2023-02-25 00:45:46 +00:00
Schneider Victor-tulias 4f4962fbc9 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: cd17310656
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21542943

Change-Id: I04412352aa7b773103cd08a9c7ce14fe75c2b789
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 21:57:41 +00:00
Schneider Victor-tulias cd17310656 Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev 2023-02-24 21:12:41 +00:00
Helen Cheuk 599109b23f Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid
Originally folder row and column for 5x5 grid was 3x3. This change is to update it to 4x4 in config to increase the max number of cells displayed. It also adds corresponding test for 5x5 grid and includes numFolderRows and numFolderColumns in the dump string

Fix: 265139500
Test: DeviceProfileDumpTest
Change-Id: I09fe3eac8113a147cb895988e5424471e4e772e5
2023-02-24 14:40:50 +00:00
Ling Wo 4f9196c305 Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev am: 6d3658dd0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21160354

Change-Id: Ia523c1d77e5b7903c3fb3cee502b771fc9e9c9bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 02:44:54 +00:00
Ling Wo 6d3658dd0c Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev 2023-02-24 02:24:54 +00:00
Brandon Dayauon 3d58117d76 Add logging to testDragAppIconToWorkspaceCell()
- add time logs to see what is taking up the most time

bug: 269555222
test: presubmit + manually
Change-Id: I36e763a42e0d8ebdcca108d9206418e05ab33e8f
2023-02-23 16:21:50 -08:00
Ling Wo d70c8a743d Revert^2 "Expose getSearchBox from the HomeAllApps class"
Reverted changes: /q/submissionid:21128652-revert-20714047-b_255390519-CAXVPNWYOY

Change-Id: I0e9680408e8b1db85600a226d808669c65ba4967
Bug: b/266169958
2023-02-23 02:42:09 +00:00
Federico Baron 87b61adde5 Merge changes I6c89c639,I6cab9202 into tm-qpr-dev am: 4ee5c429fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407904

Change-Id: I8ee82a8b1c954c47c1c495ad05d7f7a33d400e46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 01:13:07 +00:00
Federico Baron 4ee5c429fe Merge changes I6c89c639,I6cab9202 into tm-qpr-dev
* changes:
  Move 'no widgets found' to right pane and add rounded edges to right pane.
  Add ripple effect when a header in widget picker is selected.
2023-02-22 23:24:10 +00:00
Stefan Andonian d78817b455 Merge changes from topic "idp_grid_name" into tm-qpr-dev am: 78187b3812
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21529902

Change-Id: Ib632a7112fe19dc39d6f7f78fca7b668e00d35d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 22:32:15 +00:00
Stefan Andonian 2bbdb87ae6 Merge "Re-add LockedUserState util that was reverted after TAPL test failures." into tm-qpr-dev am: b334c03c74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21532181

Change-Id: I0ed0d81062e264b997e97034ff19bb8ec0aa0951
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 22:32:03 +00:00
Stefan Andonian 78187b3812 Merge changes from topic "idp_grid_name" into tm-qpr-dev
* changes:
  Add unit test and fix bug related to "Migrate IDP_GRID_NAME usage to LauncherPrefs" CL.
  Revert "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs""
2023-02-22 22:09:42 +00:00