Commit Graph

360 Commits

Author SHA1 Message Date
Charlie Anderson 3b072b9a07 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev 2023-03-08 14:15:17 +00:00
Charlie Anderson 52caf63404 Fixes several Visual issues with the app shortcut popup
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.

Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
2023-03-06 16:40:51 -05:00
Brandon Dayauon ffc7084b37 Correctly make to spec the color for "Turn on work apps" button and add stroke
- define color in base and quickstep

bug: 267975252
test: Manual - video: lightTheme: https://drive.google.com/file/d/1noY5Grq4jOxFIheL91KB_sOYRwp8XIyD/view?usp=sharing
test: darkTheme: https://drive.google.com/file/d/1o1uaTedAKbPy3BTG1GKJ0ldyHFs0-jGN/view?usp=sharing
Change-Id: I266b6624aa6f045c1f30c0db984fa9e1c5f6fe7e
2023-03-03 15:42:13 -08:00
Jagrut Desai 3addf0b66d Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev 2023-02-25 01:49:59 +00:00
Jagrut Desai 560b0eac62 Implement All Apps Icon upto the visual Specs.
Test: Visual
Bug: 267382941

Change-Id: If675c2f4767014598b23d8a2c2e684f5a8fb4f19
2023-02-24 15:41:06 -08:00
Federico Baron 4ee5c429fe Merge changes I6c89c639,I6cab9202 into tm-qpr-dev
* changes:
  Move 'no widgets found' to right pane and add rounded edges to right pane.
  Add ripple effect when a header in widget picker is selected.
2023-02-22 23:24:10 +00:00
Ats Jenk 431c0c05fd Merge "Add empty view to desktop tile in overview" into tm-qpr-dev 2023-02-22 19:30:55 +00:00
Federico Baron 8f6523a3d6 Move 'no widgets found' to right pane and add rounded edges to right pane.
Previously 'no widgets found' appeared on the left pane, but in large screen landscape we want it to appear on the right pane. Additionally, we added rounded edges to the right pane that turn into sharp edges when we scroll.

Fix: 268558448
Fix: 268557435
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and on tablet landscape mode go to the widget picker and search for a widget that doesn't exist, verify that 'no widgets found' appears on the right pane. Also verify that right pane has rounded corner that turn into sharp corners as we scroll
Change-Id: I6c89c63941e3b0680836828d0c7849d789cbce61
2023-02-22 00:34:10 +00:00
Federico Baron e8217b3c1b Add ripple effect when a header in widget picker is selected.
We need to use setSelected in order to add a ripple effect when a header is selected in tablet landscape mode, and to set the style through XML rather than programmatically the way it was done before in the method `setLargeScreenTheme`.

Fix: 268558453
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that when selecting a header there's a ripple effect on that header
Change-Id: I6cab920258a57118430d1e07416508ef36faa56d
2023-02-21 16:33:18 -08:00
Ats Jenk 4d397e2ebb Add empty view to desktop tile in overview
Show an empty view when there are no tasks on the desktop.

Bug: 267326725
Test: have a fullscreen task, open overview, observe empty view for
  desktop tile
Test: have a desktop task, open overview, observe desktop task thumbnail
  is shown in overview and empty view is hidden

Change-Id: Ifb6d96d42bf602e9cc9e397efc0e07e2accdf16b
2023-02-17 16:48:47 -08:00
Jagrut Desai 202c68c8a2 Merge "Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY Test: Visual(pics in buganizer) Bug: 265462138 Bug: 267382941" into tm-qpr-dev 2023-02-16 17:39:35 +00:00
Charlie Anderson 8ad9144ca2 adding the new Material U App Shortcut Popup design
Bug: 247880037
Test: tested manually
Change-Id: I66c291df54dfc2a76fc974082a19091deb167f73
2023-02-14 16:03:15 -05:00
Jagrut Desai ec0b4e1693 Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY
Test: Visual(pics in buganizer)
Bug: 265462138
Bug: 267382941

Change-Id: I223cd5ea7e5b553619dfc81c36f1be93e399639d
2023-02-13 13:34:23 -08:00
Sunny Goyal 77e732a1c4 Moving widget background to xml, so that the same constantstate is
used for all entries

This helps reduce launcher memory by avoiding multuple duplicate
drawable generation

Bug: 268646258
Test: Verified on device
Change-Id: I829750f081cfce65063b35a614b903066d9a4bed
2023-02-13 05:49:31 +00:00
Ats Jenk 90d0019447 Merge "Add icon to desktop tile in overview" into tm-qpr-dev 2023-02-10 21:47:31 +00:00
Ats Jenk 78b614f555 Add icon to desktop tile in overview
Copied over icon from caption desktop button in WMShell. Temporary icon
for now.
Refactored some logic in TaskView to better support for custom
orientation handling in subclasses. Subclasses can override setting
orientation for icon or thumbnail.

Bug: 267326722
Test: manual, enable desktop windowing proto 2 and go to overview
Change-Id: Id66d48fa52a418a07b954a384b2c3ea22f091b1f
2023-02-10 10:16:31 -08:00
Federico Baron 4b1a38bb7d Implement two pane widget picker
The widget picker design is currently not optimized for large screen form factor devices.
We resolve that by adding a two pane widget picker like that of the design in go/widget-picker-2023.

Bug: 256684299
Test: Make sure to be on a tablet in landscape mode.
        1.Turn on flag LARGE_SCREEN_WIDGET_PICKER.
        2. Press and hold on an empty spot in workspace until the popup menu appears.
        3. Click widgets.
        4. Notice the new two pane layout
Change-Id: Ia3ea17dc320f72f9bc5dea52399ff51d9161602b
2023-02-09 16:36:45 -08:00
Sihua Ma 7b7130db3d Merge "Rename the widget suggestion background drawable for outside usage" into tm-qpr-dev 2023-02-03 21:14:04 +00:00
Sihua Ma 13376cf2aa Rename the widget suggestion background drawable for outside usage
Bug: 237343464
Test: N/A
Change-Id: If380684dd28312af4897de301e592224b64f920d
2023-02-02 13:41:44 -08:00
Vinit Nayak 5a6863f14a Unify split options into single option
* No more split left/right/top, only have
splitscreen and icon shows vertical or horizontal
split windows
* Replace existing split icon for FreeForm

Fixes: 264930810
Test: Tested landscape and portrait, workspace,
overview, allapps

Change-Id: I443f93b6b01760b726bf9f024fb1324fdf0ed03c
2023-02-01 17:27:57 -08:00
Ikram Gabiyev 448e0ade10 Filter recents view instances by package name
Filter instances of GroupTasks based on package name
as a part of support for multi-instance

Add a feature flag to toggle multi-instance features

See the video below for how to use the demo.
Note: some extra UI elements were added since video
was recorded, but the filtering process is the same.
http://recall/-/da585DRwKRZK3S2xxcQrSm/gW9HZnbCvGyH1DQiVizOW2

See go/multi-instance for more info about the feature

Bug: 253520408

Test: manually tested the instance filtering

Change-Id: I19c947ca353699096388b9fbbdca6d75cb0041a7
2022-12-28 00:10:48 +00:00
Sunny Goyal 09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Sunny Goyal adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Jon Miranda e7417ce2ae Taskbar All Apps button visual updates
- Moved to new position
- Using 3x3 icon
- New Colors

Checked with visd that this half is good to go,
will follow up with positioning of the 3x3 icon within
its container.

Bug: 259712417
Test: manual, LTR/RTL modes, transient/persisent models

Change-Id: I298b6dbca004cdb8920e6533fffc8ca83e0197f9
2022-12-13 15:16:01 -08:00
Sunny Goyal fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
Federico Baron 4f5e573d3a Replace drawRect with drawable for delightful pagination
In order to eventually use the shape referenced in the task (https://docs.google.com/presentation/d/1V9-1C3mJ3zRGsuzzzYExisr9vLYecgADa1FucMoW_aw/edit#slide=id.g14256d0c614_0_311) we need to use a drawable. This CL adds the drawable that will be changed to that shape and uses it in PageIndicatorDots.java instead of using drawRect.

Bug: 247561880
Test: manual
Change-Id: I01e10bd9ddc7e378f2dcfdee0f84ba7443c3b9d3
2022-09-26 15:51:33 -07:00
Sunny Goyal ea6d59fbd4 Removing unused ShadowDrawable
Bug: 241152608
Test: Presubmit
Change-Id: Iae3b3799959dfe3457791cfac88a2cb4ac5770a4
2022-08-02 14:58:25 -07:00
Sunny Goyal af95ddbadc Fixing search behavior in Launcher3
> Showing no-result found only when there are no results
> Removing unnecessary view inflation in RecyclerViewPool for
  various search vide types
> Removing unused market-search link and no-empty-result illustration

Bug: 240343082
Bug: 207573083
Test: Verified Launcher3
Change-Id: Ia44799cd2385ea5dc837ef25732ca237975abde7
2022-07-28 22:05:30 -07:00
Brandon Dayauon 96f0bc582d Add ripple effect to work toggle button and "turn on work apps" button
Created new drawable xml specifically for the turn on work apps button because
the dismiss button (x) icon on the EDU card shares this drawable. This way I don't
cause collateral damage for the (x) icon dismiss button.

Changed shape -> ripple in work_apps_toggle background

bug: 229385255
test: Manually on oriole and video in bug thread
Change-Id: Id01bfb04c07a724687b0322339b12c8fc9130dfa
2022-07-07 10:14:07 -07:00
Brandon Dayauon e5142c5c53 changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon..
Fixed padding issue (tightness) between Personal/WorkTabs/EduDialog
Aligned Work Toggle button to be the same with the workTabs/eduCard
raised button up 20dp to align with specs

Fixed issue where allApps apps invade the tabs. Fixed RTL issues where it wasn't going RTL.
Fixed RTL issue for the workfab button where there was no margin on the left side of the button
Added DeviceProfile to constructor

Bug: 200810328
Bug: 224731300
Test:
	Before: https://screenshot.googleplex.com/6sRgNZQz4wKYn5n
	After: https://screenshot.googleplex.com/8hBLyDiMbMH9tn2
	After(showingLayoutBounds): https://screenshot.googleplex.com/MuVUXCegukAMzSr

Change-Id: Ibac3f5b8fe7d877c2f54a2c87f4393c1a91dc806
2022-05-06 09:52:05 -07:00
Pat Manning 48beebbed5 Update widget edit icon to use material colors.
Fix: 216821024
Test: manual
Change-Id: I3c3e463e33d7a611010e426eca1378cde027c6d6
2022-04-12 18:26:06 +01:00
Pat Manning de25c0db36 Adjust edit state drop targets and workspace scaling per device type and orientation.
This is a partial revert of ag/17540098

Bug: 202971709
Test: manual
Change-Id: I0a642f932afd75e47ce11a2c1ee94643d1a67e0c
2022-04-05 20:56:03 +00:00
Pat Manning e372366bb3 Revert "Adjust edit state drop targets, workspace scaling, and m..."
Test: manual

Revert submission 17004675-edit-state

Reason for revert: b/226274309
Reverted Changes:
Ib50509b6f:Adjust edit state drop targets per device type and...
Id1817cd3c:Adjust edit state drop targets, workspace scaling,...

Change-Id: I22863d7735f49f6a040a17cf56cc66f20a3e0986
2022-03-28 08:24:54 -04:00
Pat Manning 1acf2b18af Adjust edit state drop targets, workspace scaling, and margins per device type and orientation.
Bug: 202971709
Test: manual
Change-Id: Id1817cd3c7e7bfa5b0aa8aa20565b791ad871f64
2022-03-18 17:43:28 +00:00
Jon Miranda 48a2f7a0ac Use color tokens for all apps entry buttons.
Bug: 220356537
Bug: 205803230
Test: manual, dark mode, light mode
Change-Id: I0973d5aa9ab1ccbdcc78c1e411cbbf63953f2f94
2022-02-23 19:47:33 +00:00
Alex Chau b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
TreeHugger Robot b82a517fee Merge "Adding ripple effect to the "All Apps tab" buttons." into sc-v2-dev am: 3ba95852f3 am: 5cf55827da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16359044

Change-Id: I043288685528d6430f38b93e19e468069071a503
2022-02-11 02:45:13 +00:00
Jon Miranda fd48b0c988 Add All Apps entry button to Taskbar.
- Opens All Apps when clicked
- Fades button in/out when transitioning b/w Hotseat & Taskbar

Bug: 205803230
Test: manual
      ensures alpha gets reset properly
      clicking button opens all apps
Change-Id: I1b96bae734aa9fd9308931d6312e3d65559d4284
2022-01-31 17:22:58 -08:00
Alex Chau 27b39b9668 Put AllApps in bottom sheet for tablets
http://screen/7steQ7W8U2ga3Hs

Bug: 208599118
Test: manual
Change-Id: I36cbac3cb7cb214081e5a33a6e042ae83e745f23
2022-01-19 18:57:34 +00:00
Sebastian Franco 3a50ab4af1 Adding ripple effect to the "All Apps tab" buttons.
Test: Manually tested
Fix: 192252147
Change-Id: I38d37b581b998dc05f087533cff3968ebe0cb00d
2021-12-13 14:18:32 -06:00
Vinit Nayak 455197bf41 Add icons for staged split
Fixes: 208649953
Change-Id: I8b7bb3a650e836608ebe6aa50631026f5f6a7c63
2021-12-01 14:58:53 -08:00
Jon Miranda b77878ebe3 Update folder preview and folder background colors.
Bug: 201332301
Test: light theme / dark theme
      open and close folder, ensure colors are accurate

Change-Id: I49198eb2faee03111be33051fd1cb08094844c77
2021-10-06 16:57:33 -07:00
y bd8d9150e0 [AllApps] Polish views according to specs
Bug: 196391749 Update work edu button stroke color
Bug: 195497351 Update header font size for work apps paused state
Bug: 192673256 Show ArrowTip elevation
Bug: 192668800 Support for two line PopupOption view
Test: visual
Change-Id: I65f8c6152f54306756d6cb66de2581aff45b8d47
2021-08-31 17:04:46 -07:00
Schneider Victor-tulias ff322310a3 Convert gesture navigation tutorial still image vector drawables to layout files
Bug: 192939067
Test: manual, started full tutorial, started home, back and overview individually, locked and unlocked phone mid-tutorial step.
Change-Id: I1cba811c556139bc9ba52459f1b27f21eb156ac0
2021-08-23 11:14:04 -07:00
Sunny Goyal 77acf12905 Fixing header jump
Linking header position to an empty entry in the recyclerView,
instead of calculating the vertical scroll position. This
allows the header to be in sync with the recyclerView scroll and
item animations

Other simplifications:
> Moving top collapse handle out of header view (it doesn't scroll)
> Removing background clipping logic from full-sheet
> Moving tab bar inside the header view

Bug: 196464142
Test: Verified on device
Change-Id: Iae5a0ae9af7ce258e1b391b8e85c5c270fe56197
2021-08-16 09:45:14 -07:00
Hyunyoung Song 673b475787 AA+ Final UX spec changes
Bug: 192670508
Test: manual

Change-Id: Id448f31adef851175306cd513974a64a1f029e50
2021-07-13 09:43:08 -07:00
Hyunyoung Song 7d439991cc Merge "Update work fab radius to match height" into sc-dev 2021-07-08 18:25:17 +00:00
Samuel Fufa ae8462afb5 Update work fab radius to match height
Bug: 192666217
Test: presubmit
Change-Id: I948cab4ce5477eed68480daf70570851d9715006
2021-07-07 18:26:22 -05:00
Hyunyoung Song 675b2b6748 Accessibility bug fixes for the snack bar
Bug: 192639465
Bug: 192598846
Test: scanned using accessibility scanner and verified no issue detected

Change-Id: If776a68f7c4c421cdb51ec3eb4f05648ab1ed5c1
2021-07-07 15:36:05 -07:00
Samuel Fufa 8b1461d212 Allapps layout polishes
Bug: 192666217
Bug: 192648043
Bug: 192648475
Test: Manual
Change-Id: Ib108a6cae8317571520d367334f3bd26b259f04a
2021-07-02 13:03:11 -05:00