Now we base it on the current tappableElement insets, which will only be
> 0 for the unstashed, persistent taskbar which draws rounded corners.
This inset also stays stable during temporary stash transitions such as
when the IME is showing.
Flag: ENABLE_TRANSIENT_TASKBAR=true, ENABLE_TASKBAR_PINNING=true
Test: in split screen for both transient and pinned (persistent)
taskbar, ensure split screen divider bottom is drawn appropriately
Fixes: 278028503
Change-Id: Iab56c5dc8f9fc81c34aa01f41b5212dd5c6fd7f0
Taskbar never needs a semi-transparent scrim drawn by the decor view at
the insets area, because taskbar has the background color on its own if
needed.
Bug: 197615177
Test: SystemUIGoogleBiometricsScreenshotTests
Change-Id: Ic49c8af3ecbefcc83d1bd987812625c7e2f37157
- Setting the override frame for the gesture insets sources prevents
the insets from being calculated correctly for the IME window
- Update the set of provided insets based on the current nav mode
so that we don't report gesture insets in button nav
Bug: 265614886
Test: Dump IME window insets for button/gesture nav
Change-Id: I22f9d09a66b50d6e2fb5002af19058657a06404d
This CL was generated automatically from the following command:
$ external/ktfmt/prepare_upgrade.py --repo=packages/apps/Launcher3/ --build_id=9645412 --bug_id=266197805
This CL formats all files already correctly formatted with the upcoming
version of ktfmt.
Bug: 266197805
Test: Presubmits
Change-Id: Ide7d63a75fed98aabe348821355356c77f00a9ec
Merged-In: Ide7d63a75fed98aabe348821355356c77f00a9ec
Bug: 231648761
Fixes: 269392826
Test: Unable to reproduce 269392826, but verified this doesn't
break existing paths to adjust the insets
Change-Id: I8aa82f3fb77e627ac02352ef31b788b81c2ca901
This uses ktfmt on the PREUPLOAD hook to check file formatting.
Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
- ITYPE_BOTTOM_MANDATORY_GESTURES should always be > 0 in gesture
navigation mode, but before we were setting it equal to tappableHeight
which is 0 if the taskbar is stashed. Fixed it to be contentHeight
instead.
- Updated VIS insets to only override them to be 0 for tappableElement,
not for others like navigationBars. We still only override this for
gesture navigation; 3 button mode will continue reporting the same as
we report to the underlying apps.
Test: manually with 3 button mode, gesture nav mode with taskbar
stashed/unstashed; checked that TaskbarInsetsController dump looks as
expected, and that behaviors like Assistant and IME look correct
Flag: none
Fixes: 262516176
Change-Id: I5a1cdf5a9956777d3189ef6042493e2f5aa9b162
Bug: 260101467
Test: open chrome, enter url to pull up ime, swipe up to show taskbar,
tap on taskbar icon
Change-Id: Ic8be6c2bb82fc9b8ab83572cb8622ac157078ea9
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.
Demo: http://shortn/_Qcki3gwvf7
Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
- When taskbar is unstashed in Launcher (e.g. overview), make the unstashed height touchable
- When AllApps button is pressed in taskbar overview, also stash taskbar
Bug: 245320601
Test: manual
Change-Id: Iadd0bea13cf9a779c68e953d25f21f663c15865a
Test: Invoke assistant on tablet on both geture nav and 3 button mode;
In gesture nav mode: assistant shows at the very bottom of the screen,
layered on top of the taskbar background (in z order)
In 3 button mode: assistant shows right above the taskbar, which only
shows the 3 buttons (no taskbar icons) while assistant is showing
Fixes: 225200928
Change-Id: I2fbc05e696b58e8801e704092aa2741cb57c05c4
The frameworks extended the API to let window provide insets to given
typed window with insetsSizeOverrides. Migrate to the method to
provide insets for IME.
Test: build
Test: the IME can receive correct insets
Bug: 225200928
Change-Id: Ic8eab5198221bc8de6eca432e8b3e11067c83d57
The WM provides a new way to provide insets, modified the code to
reflect that change.
Bug: 161689946
Test: m
Merged-In: I31bd26a5ce4c3e47f8961d4fe528f3a97ec063f8
Change-Id: I31bd26a5ce4c3e47f8961d4fe528f3a97ec063f8
- TaskbarDraglayer.width isn't initialize when Taskbar is recreated before layout, so use DeviceProfile.widthPx instead
- Also listen for DeviceProfile change in TaskbarInsetsController to update Taskbar touchableRegion
Fix: 233316713
Test: Switch to 3 button, nav button works. Swtich to gesture nav, taskbar icon can be tapped
Test: Rotate deice, whole Taskbar should still be touchable
Change-Id: I29ff86fd8616a620f98d9b5438cc586bd69fac33
- This allows us to distinguish taskbar's ITYPE_EXTRA_NAVIGATION_BAR insets from its ITYPE_BOTTOM_TAPPABLE_ELEMENT insets
- Set nav bar insets as before (contentInsets)
- Set tappable elements insets the same, except when taskbar is stashed, in which case set to 0
Test: TaplTestsTaskbar; manually stash/unstash taskbar, open IME, open Calculator (which uses tappableElement() insets) and Contacts (which uses systemBars())
Fixes: 215411414
Change-Id: If00f7a590b0780715d5b8159f5135054364ce84e
Tony Wickham
Tiger
Winson Chung
Jordan Demeulenaere
Thales Lima
Jon Miranda
TreeHugger Robot
Vinit Nayak
Brian Isganitis
Alex Chau
Yunfan Chen