Commit Graph

14770 Commits

Author SHA1 Message Date
Luca Zuccarini f70e2f0a95 Merge "[Toast] Introduce SysUI's animation library to the transition manager." into tm-qpr-dev 2023-01-30 14:25:48 +00:00
Vinit Nayak d710773889 Merge "Launch initial split from taskbar in overview app menu" into tm-qpr-dev 2023-01-28 05:25:12 +00:00
Andy Wickham 275b80e687 Merge "Move search bar background protection on top of scrollbar." into tm-qpr-dev 2023-01-28 01:35:24 +00:00
Vinit Nayak 49dc6d2712 Launch initial split from taskbar in overview app menu
* Consolidated init calls in SplitSelectStateController
* Also add support to launch from taskbar all apps
* Add logic in SplitSelectStateController to know whether
or not we need to dismiss existing TaskView vs relying
on mSplitHiddenTaskView null check
* Default click handling for SplitShortcut is to start
split selection mode

Bug: 251747761
Test: Initiated split from smart actions, thumbnail app
icon, home, taskbar in overview, all apps. Saw it choose
the latest thumbnail

Change-Id: Ib4f64e619c97615af458a19a9c0efd86c92979d9
2023-01-27 16:46:14 -08:00
Sunny Goyal 150b7b0497 Merge "Removing unnecessary abstraction of AdapterProvider" into tm-qpr-dev 2023-01-27 21:40:27 +00:00
Sunny Goyal 49d153e4bf Removing unnecessary abstraction of AdapterProvider
Bug: 266605714
Test: Presubmit
Change-Id: Ib5ccecc33e66e61cb27d083591c8fb7c13a96698
Merged-In: Ib5ccecc33e66e61cb27d083591c8fb7c13a96698
2023-01-27 16:55:55 +00:00
Luca Zuccarini 2098381808 [Toast] Introduce SysUI's animation library to the transition manager.
Bug: 250588519
Test: manual, see videos in bug
Change-Id: Iccc440c95ecc14d39e35d911798e239b698b950a
2023-01-27 13:49:40 +00:00
Thales Lima 91b9de1fe2 Merge "Create attr for padding between icon and text in cells" into tm-qpr-dev 2023-01-27 10:23:30 +00:00
Holly Jiuyu Sun c3c77fc049 Merge "Move ENABLE_HIDE_GBOARD_HEADER_STATIC from feature flag to server side flag." into tm-qpr-dev 2023-01-26 23:24:21 +00:00
Thales Lima d852d65693 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 22:50:18 +00:00
Stefan Andonian 734c4530ed Merge "Add null check for NPE in FolderIcon." into tm-qpr-dev 2023-01-26 21:32:44 +00:00
Andy Wickham 03fdeb7684 Move search bar background protection on top of scrollbar.
This way the search bar looks more connected to the keyboard
without the scrollbar showing next to it.

Note: Here the search bar is added on top of all other views
(previously it was inserted above only the header), and the
protection is always added just behind the search bar.

Also adjusts the height of the scrollbar to end above the search
bar when floating search bar is enabled.

Screenshots:
Scrollbar behind search bar: https://drive.google.com/file/d/10ZJ-q5nA9ZBjr7gjoauTDDAbQRUNk7S7/view?usp=share_link&resourcekey=0-pF6eOcuKz2_sCA_eZpa1Sw
New scrollbar height with floating search: https://drive.google.com/file/d/1fVIJjiG7RMme5fBXiSJmxNfOhHJ__Gwj/view?usp=share_link&resourcekey=0-b9RsB7f55U_rIZBu4IhVGQ

Fix: 265478433
Test: With and without floating search and always-on keyboard and
work profile.

Change-Id: I4f7ae0d376dae215c0cbd8deaee3e4a409d21ae4
2023-01-25 13:42:35 -08:00
Brandon Dayauon 5809508f25 Merge "Fix preference screen title to make folded devices the same as phone" into tm-qpr-dev 2023-01-25 21:38:17 +00:00
Andy Wickham 62ef7ba819 Merge "Fix header padding when search not enabled." into tm-qpr-dev 2023-01-25 19:10:09 +00:00
Holly Sun 6a62176621 Move ENABLE_HIDE_GBOARD_HEADER_STATIC from feature flag to server side flag.
Bug: 266708932
Test: manual with adb command
Change-Id: Id064367ee970120cf0aa668b9c81613f7262bad8
2023-01-25 10:12:38 -08:00
Sunny Goyal dbc5e56e07 Merge "Merging unnecessary subclass of ActivityAllAppsContainerView" into tm-qpr-dev 2023-01-25 06:37:15 +00:00
Fengjiang Li e73db2a011 Merge "Predictive back: widget to all apps" into tm-qpr-dev 2023-01-25 05:26:49 +00:00
Fengjiang Li 6bb8d79549 Predictive back: widget to all apps
This CL adds a layer of OnBackPressedHanlderRouter to Launcher:
1. 4 OnBackPressedHandler(s) are added in such order: auto cancel action mode handler, drag handler, view handler and state handler
2. first handler who can handle back will handle the entire back gesture
3. Let WidgetsFullSheet to handle widget to all apps transition

Bug: b/260956481
Test: manual
Change-Id: Idbce3dcec746226dd68aaabaddc8fe01334e9673
2023-01-24 15:51:46 -08:00
Sunny Goyal 34c499dc84 Merging unnecessary subclass of ActivityAllAppsContainerView
Bug: 266605714
Test: Presubmit
Change-Id: I87272ee827055f58f91a4ad9fb25d5351d453cdb
2023-01-24 13:01:00 -08:00
Sebastián Franco 68f5667338 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev 2023-01-24 20:02:35 +00:00
Brandon Dayauon e530801f44 Fix preference screen title to make folded devices the same as phone
Now it says "Search your Phone" on folded devices instead of
"Search your tablet" when unfolded

bug: 265610885
test: Manually - on foldables and tablets
Change-Id: I39ee08539b70b2e7258bca86b1450c62c75f748f
2023-01-24 11:10:15 -08:00
Stefan Andonian 74471716ca Merge "Fix crash in LauncherPreviewRenderer." into tm-qpr-dev 2023-01-24 17:35:27 +00:00
Alex Chau d2e4906230 Merge "Revert "Add logs to track app grid changes"" into tm-qpr-dev 2023-01-24 17:01:56 +00:00
Alex Chau b415beed17 Revert "Add logs to track app grid changes"
This reverts commit d2706823cb.

Reason for revert: b/258560494

Change-Id: Idb13ff4963ebf364c4b144a69621a13daa376a39
2023-01-24 11:26:06 +00:00
Sunny Goyal e1daf91dfd Merge "Moving all intent receiver register calls to a single place" into tm-qpr-dev 2023-01-24 00:10:08 +00:00
Andy Wickham ad753607d2 Fix header padding when search not enabled.
This was specifically affecting taskbar all apps with
floating search bar enabled. Header placement should not
be changed in that case.

Fix: 266440950
Test: Manual in taskbar and other all apps surfaces with and
without work profile, floating search flag on and off.

Change-Id: I2296a079cc15387a517c61e6b8a21fa0081cba23
2023-01-23 10:49:15 -08:00
Stefan Andonian dbff8cda6c Fix crash in LauncherPreviewRenderer.
The LauncherPrefs INSTANCE variable needs to be registered with the
sandbox context used by the LauncherPreview. This will stop the crash
from occuring.

Bug: 266164372
Test: Verified that crash no longer occurs.
Change-Id: I12ef12d082b7afdb08b38321527d13c637e84f2f
2023-01-23 18:11:49 +00:00
Sunny Goyal a992ac9e8d Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
Merged-In: Ib410e5bf02773cefde5bf0a0a1f2f1c108718d24
2023-01-22 05:24:48 +00:00
TreeHugger Robot 654f714718 Merge "Implement initial transient Taskbar EDU tooltips." into tm-qpr-dev 2023-01-21 07:28:30 +00:00
Brian Isganitis b21ad2da8c Implement initial transient Taskbar EDU tooltips.
Since this tooltip looks and behaves differently than the existing EDU
sheet, it has its own view and controller implementations (I also may
have wanted to write some Kotlin).

To keep transient taskbar open while on the second EDU step, another
autohide suspend flag is defined. Additionally, special casing is added
to avoid hiding transient taskbar if autohiding is currently suspended.

Tooltips use the same assets as the bottom sheet for now, and are scaled
down to fit the tooltip dimensions.

Reset `Taskbar Education` in Developer Options to try EDU again.

[Demos]
- First: https://screenshot.googleplex.com/ASBeGvrb2EA5wEF.png
- Second: https://screenshot.googleplex.com/7fnfcTh9bMYezDc.png

Test: Manual
Test: Open app, see swipe-up tooltip.
Test: Swipe up to show transient taskbar, see features tooltip.
Bug: 263157739
Fix: 258460203
Change-Id: I473f5fccbae279db0614763b640da0a120b6b7f7
2023-01-20 15:16:12 -08:00
Alex Chau 7e1144ee99 Merge "Fix IllegalStateException caused by trying to snap to destination before initalizing page scrolls." into tm-qpr-dev 2023-01-20 15:07:10 +00:00
Nick Chameyev effbe5aa48 Merge "Calculate StatusBar height locally in Launcher" into tm-qpr-dev 2023-01-20 11:42:19 +00:00
Jagrut Desai b207102b98 Merge "Adding a debug feature flag for taskbar pinning." into tm-qpr-dev 2023-01-19 21:50:05 +00:00
Nicolò Mazzucato 1207e773e2 Merge changes I2c1e440b,I805d56d4 into tm-qpr-dev
* changes:
  Add OPTIMIZE_MEASURE flag to QuickSteplauncher window
  Log device profile changes in perfetto traces
2023-01-19 19:42:26 +00:00
Jagrut Desai ffe8cc01d5 Adding a debug feature flag for taskbar pinning.
Bug: 265307333
Test: cl

Change-Id: I95cea392924fb9dc2acff99cd97a5fb4ddc32fbc
2023-01-19 19:16:23 +00:00
TreeHugger Robot bc7efd06a7 Merge "Fixing while navication bar in all-apps in 3-button mode." into tm-qpr-dev 2023-01-19 02:06:30 +00:00
Sunny Goyal 7450874e28 Fixing while navication bar in all-apps in 3-button mode.
Launcher was not accounting for all-apps-nav-bar-scrim when
computing sysui-flags

Bug: 194486821
Test: Verified on device
Change-Id: I692977fba5999bbab9737bac4b27c15c2912e6af
2023-01-18 15:36:28 -08:00
Federico Baron a9e5f5a1ef Merge "Set the ENABLE_DOWNLOAD_APP_UX_V2 flag to true" into tm-qpr-dev 2023-01-18 19:36:59 +00:00
Federico Baron da581c38e4 Merge "Change preload icon size to always be 0.7 scale when downloading" into tm-qpr-dev 2023-01-18 19:17:14 +00:00
Stefan Andonian 8b85f83785 Add null check for NPE in FolderIcon.
Bug: 265298513
Test: N/A
Change-Id: Id55bd488c40edcca376df2843b1a1999aeb944be
2023-01-18 18:19:26 +00:00
Nick Chameyev a8037620bd Calculate StatusBar height locally in Launcher
When reading the status bar inset on devices with
multiple displays after switching the displays
the inset is not updated immediately (SystemUI
should update the height of the window first by
reacting to the display switch in it's own process).

Due to this race condition Launcher is very likely
to calculate DeviceProfile with incorrect inset
of the previous display first and update it to
the correct one only after SystemUI finished the
window update.

To avoid this adding calculation of the StatusBar
height to Launcher locally using the same utility
method that is used by SystemUI.

Bug: 264656380
Test: manual test that the statusbar height is calculated
 correctly in Launcher on a device with two displays, both on
 the inner and outer display and different rotations
Change-Id: Ia16ecadd8fcac29082d27ca693ab7740ce6161c4
2023-01-18 16:04:41 +00:00
Alex Chau 6ef0f12286 Merge "Use transient taskbar size/margin to calculate taskbar position for persistent taskbar" into tm-qpr-dev 2023-01-18 15:37:34 +00:00
Federico Baron 3278715fd4 Change preload icon size to always be 0.7 scale when downloading
In order to match upcoming designs. We will keep the icon size when downloading at 0.7 scale

Test: download an app with ENABLE_DOWNLOAD_APP_UX_V2 on
Bug: 254858049
Change-Id: I7f22eb3a5c6f1e75f19e033ff11a70aa4010ea10
2023-01-17 16:42:43 -08:00
TreeHugger Robot a13d5c4b91 Merge "Workspace pagination UI update" into tm-qpr-dev 2023-01-17 23:29:18 +00:00
TreeHugger Robot 196569bb50 Merge "Add finish icon scale animation for downloading apps" into tm-qpr-dev 2023-01-17 19:38:47 +00:00
Stefan Andonian 1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Nicolo' Mazzucato cb7bd50247 Log device profile changes in perfetto traces
This is needed to easily spot unwanted DeviceProfile changes in perfetto traces, as each one causes many new inflation and slows down the ui thread considerably.

Test: recorded trace with this log
Bug: 258214245
Change-Id: I805d56d4dfe1c08d7f28215c0462d01fcaece84e
2023-01-17 14:54:11 +00:00
Alex Chau 85d664efaa Use transient taskbar size/margin to calculate taskbar position for persistent taskbar
- DeviceProfileTest should use persistent taskbar in 3-button mode

Fix: 260596114
Test: DeviceProfileTest
Change-Id: Iadcca218dab2bc2eedc006c86dbbe3f9a0fa5e51
2023-01-16 17:00:46 +00:00
Sebastian Franco de1fe14a47 Adding the avility to add icons on multiple CellLayouts on tests.
I needed to change the code so that you can pass the CellX/Y
position to the drag function instead of the pixel coordinates
and we can pass X position bigger than one CellLayout.

Also, I notice that getCellCenter only worked for 1x1 items
so I added the option to specify the widget size.

Fix: 262431878
Test: atest ReorderWidgets#multipleCellLayoutsSimpleReorder
Change-Id: I3b09de770e8f99aa10cae8cea32e7e6bc02c7b8b
2023-01-16 10:32:40 -06:00
TreeHugger Robot 77a388c79e Merge "Predictive swipe: show extra app icons at bottom of All Apps's RecyclerViews" into tm-qpr-dev 2023-01-14 06:03:52 +00:00