34fa499029
Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev am: f3fdca59d2
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23143004
Change-Id: If2d7d00987a057164717ce246490e6bdb20fe3e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-10 22:12:09 +00:00
f3fdca59d2
Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev
2023-05-10 21:40:40 +00:00
862585eb1b
Merge "Fixing NPE in TransfromParams.java" into udc-dev am: 4d17468f88
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23120958
Change-Id: I7e0c19d989c539ffc4bd54bcc002378d921d96ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-10 19:38:52 +00:00
64809780ce
Revert "Fix null-pointers in SurfaceTransactionApplier constructor."
...
This reverts commit d86c5657e0
2023-05-10 19:34:01 +00:00
4d17468f88
Merge "Fixing NPE in TransfromParams.java" into udc-dev
2023-05-10 18:57:17 +00:00
569862b756
Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev am: fb085e6393
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23117884
Change-Id: Iefc56e4eb7f2e8185d0cb96e20a05b35aa93792c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-10 17:52:25 +00:00
fb085e6393
Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev
2023-05-10 16:49:09 +00:00
4f767cfc5b
Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev am: d382a4880b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23088599
Change-Id: I729273082342f4559c32eff5408e765720bcf154
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 22:02:46 +00:00
4aa44e5169
Fixing NPE in TransfromParams.java
...
- we were not actually using mRecentsSurface so we no longer need to compute that. By removing this we will also fix the NPE.
Test: Pre-Submit
Fixes: 269716918
Flag: not needed
Change-Id: Ief4be341061a1c914456d6740f175662ccebc364
2023-05-09 14:45:17 -07:00
d382a4880b
Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev
2023-05-09 21:33:36 +00:00
0414930150
Merge "Un-Split TaplTestsTaskbar" into udc-dev am: 53b4435b7e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22821856
Change-Id: I8abc321724b901da201214975309690cf844ff41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 20:55:14 +00:00
9bdeeb9f18
Merge "Fix tutorial menu layout issues" into udc-dev am: 458971616d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23089641
Change-Id: Ieffbff7adf222645c66dc9e6f6ad1a3e251f333e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 20:55:05 +00:00
4656cd1846
Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev am: 5f475a2f48
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22998399
Change-Id: I603fef8494698880c08f253b261e5c6b2a29345b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 20:54:56 +00:00
53b4435b7e
Merge "Un-Split TaplTestsTaskbar" into udc-dev
2023-05-09 20:43:01 +00:00
4e909d07ac
Animate the position of the selected bubble arrow in the expanded bubble bar.
...
Fixes: 280605070
Test: Tested on a physical device
Change-Id: I961254527ba9a26d211c2c348a937a424fa2fb4d
2023-05-09 16:35:30 -04:00
458971616d
Merge "Fix tutorial menu layout issues" into udc-dev
2023-05-09 20:18:07 +00:00
5f475a2f48
Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev
2023-05-09 20:15:01 +00:00
6e6705a6bd
Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev am: a72094ad66
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039499
Change-Id: Iccf82ac63ea13c11a35f217ad223c4c6ce676a06
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 18:09:48 +00:00
a72094ad66
Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev
2023-05-09 18:02:53 +00:00
a5df34e1c8
Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380
Change-Id: I4a0253c3bd37820dfaf0d4f46592d87d5b7b9215
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 16:57:57 +00:00
9569ce86a2
Un-Split TaplTestsTaskbar
...
Before we use TaskbarModeSwitch but had a drawback where we would not know which variant of taskbar the test failed for. So, we split the taskbar tests into transient and persistent for better error logs and debugging.
But, now we can use Parameterized Test Runner to achieve the same and do not have to duplicate test code for testing two different variants of Taskbar.
There can be instances where we only want to test certain taskbar variant only, we have separated files for that.
Test: Presubmit
Bug: 267648422
Flag: not needed
Change-Id: I4322498f13d257a5f1793b008f45b09ac9b9f3ff
2023-05-09 09:36:09 -07:00
75109c7abc
Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev
2023-05-09 16:19:44 +00:00
3c5a757b24
Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR am: b33a2e0762
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22958378
Change-Id: I9e5a7f273d0d17f2c8c979fa943f52d4a728c3e6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 08:00:35 +00:00
b33a2e0762
Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
...
Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Change-Id: I9c58ba50f0269c69a12f548a1873c2d8251f6243
2023-05-08 17:27:03 -07:00
047f92d81e
Merge "Potential fix for end callback not being run in 3-button" into udc-dev am: 606c4bfc59
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23019205
Change-Id: I6ab89a4f13d85c02b14608e74291ba2892484d6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-09 00:17:26 +00:00
29fcd9a636
Taskbar All Apps Icon Shortcuts Popup Accesiiblity
...
Before we were only applying the icon.clearAccessibilityFocus() only on normal popup and not material u popups, since the flag is turned on for udc, we can move it outside.
There seems to be a bug associated with either nested abstract floating views or the accessibility service where upon opening a nested abstract floating view from another the icon get the focus. This change make the bug littl less visible to use but users will still see this bug if they open the shortcut pop agian withought closing taskbar all apps.
The accessibility delegate was always null when using the TaskbarOverlayContext, now we use TaskbarActivityContext Delegate when in TaskbarOverlayContext.
Test: Manual
Bug: 280657266
Flag: not needed
Change-Id: I631e3aa6e54748c4c8ea2ac7daf5473b198e47d6
2023-05-08 16:25:53 -07:00
d9253224b3
[5/n] Log cardinality to StatsLogManager
...
Test: app builds
Bug: 278271805
Change-Id: Ia0180815509759caf867296a7941fa32402d8f45
2023-05-08 16:13:05 -07:00
c50f870625
Fix tutorial menu layout issues
...
- Fixed back button image padding (and updated all other images to prevent hidden padding)
- fixed done button size
- padding top and bottom insets for status bar and nav bar
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281121442
Fixes: 281121138
Test: launched the tutorial menu on handheld, foldable and tablet, compared before/after pictures
Change-Id: I61bce2fc4a8d3824048229e0d48f9a429c80a204
2023-05-08 15:43:39 -07:00
f46fa7ac49
Restore Recents TaskView based on all taskIDs, not first
...
* Return a copy of taskIds in TaskView#getTaskIds() to
prevent accessors from getting clobbered values
* In RecentsView#applyLoadPlan we overwrite values in that
array, so callers using it to cache old values would read
incorrect values when reading it after a TaskView has been
bound to new tasks.
* Load/Unload visible task data for all tasks in a given
TaskView, not just single task <-- probably not necessary for
bug fix, but seems sensible
Flag: none
Fixes: 266905177
Test: Quickswitch works as expected. Currently
unable to test thumbnails (created b/281582106)
Change-Id: Ifd4d8a856976ab9cc200b0f61eca1c68897f343c
2023-05-08 22:34:29 +00:00
b841d5267c
Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev am: 35f5bfea4c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23058990
Change-Id: I9e4d381b1f43ec435e8dc5c94c627d69281c576b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-08 21:35:14 +00:00
606c4bfc59
Merge "Potential fix for end callback not being run in 3-button" into udc-dev
2023-05-08 21:13:01 +00:00
35f5bfea4c
Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev
2023-05-08 18:52:25 +00:00
b4d421d37a
Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev am: a40de23f04
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973611
Change-Id: Icd979852965966821f0dfdc9babeef548cbfe340
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-08 16:57:26 +00:00
676950a91a
Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev am: 39e28c9190
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22992541
Change-Id: I14186dee9f80c2852db4724eee27764e561ee017
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-08 16:57:06 +00:00
a40de23f04
Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev
2023-05-08 16:50:13 +00:00
39e28c9190
Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev
2023-05-08 14:20:36 +00:00
f4f2f99af7
Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev am: 764608263f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534247
Change-Id: I4cc2a84665537989860e27603f82605f0e61fcc2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 18:03:13 +00:00
0608101d80
Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev am: b7dce64db5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534246
Change-Id: Ib36c26a055c24797c8e7f012a605d450dd5a2a5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 18:03:03 +00:00
764608263f
Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev
2023-05-06 17:22:21 +00:00
b7dce64db5
Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev
2023-05-06 17:22:06 +00:00
50d31f5530
Merge changes I35fe528b,Ia612c1b5 into udc-dev am: 0b53332c31
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22419061
Change-Id: I25ddaa428ca3fd58f079e93b7430b0528fda2f06
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 15:35:43 +00:00
0b53332c31
Merge changes I35fe528b,Ia612c1b5 into udc-dev
...
* changes:
Don't close AFVs when opening Taskbar folder.
Keep persistent Taskbar visible over Taskbar All Apps.
2023-05-06 14:42:54 +00:00
1f205bb22d
Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404
Change-Id: Ia14f1de012521784b37c4b412f7268e22cbdabd6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 07:56:35 +00:00
8e7e159645
Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev
2023-05-06 07:12:18 +00:00
4f00ae9e76
Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497
Change-Id: Id7faac43f67f98127b8fa223fa3dbd62b3a3d502
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-06 02:42:17 +00:00
8b0fcbffb0
Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev
2023-05-06 01:57:51 +00:00
c37bf46381
Adds BubbleControllers to TaskbarControllers
...
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
controllers.
* Adds the relevant views used by the bubble controllers to the
transient taskbar layout.
Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
2023-05-05 17:02:38 -07:00
df51c1ada8
Try to detect and handle delayed quickswitch task launch failure
...
- The main issue arises when a task is successfully launched from
overview, but the activity later finishes (ie. during resume) which
prevents the usual logic of resetting Launcher to a good state
(ie. it can get stuck in overview with a blank or empty snapshot)
In this case, the Launch will "succeed" so that onTaskLaunchFailed
is not called, but then also silently fail (launched task finishes
and Launcher is again resumed) before Launcher stops, which does the
usual resetting of the state back to normal state after quickswitching.
This change checks for this case by listening for the activity and
transition state, and in the case where Launcher has not been stopped
or is resumed again after the transition finishes, returns the
user to the default home state.
This primarily only affects quickswitch for now, as other launch
failures leave the user in a valid state (ie. overview) while this
issue will leave the user in background state while quickswitching.
Bug: 268448123
Test: Quickswitch to an activity that finishes when resumed
Change-Id: I7d554f8fd521f7bc480dc06930ad91eeef0f1a1a
2023-05-05 23:55:22 +00:00
a6e71d3cf4
Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490
Change-Id: Ia3d62df5f0585c84c18cb8eed34e87144113954e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-05-05 23:30:54 +00:00
63cf4d07a8
Updating SurfaceTransactionApplier to handle view not being attached
...
Bug: 278833389
Test: Presubmit
Flag: N/A
Change-Id: I88c240a1a7bdfe2e68c858c30e91cc5d06bc7bcf
2023-05-05 15:57:42 -07:00
Treehugger Robot
Jagrut Desai
Sunny Goyal
Fengjiang Li
Schneider Victor-tulias
Vinit Nayak
Liran Binyamin
Winson Chung
TreeHugger Robot
Lucas Silva
Mady Mellor
Brian Isganitis
Saumya Prakash