TreeHugger Robot
abbb482160
Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352
Change-Id: I7abe815c7ca7801d7172663ff8370a84ff8cc973
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-04 02:00:37 +00:00
TreeHugger Robot
c012085c6c
Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev
2022-06-04 01:38:29 +00:00
Tony Wickham
8d72018a87
Don't allow swiping to HintState if we're already in HintState
...
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
fast enough to commit before letting go; this cancels the state
animation, returning towards Normal (but, crucially, StateManager
still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
but this time faster/farther to actually reach Hint; this time, the
animation does go towards Hint, but gets stuck there. The reason it
gets stuck is because StateManager thinks we're already in Hint from
step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
rely on to return to Normal.
The simple fix is to prevent the second swipe in the first place.
Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Winson Chung
9f5d1568bc
Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308
Change-Id: I8afff3488f55a2bd94b1d6adbf412aab9a63cf2c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-01 22:23:34 +00:00
Winson Chung
238f380853
Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev
2022-06-01 22:06:48 +00:00
Luca Zuccarini
f518ba7289
Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230
Change-Id: I3369902633ced33389b31f04916222cfe714c7d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-06-01 09:53:14 +00:00
Winson Chung
7ca87c785a
Ignore pinned tasks for purposes of gesture nav
...
Bug: 234170890
Test: Enter content pip, swipe up and see if a duplicate stub taskview
is created
Change-Id: I62a994749fcaeff48901410ede26b848fa15b830
2022-05-31 23:32:26 +00:00
Luca Zuccarini
a36af25ab7
Remove workspace fade from ALL_APPS > NORMAL transition.
...
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.
Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
TreeHugger Robot
6f1e20041f
Merge "Use DeviceProfile.widthPx to initialize Taskbar touchableRegion" into tm-dev am: 192b3c3118
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18634727
Change-Id: I1fc2475e6102d2cbc0c64a29989ae5e73faeef5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-27 23:33:36 +00:00
Brian Isganitis
e59a175c66
Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev am: deaf8985f6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18618746
Change-Id: Iee264fcac7409d83676907f48bd5ee641ba966ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-27 17:57:11 +00:00
Alex Chau
4eebbac3b7
Use DeviceProfile.widthPx to initialize Taskbar touchableRegion
...
- TaskbarDraglayer.width isn't initialize when Taskbar is recreated before layout, so use DeviceProfile.widthPx instead
- Also listen for DeviceProfile change in TaskbarInsetsController to update Taskbar touchableRegion
Fix: 233316713
Test: Switch to 3 button, nav button works. Swtich to gesture nav, taskbar icon can be tapped
Test: Rotate deice, whole Taskbar should still be touchable
Change-Id: I29ff86fd8616a620f98d9b5438cc586bd69fac33
2022-05-27 18:35:26 +01:00
Brian Isganitis
deaf8985f6
Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev
2022-05-27 17:25:16 +00:00
Vinit Nayak
fa886a3edf
Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508
Change-Id: I1cd0d663d6183ff28a30993e4bc8c84688e055e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-27 03:11:02 +00:00
Vinit Nayak
e8a4e0e2dc
Merge "Limit starting bounds of swipe to animation start rect" into tm-dev
2022-05-27 02:52:36 +00:00
Andy Wickham
2348a0bf9b
Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827
Change-Id: Ic346d0af6df90c570ce1c718622981feb3ac792e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-26 21:59:43 +00:00
Vinit Nayak
f7b4e7f497
Limit starting bounds of swipe to animation start rect
...
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12
Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.
Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham
4ca247a6bb
Merge "Moves Search results into a separate RV (take 2)." into tm-dev
2022-05-26 21:41:55 +00:00
Brian Isganitis
afd72f0726
Have separate DeviceProfile instances for taskbar and all apps windows.
...
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.
Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7 )
2022-05-26 17:21:50 +00:00
Alex Chau
516f9cab61
Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev am: 56e367b744
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18598420
Change-Id: I34d8c855f8b7ab140bba18fcd532dc86d08502a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-26 15:06:49 +00:00
Alex Chau
56e367b744
Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev
2022-05-26 09:24:23 +00:00
Sunny Goyal
33a58f248e
Merge "Creating the transaction on the UI thread" into tm-dev am: 279911fafc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18591002
Change-Id: Ic51cc1a24c0b1818d7731a89c8ae091aa788e923
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 22:43:32 +00:00
Sunny Goyal
279911fafc
Merge "Creating the transaction on the UI thread" into tm-dev
2022-05-25 22:24:04 +00:00
Schneider Victor-tulias
101d7e9699
Merge "Add screen recording to drag to splitscreen taskbar tests to help with debugging." into tm-dev am: 467f30dbb7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18529596
Change-Id: Iddfa42484bf629568ba56c056d861582f7ecffa7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 21:23:25 +00:00
Schneider Victor-tulias
467f30dbb7
Merge "Add screen recording to drag to splitscreen taskbar tests to help with debugging." into tm-dev
2022-05-25 21:03:04 +00:00
TreeHugger Robot
63a50b8151
Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev am: 9557b10c59
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18400686
Change-Id: I896b77a28054e89f1f8fce7a2002ce8d275d50c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-25 19:21:49 +00:00
TreeHugger Robot
9557b10c59
Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev
2022-05-25 18:48:17 +00:00
Bill Yi
e965dfe6eb
Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev
2022-05-25 18:43:37 +00:00
Schneider Victor-tulias
3efef1ce5a
Attempt to preload the Launcher activity when the user reaches the All Set Page.
...
Preloading the Launcher activity once the user reaches the SUW All Set app allows for a smoother first reveal transition. Refactored TIS and TISBinder to make this possible.
Fixes: 226726244
Test: factory reset and flashed a build onto a pixel 6 pro
Change-Id: I1be3383bafdde17b951329de4c7d6b87affd210c
2022-05-25 10:02:20 -07:00
Alex Chau
e2e1509d55
Fix taskbar icon flicker and jump when transforming to hotseat
...
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization
Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869 )
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
Sunny Goyal
cdc111a158
Creating the transaction on the UI thread
...
This avoids the error when the transaction is created after
the surface is released. In case the surface is released after
transaction object is created, the apply() call simply ignores
that error, whereas previously the transactionCreation will throw
an error
Bug: 231889963
Test: Verified by manually releasing the surface that there is no crash
Change-Id: I9a4b9ca0be2ed687b2fc692570415256e3e479f7
2022-05-24 17:14:44 -07:00
Andy Wickham
2ba7797edb
Moves Search results into a separate RV (take 2).
...
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.
Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Bill Yi
dbaeaa5c05
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I8dab647a81e5f333a8c4d9ad5dbe13247429f7c1
2022-05-24 14:49:54 -07:00
Sunny Goyal
006bcf6db1
Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev am: 689b000316
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18561212
Change-Id: Ic7aedab14ad446dd045c79ed96f643a421466c04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-24 21:38:34 +00:00
Schneider Victor-tulias
aa5ae621c5
Add screen recording to drag to splitscreen taskbar tests to help with debugging.
...
Test: presubmit and local
Bug: 231615831
Change-Id: I87ea5eb30eaf9ec1f4f96572c78bc9daf976a589
2022-05-24 11:46:31 -07:00
Sunny Goyal
617f9fae3d
Avoiding updating task via scroll if RectF spring animation is running
...
Bug: 231333965
Test: Verified no update at the end of home transition
Change-Id: I2a106f4d7661f9d409425ce2ed755e74e1abe14b
2022-05-23 10:13:10 -07:00
Winson Chung
f7ada158ef
Merge "Ensure that we're animating the current live tasks when going back" into tm-dev am: 3e6cd99990
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18461390
Change-Id: Ifb3c795a3177bbafe3fe8255374dd3a13a2060f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-19 07:55:11 +00:00
Luca Zuccarini
e10218b6ac
Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev am: 175fc66aa8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18375247
Change-Id: Ie75c4dfc9fcfa8bf4a69dad41b8b9f46620638d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-18 22:07:08 +00:00
TreeHugger Robot
c44c8e8a11
Merge "Fix crash if AM returns empty task list" into tm-dev am: aca91898a8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18379858
Change-Id: I36cf573d13b58f7f4817ae1520bd620b513573fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-18 22:06:51 +00:00
Luca Zuccarini
70f5407ca7
Merge "Update the NORMAL<->ALL_APPS swipe transitions on phones." into tm-dev am: 3eb149b055
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18185506
Change-Id: Iad1d2b6eda5ba54c1677f1d68622770f47953dd0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-18 20:25:06 +00:00
Vinit Nayak
1d95882e6b
Merge "Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar" into tm-dev am: cfdb076d12
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18286602
Change-Id: I011cd81699226731080ca7d613d7923a4bfa8f00
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-18 20:24:50 +00:00
TreeHugger Robot
a90484e322
Merge "Revert "Snap to last task if swiping down at a greater Y than X velocity."" into tm-dev am: a3ce2fc552
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420831
Change-Id: I9e7fb39184c5028cab70fe97feaa0d4179015eed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-18 20:24:41 +00:00
Sunny Goyal
f7ef2d481d
Merge "Fixing transaction applier holding on to the release check if no frame update was scheduled" into tm-dev am: 6956b5cc7c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18360436
Change-Id: I658ceb421f7b1c4d4c65aab22bb2acc4f1cc8179
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-18 20:24:00 +00:00
TreeHugger Robot
049ce2342a
Merge "Clear recents animation controllers and recents animation snapshots synchronously." into tm-dev am: 6ac4f9e882
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18243102
Change-Id: I87a2d19abbd69bd6f090c23a418de7242faf918f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-05-18 20:23:52 +00:00
Winson Chung
b6fa2ce486
Ensure that we're animating the current live tasks when going back
...
- The other call to launch tasks animated doesn't work for the current
task you swiped from when in split.
http://recall/-/g6hkB0pXjyQSvfA8STqRAT/bKHWGjhf2yQVpmRkvn3aeD
Bug: 223750399
Test: Enter overview, swipe back
Test: Enter overview from split, swipe back
Change-Id: Icbe2944df2bb382e072c2890001d7eae505a7b04
2022-05-18 18:46:54 +00:00
TreeHugger Robot
93af9c37c7
Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev
2022-05-18 14:56:12 +00:00
Luca Zuccarini
175fc66aa8
Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev
2022-05-18 14:21:27 +00:00
TreeHugger Robot
aca91898a8
Merge "Fix crash if AM returns empty task list" into tm-dev
2022-05-17 23:26:17 +00:00
Sunny Goyal
8b5be54b47
Fix crash if AM returns empty task list
...
Bug: 231630259
Test: Verified on device
Change-Id: I15a48def7f7a7715adbbff94e29e889da100551e
2022-05-17 11:11:45 -07:00
Luca Zuccarini
3eb149b055
Merge "Update the NORMAL<->ALL_APPS swipe transitions on phones." into tm-dev
2022-05-17 16:06:27 +00:00
Vinit Nayak
cfdb076d12
Merge "Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar" into tm-dev
2022-05-17 13:56:51 +00:00