PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
65,237 Commits 1 Branch 0 Tags
f293c432011aef48a13502ec6b8f7e7b732cf0fa
Commit Graph

15659 Commits

Author SHA1 Message Date
Jeremy Sim fb7fda5816 Merge "Add unit tests for SplitSelectDataHolder" into udc-qpr-dev am: 3ce64d592b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23924739

Change-Id: Ibe56fe7e0d46856914e62fbb6355df6aa0b7ab04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-14 18:39:39 +00:00
Jeremy Sim a8690f5eb6 Add unit tests for SplitSelectDataHolder 
This CL adds unit tests for the SplitSelectDataHolder class.

Fixes: 288318661
Test: None
Change-Id: Ia09b928be1c73dcf8a198ea5ece16f0557fb5b0d
 2023-07-13 15:28:04 -07:00
Anushree Ganjam 84744648e8 Merge "Introduce Default Ime height." into udc-qpr-dev am: e1a4eb4a09 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23595397

Change-Id: I835dac8a27e4dea2b2fa5f12ee34b29086804430
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-13 07:16:25 +00:00
Tracy Zhou 033ac58343 Merge "Introduce multi finger trackpad gestures to tapl tests" into udc-qpr-dev am: 666c3b231d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23895346

Change-Id: Ib4732c4f6e117f378132e6c8e06eea29e7e2db5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-13 07:15:56 +00:00
Anushree Ganjam e1a4eb4a09 Merge "Introduce Default Ime height." into udc-qpr-dev 2023-07-13 06:23:28 +00:00
Tracy Zhou 666c3b231d Merge "Introduce multi finger trackpad gestures to tapl tests" into udc-qpr-dev 2023-07-13 06:11:26 +00:00
Tracy Zhou db476c3921 Introduce multi finger trackpad gestures to tapl tests 
- Add tests to go to overview from home and all apps

Bug: 281732733
Test: presubmit
Change-Id: Ief6d72d7293ca7dff935e764362aa5ab271fd36b
 2023-07-12 19:52:04 -07:00
Mady Mellor bdbbe554a1 Merge "Revert "Bubble bar drag to dismiss"" into udc-qpr-dev am: d76c9cbcd7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24046705

Change-Id: I6cd89728b7dd285536234fb7664d8618739c7db0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-13 02:30:02 +00:00
Mady Mellor d76c9cbcd7 Merge "Revert "Bubble bar drag to dismiss"" into udc-qpr-dev 2023-07-13 01:38:05 +00:00
Winson Chung af4b8c6312 Merge "Remove legacy unused proto tracing code to prevent confusion" into udc-qpr-dev am: 7d58acf943 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23987649

Change-Id: I4488871ff653fbfa31015dfa624e156c8d6e64c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 23:57:16 +00:00
Winson Chung 7d58acf943 Merge "Remove legacy unused proto tracing code to prevent confusion" into udc-qpr-dev 2023-07-12 23:50:53 +00:00
Mady Mellor e7cc3997d0 Revert "Bubble bar drag to dismiss" 
Revert submission 23879277-bubble_bar_dismiss

Reason for revert: issues with touch

Reverted changes: /q/submissionid:23879277-bubble_bar_dismiss

Change-Id: I4311abff0e542907b09b0aa865d68257b47f6af1
 2023-07-12 22:27:17 +00:00
Vinit Nayak 052785e1ab Merge "Allow pressing home button on recents if command queue not empty" into udc-qpr-dev am: cf6b71a14e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23922250

Change-Id: I637343cd86a7eebd3ff3635e6375e9ccb76c97fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 21:10:09 +00:00
Vinit Nayak 84d1dc400d Merge "Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag" into udc-qpr-dev am: f909a72f3f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030568

Change-Id: I98d975410dfe4bb8ec6ccba94fde4bf4b27d59a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 21:09:01 +00:00
Vinit Nayak cf6b71a14e Merge "Allow pressing home button on recents if command queue not empty" into udc-qpr-dev 2023-07-12 20:58:59 +00:00
Vinit Nayak f909a72f3f Merge "Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag" into udc-qpr-dev 2023-07-12 20:57:22 +00:00
Fengjiang Li 340afb8d12 Merge "Recreate hotseat predictor whenever we query it due to workspace change" into udc-qpr-dev am: 30b9bc7587 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23987658

Change-Id: I73ddd5b7b1f77f3312bc0840996b383ed5570232
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 20:48:13 +00:00
Liran Binyamin 6bd839f383 Merge "Check that the bubble bar has bubbles before showing it" into udc-qpr-dev am: d0121222a5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024256

Change-Id: Id5be73c1a93b5c8e047993c46f25d302fd31b384
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 20:46:47 +00:00
Fengjiang Li 30b9bc7587 Merge "Recreate hotseat predictor whenever we query it due to workspace change" into udc-qpr-dev 2023-07-12 20:12:06 +00:00
Liran Binyamin d0121222a5 Merge "Check that the bubble bar has bubbles before showing it" into udc-qpr-dev 2023-07-12 19:58:16 +00:00
Ivan Tkachenko e4e39296ec Merge "Bubble bar drag to dismiss" into udc-qpr-dev am: e3d4a69749 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23879277

Change-Id: I82bd9a7499ddd73b9df80106a943a534690c3164
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 17:43:23 +00:00
Anushree Ganjam 5730f03c9f Introduce Default Ime height. 
Assume IME_DEFAULT_HEIGHT_DP = 300.
When ime is yet to be shown but the UI is ready, then use
IME_DEFAULT_HEIGHT_DP.

For the 2nd time onwards save the actual ime height and use it when the
keyboard is not shown yet.

Bug: 285166099
Test: Manual
Change-Id: I33e38cbd5c2910f4a6dc4cc83c8dc4b6d94fbcff
 2023-07-12 17:21:40 +00:00
Ivan Tkachenko e3d4a69749 Merge "Bubble bar drag to dismiss" into udc-qpr-dev 2023-07-12 17:13:50 +00:00
Fengjiang Li ff15fbffec Recreate hotseat predictor whenever we query it due to workspace change 
Fix: b/289013842
Test: unit test, also verified moving icons will recreate hotseat predictor
Change-Id: I1f19b17654b87156132a4e4dee26e12312589dba
 2023-07-12 10:11:12 -07:00
Liran Binyamin 1d7494b4a5 Check that the bubble bar has bubbles before showing it 
ag/24024252 relied on the bubble bar being invisible to indicate that
the bar is empty. But that assumption was wrong. The bubble bar gets
hidden when the device is locked. The result is that unlocking the
device leaves the bubble bar stashed.

This change actually verifies whether the bubble bar is empty before
showing it.

Fixes: 290608658
Test: Manual:
      - Have some bubbles in the bar
      - Lock the device and unlock
      - Observe that the bubble bar is unstashed
Change-Id: I4ca5c10e0cec57d3c6b4e056e06ebcf04aa1571a
 2023-07-12 12:36:25 -04:00
Liran Binyamin d93bb84d9d Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev am: 7dd280eef3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024252

Change-Id: I7c6a545a1fc71ccbb74d97f702a6a9bc04852ac0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 15:34:12 +00:00
Liran Binyamin 7dd280eef3 Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev 2023-07-12 15:09:21 +00:00
Liran Binyamin f8fcd3c9a6 Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev am: 2c1e84b3a1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24012984

Change-Id: Id2ca1b1de161e71bea2978e3231f4f1bba2cc22a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 14:55:22 +00:00
Liran Binyamin 2c1e84b3a1 Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev 2023-07-12 14:41:32 +00:00
Ivan Tkachenko eceb797d2f Bubble bar drag to dismiss 
* Added dismiss view to the taskbar
* Bubble drag to dismiss of:
  * A single bubble when the bubble bar stack is expanded
  * All bubbles when the bubble bar stack is colapsed
* Added dismiss related calls to WMShell in SystemUI through SystemUIProxy

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: Ibb62a0b1ab9fafa8a3acf07450ce2132ed605adc
 2023-07-12 07:13:12 +01:00
Mady Mellor 1bbcc8a90d Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev am: db3cdd4e97 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010039

Change-Id: Ic0e5a9ce061e1bc892a021c09153572e0c7b164d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 01:17:28 +00:00
Mady Mellor 36eb8b089d Handle any image / label changes for bubble updates in bubble bar am: 1812924a53 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010038

Change-Id: Ib7d204f2bd06f8474613b134d25e9ff08e32c74d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-12 01:17:25 +00:00
Mady Mellor db3cdd4e97 Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev 
* changes:
  Show / hide the "update" dot on bubbles in bubble bar
  Handle any image / label changes for bubble updates in bubble bar
 2023-07-12 01:00:10 +00:00
Vinit Nayak 46b2beea26 Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag 
Fixes: 270393906
Flag: none
Test: Compiles
Change-Id: I1431f544b26cef5cd417c9a5a97f183b49fe7adc
 2023-07-11 17:05:17 -07:00
Vinit Nayak d9fd3f2e58 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev am: 64f3766ba7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23986000

Change-Id: I6728ffc217017fad591b0ada439b4587197d6352
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-11 23:28:35 +00:00
Vinit Nayak 64f3766ba7 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev 2023-07-11 23:06:47 +00:00
Mady Mellor c299ad645a Show / hide the "update" dot on bubbles in bubble bar 
Updates BubbleView to include logic to render the update dot on a
bubble. This only shows for BubbleBarBubbles, not the overflow.

We only show the dot (and the badge) when:
- the bubble has new content / appropriate flags set
- AND the bubbles are expanded
  OR on the first bubble when bubbles are collapsed
- AND when the flyout is not animating (this bit doesn't exist yet)

If a bubble has a dot and is opened, the dot will animate away.
To do this, we update the flags set on a bubble.

The flag needs to be set on WMShell side as well as Launcher side.
When a bubble is shown by WMShell, it automatically updates the flag.
This CL adds code to update the flag on Launcher side when we call
into WMShell to show the bubble.

Test: manual
Bug: 269670235
Change-Id: I32f652effa9a73c567981aa5a2a5864e9c3c0c66
 2023-07-11 15:09:29 -07:00
Liran Binyamin 05ef774e6e Don't show the bubble bar when it is empty 
Sometimes the bubble bar shows when the launcher process starts up
even when there are no bubbles.

bubblesShowingOnHome is set to true when the launcher transitions into
Home, but that state also triggers a call to showBubbleBar() which will
eventually set the visibility on the bar.
During initialization we also call setHiddenForNoBubbles to hide the bubble
bar if it's empty, but these events happen separately so the bar may or
may not be hidden.

This change avoids calling showBubbleBar when setBubblesShowingOnHome is
called and the bar is invisible. Instead the bubble bar will become visible
once bubbles are added.

Fixes: 290608658
Test: manual
       - Toggle bubbles off and back on in settings
       - Restart launcher
       - Observe the bubble bar is not displayed
Change-Id: I30640764d7b6eae64e1c5b5c687760465bf9a7b1
 2023-07-11 17:12:00 -04:00
Liran Binyamin 1c03ed001d Pass bubble bar offsets instead of position to WMShell 
This allows WMShell to calculate the position of the expanded view
correctly when the bubble bar is being expanded from stashed.

Test: See ag/24012908
Change-Id: I7b917e761c827135942d918917c920b06650f496
 2023-07-11 17:08:09 -04:00
Mady Mellor 1812924a53 Handle any image / label changes for bubble updates in bubble bar 
When we get an update to a bubble it could mean that there's a new
message OR that something about the visual representation changed.

This CL modifies BubbleBarController to handle any visual changes
that might have occurred to an updated bubble (e.g. bubble image
changed).

It does this by updating the bubbleInfo on the existing bubble.

Test: manual
Bug: 269670235
Change-Id: I03d2510aef335dafccb32d6adcd4c6adf8b3297d
 2023-07-11 13:34:46 -07:00
Mady Mellor ecf080eb5c Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev am: 3e952e034c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24010037

Change-Id: Id9470422fa6e14e59432ef859cde823b3f588aa7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-11 20:28:39 +00:00
Brian Isganitis 8d3ea8eeb5 Merge "Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""" into udc-qpr-dev am: 1a50287c08 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24024243

Change-Id: I3a0e4e72548414078c673742ff1d3768cffc94ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-11 20:28:15 +00:00
Mady Mellor 3e952e034c Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev 2023-07-11 20:24:14 +00:00
Brian Isganitis f54c6fa4b4 Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" 
This reverts commit 853a5b9e0c.

Fixes SecondaryDisplayLauncher class by using lambda instead of method
reference for #getAllAppsItemLongClickListener. This change is necessary
because mDragLayer is late-init.

Test: Home Settings > Developer Options > Launch Secondary Display
Bug: 289261756
Flag: No
Change-Id: I7b83f81651dde360edea6ee7bea6cc82441e6bef
 2023-07-11 13:21:47 -04:00
David Saff 20d1f741b9 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev am: aaf3094540 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24017969

Change-Id: I1048ccfe13a8b888d5c3dd6384cb801623e1c7e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-11 13:12:21 +00:00
David Saff aaf3094540 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev 2023-07-11 12:32:36 +00:00
David Saff 853a5b9e0c Revert "Provide AllApps item OnLongClickListener through ActivityContext." 
This reverts commit 0acab2532d.

Reason for revert: b/290403189

Change-Id: Ie3f67f78a8ffce8c2d5a92f65a7e74d788c82a81
 2023-07-11 10:45:33 +00:00
Mady Mellor 4e0ec1e458 Unify calls to sysuiProxy#showBubble into one method 
This will make it easier to note that a bubble has been "visited"
so that we can hide the update dot (coming in future CL).

Test: manual
Bug: 269670235
Change-Id: Ie2dbbc478198ece65c05927295d3c3031a7be82e
 2023-07-10 13:38:15 -07:00
Vinit Nayak f6c2e87747 Dismiss split select when tapping on home button 
Bug: 276361926
Test: Initate split, dismiss whenever home is pressed,
doesn't dismiss when all apps dragged down
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Idc95123e27963c3913d04c6eb27f0e4c9b1eb401
 2023-07-10 11:06:42 -07:00
Tracy Zhou 35fd1517bc Merge "Fix icon not showing in staged split from keyboard shortcut" into udc-qpr-dev am: 10b5a3903a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23996760

Change-Id: Iceb6e903bd2c83a87b8ebe5289ed4fbfcb324fc6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-10 17:48:09 +00:00