Brandon Dayauon and Android (Google) Code Review
c1c1c873b9
Merge changes from topic "fastScrollerPrivateSpaceDrawableToLetters" into main
...
* changes:
Update letter list textview background color to spec.
Remove color animations when scrolling.
2024-10-18 23:07:09 +00:00
Sunny Goyal and Android (Google) Code Review
4eaf3df1fe
Merge "Moving PluginManager to dagger" into main
2024-10-17 21:47:28 +00:00
Sunny Goyal
9cd3154952
Moving PluginManager to dagger
...
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread
Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Bill Yi
fbe5044c4e
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I5e1473aede364901d9b4da42154df8c7c5f90ad5
2024-10-16 18:09:30 -07:00
Brandon Dayauon
7e1149471a
Update letter list textview background color to spec.
...
Spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2746-180205&node-type=frame&m=dev
bug: 358673724
Test: manually - photo: https://drive.google.com/file/d/1RWlaSRHbXCYhsY1F3nzruldQnABszUiz/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: I03cd4fbf1e76a7ad34983ace18a69a52116e7834
2024-10-15 15:01:25 -07:00
Treehugger Robot and Android (Google) Code Review
9777937d41
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-10-12 22:24:21 +00:00
Brandon Dayauon and Android (Google) Code Review
7e1ca3965b
Merge changes from topic "fastScrollerPrivateSpaceDrawableToLetters" into main
...
* changes:
Add spannedDrawable for the divider in the letter fastScroller.
Only have private space drawable section for beginning of private space section and keep letters for everything else.
2024-10-11 22:33:53 +00:00
Brandon Dayauon
c9ac51c521
Add spannedDrawable for the divider in the letter fastScroller.
...
Divider exported from: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2751-194737&node-type=frame&m=dev
bug:358673724
Test photo: https://drive.google.com/file/d/1I_Mu7mjxboP3puAJuiA9X9V3ogFR0oin/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: Ica5f05befbd63dc93b9c50bbbd6821cd931d148b
2024-10-10 16:31:41 -07:00
Brandon Dayauon
9d60a18c5c
Only have private space drawable section for beginning of private space section and keep letters for everything else.
...
spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2746-180205&node-type=frame&m=dev
As of recent request: Only using the bubble background for everything and have private space go back to using letters.
Will include divider in followup.
bug:358673724
Test photo: https://drive.google.com/file/d/1dC3fgfWiumhyLm4vI-VfnXIYQyjPyrnk/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: I30487581eec4bd3e1921de4e3d899cfe2e2a703f
2024-10-10 16:31:39 -07:00
Bill Yi
d08761ed7e
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I45e6541b3e3a0776ad8ed5fbefc888a820a0e94c
2024-10-10 14:27:50 -07:00
Treehugger Robot and Android (Google) Code Review
1160d080f4
Merge "Fix cropped folder name text in arabic" into main
2024-10-09 19:35:13 +00:00
Bill Yi
3aa92f27c1
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ib747fa4d2a253f79f1aa07f59e9484be4876a2f6
2024-10-07 13:40:14 -07:00
Liam Lee Pong Lam and Android (Google) Code Review
644aad280b
Merge "Implement focus state on personal/work tab button" into main
2024-10-04 20:33:00 +00:00
Shamali P
adc171b313
Move padding from parent to WidgetPagedView and siblings in 2-pane pkr
...
WidgetPagedView seems to rely on padding to position it such that
talkback doesn't focus on it before sticky header.
Bug: 348107507
Test: With talkback
Flag: EXEMPT bugfix
Change-Id: I2fcdc0cbf027a7a8c1bee104f85a61f700faf776
2024-10-02 16:55:59 +00:00
Bill Yi
9e196da120
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Id0277715e43f68ca608c9ecf9629a5aa0c31d6fa
2024-10-01 10:28:37 -07:00
Treehugger Robot and Android (Google) Code Review
49e27e5257
Merge "Make widget sheet layout container not focusable" into main
2024-09-30 22:44:28 +00:00
Bill Yi
dfbe78fc07
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Iece37a3f71514301080854e669827f80721f103a
2024-09-26 19:16:07 -07:00
Toni Barzic
2c72b9bd1a
Fix cropped folder name text in arabic
...
Centralize the folder name within folder footer using gravity property
instead of adding padding to the folder name view. Padding as calculated
was cropping the folder name to the text line height, which was
insuficient in some cases, as eveidenced by the linked bug.
Bug: b/358006967
Test: Open a folder on home screen with arabic system language.
Verify that the folder name displays correctly.
Flag: EXEMPT bugfix
Change-Id: I4436c224f7f6541f447e3a5354ff870cf4d50698
2024-09-26 04:57:45 +00:00
Liam, Lee Pong Lam
d4488bfd72
Implement focus state on personal/work tab button
...
figma: https://www.figma.com/design/ccBEWEnusF6lE4edgCw7bG/Android-Interactions-Library?node-id=6315-109525&node-type=frame&t=SBKtwrMnJ0ppeUxa-0
result: https://photos.app.goo.gl/LEWF6tsKz3BXXWuv5
hsv: https://hsv.googleplex.com/4794951907934208
Bug: 327430110
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Ia953c92f30cbd65a83f8e60e8bb2d4b17073b369
2024-09-25 20:34:49 +00:00
Bill Yi
a49603e5ad
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ib3293ab1b3861b89e85944d3fd5e43a7a905cf61
2024-09-23 21:58:49 -07:00
Saumya Prakash and Android (Google) Code Review
4cf02b8538
Merge "Add "New Window" option to Taskbar menu." into main
2024-09-20 18:20:36 +00:00
Bill Yi and Android (Google) Code Review
8ad0e6b80a
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-09-20 03:31:40 +00:00
Saumya Prakash
8e0ed4b01b
Add "New Window" option to Taskbar menu.
...
This change adds a new menu option to Taskbar that is invoked when long
pressing an icon. It createds a new instance for an app if the app
supports multi instance in Desktop Mode.
Bug: 315344726
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ibc42fbb1ad485496cd938af730b86e051cea559a
2024-09-19 21:30:43 +00:00
Bill Yi
d424c551ba
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I40d81f3ac8072f5a709c77b154bbf2797e1d9865
2024-09-18 20:44:38 -07:00
Sunny Goyal
2a359916ca
Moving some utility class to IconCache to make it easier to use outside Launcher
...
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I7583ae162b652e73a33f1aee76714e292b707e39
2024-09-18 10:05:05 -07:00
Sunny Goyal and Android (Google) Code Review
e14032d578
Merge "Cleaning up some enabled features" into main
2024-09-17 03:22:23 +00:00
Sunny Goyal
4f9ba255a4
Cleaning up some enabled features
...
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
ENABLE_DEVICE_SEARCH
ENABLE_HIDE_HEADER
ENABLE_TWOLINE_ALLAPPS
IME_STICKY_SNACKBAR_EDU
FOLDER_NAME_MAJORITY_RANKING
SCROLL_TOP_TO_RESET
ENABLE_SEARCH_UNINSTALLED_APPS
ENABLE_HOME_TRANSITION_LISTENER
Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Bill Yi
6f8075222b
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ifc2d4959dd29cf6abf0268d6d86bbfd2e574f20b
2024-09-13 12:00:01 -07:00
Toni Barzic
667fe050ff
Make widget sheet layout container not focusable
...
SpringRelativeLayout views in widgets sheets UI are non-actionable
containers, and as such they would ideally not receive focus. They were
made focusable as a workaround for an issue where back action was no-op
when widget search text box was focused, and there were no other
focusable elements in the UI b/197129170.
WidgetSearchBarController handles back action by clearing
focus, which ends up refocusing the search text box. This CL, removes
this back action override, and let's back action through - it will end
up being handled by `WidgetsFullSheet.onBackInvoked` which resets the
search.
Bug: 365120544
Test: Manual - verified back action with widget search active (and in
case with no results) in emulator
Flag: EXEMPT bugfix
Change-Id: I1fed37372521947b7d4644047807dc451b0119a4
2024-09-11 18:50:56 +00:00
Marcelo Arteiro and Android (Google) Code Review
13d9588f88
Merge "Updates many launcher color to new dynamic tokens" into main
2024-09-04 11:27:16 +00:00
Marcelo Arteiro
c6fca0e16b
Fixes wrong colors in SUW -> AllSet
...
Screenshot: https://screenshot.googleplex.com/6Yy9bQuQqox2rPB.png
Fixes: 355462084
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I92b9839d345ab16f0229b546fb6c0e00ced02671
2024-08-30 12:41:34 +00:00
Charlie Anderson and Android (Google) Code Review
7f4e40c958
Merge "Slightly lower icon shadow insets to avoid accidental shrinking or padding" into main
2024-08-28 11:24:01 +00:00
Treehugger Robot and Android (Google) Code Review
f35a60136f
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-08-28 02:48:37 +00:00
Sunny Goyal and Android (Google) Code Review
3aa9668bef
Merge "Cleanup unused workspacePageIndicator" into main
2024-08-27 23:03:20 +00:00
Charlie Anderson
0c54dbd4a5
Slightly lower icon shadow insets to avoid accidental shrinking or padding
...
Bug: 350758155
Test: locally
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I5d0396c3e4710873ff797a35b97fad7e79a14495
2024-08-27 22:41:42 +00:00
Sunny Goyal
42becd041b
Cleanup unused workspacePageIndicator
...
Fix: 270395278
Flag: NONE removing dead code
Test: verify everything still works the same
Change-Id: Id0eda5c5994c3323a8d16900678fbd7b39911b62
2024-08-27 12:23:21 -07:00
Shamali Patwa and Android (Google) Code Review
94c4dbfbbb
Merge "Reuse widget picker's surface color in add item dialog." into main
2024-08-27 13:55:03 +00:00
Bill Yi
89cf733f24
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: Ibda937ad6b5ad93bbccac97b15f5f0a934a8a7bf
2024-08-27 00:22:17 -07:00
Shamali P
0cac409a60
Reuse widget picker's surface color in add item dialog.
...
In ag/28129361 add item dialog's color was changed to reference
material color token defined in launcher theme. But add item activity
inherits from Theme.Translucent.NoTitleBar for its appearance (while
launcher theme uses deviceDefault.Light), so, cannot inherit as is from
the launcher theme. Since, there is already a token specific for widget
picker surface color imported via widgetTheme, using it so it stays
in sync with main picker.
Bug: 354604590
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I61ed5e65b0efd065490a54251028cde5888e4391
2024-08-26 23:16:25 +00:00
Brandon Dayauon and Android (Google) Code Review
412821fadf
Merge "Create an alpha letter scroller" into main
2024-08-26 20:21:17 +00:00
Brandon Dayauon
1f8f88696b
Create an alpha letter scroller
...
- The function used is a raised cosine function to determine the sections to animate.
Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary
bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Uwais Ashraf and Android (Google) Code Review
37752f5e19
Merge changes I31d9a51e,I1bc14be7 into main
...
* changes:
Prevent requestLayout() when updating drawables that don't change size
Fix splash icon size to 52dp
2024-08-22 09:13:41 +00:00
Uwais Ashraf
f1c14902ca
Fix splash icon size to 52dp
...
Fix: 360804090
Test: presubmits passing, manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I1bc14be7d2d25a985d26709eb59b8aa4887d4764
2024-08-21 15:44:03 +00:00
Treehugger Robot and Android (Google) Code Review
2f79414090
Merge "Import translations. DO NOT MERGE ANYWHERE" into main
2024-08-21 07:56:17 +00:00
Shamali Patwa and Android (Google) Code Review
e4262972cc
Merge changes from topic "sug-a11y" into main
...
* changes:
Adjust tap target of the profile tabs in picker
Focus on first item to match the behavior with widgets list
2024-08-20 21:50:44 +00:00
Shamali P
8c965c67dc
Adjust tap target of the profile tabs in picker
...
Uses insets on background drawable to maintain visual size.
Bug: 360245807
Test: Accessibility scanner
Flag: EXEMPT bugfix
Change-Id: I1fbc7c2c782a1e331dd1ba77b0a3bf8aad277792
2024-08-20 00:42:32 +00:00
Bill Yi
f81a5125f8
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I9e1c3f5d14d60f9c8c37dfcb217ba39ba992ed14
2024-08-19 14:42:43 -07:00
Shuming Hao
f1d0df2867
Remove unused resources for split screen handle
...
Bug: 338079912
Test: Manually
Flag: EXEMPT cleanup
Change-Id: I09c02de82186f2080ce10ee75ecb75f9d7f8859a
2024-08-19 09:54:25 -07:00
Brandon Dayauon and Android (Google) Code Review
36b02ec389
Merge "Set maxLines for private space header to 1." into main
2024-08-15 01:16:06 +00:00
Brandon Dayauon
4f7d4c2975
Set maxLines for private space header to 1.
...
This is an issue for large font/display that in the arabic language will clip the Private text.
bug: 357942579
Test manually: https://drive.google.com/file/d/1FFZpXmfwKlRG7mvmSCtc1dtjwUjuXjfW/view?usp=sharing
Flag: NONE bugix
Change-Id: I22943237e10b502edb6aae6845fbe6027fda1323
2024-08-14 13:47:37 -07:00