Commit Graph

2677 Commits

Author SHA1 Message Date
vadimt 1ac98548a7 resolve merge conflicts of 08776ada1e to ub-launcher3-qt-future-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082
Merged-in: I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082
2019-10-03 20:58:15 +00:00
TreeHugger Robot 4a4755fc70 Merge "Fill in LauncherTarget fields with values extracted from LauncherLogProto.Target." into ub-launcher3-qt-future-dev 2019-10-02 23:09:52 +00:00
Tony Wickham c449a6417d Update all apps fade interpolators for home <-> all app
Previously, predictions faded in quickly but then all apps faded in
linerally over entire rest of the transition. Now, all apps fades in
quickly after reaching the overview threshold where predictions are
opaque.

Also implemented the reverse, so that predictions/all apps content
remain opaque when returning home until reaching the overview threshold
near the bottom, where they fade out as quickly as they faded in.

We do this for 3-button mode as well.

Bug: 141986013
Change-Id: Ia35ab3ac9714e89f754293445a7839e15da5313d
2019-10-02 09:51:51 -07:00
vadimt 7371e4da68 Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
Merged-in: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 19:18:14 +00:00
Tony Wickham c9654eb091 Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
2019-10-01 10:16:26 -07:00
Vadim Tryshev 1430f132f3 Merge "Deprecating LauncherInstrumentation constructor with parameter" into ub-launcher3-qt-qpr1-dev
am: dd079691c1

Change-Id: I7419be6416f26274bf03abfd84eedef20fd6f084
2019-09-27 13:21:46 -07:00
vadimt 2611d79f69 Deprecating LauncherInstrumentation constructor with parameter
Change-Id: I779b4a8fde2db73cced8133f12d1356ad0b8729e
2019-09-27 12:00:09 -07:00
TreeHugger Robot d69327e9c0 Merge "Fix ScrimView caret alignment and ignore touches" into ub-launcher3-qt-future-dev 2019-09-27 00:15:36 +00:00
Samuel Fufa 0316d6cd7a Fix ScrimView caret alignment and ignore touches
Test:Manual
Bug:79868152
Change-Id: Idd5a2b965173b8071697b50aac8760b0d84e469f
2019-09-26 16:30:46 -07:00
Becky Qiu 5ba1fc93c4 Merge "Add OverviewScreenshotActions plugin interface and use it in TaskView." into ub-launcher3-qt-future-dev 2019-09-26 18:17:30 +00:00
Becky Qiu d3f6d72ebf Add OverviewScreenshotActions plugin interface and use it in TaskView.
Bug: 139828243
Change-Id: Idbefc11ef32619dd5eaaa5552088859eb2304e1e
Merged-In: Idbefc11ef32619dd5eaaa5552088859eb2304e1e
2019-09-26 18:05:47 +00:00
vadimt eda5c215b7 Merge "Removing debug tracing for a fixed bug" into ub-launcher3-qt-qpr1-dev
am: b72cd2629c

Change-Id: Id28e20b5fe23c6f6501f3c7a38305f0a306b287a
2019-09-25 12:21:06 -07:00
vadimt 49b64a98ca Removing debug tracing for a fixed bug
Bug: 141275518
Change-Id: I171361d4f797f587b404eed07108224d8ab844f8
2019-09-25 11:26:56 -07:00
Vadim Tryshev ec1ae481d4 Merge "Removing temporary checks that tests are running on AVD" into ub-launcher3-qt-qpr1-dev
am: 6929199c8a

Change-Id: Iaa6200f0371a4deca630194ac8ecfcfc04313750
2019-09-24 18:18:19 -07:00
Vadim Tryshev 6929199c8a Merge "Removing temporary checks that tests are running on AVD" into ub-launcher3-qt-qpr1-dev 2019-09-25 00:56:05 +00:00
vadimt 926e29f8b6 Removing temporary checks that tests are running on AVD
Bug: 136278866
Change-Id: I2b7b63b7745936ea84b7cba599e21d954b682ba5
2019-09-24 17:19:51 -07:00
TreeHugger Robot ffa00614b4 Merge "Move offscreenTranslation calculation to LauncherRecentsView" into ub-launcher3-qt-future-dev 2019-09-24 23:25:46 +00:00
Tony Wickham 8a1ba838f4 Move offscreenTranslation calculation to LauncherRecentsView
Couple of benefits here:
- Doesn't rely on having a measured TaskView, since it already knows how
  to calculate the task size
- Code can be shared (planning to use this for quick switch from home)

Bug:
Change-Id: I517a78506ac95fcc37d9225a074427941d691903
2019-09-24 14:23:26 -07:00
vadimt bba8c98de3 Removing "Failed to get system health diags" message from fallback tests
am: 9b1c168273

Change-Id: I4528370073f0258e5f0276dfb1d71dae9816ddea
2019-09-24 13:13:12 -07:00
vadimt 9b1c168273 Removing "Failed to get system health diags" message from fallback tests
Now getting diags though the test process that has right permissions.

This doesn't fix other failures in fallback tests.

Bug: 141517004
Change-Id: Ibba5f0471a83525a64544c62dbe82ab3e11712cd
Merged-in: Ibba5f0471a83525a64544c62dbe82ab3e11712cd
2019-09-24 19:31:35 +00:00
vadimt 6d5511a42f Merge "Removing debug tracing for flakes that stopped reproing" into ub-launcher3-qt-qpr1-dev
am: 76aadac4e4

Change-Id: I5099741d3502584f7d501d74897944edc3339977
2019-09-23 14:56:04 -07:00
vadimt 5466699f0b Removing debug tracing for flakes that stopped reproing
Bug: 139941530
Bug: 140311911
Change-Id: Idf4c013373e627db92aa96f9207e25336ee039f8
2019-09-23 13:57:32 -07:00
Tony Wickham 521224131e resolve merge conflicts of 5c229885fc to ub-launcher3-qt-future-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.

Change-Id: I41247ff46308b72158731e4a47466533d42e67c6
2019-09-20 16:22:59 -07:00
Tony Wickham 5c229885fc Merge "Don't crash when swiping up if there are no TaskViews" into ub-launcher3-qt-qpr1-dev 2019-09-20 22:44:28 +00:00
Tony Wickham 60bf8c117b Don't crash when swiping up if there are no TaskViews
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.

Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
Merged-In: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
2019-09-20 22:01:18 +00:00
Becky Qiu 4df06903bc Fill in LauncherTarget fields with values extracted from LauncherLogProto.Target.
Test: manual
Bug: 137777105

Log result:
1. Swipe to -1:
  data {
    elapsed_timestamp_nanos: 1372265229686264
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        extension {
          src_target {
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
2. Swipe out of -1:
  data {
    elapsed_timestamp_nanos: 1372368006970305
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        extension {
          src_target {
            page_id: -1
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
3. Launch app from homescreen:
  data {
    elapsed_timestamp_nanos: 1372397640628726
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: HOME
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
            grid_x: 2
            grid_y: 1
          }
          src_target {
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
4. Launch app from hotseat:
  data {
    elapsed_timestamp_nanos: 1372399813031963
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: HOME
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
            grid_x: 2
          }
          src_target {
            container: HOTSEAT
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }
5. Launch app from allapps prediction:
  data {
    elapsed_timestamp_nanos: 1372403080724736
    atom {
      launcher_event {
        action: LAUNCH_APP
        src_state: ALLAPPS
        dst_state: BACKGROUND
        extension {
          src_target {
            item: APP_ICON
          }
          src_target {
            container: PREDICTION
          }
        }
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I981401d06577c15948cfee0062b8a6f8a5594345
2019-09-20 21:26:59 +00:00
vadimt ca939f073c Adding tracing for a lab-only flake.
am: 9f6cde1443

Change-Id: I31ce596847aa1506cefbde711ae6ad6f3e3b777e
2019-09-19 17:25:43 -07:00
vadimt 9f6cde1443 Adding tracing for a lab-only flake.
Bug: 141275518
Change-Id: I95544a55ef13002f696a82e52d54ffb6251d0e39
2019-09-19 16:07:05 -07:00
Shashwat Razdan 0c2a248109 Added AppLaunchEventsPlugin which relays app launch/dismiss events to
all connected plugins.
Listener for this plugin is added in PredictionAppTracker which receives
all app events.

Change-Id: Iec53d20272f6a587f78e3d84666efa4f02cf6962
(cherry picked from commit ae084dafd9)
2019-09-19 05:08:54 +00:00
Tony Wickham cdcfd98c05 Merge "Allow scroll to clear all in 3 button+fallback mode" into ub-launcher3-qt-qpr1-dev
am: 24fb1526e2

Change-Id: I59bf92b05d45c31705166e1211cf02ccbc348383
2019-09-18 08:12:41 -07:00
Tony Wickham 24fb1526e2 Merge "Allow scroll to clear all in 3 button+fallback mode" into ub-launcher3-qt-qpr1-dev 2019-09-18 14:54:20 +00:00
Tony Wickham 0638249b3e Allow scroll to clear all in 3 button+fallback mode
We weren't calling onSwipeUpToRecentsComplete(), which meant we kept the
disallowScrollToClearAll from prepareRecentsUi indefinitely.

Also don't update the icon scale if it is supposed to be scaled down, to
avoid it from scaling up and overlapping with the app window.

Fixes: 141184247
Change-Id: I49406764373e7121e289da7477dcbb58d0b98fd5
2019-09-17 15:10:33 -07:00
Jon Miranda 6f7e9702e3 Support defining X column layout for all apps as a display option.
Bug: 124967099
Change-Id: I7bf576759b3fa4f6ca617fbbd660541c12fd09ac
2019-09-16 16:24:59 -07:00
Tracy Zhou 6b272369e7 Make sure that live tile overlay is added only once.
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.

Test: manual
Fixes: 135864059
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
2019-09-16 20:52:35 +00:00
Tony Wickham 3ff1000632 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev
am: fc520edbc6

Change-Id: I8e5b43a582bd243e21f02b5a83b931f4f277eb95
2019-09-13 14:29:31 -07:00
Sunny Goyal 30d998c625 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev
am: 791dd73217

Change-Id: I1ecde4721df9895b0fb215f36a43d8cb85a392ef
2019-09-12 15:05:48 -07:00
Hyunyoung Song 057059665e When DeviceConfig/FeatureFlag value is different than the previous value, refresh icon cache
am: e17a699618

Change-Id: I5c2e54c069fc03172f471f9655cd8b09b5ac6dce
2019-09-12 15:05:19 -07:00
Tony Wickham fc520edbc6 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev 2019-09-11 23:42:23 +00:00
Tony Wickham 51f2919815 Replace OnGlobalLayoutListener with StateListener to update predictions
Previously we were using OnGlobalLayoutListener, which is only called
when AllAppsContainerView or a child is re-laid out or visibility
changes to or from GONE. Since we no longer relayout when already
scrolled to the top, we need a better hook to check whether all apps has
changed visibility for the purpose of updating predictions.

Bug: 140823188
Change-Id: I7c4a0d94c529eb86b55729c75843c8b0bd673d8c
2019-09-11 14:41:52 -07:00
Sreyas 78010c1958 Refactoring RecentsView to handle non-TaskViews
Change-Id: I0bc28ef670a1dad9a3912ca5360c9bab18afd4b2
2019-09-11 14:07:26 -07:00
TreeHugger Robot 791dd73217 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev 2019-09-11 20:16:19 +00:00
Hyunyoung Song e17a699618 When DeviceConfig/FeatureFlag value is different than the previous
value, refresh icon cache

Bug: 135638690
Bug: 138964490

Test: manually toggled feature flag UI on/off
$ adb shell device_config put launcher APP_SEARCH_IMPROVEMENTS [true|false]
when launcher is in foreground and also when it is in the background

Afterwards, saw if "bank" would show BofA app or not

Change-Id: I98b62bd07b14a225168217d7eb9bfdfc7f74435d
2019-09-11 10:38:14 -07:00
Sunny Goyal 3600fb7777 Adding support for building a "spring like animation" with precomputed values
Bug: 138396187
Change-Id: Idba323090ecd9aca43c01414a32ab3b2e292e73e
2019-09-09 17:21:53 -07:00
Winson Chung 478414a7c3 Merge changes I4532e429,I532645de into ub-launcher3-qt-future-dev
* changes:
  Defer listening on widget host until after the state transition ends
  Migrate to using DefaultDisplay
2019-09-09 21:39:18 +00:00
Miranda Kephart fad2f3734d Merge "Add distance threshold for assistant gesture fling" into ub-launcher3-qt-qpr1-dev
am: 329cc8c53f

Change-Id: Ib1e4040010cf3919163e24971d2a368664bec1db
2019-09-09 14:22:47 -07:00
Tony Wickham 0d37f05a12 Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev
am: d785fc289c

Change-Id: I69738f5d9c1f77195f2f82f963958d3cc741e9af
2019-09-09 14:17:33 -07:00
Vadim Tryshev c698c0cdbb Merge "Adding a test method to get a Launcher object when it becomes non-null" into ub-launcher3-qt-qpr1-dev
am: b34f951e7e

Change-Id: Id63a1df1aef2f35b0f6cdb0f8ab851163c8140c9
2019-09-09 14:17:20 -07:00
Miranda Kephart 329cc8c53f Merge "Add distance threshold for assistant gesture fling" into ub-launcher3-qt-qpr1-dev 2019-09-09 21:02:43 +00:00
Winson Chung ef52876739 Defer listening on widget host until after the state transition ends
Bug: 140246642
Change-Id: I4532e4298f04ff5c6dea04ccda89320995cadb80
2019-09-09 10:24:53 -07:00
Winson Chung 13c1c2cd65 Migrate to using DefaultDisplay
- Remove extra binder calls to get the default display

Bug: 140633033
Change-Id: I532645deac101a6065d90484b87a67b67aa717f5
2019-09-09 10:21:28 -07:00