Commit Graph

96 Commits

Author SHA1 Message Date
Sunny Goyal 8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Uwais Ashraf fe1a9c36b7 Merge "Use script to auto-enable all tests that are currently working" into main 2024-04-09 00:01:05 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Vadim Tryshev 47f192f3be Merge "Restoring the full set of combinations in testDragShortcutToMultipleWorkspaceCells in presubmit" into main 2024-04-08 23:02:42 +00:00
Uwais Ashraf 7a0150d02e Use script to auto-enable all tests that are currently working
Fix: 325088906
Test: presubmits passing, gradle robo run passing locally
Flag: NA
Change-Id: I481bfe9caeb8cc18b3e01ec8b7a58fb0eb36fdaa
2024-04-08 20:59:23 +00:00
Vadim Tryshev 785da8d60a Restoring the full set of combinations in testDragShortcutToMultipleWorkspaceCells in presubmit
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib345c94c79c7dda72283eb03515cd254e31e7c0b
2024-04-01 18:01:54 -07:00
Jeremy Sim 742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Schneider Victor-tulias cbdf4d3eef Merge "Add debug logs for b/321775748" into main 2024-03-25 20:26:43 +00:00
Schneider Victor-tulias d3b014ea91 Add debug logs for b/321775748
Flag: N/A
Bug: 321775748
Test: FallbackRecentsTest
Change-Id: I0dde08c4e6b2942713274d2ae29e52d5504ea25d
2024-03-25 14:24:35 -04:00
Sihua Ma 9b1a028bd4 Revert^2 "Move FastBitmapDrawableTest to Robolectric"
393477ca54

Change-Id: I051d2456c6930336c92ffe4c6101e6dd77a502c0
2024-03-21 21:50:20 +00:00
Priyanka Advani 393477ca54 Revert "Move FastBitmapDrawableTest to Robolectric"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7cb746baffc9bec3315dd324173fd9bde100e4cf
2024-03-21 19:07:50 +00:00
Sihua Ma cc54051d12 Merge "Move FastBitmapDrawableTest to Robolectric" into main 2024-03-21 17:06:45 +00:00
Sunny Goyal 5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Sihua Ma 4ff471c2f0 Move FastBitmapDrawableTest to Robolectric
Flag: N/A
Bug: 297950111
Test: atest Launcher3RoboTests
Change-Id: Icef741a1c19bb494f7b74078ce1e7f52ed55a769
2024-03-19 20:27:29 +00:00
Fengjiang Li 00711e68a5 Merge "Enable predictive back in TAPL tests" into main 2024-03-15 14:52:58 +00:00
Fengjiang Li e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Uwais Ashraf cf70589921 Merge "Enable tests which do not require any modification" into main 2024-03-13 15:42:07 +00:00
Uwais Ashraf 4ee1701fd1 Enable tests which do not require any modification
Fix: 329052420
Flag: NA
Test: Presubmits + :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Change-Id: I27e847c923076e4e978fd7359c9c62745d4f5f0a
2024-03-13 12:27:46 +00:00
Sebastián Franco ad46eb75f4 Revert^4 "Removing all restored backups except one so we don't have old backups"
To prevent the error I introduce the method restorePreviousState().

This reverts commit 1234090589.

Reason for revert: Fixing presubmit breaks

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I63666c29eb91dada4243af019ab0538c40bc0f78
2024-03-12 11:01:26 -07:00
Sebastián Franco 8a5dd1b3cf Merge "Revert^3 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-11 20:17:43 +00:00
Sebastián Franco 1234090589 Revert^3 "Removing all restored backups except one so we don't have old backups"
This reverts commit 4b960d1f11.

Reason for revert: Breaking presubmit, no bug number yet 

Change-Id: I0bafad8bf63fae1d9408b65c6c18c79ab5d40d05
2024-03-11 20:15:24 +00:00
Sebastián Franco 37e9aa2504 Merge "Revert^2 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-11 17:09:21 +00:00
Sebastián Franco 4b960d1f11 Revert^2 "Removing all restored backups except one so we don't have old backups"
This reverts commit 3306fa5325.

Reason for revert: Fixing issue that caused b/328782012

Change-Id: Ib6a1bbfeedf608f5f77ac6be500271e811320f32
2024-03-08 18:53:57 +00:00
Sebastián Franco 3306fa5325 Revert "Removing all restored backups except one so we don't have old backups"
This reverts commit bd43b9344f.

Reason for revert: b/328782012

Change-Id: I1666fbd63d82da06ed8c3d9ce58b5ed6b298618b
2024-03-08 18:42:30 +00:00
Sukesh Ram 73b07daab3 Add logs for TaplAddConfigWidgetTest test
Flag: NONE
Bug: 324419890
Test: Check logs when flake is reproduced
Change-Id: I2fdb1e4f96c8095a387280c79e074ee42eb0010c
2024-03-07 18:53:15 +00:00
Sebastian Franco bd43b9344f Removing all restored backups except one so we don't have old backups
Adding test to make sure this is the case.

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I84c3a92f40598137d5c5c52d34af7583b384122c
2024-03-07 11:23:55 -06:00
Vinit Nayak 91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Uwais Ashraf 9c2f5a4c62 Remove classes related to E2E testing from deviceless test classpath
Fix: 327187136
Flag: NA
Test: gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Test: presubmits passing
Change-Id: I4f05524bdc55d8473f3b5115cc239eb8cc48a856
2024-03-04 13:45:32 +00:00
PODISHETTY KUMAR b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Vinit Nayak 5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Jeremy Sim 8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Vadim Tryshev 0fa523bb32 Merge "Removing logging for verifying internal Launcher state from tests" into main 2024-02-29 19:18:04 +00:00
Jeremy Sim 41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Sukesh Ram 872b9f9a61 Debugging Logs for TaplDragTest#testDragAppIconToMultipleWorkspaceCells
Add logging for TaplDragTest#testDragAppIconToMultipleWorkspaceCells.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326908466
Change-Id: Icb3262d6af66c9b947cb0cc92c1c67556fba315f
2024-02-28 19:28:07 +00:00
Federico Baron 6f7916d647 Merge "Fix TaplOpenCloseAllAppsTest#testAllAppsFromHome" into main 2024-02-28 06:17:13 +00:00
Sukesh Ram 1909570ed3 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I5f08192bb1143c1d23f8884bb207ce69c5830a41
2024-02-28 01:06:14 +00:00
fbaron f1bbcbd743 Fix TaplOpenCloseAllAppsTest#testAllAppsFromHome
Bug: 322228038
Flag: NONE
Test: TaplOpenCloseAllAppsTest#testAllAppsFromHome
Change-Id: I13b31dc16fca02a4e8770aca56e35e8606dd21b3
2024-02-27 16:24:10 -08:00
Treehugger Robot 90182bffc1 Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-02-28 00:02:38 +00:00
Vadim Tryshev dae8b65dea Removing logging for verifying internal Launcher state from tests
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I25afcc30446d429171445f8e1b6033b277166725
2024-02-27 20:23:49 +00:00
Sukesh Ram 41c2a9a900 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I1309e8c1b2ce7b6c06cb520818ef109bbf2f2d23
2024-02-27 19:36:55 +00:00
Fengjiang Li f0c0bb493d Merge "Fix bug where TAPL test is checking test's ApplicationInfo" into main 2024-02-27 18:29:37 +00:00
Helen Cheuk 96fd73ed84 Merge "Stash taskbar when software keyboard is docked" into main 2024-02-27 10:40:07 +00:00
Fengjiang Li 9f86b17c2c Fix bug where TAPL test is checking test's ApplicationInfo
Bug: 326118348
Test: This is the test
Flag: NONE
Change-Id: I7519727366b1ad03a50da07d6d331135fdcb89a4
2024-02-26 19:03:55 -08:00
Vadim Tryshev 0c7fd04a8f Removing verifying internal Launcher state from tests
I’ve never seen a useful failure from these checks, and now I’m seeing a false positive error. That error is fixable by reworking the code, but I think the value of these checks is not worth the effort.

Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: If675dad254fb82a2a842ef3f9054936f38de1cff
2024-02-26 10:44:57 -08:00
Vadim Tryshev 0b32b7a9cb Merge "Add tracing for a bug where current RecentsActivity is null" into main 2024-02-26 18:33:31 +00:00
Jordan Silva 36304fd1c6 Merge "Add function to start a test activity with different name and label" into main 2024-02-26 11:33:51 +00:00
Pat Manning 5aa23d41dd Focus a task by default when using keyboard to go to overview.
Fix: 322898816
Test: TaplTestsQuickstep.java
Flag: None.
Change-Id: I6d4b0ca6593ed2ac7c7d8793954c36e55b5978de
2024-02-23 12:22:06 +00:00
Federico Baron cda8adfad3 Merge "Fix testDragToFolder()" into main 2024-02-23 00:41:55 +00:00
Vadim Tryshev c94b2a7045 Add tracing for a bug where current RecentsActivity is null
Bug: 321775748
Test: presubmit
Flag: N/A
Change-Id: I46fde7a73a3bfe02ed6276b4ac5f3e6c33bda387
2024-02-22 16:19:16 -08:00