Commit Graph

17575 Commits

Author SHA1 Message Date
Helen Cheuk c225b99be2 Merge "Add radius to widget internal focus to fit new focus outline design" into main 2023-12-19 16:59:50 +00:00
Tony Wickham 054d953a0d Merge "Log app launches via taskbar drag and drop" into main 2023-12-19 16:17:21 +00:00
Himanshu Gupta ce2b013d31 Merge "Adding methods to access LauncherApps APIs." into main 2023-12-19 11:27:09 +00:00
helencheuk 1b3b67d004 Add radius to widget internal focus to fit new focus outline design
Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I9b11e8bf21dbb5045586907f0fc13577e236c8e7
2023-12-19 11:27:04 +00:00
Sergey Pinkevich 102e54ba05 Merge "Split tasks in RTL mode" into main 2023-12-19 10:19:02 +00:00
Tony Wickham 1a8cf0a9f6 Log app launches via taskbar drag and drop
- This also goes through the app predictions pipeline to update
  hotseat predictions

Fixes: 316940471
Test: Drag apps to split screen, ensure taskbar predictions update
      (also verify by logging AppPredictor#notifyAppTargetEvent)
Flag: None
Change-Id: I844414ecb56b4e36a2c94d913c1fb37abf056593
2023-12-18 23:30:59 +00:00
Himanshu Gupta 6c25654e84 Adding methods to access LauncherApps APIs.
These methods are added to ApiWrapper class
so that Launcher can acess these APIs.

Bug: 308054233
Test: Presubmit
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Change-Id: Ic2e64b38cc8b0d262d3f6e9614e2b3fceb9d82a0
2023-12-18 19:47:13 +00:00
Charlie Anderson 511421c12f Adds logging for Launcher restore metrics in Launcher and LoaderTask
- Adds flag for indicating when we are loading after a restore, separate from the pending restore flag
- Adds many success/failure scenario metrics when loading and binding items

Flag: ACONFIG enable_launcher_br_metrics DEVELOPMENT
Test: locally verified
Bug: 307527314
Change-Id: I9d2660f6d9d7cd5813072201e96b1a64aec4ea4b
2023-12-18 19:32:02 +00:00
Sergey Pinkevich e0ccb4e618 Split tasks in RTL mode
For `translationX` in RTL (right to left layout) mode we should take into account `secondarySnapshotWidth`, not the primary one.

The same for `translationY` for foldable phone in folded mode

Known issue: there is still a wrong position for overview app icon, but it is not related to the task thumbnail, and will be fixed in a dedicated task
(Screenshot of the issue: https://screenshot.googleplex.com/9GHNWxQ5H6vJPn5)
Known issue task: b/315787393

Bug: 309452423
Flag: NONE
Test: manual

Tablet: https://drive.google.com/file/d/1WGUVcFq0sFTJYsAwcjE6E1SHMRe7_TaV/view?usp=sharing
Foldable phone: https://drive.google.com/file/d/1GvDgYg8R9OEoMSDKZaZVXSlsxh_qS-wW/view?usp=sharing

Change-Id: Iefe7fec586592e6a72c0f3be5933307213d92c7f
2023-12-18 18:41:27 +00:00
Federico Baron a06a171874 Merge "Remove unused flag UNFOLDED_WIDGET_PICKER" into main 2023-12-18 17:57:21 +00:00
Greg Kaiser 486c96be87 Merge "Revert "App Pairs: Implement Overview Actions View button"" into main 2023-12-18 15:15:59 +00:00
Greg Kaiser 45ba84268c Revert "App Pairs: Implement Overview Actions View button"
Revert submission 25143701-app-pairs-action-button

Reason for revert: Causes P0 b/315292030

Reverted changes: /q/submissionid:25143701-app-pairs-action-button

Change-Id: I1fcbb9f333ca29c5db255232dc9475dec465ac81
2023-12-18 14:53:19 +00:00
Jeremy Sim 789414190f Merge "App Pairs: Implement Overview Actions View button" into main 2023-12-18 05:07:36 +00:00
Jeremy Sim e1fcb5390b App Pairs: Implement Overview Actions View button
[App Pairs 6/?]

This patch includes:
- Ability to "save app pair" from Overview Actions
- The actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.

Note: This patch introduces a slight regression (b/315545418) where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Bug: 315545418
Bug: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I0eb1fa9520ba14074ede3480e771b340cf2f6e2c
2023-12-18 02:25:22 +00:00
William Leshner c43435c063 Merge "Handle widget taps in WidgetPickerActivity." into main 2023-12-15 23:20:23 +00:00
fbaron e03af75df4 Remove unused flag UNFOLDED_WIDGET_PICKER
this flag was made long before we actually implemented unfolded two pane picker and by that point we migrated to using aconfig so this flag is not used.

Bug: 301918659
Flag: NONE
Test: NONE
Change-Id: Ibc541826d85ae251337567ae0275e1cd02c7bb43
2023-12-15 14:46:39 -08:00
Federico Baron ff2eec89ea Merge "Stop interrupt to see if it fixes failing tests" into main 2023-12-15 21:26:54 +00:00
fbaron e392955e37 Stop interrupt to see if it fixes failing tests
Bug: 316394228
Test: atest WidgetsListContentEntryTest
Flag: NONE
Change-Id: Iaabbcb0c00040f78ad4d6355fef9bc91f4b66ed7
2023-12-15 11:30:58 -08:00
Helen Cheuk 9c0f738cdb Merge "Add focus outline to launcher" into main 2023-12-15 18:03:36 +00:00
helencheuk b4626f4698 Add focus outline to launcher
Fix: 310953377
Test: TBC
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: Ie395ec74c8a4a13a68539ca7ec6496481d96b860
2023-12-15 16:56:31 +00:00
Catherine Liang 7e3721692c Merge "Fix Launcher preview display size" into main 2023-12-14 21:33:25 +00:00
Catherine Liang b0de412e47 Fix Launcher preview display size
When previewing the Launcher in the Wallpaper Picker for a different
display size than the current screen, the preview no longer adapts to
that screen size.

Flag: ACONFIG com.android.wallpaper.multi_crop_preview_ui_flag DEVELOPMENT
Bug: 316000567
Test: manually verified
Change-Id: Ib10f2c9acec98ed99cadd40a588e2ffdea900ba6
2023-12-14 19:08:39 +00:00
Fengjiang Li e228112c33 Merge "Cancel all apps icons preinflation when device profile has changed" into main 2023-12-14 18:16:30 +00:00
Sebastián Franco d93bb98e02 Merge "Remove ENABLE_NO_LONG_PRESS_DRAG flag." into main 2023-12-14 17:20:45 +00:00
Fengjiang Li b7a5eb9ef4 Merge "Remove duplicated widget host view reinflation on screen rotation" into main 2023-12-14 07:02:17 +00:00
Charlie Anderson 97eedb9570 Merge "fix font-scaling from clipping folder child icons" into main 2023-12-14 03:30:55 +00:00
Fengjiang Li 939ca48bae Cancel all apps icons preinflation when device profile has changed
Bug: 312816372
Test: perinflate large number of App Icons then rotate screen. Verified 1) preinflation runnable is cancelled and 2) no ViewHolder created from this cancelled runnable is added to RecyclerViewPool
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION ENABLED
Change-Id: I1a6110278e1af2b32387ab27273106d30513886f
2023-12-13 15:31:30 -08:00
Anushree Ganjam 8a401e8817 Merge "Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY" into main 2023-12-13 22:57:59 +00:00
Charlie Anderson 797ed83700 Merge "Add wrapper for logging backup & restore metrics from Launcher" into main 2023-12-13 19:33:26 +00:00
Brandon Dayauon 65eecc9352 Merge "Make two line text support only for ENGLISH locale" into main 2023-12-13 19:20:35 +00:00
Tracy Zhou f2643521ec Merge "Introduce taskbar_phone_size" into main 2023-12-13 18:04:04 +00:00
Jagrut Desai 113569f446 Merge "Increasing the LOW_TICK intensity of haptic feedback for taskbar invocation" into main 2023-12-13 16:12:43 +00:00
Tracy Zhou 9ccd5d4257 Introduce taskbar_phone_size
In small screen, we use 48dp for nav bar height, while it's 60dp for task bar.

Bug: 230395757
Test: manual
Change-Id: Ia7083a1b2246981466e1163404c63b645a6bf5b1
2023-12-13 00:38:15 -08:00
Fengjiang Li 09c3c21472 Remove duplicated widget host view reinflation on screen rotation
Don't reinflate from LauncherAppWidgetHostView#onConfigurat#onConfigurationChanged because Launcher activity will rebind app widgets on configuraiton change. This will reduce lock contention to inflate complex widget views and reduce flicker.

Bug: 285279824
Flag: None
Test: Rotate screen and verify widget are rendered correctly
Change-Id: I69abc7f1fe0ca5704ac887142c73b8d245fead4e
2023-12-12 22:41:03 -08:00
Jon Miranda 20fdc7b508 Move taskbar clean up so that it only gets called when user swipes up to go home.
This fixes the bug where the flag gets set when user taps on nav handle, which
results in the taskbar animation playing.

Flag: N/A
Test: open app
      wait for taskbar to finish stashing*
      tap on nav handle
      nothing happens (desired affect)
      * I will address tapping on taskbar while its animating in a separate change
Bug: 292108880
Change-Id: I75870050225bdd951c69224d272d0bd5a3d6d4ea
2023-12-13 02:51:28 +00:00
Federico Baron 4266fa49e2 Merge "Update two pane sheet widget picker to use RelativeLayout since ConstraintLayout was causing test failures" into main 2023-12-13 01:47:21 +00:00
Jordan Silva 7808efbba1 Merge "Fix crash when restoring data from phone to tablet with responsive grid" into main 2023-12-13 00:49:26 +00:00
Brandon Dayauon 553a2c8775 Merge "Apply the expand animation on Private Space" into main 2023-12-13 00:02:56 +00:00
Brandon Dayauon cc5db6183f Merge "Include a developer option sliding flag to toggle the different amount of apps to show" into main 2023-12-13 00:01:08 +00:00
Brandon Dayauon d7f0ccf52e Merge "Move UnionDecorationHandler to Launcher" into main 2023-12-13 00:00:14 +00:00
fbaron b3b0215cb1 Update two pane sheet widget picker to use RelativeLayout since ConstraintLayout was causing test failures
There are test failures when using ConstraintLayout without a known solution, see https://chat.google.com/room/AAAACwktJi8/2OogGWfbLvI. Switching back to a relativelayout to resolve those issues.

Bug: 301918659
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I004c2d77ca308d85b29217d4f1e548067126556f
2023-12-12 15:12:40 -08:00
Sebastian Franco cefdb28599 Remove ENABLE_NO_LONG_PRESS_DRAG flag.
Fix: 299748096
Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Test: atest TaplDragTest
Change-Id: I6f14f2b048e111912fa0d1b8170ca702705e00bc
2023-12-12 15:23:06 -06:00
Brian Isganitis 59c8b69ef4 Merge "Split AFVs that controller should not intercept from TYPE_ACCESSIBLE." into main 2023-12-12 20:47:46 +00:00
Charlie Anderson 861c2eed78 Merge "Adds more in depth logging of Launcher restore functionality" into main 2023-12-12 20:30:19 +00:00
Jagrut Desai 78d511614c Increasing the LOW_TICK intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ib8f64e3ae51f5468b9086808551aae826636e03c
2023-12-12 10:40:58 -08:00
Charlie Anderson c61288e271 Adds more in depth logging of Launcher restore functionality
Test: locally
Flag: N/A
Bug: 294386159
Change-Id: I810239047480090911c54dbe65a4aad8515f640c
2023-12-12 11:04:52 -05:00
Jordan Silva ce396d8abf Fix crash when restoring data from phone to tablet with responsive grid
This issue happens when restoring the data from a phone to a tablet or vice-versa. When Launcher is restoring the data, it allows the device to load a disabled or invalid grid temporarly for the migration. This leads to a crash when the responsive grid is enabled.
The hotseat spec has only WIDTH or HEIGHT specs in a certain posture. When the user restores the data from a phone to a tablet, the Launcher loads a handheld spec that doesn't have HEIGHT specs for the hotseat in landscape (spec_handheld_hotseat_[grid].xml). However, the tablet, in landscape, tries to retrieve the hotseat HEIGHT spec.

It also prevent crash when responsive grid is used with multi window mode. isVerticalBarLayout becomes false. Then, the responsive grid tries to load a hotseat spec that doesn't exist (using DimensionType.HEIGHT). Phones have hotseat specs only for DimensionType.WIDTH.

Bug: 315548992
Fix: 315069300
Fix: 315377544
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: v2/android-crystalball-eng/health/microbench/systemui/main/systemui-notification-3-jank-suite
Test: atest CtsWindowManagerDeviceDisplay:android.server.wm.display.MultiDisplaySystemDecorationTests#testSendPrimaryHomeIntentActivityOnDisplayWithDecorations -- --abi x86_64
Change-Id: Ibd6537e0528868da9a1b7672c43b5455fa6a8184
2023-12-12 10:46:22 +00:00
Jeremy Sim e73146de77 Merge "Fix clipping issue when dragging app pair icons" into main 2023-12-12 01:03:42 +00:00
Jeremy Sim 160225029d Merge "App Pairs: Launch animation" into main 2023-12-12 00:58:49 +00:00
Charlie Anderson 489f1ada5c Add wrapper for logging backup & restore metrics from Launcher
Bug: 25177913
Flag: ACONFIG com.android.launcher3.enable_launcher_br_metrics DEVELOPMENT
Test: locally

Change-Id: I220721f705eb7244a1f13ef8997682999d799f51
2023-12-11 17:01:28 -05:00