Commit Graph

2169 Commits

Author SHA1 Message Date
Winson Chung a3ed49d566 Merging ub-launcher3-qt-dev, build 5633311
Test: Manual

Bug:119330044 P1 [STOPSHIP] Add back shape detection in Launcher icons
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:132298752 P1 Adding widget locks home screen page
Bug:132757019 P1 Swipe up twice quickly from app in 2 button mode; can't access all apps
Bug:133518678 P1 In 2 button mode, flinging up strongly favours quickswitch
Bug:133806285 P1 All apps causes overview to peek in
Bug:133844237 P1 Respect limited width Exclusion Rects in bottom area?
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:134062513 P1 Quickswitch sends lifecycle events to -1
Bug:134094839 P1 Launcher kept crashing on OTA update
Bug:134096917 P1 Launcher animation component gets stuck during swipe up
Bug:134164918 P1 STOPSHIP: Disable chips hard-coded value in qt_dev Launcher
Bug:134172603 P1 Tracing for lab-only flakes
Bug:134442147 P1 Sometimes All Apps won't update on app install/uninstall/update
Change-Id: Ia530fbf9bb5fa67b602ce44aef0cc4a1d1494e13
2019-06-04 12:20:05 -07:00
TreeHugger Robot 72c6e7b736 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev 2019-05-31 23:22:30 +00:00
Tony Wickham a04e746e84 Fix getting stuck in BackgroundAppState for 2-button mode
When ending in recents, we reapply the state - therefore, it's important
to make sure we are in OverviewState before onSwipeUpComplete(). This is
done by mLauncherTransitionController, which sets OverviewState on end.
We already force mLauncherTransitionController to end before calling
onSwipeUpComplete(), but in this case we were calling cancel() and
setting mLauncherTransitionController = null, which meant we could never
call end() on it. Instead, we should always call end() if we set it to
null.

Also ensure mLauncherTransitionController is created even if the gesture
is completed, if an existing controller isn't already running. This can
happen if you swipe up quickly enough that we get onGestureEnd before
launcher is drawn, and in that case we still want the launcher component
to animate once its ready. This is even more important for 2-button
mode, because again, we rely on mLauncherTransitionController to set the
state to OverviewState before we reapply it.

Finally, clarified some methods by renaming "swipeUp" to
"swipeUpToRecents".

Bug: 132757019
Change-Id: Ieb24a4f36a39780e5d64d7bc312791608db474d1
2019-05-31 16:11:40 -07:00
TreeHugger Robot 061c43eb4f Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev 2019-05-31 23:01:36 +00:00
Govinda Wasserman 164ebb2e8c Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev 2019-05-31 18:09:53 +00:00
Sunny Goyal 03d32ddb23 Fixing overview scrim not initialized properly when launcher starts
State UI depends on visible content, which can change due to predicitons.
Reapplying the state whenever then happens ensures that we are in correct
start UI

Change-Id: I9f195a92b747fda8a5b217dc960f230d7a695255
2019-05-31 11:00:35 -07:00
Tony Wickham 8765e262c2 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev 2019-05-31 17:46:03 +00:00
Tony Wickham 436d5971b1 Don't recreate the launcher animation controller if gesture ended
This can happen if we get onApplyWindowInsets() after onGestureEnded().
In that case, we can get into some bad states because the running
animation is overwritten and thus can't be canceled.

Bug: 134096917
Bug: 133806285
Change-Id: Ic517d68a46a4446ca382445df1ba62c26e8243ad
2019-05-31 10:21:28 -07:00
Govinda Wasserman 254be7b0e4 Adds trigger for new gesture entrypoint to Assistant bundle
BUG:130186141
Change-Id: I43a4c3d3c9a46b4a1a5c53a81b037ba2be194188
FIX:130186141
2019-05-31 12:20:50 -04:00
TreeHugger Robot f36e5e002a Merge "Fixing interactive state for background states and notifying LauncherCallback accordingly" into ub-launcher3-qt-dev 2019-05-31 06:01:25 +00:00
Jon Miranda 2ff7b53ec5 Fix bug where QSB flickers on app close.
Bug: 123900446
Change-Id: I9b03b2d91d264de237328511b5406e5fcd22dbac
2019-05-30 20:53:27 -07:00
TreeHugger Robot 958cc0657f Merge "Tuning app open/close animation." into ub-launcher3-qt-dev 2019-05-31 02:04:03 +00:00
Jon Miranda b3c9077c76 Tuning app open/close animation.
* Mostly value changes.
* Added a way to round the corners during swipe up to home animation.

Bug: 123900446
Change-Id: Id61d241d919ba51ced0633585e36b7d93efe30b0
2019-05-30 18:43:22 -07:00
TreeHugger Robot ba33d1d216 Merge "If y velocity > x velocity in 2-button mode, go to recents" into ub-launcher3-qt-dev 2019-05-31 00:49:10 +00:00
Tony Wickham 1689d65ac3 If y velocity > x velocity in 2-button mode, go to recents
Also, when landing in recents, snap to the nearest page so that swipe up
consitently goes to task 0 instead of sometimes scrolling to task 1.

Bug: 133518678
Change-Id: I63a161a9f1f87266d3c3fc71c98cd5fc5e2f8874
2019-05-30 17:38:46 -07:00
Sunny Goyal 38d8a63d07 Disabling horizontal swipes if the app has draggable content at the bottom
Bug: 133844237
Change-Id: I67a4140d56f87c464e436d394da77127a965c3e5
2019-05-30 15:13:09 -07:00
Winson Chung 0ef6fe00b0 Merging ub-launcher3-qt-dev, build 5619253
Test: Manual
Bug:112282235 P3 Starting an app from Launcher very rarely takes > 10 sec
Bug:121279417 P2 Why LauncherInstrumentation.WAIT_TIME_MS == 60000?
Bug:123892607 P1 Test broken: WellbeingTests.testPauseAppFromAllApps
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:125844074 P2 Final UX and animations for Launcher DWB integration
Bug:131360075 P1 [Gesture Nav] Polish/finish landscape
Bug:131698989 P2 Add task callback for locked state change
Bug:131741395 P2 Allow windows to scale/move past overview positioning
Bug:131768436 P1 Bad placement of search bar
Bug:131854153 P1 Lots of Cuttlefish (and not only) tests are broken
Bug:131867841 P1 Changing display size does not update the grid
Bug:132460627 P1 Unable to swipe to all apps screen on devices
Bug:132687470 P1 Swiping home from forced landscape app creates cutoff task thumbnail
Bug:132756514 P1 Sometimes (when quick switching?) user gets stuck in full-screen recents view
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:132917885 P1 Reduce swipe-up gesture region height in landscape
Bug:132975416 P1 Flake in NexusPredictionAppTracker.getAppPredictionContextExtras
Bug:132993129 P1 If predictions disabled, app predictions loading bar appears briefly on device restart
Bug:133113732 P1 [B1/C1][QT][CTS_Verifier_9.0_r1]Device Owner Tests-LockTask UI-Enable Overview button failure
Bug:133167096 P1 It is way too easy to dismiss apps from the lock screen
Bug:133651528 P1 [QT]"Pixel Launcher isn't responding" dialog pop up ,after DUT restored.
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133765491 P1 App docked in split screen flickers with emptiness observed while rotating the device
Bug:133783088 P1 Footer showing up on all overview task snapshots even with no items showing.
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:64712476 P3 Import translations for dev branches

Change-Id: Ib4bcefdbb4027992e75e2742d72f199e13467875
2019-05-30 13:18:41 -07:00
Sunny Goyal e9c6f4cc69 Fixing interactive state for background states and
notifying LauncherCallback accordingly

During quick switch Launcher can get resumed only to be paused again
when launching a new app. Updating the logic for deferred resume to
account for that and moving some additional calls to deferredResume

Bug: 134062513
Change-Id: Ia607f178bc17d45d53fb032a06cd70f9abc6b513
2019-05-30 11:59:29 -07:00
vadimt 26185e1fed Adding debug tracing for a lab-only issue
Task doesn't get resumed upon clicking at it.

Bug: 133765434
Change-Id: I8c5c1308041949d94c6982c78b8337ea81ad400f
2019-05-30 10:30:32 -07:00
Sunny Goyal 1d7b2a0672 Merge "Overview - Add motion to the footer shown on overview tasks." into ub-launcher3-qt-dev 2019-05-30 00:18:38 +00:00
Zak Cohen 3f6019fde4 Overview - Add motion to the footer shown on overview tasks.
The motion mirrors the icon view.

Bug: 125844074
Test: manual
Change-Id: Ib980657763aa82c45319c7c93be652f6fc89ffe4
2019-05-29 16:54:36 -07:00
TreeHugger Robot 1dbec0ef43 Merge "Fix bug where shape reveal progress gets started too early." into ub-launcher3-qt-dev 2019-05-29 21:57:41 +00:00
TreeHugger Robot fafe347533 Merge "Animate workspace upwards when opening an app." into ub-launcher3-qt-dev 2019-05-29 21:53:32 +00:00
TreeHugger Robot ea068967ae Merge "Add staggered springs animation when swiping up to home." into ub-launcher3-qt-dev 2019-05-29 21:47:27 +00:00
Jon Miranda 119a586245 Animate workspace upwards when opening an app.
Bug: 123900446
Change-Id: I3d08985f8362038f50728e91e2fedf1c97e326ff
2019-05-29 14:39:01 -07:00
Jon Miranda c69d1ffd92 Add staggered springs animation when swiping up to home.
Bug: 123900446
Change-Id: I275e34c6dca5b026f272ab216b18651c0df27bc4
2019-05-29 14:32:49 -07:00
Jon Miranda 928fc8d1e2 Fix bug where shape reveal progress gets started too early.
* This caused the shape to not match the window size on app close.

Bug: 123900446
Change-Id: Iaa2c06f19c535f72ae4c080b4bc847d336f1a77d
2019-05-29 14:19:16 -07:00
vadimt b06f9f8c78 Increasing wait time after mode switch.
This is temporary. Apparently, it takes time for Sys UI to update after
the mode switch.

Change-Id: I434b86af15d9987a448682684c790d89acab85dc
2019-05-29 13:05:06 -07:00
Bill Yi 9789beae0e Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I029f3fe3ecc187db70a0e86ed98f498f04be1d0a
2019-05-28 19:13:27 -07:00
Winson Chung 293d964024 Merge "Support individual lock task features" into ub-launcher3-qt-dev 2019-05-29 00:10:02 +00:00
Tony Wickham 5860288fc8 Merge "Continue scaling down recents past final position in 0 button mode" into ub-launcher3-qt-dev 2019-05-28 23:21:32 +00:00
TreeHugger Robot e34c91765f Merge "Improving swipe up interaction when device is locked" into ub-launcher3-qt-dev 2019-05-28 23:05:31 +00:00
Sunny Goyal 221895d06b Improving swipe up interaction when device is locked
When device is locked, only scale down the top task as a response to
the user interaction. When user flings or lifts his finger, the task
is dismissed to go to the lock screen

LockScreenRecentsActivity is an empty activity which starts on top of lock
screen and finishes immediately. This allows us to start a recents transition
with just the top activity as the animation target. This target is then used
for swipe up interaction

Bug: 133167096
Change-Id: I466ed142ea33d626c78cb9cc5f6311bad26b8d98
2019-05-28 15:55:07 -07:00
Zak Cohen 560fe07448 Chips container - Don't hard code the height of the chips container.
When the container was present, but empty, it was showing it's background.

Bug: 133783088
Change-Id: I97b65435d66e9ced7f5487dc50a00665794f8fcd
Tested: manual
2019-05-28 14:53:41 -07:00
Tony bef6a44e7b Continue scaling down recents past final position in 0 button mode
- Previously, we clamped the progress to 1 when reaching mTransitionDragLength.
  Now, we allow dragging all the way to the top of the screen, and store this
  new top progress in mDragLengthFactor (> 1f).
- Because the launcher animation controller is inherently bound to a progress
  between 0 and 1, we have to do a bit of trickery involving interpolators.
  Specifically, we normalize the progress to 0 to 1 by dividing by
  mDragLengthFactor, but then we set the interpolators to multiply their
  progress by mDragLengthFactor. The result is that the animation progress
  appears to go from 0 to mDragLengthFactor, just like the window progress.
- To avoid scaling too small, we start interpolating the progress at a certain
  point, ending at a specified max progress when reaching the top of the screen.

Bug: 131741395
Change-Id: Ie8b4b56d37249cd1456f93c110c26c78fe052dc0
2019-05-28 21:41:43 +00:00
vadimt 2d6cd80bc9 Launcher reports whe 0-button swipe-up gesture pause is detected.
This eliminates an unreliable timeout.

Also removing an unnecessary check for harness that is done by the
called method.

Change-Id: If954580060415cbb2952532c16ea0ae4dc7b9469
2019-05-24 19:28:40 -07:00
Sunny Goyal 55d1e44c47 Fixing user getting stuck in quick-switch state
If we are cancelled after the animation has completed, but before the deferred frame
was captured, we set the state as cancelled, and start the new consumer with the
existing recents controller.
But after the deferred frame, we finish the controller (and since the state was set to
cancelled, do not launch the new task)

Bug: 132756514
Change-Id: If30af713c76b6d895d0b01b93d31c0e1403b7214
2019-05-24 17:20:10 -07:00
TreeHugger Robot 3831fc99dc Merge "Making some fields accessible to subclasses" into ub-launcher3-qt-dev 2019-05-24 22:28:34 +00:00
Sunny Goyal c62699fd63 Merge "Removing prediciton loading state" into ub-launcher3-qt-dev 2019-05-24 22:01:09 +00:00
TreeHugger Robot 1625bf74dd Merge "Adding myself as an owner of test directories" into ub-launcher3-qt-dev 2019-05-24 18:06:28 +00:00
vadimt addaab60fa Adding myself as an owner of test directories
Change-Id: I3d6649a2b804715cebb80b8cac881ef227738088
2019-05-24 10:54:12 -07:00
TreeHugger Robot f54839bf35 Merge "Remove unnecessary dispatchInsets routing" into ub-launcher3-qt-dev 2019-05-24 00:31:18 +00:00
Sunny Goyal 4c96dd2cd0 Merge "Moving TestInformationProvider to Launcher3 so that it can be used for testing Launcher3 without quickstep" into ub-launcher3-qt-dev 2019-05-24 00:12:14 +00:00
Sunny Goyal 9820c05f2b Removing prediciton loading state
Also fixing test flakyness due to delayed prediction loading

Bug: 132993129
Bug: 131854153
Change-Id: I85f7afff0e3ee0ca9e40e92e91681f797a0bc2de
2019-05-23 17:01:19 -07:00
TreeHugger Robot a80180bfcb Merge "Set scroller to new max duration if snapping too slowly" into ub-launcher3-qt-dev 2019-05-23 21:53:06 +00:00
Tony Wickham 9b832295c3 Set scroller to new max duration if snapping too slowly
Change-Id: I87bfc8f767f7ae9cbe838c2a9ba229bec179f526
2019-05-23 14:42:24 -07:00
Winson Chung dd71ca0437 Support individual lock task features
- If screen pinning is enabled, disable gestures and wrap with input
  consumer to break out of screen pinning (existing logic)
- If Home & Overview are both disabled, disable gestures completely
- If only Home is disabled, then always launch the user into fallback
  recents (to simplify logic around breaking out of overview into Home)
- If only Overview is disabled, then prevent swiping from going into
  overview or from triggering overview from home
- Switch to using screen pinning flag check instead of binder call

Bug: 133113732
Bug: 131698989

Change-Id: Ie6f447520d4cc3fa1eaaf8427ee014851688bf37
2019-05-23 14:33:05 -07:00
Sunny Goyal 68ff2d91cf Making some fields accessible to subclasses
Bug: 132975416
Change-Id: Icc7043d8299c88fcf505068f8cabd4705d19010d
2019-05-23 14:16:06 -07:00
Sunny Goyal ab3963ddcf Moving TestInformationProvider to Launcher3 so that it can be used for
testing Launcher3 without quickstep

Also keeping the provider as disabled until needed

Change-Id: Ib5f459e02ae551724b390f3b74f43d601568d749
2019-05-23 14:02:33 -07:00
TreeHugger Robot 571e51161c Merge "Quick patch for PredictionUiStateManager.applyState interrupting allapps" into ub-launcher3-qt-dev 2019-05-23 20:53:27 +00:00