Commit Graph

4122 Commits

Author SHA1 Message Date
thiruram 7fa1c8a25d Fixes folder logging. am: b53764bd4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11902346

Change-Id: Ib9b34794311a41e0b54c19d1c0097f6d36680917
2020-06-20 00:56:17 +00:00
thiruram b53764bd4b Fixes folder logging.
Only LAUNCHER_FOLDER_LABEL_UPDATED events will have FromState, ToState
and FolderLabelInfo. Other folder events such as OPEN, DRAG etc will have
basic fields only populated.

Sample Log: https://paste.googleplex.com/5468394805526528
Screencast: http://rcll/hSUQjtQXfQM5i9DjjAQTf2/Zn5FeiVDONaQj0mK1JNjg

Bug: 159164315
Change-Id: I903fc7b62bcee748aa3ef695453be3e14d388712
2020-06-19 17:06:46 -07:00
TreeHugger Robot 38126202d8 Merge "Fix RecentsView scroll linking" into ub-launcher3-rvc-dev am: 72ac78189f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11936452

Change-Id: I5f9e7ef48d82c8ecd4f496e8b7c960b7dd232f56
2020-06-19 23:37:45 +00:00
TreeHugger Robot 108c7b65ed Merge "Fixing fallback recents not getting proper insets on configuration change" into ub-launcher3-rvc-dev am: f9ae1a838a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11934077

Change-Id: I11c0b6c85c66551b9a425eb0d9ce232e6a720392
2020-06-19 23:37:39 +00:00
TreeHugger Robot 72ac78189f Merge "Fix RecentsView scroll linking" into ub-launcher3-rvc-dev 2020-06-19 23:28:55 +00:00
TreeHugger Robot f9ae1a838a Merge "Fixing fallback recents not getting proper insets on configuration change" into ub-launcher3-rvc-dev 2020-06-19 23:22:54 +00:00
Tony Wickham 94d1b4be17 Fix RecentsView scroll linking
- Reverts change from ag/11900651 that deferred setting
  mRecentsViewScrollLinked = true
- Instead, setCurrentPage(mCurrentPage) after updating layout rotation
  to ensure we recompute page scrolls before using them

Test:
- Auto rotate on, home rotation off, open Calculator in landscape,
  swipe up slowly and ensure it never turns invisible
- Quick switch from Calculator to Clock, start swiping directly up
  immediately after settling on Clock, ensure Calculator window
  remains at its scroll position to the side (b/159461591)

Fixes: 159461591
Change-Id: Iab92963cc6c33df42b77f5ccfa3932382e8f869a
2020-06-19 17:42:18 -05:00
Tony Wickham fb8d090c68 Merge "Remove progress != mFullscreenProgress optimization" into ub-launcher3-rvc-dev am: e19b065c7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11932417

Change-Id: I41422ebccc64c9178f33598f609da228db6515dd
2020-06-19 18:54:23 +00:00
Zak Cohen 1f3a4b6530 Image actions - fix uri permissions. am: aef8b86b4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11933718

Change-Id: I6ca5eff182795fe4c60032da5539d9d6d0428b21
2020-06-19 18:54:12 +00:00
Tony Wickham e19b065c7c Merge "Remove progress != mFullscreenProgress optimization" into ub-launcher3-rvc-dev 2020-06-19 18:45:44 +00:00
Sunny Goyal 9d89f75ce4 Fixing fallback recents not getting proper insets on configuration change
> Using common code for Launcher and recents for insets dispatching
> Fixing recents auto closing when there is no running task

Bug: 158750568
Bug: 159133601
Change-Id: Iee25c603a77a1ac546ada1840f3afaf5797b8802
2020-06-19 11:41:53 -07:00
Zak Cohen aef8b86b4a Image actions - fix uri permissions.
Feedback wasn't working, also Share wasn't showing its preview.

Bug: 159122067
Test: built and run locally
Change-Id: Iccea012a8fc0009a6a980f6233f42c4e7619f4ec
2020-06-19 18:02:44 +00:00
Tony Wickham 6a8ba169f2 Remove progress != mFullscreenProgress optimization
Sometimes other methods modify things like icon scale that setting
the fullscreen progress should override.

Test: open Calculator, open Clock, quick switch to Calculator and
ensure its task icon is not showing

Bug: 157105795
Change-Id: Iaed3e42f540fdff3648e9db7e6d7dc0b0d0a75df
2020-06-19 12:20:38 -05:00
Vadim Tryshev eee5fbe313 Merge "Removing debug requests from non-debug test info handlers" into ub-launcher3-rvc-dev am: 84aaecca64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11827372

Change-Id: Iee1cd7c886309c32d6811ac949239350ea72d82e
2020-06-19 16:51:52 +00:00
Vadim Tryshev 84aaecca64 Merge "Removing debug requests from non-debug test info handlers" into ub-launcher3-rvc-dev 2020-06-19 16:37:41 +00:00
TreeHugger Robot ab820472fb Merge "Fixing jump when swiping up in landscape and in waterfall cutout" into ub-launcher3-rvc-dev am: a5e45ad485
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11900651

Change-Id: I34dc565be6d7eb5ff3e9f82ba9061aaca171ecdc
2020-06-19 07:27:52 +00:00
TreeHugger Robot a5e45ad485 Merge "Fixing jump when swiping up in landscape and in waterfall cutout" into ub-launcher3-rvc-dev 2020-06-19 07:17:02 +00:00
Tony Wickham 1c5a3e082b Merge "Inline TaskView#resetVisualProperties() into RecentsView" into ub-launcher3-rvc-dev am: f13a51c4b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11917351

Change-Id: I6d7f8483d94e7fcd480dca0d1b3bd72f7865f884
2020-06-19 05:52:44 +00:00
Tony Wickham f13a51c4b8 Merge "Inline TaskView#resetVisualProperties() into RecentsView" into ub-launcher3-rvc-dev 2020-06-19 05:26:32 +00:00
TreeHugger Robot cc3e9f0614 Merge "Follow up for ag/11916646" into ub-launcher3-rvc-dev am: 5c33e250fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11923398

Change-Id: Ia631a5640026628b967814f370e38921ff9186f5
2020-06-19 01:47:06 +00:00
TreeHugger Robot 5c33e250fc Merge "Follow up for ag/11916646" into ub-launcher3-rvc-dev 2020-06-19 01:42:09 +00:00
TreeHugger Robot cc764ffc94 Merge "Add spring to workspace scale when going from Hint state to Normal state." into ub-launcher3-rvc-dev am: 92b0b1d0a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11871917

Change-Id: If2b1b8b2e0c9bcb552472f48538f48ca57b8d46d
2020-06-19 01:40:29 +00:00
TreeHugger Robot 92b0b1d0a1 Merge "Add spring to workspace scale when going from Hint state to Normal state." into ub-launcher3-rvc-dev 2020-06-19 01:28:25 +00:00
Tony Wickham d2fffa6ea5 Inline TaskView#resetVisualProperties() into RecentsView
- This was only used in RecentsView#resetTaskVisuals() anyway
- Previously resetVisualProperties() just called resetViewTransforms()
  plus setFullscreenProgress(0) and setModalness(0)
- The latter 2, specificially setFullscreenProgress(0) led to problems
  such as the bug below. Instead, we should reset to the current
  mFullscreenProgress and mTaskModalness.

Bug: task view sometimes shifted up during quick switch
Steps:
- Do the quick switch gesture very quickly
- At the start of the gesture, we call getTasks(), which calls
  applyLoadPlan() asynchronously
- applyLoadPlan() calls resetTaskVisuals(), so if this happened
  after the gesture ended, we would setFullscreenProgress(0) on all
  the task views, hence the upwards shift (if the gesture was still in
  progress, it would reapply the real fullscreen progress)

Fixes: 157105795
Change-Id: Idb9d91ff89701d726838b47f955d4300f5ef13bd
2020-06-18 20:25:34 -05:00
Samuel Fufa 0b0a57f422 Merge "Allow Users to migrate their hotseat when returning from AiAi" into ub-launcher3-rvc-dev am: a529cd0f5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11855090

Change-Id: I988af6be3b74c45692adf281448ec2d9d936448e
2020-06-19 01:08:12 +00:00
Samuel Fufa 1d08cc681c Follow up for ag/11916646
- Fixes launcher breakage

Bug: 159170242
Change-Id: Ib21bfee8d5f63d31a8807ad87ac47d600fb62e7a
2020-06-18 17:57:39 -07:00
Jon Miranda 271638574f Add spring to workspace scale when going from Hint state to Normal state.
Bug: 151768994
Change-Id: If03d39e5ef6319355a7691d60fc0152de2fc3cec
2020-06-18 17:53:07 -07:00
Samuel Fufa a529cd0f5f Merge "Allow Users to migrate their hotseat when returning from AiAi" into ub-launcher3-rvc-dev 2020-06-19 00:51:18 +00:00
TreeHugger Robot b98168273f Merge "Show a snackbar on predicted icon longpress" into ub-launcher3-rvc-dev am: c471a9a6bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11916646

Change-Id: I202db77991f7c3dd58f5c832325e477f07d19b3b
2020-06-18 23:39:10 +00:00
TreeHugger Robot a2339c5f51 Merge "Deprecates LAUNCHER_ALL_APPS_RANKED event." into ub-launcher3-rvc-dev am: e49de265da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11889123

Change-Id: I52a9e7fa51257d1a1b02e96a00675a4afda6a291
2020-06-18 23:39:02 +00:00
Samuel Fufa d25a112b0e Allow Users to migrate their hotseat when returning from AiAi
- If a user has mostly predicted hotseat, show a snack bar. otherwise, show migration option.
- Guard onboarding activity with permission `com.google.android.apps.nexuslauncher.permission.HOTSEAT_EDU`

Bug: 158569583
Test: Manual
Change-Id: Id0c1c812233fcf288a2f49848720199dedd2015d
2020-06-18 16:38:58 -07:00
TreeHugger Robot c471a9a6bb Merge "Show a snackbar on predicted icon longpress" into ub-launcher3-rvc-dev 2020-06-18 23:34:58 +00:00
thiruram ffb55ddece Deprecates LAUNCHER_ALL_APPS_RANKED event.
LauncherUiChanged.rank field is repurposed to store all apps rank.

Change-Id: Iabad98312589d8f53b6547433540f3ec9dff0b3f
2020-06-18 15:08:16 -07:00
TreeHugger Robot de1104245f Merge "Fix bug where All Apps Edu gets closed via user input before animation ends." into ub-launcher3-rvc-dev am: 8e9405d7cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11917527

Change-Id: If9c7c4f6070e1e941b1d2250ab4d63a99266f59f
2020-06-18 21:22:31 +00:00
TreeHugger Robot 8e9405d7cd Merge "Fix bug where All Apps Edu gets closed via user input before animation ends." into ub-launcher3-rvc-dev 2020-06-18 21:20:36 +00:00
TreeHugger Robot 7c80084f75 Merge "Avoid hotseat edu button overlapping" into ub-launcher3-rvc-dev am: d4de6d4bba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885084

Change-Id: I59913b015ba584a5b8a1b28b7f51232a6a8cff4d
2020-06-18 21:17:17 +00:00
TreeHugger Robot d4de6d4bba Merge "Avoid hotseat edu button overlapping" into ub-launcher3-rvc-dev 2020-06-18 21:06:44 +00:00
TreeHugger Robot 6b9cdf318f Merge "Add flag Intent.FLAG_ACTIVITY_NEW_TASK when launching suggestion settings" into ub-launcher3-rvc-dev am: 3b80398889
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11917339

Change-Id: I43f2c09838b517c0ab8479fce33461b2b3b75340
2020-06-18 20:58:28 +00:00
TreeHugger Robot 3b80398889 Merge "Add flag Intent.FLAG_ACTIVITY_NEW_TASK when launching suggestion settings" into ub-launcher3-rvc-dev 2020-06-18 20:48:52 +00:00
Jon Miranda 1bbd2831f3 Fix bug where All Apps Edu gets closed via user input before animation ends.
Also fixes bug where user continuously swipes to hint view causes count
to increase more than the max count which prevents all apps edu from showing.

Bug: 151768994
Change-Id: I3186398d441e723a2cfb6e396b03944502a65cf5
2020-06-18 13:40:33 -07:00
Samuel Fufa 9058e305e5 Avoid hotseat edu button overlapping
Screenshot: https://screenshot.googleplex.com/cCNn6hdrqu1
Bug: 158194467
Change-Id: I465ab73be2079f20994b3f2bbe57f64e46d05777
2020-06-18 13:32:17 -07:00
Samuel Fufa c376a1de2c Add flag Intent.FLAG_ACTIVITY_NEW_TASK when launching suggestion settings
Bug: 158604370
Test: Manual
Change-Id: I01e313d29cbc9b7ea2413547d9a7b4940d126ce8
2020-06-18 13:13:45 -07:00
TreeHugger Robot ad7b76f06c Merge "Avoid Crash when longpressing disabled predicted item" into ub-launcher3-rvc-dev am: fcc4a2d83f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885880

Change-Id: I93501564f45c50a7165c8391a477b8e4a695a783
2020-06-18 17:58:49 +00:00
Samuel Fufa 44c1b5e03d Show a snackbar on predicted icon longpress
The first time a user long presses a predicted icon, suppress drag/drop and show a snackbar about app predictions.

Bug: 159170242
Test: Manual
Change-Id: I5f853a9774b38ad9fad22ff55feff417a801f52c
2020-06-18 10:57:32 -07:00
TreeHugger Robot fcc4a2d83f Merge "Avoid Crash when longpressing disabled predicted item" into ub-launcher3-rvc-dev 2020-06-18 17:45:57 +00:00
Jonathan Miranda 8a44e065b1 Merge "Use screenSpaceBounds to position the target window for recents mw animation." into ub-launcher3-rvc-dev am: 42dd4f4afd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11900648

Change-Id: I9cb0301698d887f02a5e49f380b2b1b0442cedc6
2020-06-18 17:18:01 +00:00
Jonathan Miranda 42dd4f4afd Merge "Use screenSpaceBounds to position the target window for recents mw animation." into ub-launcher3-rvc-dev 2020-06-18 17:03:18 +00:00
Sunny Goyal b64fc6c26f Fixing jump when swiping up in landscape and in waterfall cutout
> Adding tests for TaskViewSimulator to ensure proper calculations
> Disabling orientation listener while user is interacting with quickstep

Bug: 158781568
Bug: 156891776
Change-Id: I299c3b1243ac0dbf28faee1b8566c77ea3954e33
2020-06-18 00:29:00 -07:00
Hyunyoung Song d5b03cc19e Add LAUNCHER_WORKSPACE_SNAPSHOT event_id am: 714659f6d0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11897445

Change-Id: Ib44004d4632417d631af3f1687b273ca5fb504b3
2020-06-18 07:10:55 +00:00
Hyunyoung Song 714659f6d0 Add LAUNCHER_WORKSPACE_SNAPSHOT event_id
Bug: 159210161
Change-Id: Ie8e843ee10bf4ab0761232a3e61eb28e487666ab
2020-06-17 22:39:36 -07:00