Commit Graph

12654 Commits

Author SHA1 Message Date
Mateusz Cicheński efeae8e3aa Merge "Fix entry bounds for 3 button nav" into tm-qpr-dev am: 321127d14a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21847300

Change-Id: I2a4dafc799be1cc58b4cf54062571a7b39a5de6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:12:54 +00:00
Brian Isganitis 16fdd8b4f0 Ensure taskbar background always transparent in notification tray. am: 84261f9d9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593273

Change-Id: I301369bdce2bf00ef00d95d75ae91365022e4d6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:12:04 +00:00
Jagrut Desai 545f6540c3 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev am: d301c9b628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21735251

Change-Id: Ibdb3a308550727a8c03c83c99e1c8566b443e503
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:11:29 +00:00
Mateusz Cicheński 321127d14a Merge "Fix entry bounds for 3 button nav" into tm-qpr-dev 2023-03-08 23:52:41 +00:00
Brian Isganitis 84261f9d9b Ensure taskbar background always transparent in notification tray.
Persistent, taskbar can be in light or dark modes. Since notification
tray has its own background color, we should hide ours to avoid clashing
with it.

Test: Manual
Fix: 270758899
Change-Id: Iedc6aae42aac30987af3259ccee11c5998e10517
2023-03-08 23:51:34 +00:00
Jagrut Desai d301c9b628 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev 2023-03-08 23:34:01 +00:00
TreeHugger Robot 9fbd4b9c4e Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev am: 19c0877745
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21806280

Change-Id: I1c37aee0caa430161761f2bdddc89669be6f553c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 20:18:52 +00:00
Sunny Goyal 7975109d74 Merge "Removing flag management UI states from flag definition" into tm-qpr-dev am: 839fc20feb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21725630

Change-Id: I64613adac5217b6a2abd734e80af21f9ba2962d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 20:18:37 +00:00
TreeHugger Robot 19c0877745 Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev 2023-03-08 20:04:50 +00:00
Sunny Goyal 839fc20feb Merge "Removing flag management UI states from flag definition" into tm-qpr-dev 2023-03-08 19:45:21 +00:00
Ats Jenk 4261ab7e99 Merge "Set desktop icon to always use black for the icon" into tm-qpr-dev am: 8efad6b111
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21892092

Change-Id: I5147a219b6f05e70d1a02530258d3c7a913591be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:26:14 +00:00
Ats Jenk 8efad6b111 Merge "Set desktop icon to always use black for the icon" into tm-qpr-dev 2023-03-08 19:10:09 +00:00
Brian Isganitis cba28f0b3f Merge "Log when taskbar is in task switcher container." into tm-qpr-dev am: ba5b25c198
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21780681

Change-Id: Id8de9691667824ccc6bf78c4d4c804f99882f8be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:09:30 +00:00
Sihua Ma fc9d3a50ad Merge "Set the original drawable for floating widget view" into tm-qpr-dev am: 792dda2344
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20899726

Change-Id: I345f74a393fb994b7b83ccde884263c8a43b4678
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 19:09:19 +00:00
Brian Isganitis ba5b25c198 Merge "Log when taskbar is in task switcher container." into tm-qpr-dev 2023-03-08 18:56:02 +00:00
Sihua Ma 792dda2344 Merge "Set the original drawable for floating widget view" into tm-qpr-dev 2023-03-08 18:26:59 +00:00
Jagrut Desai 1dc99f3848 Announce for accessiblity when taskbar is invoked/closed
Test: Manual
Bug: 265620540
Change-Id: I6660be7716ec59c765f3d54f8fe9889eaaf56e10
2023-03-08 09:54:10 -08:00
Charlie Anderson 04d2397c43 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev am: 3b072b9a07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21559561

Change-Id: I070d83e8389c5a4df8b60923b9615a00e2bbc037
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 14:35:52 +00:00
Charlie Anderson 3b072b9a07 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev 2023-03-08 14:15:17 +00:00
Sihua Ma 914549b482 Set the original drawable for floating widget view
This ensures that the background of the widget will not disappear after cancelling opening the widget activity.

Normally, when opening and closing the widget activity, the following procedures are executed:

tap on widget
-> opening animation initialized -> opening animation finished
-> close the activity
-> closing animation initialized -> closing animation finished

The steps above would work fine. However, a different set of procedures is followed if we try to cancel opening the widget activity:

tap on widget
-> opening animation initialized
-> opening animation started
-> swipe back before opening animation is completed
-> closing animation initialized
-> opening animation finished
-> closing animation started
-> closing animation finished

During the animation initialization process, FloatingWidgetBackgroundView would be initialized. It will then cache the original background and replace with a temporary drawable with alpha set to 0. The background is only restored at the end of the animation.

If two FloatingWidgetBackgroundView is initialized on the same app widget view before one of them is finished, the second floating view will treat the temporary drawable as the original background. At the end of the closing animation, the temporary drawable with an alpha value of 0 will be set for the app widget view, causing the background of the widget view to disappear.

This CL stores the original drawables into the background view so they could be retrieved during the initialization process of the floating background view.

Test: Manual
Fix: 259526083
Change-Id: Iefa29b22b690076a4fc3fc77fe6eea4b6316f852
2023-03-07 15:20:22 -08:00
Ats Jenk 80f4c20f6c Set desktop icon to always use black for the icon
Desktop icon in overview was using a themed color for the icon. But the
background is always a white circle. When using a dark theme, the themed
primary text color is too light. Fixing the color of the icon to be
black always.

Bug: 267326722
Test: enable dark mode, open overview and check the desktop tile icon
Change-Id: Ibcfdfd92ffe2db41cf6ed75c3da8f6457773c2bf
2023-03-07 14:24:37 -08:00
Schneider Victor-tulias 673549f1df Merge "Translate the navigation setting text to prevent overlapping with home gesture hint" into tm-qpr-dev am: f1a0bd61f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21681580

Change-Id: I76652e3df99cad129f3b1443257b65454c1bf389
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 21:13:43 +00:00
Schneider Victor-tulias f1a0bd61f4 Merge "Translate the navigation setting text to prevent overlapping with home gesture hint" into tm-qpr-dev 2023-03-07 20:49:22 +00:00
Jon Miranda 89d42acf47 Merge "Use dY to determine if taskbar nav threshold is met." into tm-qpr-dev am: 05f08214be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21802101

Change-Id: I08787b44374c195e617fa35147b31232ea4bfcc4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 20:18:02 +00:00
Jon Miranda 05f08214be Merge "Use dY to determine if taskbar nav threshold is met." into tm-qpr-dev 2023-03-07 20:07:24 +00:00
Jon Miranda 3ed72b4f92 Use dY to determine if taskbar nav threshold is met.
Prior to this change, we used absoulte screen values.
With this change, the nav threshold is aligned with all other taskbar
thresholds.

Fixes: 269167210
Bug: 267646355
Test: swipe up to show taskbar
Change-Id: Ie2017577fd640b4173fd5ba10122d6906e74f90a
2023-03-07 16:50:42 +00:00
Mateusz Cicheński c5cbf0f326 Fix entry bounds for 3 button nav
The fix uses the similar approach to shelf height to ensure that the
keep clear area is being updated as soon as possible for quickstep.

Without this, the entry animation finishes before the actual keep
clear area from the view is registered, which causes the PiP to enter
lower right corner and then move up, which was the regression.

Bug: 260779127
Test: manually
Test: http://recall/-/g8x7ZkgdfbqscttAA9wzl9/72aNHwWH5wihwN4gf3mfj

Change-Id: Ide11a903558d7e6cb9e477abe12b81129a7f7afc
2023-03-07 07:50:06 +00:00
Brian Isganitis c762ef68d4 Log when taskbar is in task switcher container.
Test: wwdebug & wwlogcat
Bug: 261177876
Change-Id: Id4eda7ee7e4e2c1aa60e07d5b65410b3847d9ac6
2023-03-07 03:29:21 +00:00
Brandon Dayauon 76e123820a Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev am: d0838d3ac1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470669

Change-Id: I2a0d9cccea4a9593af9d4079b0c58f16e27f5156
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 03:25:10 +00:00
Brandon Dayauon d0838d3ac1 Merge "Correctly make to spec the color for "Turn on work apps" button and add stroke" into tm-qpr-dev 2023-03-07 02:55:01 +00:00
Tony Wickham 8c61868b40 Merge "Align taskbar children to Y value instead of X." into tm-qpr-dev am: 7fa1e32f21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21787133

Change-Id: I2afc1e79594f57806e9ece07ecda18f0d899a922
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 00:06:08 +00:00
Tony Wickham 7fa1e32f21 Merge "Align taskbar children to Y value instead of X." into tm-qpr-dev 2023-03-06 23:51:50 +00:00
Brian Isganitis ef9514beab Merge "Implement light mode for persistent Taskbar." into tm-qpr-dev am: 2790c9dbbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21592661

Change-Id: Idbf2609daac8c6e35c9edae08e05b379eae80a0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 23:48:02 +00:00
Vinit Nayak 313a44039f Revert "Create TAPL test suite for splitscreen"
This reverts commit 03815e6c79.

Reason for revert: b/271852893

Change-Id: I165a15b29e41ce1114f6b7d92d22cdd8e0dfb5b0
2023-03-06 23:47:20 +00:00
Brian Isganitis 2790c9dbbf Merge "Implement light mode for persistent Taskbar." into tm-qpr-dev 2023-03-06 23:07:41 +00:00
Charlie Anderson 52caf63404 Fixes several Visual issues with the app shortcut popup
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.

Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
2023-03-06 16:40:51 -05:00
TreeHugger Robot bc74b530aa Merge "Fix an issue with concurrent modification on widget holders list" into tm-qpr-dev am: f22345eace
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21694006

Change-Id: I8104399f1212808af99a048327d7b559f355e006
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 20:45:48 +00:00
TreeHugger Robot f22345eace Merge "Fix an issue with concurrent modification on widget holders list" into tm-qpr-dev 2023-03-06 20:05:29 +00:00
Johannes Gallmann 72313feac1 Merge "Add onEndCallback to ContainerAnimationRunner" into tm-qpr-dev am: 83683829f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21750179

Change-Id: Iebc90a935e9bbdd865f2fd03b531e5f5bcfefa66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 19:54:47 +00:00
Schneider Victor-tulias ec76d6e4b9 Translate the navigation setting text to prevent overlapping with home gesture hint
On large fonts and display sizes, the navigation settings text can overlap with the home gesture hint. Adding some additional translation to account for this.

Fixes: 269716511
Test: Launched all set page on the largest and default font and display sizes on a phone
Change-Id: I4a40b06b827667de9b0bdb893320b0a9890f6699
2023-03-06 19:14:40 +00:00
Johannes Gallmann 83683829f7 Merge "Add onEndCallback to ContainerAnimationRunner" into tm-qpr-dev 2023-03-06 18:55:49 +00:00
Hyunyoung Song a10811b4fe Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev am: eeee84efb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21447384

Change-Id: I97443edd17e2c0d4982a9a63bdd61c78c1b9e4e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 18:39:09 +00:00
Hyunyoung Song eeee84efb6 Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev 2023-03-06 18:23:32 +00:00
Pat Manning d3cffe8156 Align taskbar children to Y value instead of X.
Fix: 271858023
Test: manual on tablet.
Change-Id: I60882a062d5f2bb8f24525e2cec9c4a091b31545
2023-03-06 17:57:58 +00:00
Hongwei Wang 5f57433ebc Merge "Turn ENABLE_PIP_APP_ICON_OVERLAY on by default" into tm-qpr-dev am: 1897e4f40f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21613694

Change-Id: I03d3746ad0795a87307676fe2ee2d7c18454bcc7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 17:50:09 +00:00
Hongwei Wang 1897e4f40f Merge "Turn ENABLE_PIP_APP_ICON_OVERLAY on by default" into tm-qpr-dev 2023-03-06 17:13:56 +00:00
TreeHugger Robot 3dda7ab75f Merge "Sync overview scroll so that it ends before/at same time as taskbar animation" into tm-qpr-dev am: a176ad060f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778039

Change-Id: I1d7772bfe999a4b9967b1656b99023c94eecdb17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:46:22 +00:00
Jeremy Sim 2a81b79a3c Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev am: ad9bdcfd2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21221178

Change-Id: I14e25affb3d204cd2fcf0f693fd53ce502e576f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:46:09 +00:00
Sunny Goyal 5a4ff1a073 Merge "Simplifying code around multiple translation components" into tm-qpr-dev am: 33c3e77411
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593003

Change-Id: Id4e43cb78aa1aaeca74c0c3ee449e9bda91924aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:44:31 +00:00
TreeHugger Robot f5153d5de2 Merge "Translate taskbar to hotseat without jump when swiping up from overview" into tm-qpr-dev am: 3dd1440520
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21592805

Change-Id: Ic8972961193226ab1cb1a0a31bd6ff9e12f980c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:40:43 +00:00