Commit Graph

14046 Commits

Author SHA1 Message Date
Jordan Silva efb3f85615 Merge "Set the elevation for TaskMenuView when overview icon menu is enabled." into main 2025-03-20 09:22:09 -07:00
Treehugger Robot aa53bd3392 Merge "Allow fast flinging to cancel task dismiss." into main 2025-03-20 07:15:16 -07:00
Uwais Ashraf bbe63db85c Merge changes from topic "cleanup-existing-update-disabled-flags" into main
* changes:
  Remove existing superceded calls to updateDisableFlags
  Change actions view disabling logic
2025-03-20 07:00:19 -07:00
Pat Manning 90eceafb5f Merge "Update recents focus when TOGGLE command is issued to OverviewCommandHelper." into main 2025-03-20 06:42:50 -07:00
Pat Manning 1ecece51d7 Update recents focus when TOGGLE command is issued to OverviewCommandHelper.
Removing condition that was added in ag/32267401.

Fix: 404098161
Test: Manual.
Flag: EXEMPT bugfix
Change-Id: I62d061d3c5588c846038b580f323aaebb9c667cf
2025-03-20 04:24:07 -07:00
Pat Manning 0ad72c5837 Allow fast flinging to cancel task dismiss.
Fix: 404213155
Test: Manual. Fling tasks back to rest state.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I7b738b80c375fe96994798ffadc9b5f77dd8a208
2025-03-20 11:22:40 +00:00
Johannes Gallmann be97a35d31 Merge "Fix back button not reacting to accessibility actions" into main 2025-03-20 03:50:14 -07:00
Johannes Gallmann 4d1ab3a784 Fix back button not reacting to accessibility actions
Bug: 403184586
Test: Manual, i.e. verified that back button is clickable with TalkBack
      enabled. Also verified no regressions in kids themed taskbar.
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: Ie6fd6b7d8a76cdac0389c4dd33f8cb62f689ba61
2025-03-20 09:24:27 +01:00
Treehugger Robot 57f0e8ebe6 Merge "Add flag to gate checking last task visibility on dismiss." into main 2025-03-20 00:36:11 -07:00
Priyanka Advani (xWF) 5283a91609 Merge "Revert^3 "Inflate TaskThumbnailViewDeprecated as TaskContentView"" into main 2025-03-19 14:53:59 -07:00
Priyanka Advani (xWF) 92aef0d99a Revert^3 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bca368924c.

Reason for revert: Droidmonitor created revert due to b/404894013. Will be verifying through ABTD before submission.

Change-Id: If43e23bca9f7e62f26ee3c977cac643fcda3e3e6
2025-03-19 12:56:55 -07:00
Uwais Ashraf f7d0e2a576 Remove existing superceded calls to updateDisableFlags
Fix: 402351284
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest (attached abtd run)
Test: OverviewMenuImageTest (attached abtd run)
Change-Id: Iffea8cd0afea52cfbfd8ed44a956da0aa26e91c6
2025-03-19 18:04:01 +00:00
Uwais Ashraf 7fd33ebde5 Change actions view disabling logic
1. Introduces "central task" - the task relating to the actions view
2. Decouple the overlay and actions view
3. Undo filter of taskViewType == SINGLE for overlay as it can be enabled for split tasks as well

Bug: 402351284
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest (attached abtd run)
Test: OverviewMenuImageTest (attached abtd run)
Change-Id: Id7bc5c9c6620183d91e99d9dc5d2980eb8e3ec36
2025-03-19 18:03:52 +00:00
Jon Miranda ed79f7f269 Merge "Crop based on real-time insets" into main 2025-03-19 10:28:40 -07:00
Sam Cackett 302a61748a Merge "Revert^2 "Inflate TaskThumbnailViewDeprecated as TaskContentView"" into main 2025-03-19 10:15:29 -07:00
Sam Cackett bca368924c Revert^2 "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit 1048b2711c.

Reason for revert: Reland CL with fix

Original message:
Inflate TaskThumbnailViewDeprecated as TaskContentView

If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Bug: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug

Change-Id: Ib43331023d99316c7b0c9de2ab81e379db58bb50
2025-03-19 10:05:25 -07:00
Alex Chau ddc72547d4 Merge "Correct the call of getExpectedCurrentTask" into main 2025-03-19 07:55:32 -07:00
Jordan Silva e3437e4f12 Merge "Fix Chip menu expanding outside the screen" into main 2025-03-19 07:00:27 -07:00
Pat Manning 28b827b489 Add flag to gate checking last task visibility on dismiss.
Bug: 404203362
Test: Manual. Open 9 apps, dismiss all bottom grid tasks, dismiss first top task, observe no jump.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ie21d234f6a44c4566c4f73d4cc3c32f6a8375e6d
2025-03-19 13:44:56 +00:00
Will Osborn b307f55a19 Merge "Small fixes for per-display TaskAnimationManager" into main 2025-03-19 06:23:32 -07:00
Treehugger Robot 8b312ff5bb Merge "Refactor: Use AppChipStatus enum instead of isExpanded boolean" into main 2025-03-19 06:19:44 -07:00
Treehugger Robot 91a790754b Merge "Only accessing mListeningHolders on main thread" into main 2025-03-18 13:23:12 -07:00
Tony Wickham 1588bb1a57 Merge changes I1b67d065,Ib2e7f859 into main
* changes:
  Don't show hover tooltip while an app popup is open
  Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
2025-03-18 11:38:05 -07:00
Treehugger Robot 1c0d0fa376 Merge "Remove FLAG_SPLIT_TOUCH from launcher code" into main 2025-03-18 11:37:17 -07:00
Pat Manning 81b6d25bb8 Merge "Prevent jumping to last grid task when not visible." into main 2025-03-18 11:22:34 -07:00
Jordan Silva d2e930bbb7 Fix Chip menu expanding outside the screen
This CL removes isLandscape condition from menu translation that
prevents Comet to translate the menu with split app. The menu needs to
be translated when in split screen mode, regardless of orientation.

Fix: 404549940
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: I5e4d07a9f1d2e36b847808aec9ae348a7ef78f59
2025-03-18 11:18:55 -07:00
Pat Manning 337b3ea7b0 Merge "Play haptic after dismissal even if no neighbors spring into place." into main 2025-03-18 11:10:16 -07:00
Pat Manning f3ef4e9961 Merge "Prevent multiple competing dismissals." into main 2025-03-18 11:04:47 -07:00
Liana Kazanova (xWF) defa140c20 Merge "Revert "Inflate TaskThumbnailViewDeprecated as TaskContentView"" into main 2025-03-18 10:04:13 -07:00
minch 683c68af39 Correct the call of getExpectedCurrentTask
Bug: 401582344
Flag: EXEMPT bug fix
Test: m
Change-Id: I683be73a6632ba719396d44454a8650bbee7267d
2025-03-18 09:57:52 -07:00
Liana Kazanova (xWF) 1048b2711c Revert "Inflate TaskThumbnailViewDeprecated as TaskContentView"
This reverts commit bba7e8af37.

Reason for revert: DroidMonitor: Potential culprit for http://b/404515699 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Iadb65f37b9712c3d6e5943847520ca3bd76624c7
2025-03-18 09:26:32 -07:00
Will Osborn 1f5a92ed1a Small fixes for per-display TaskAnimationManager
Test: locally tested on Tangor
Flag: EXEMPT bugfix
Bug: 402362875
Change-Id: I37d3f563c30b019de8b43896b94a599c836f0dac
2025-03-18 16:15:28 +00:00
Jordan Silva f41ec597ef Set the elevation for TaskMenuView when overview icon menu is enabled.
Bug: 317007147
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Change-Id: I7c8b0a181e39bdf2d2048b87d6ceecf2b95e3265
2025-03-18 15:13:38 +00:00
Pat Manning 9fdc7032ba Play haptic after dismissal even if no neighbors spring into place.
Currently haptics will play as the neighbors reflow into place, but if none reflow, we also want a haptic to fire.

Fix: 398198796
Test: Manual. Dismiss end task so none move, feel haptic play.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I467a45472992722bcd05ef31cbaeb157441c4931
2025-03-18 15:10:53 +00:00
Jordan Silva 6c25c4dce3 Refactor: Use AppChipStatus enum instead of isExpanded boolean
- Replaced the boolean `isExpanded` flag in `IconAppChipView` with an enum `AppChipStatus` for better state management.
- Added `AppChipStatus` enum with `Expanded` and `Collapsed` states.

Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ibbf8ccd963e540f5bd766569a1df01ad1bafd4c0
2025-03-18 14:51:45 +00:00
Treehugger Robot 1f500d3cd3 Merge "Inflate TaskThumbnailViewDeprecated as TaskContentView" into main 2025-03-18 05:35:14 -07:00
Pat Manning 832f178138 Prevent jumping to last grid task when not visible.
Fix: 404203362
Test: Manual. Open 9 apps, dismiss all bottom grid tasks, dismiss first top task, observe no jump.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I11058b90b7d8c90256329849554886d652624926
2025-03-18 12:26:41 +00:00
Treehugger Robot e5cebbd9ca Merge "Do not notify desk mode changes on visible desk tasks count changes" into main 2025-03-17 18:29:02 -07:00
Tony Wickham 88a9e18f7c Don't show hover tooltip while an app popup is open
Flag: EXEMPT bugfix
Test: TaskbarHoverToolTipControllerTest
Fixes: 397243128
Change-Id: I1b67d065e9e79e13a5a341a5d133da700ef5f40c
2025-03-17 22:36:27 +00:00
Sunny Goyal ff41a8bf66 Only accessing mListeningHolders on main thread
Bug: 402648481
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I037fff805be0b52407ed020e33aeb9db45616dd9
2025-03-17 14:32:04 -07:00
Alex Chau 4a60b862e2 Merge "Update scale on TaskView instead for select mode" into main 2025-03-17 13:12:09 -07:00
Treehugger Robot ab933e6098 Merge "[CD Taskbar] Move DisplayController method calls to BaseTaskbarContext" into main 2025-03-17 12:11:06 -07:00
Siarhei Vishniakou 8dd9181a3d Remove FLAG_SPLIT_TOUCH from launcher code
The splitting behaviour is now permanent, so this flag is deprecated and
it's no longer necessary to set it.

Bug: 239934827
Test: TEST=inputflinger_tests; m $TEST && $ANDROID_HOST_OUT/nativetest64/$TEST/$TEST
Flag: NONE removing flag
Change-Id: Ie7dafaeffdb6f5854a61e6ece0217d8bf5e496af
2025-03-17 11:59:05 -07:00
Shamali Patwa fedb2319af Merge "Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call" into main 2025-03-17 11:19:13 -07:00
Sam Cackett bba7e8af37 Inflate TaskThumbnailViewDeprecated as TaskContentView
If the enableRefactorTaskThumbnail is false, then inflate
TaskThumbnailViewDeprecated as TaskContentView so that the behaviour
matches the previous pre-factor behaviour

Fix: 402277471
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual. See bug
Change-Id: Ie62d4d83d0a16d965820d2a218a44478b660a806
2025-03-17 17:45:34 +00:00
Sunny Goyal d7a1c17988 Merge "Moving LauncherAppWidgetHolder to dagger" into main 2025-03-17 10:42:15 -07:00
Jon Miranda a3f54bae16 Merge "Relayer taskbar to application_overlay when shade is opened" into main 2025-03-17 09:15:29 -07:00
Orhan Uysal afd0b905e2 Merge "Temporarily add a null intent check." into main 2025-03-17 09:04:45 -07:00
Shamali P 56dd87a584 Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call
It is now injected via a factory so a new instance is used each time.

Bug: 399641570
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Iee703f0c954c95599c07ceb788edabb0d808abb2
2025-03-17 14:41:53 +00:00
Alex Chau 843a881e7c Update scale on TaskView instead for select mode
- Avoid zooming in RecentsView in Select mode, instead zoom in the selected TaskView only to avoid changing RecentsView's scale and pivot, otherwise when doing home gesture in Select mode RecentseView zoom will be distorted
- Set taskModalness on all TaskViews, so they can fade out while entering Select mode, this avoid janky transitionig of non-selected TaskView appearing during hoem gesture
- Keep overviewGridEnabled true until transitioning out of a RecentsView visible state, so showAsGrid() remains true and the Overview grid won't deform midway through animating
- When leaving Select mode to RecentsView invisible state (e.g. Home), leave taskModalness 1 until the last frame so selected TaskView remains zoomed in until RecentsView is invisible

Fix: 322818393
Test: OverviewTaskSelectImageTest
Test: Repeat with combination of default/fallback, live/static tile, handheld/tablet
1) Swipe up from Overview
2) Swipe up from Select to go Home
3) Backc/cross button to exit Select to Overview
Flag: com.android.launcher3.enable_grid_only_overview

Change-Id: I8fec62315cbd404502852654772edb1d695f1ec6
2025-03-17 14:39:40 +00:00