- Also limit usage of displayContext on getWindowCornerRadius only, any other usage causes perf regression
- Note that displayContext does not respond to configuration changes, there might be existing functionality bug already that resources are stale after configuration changes, keeping b/408988616 open to handle it in the future
Bug: 408988616
Fix: 409222870
Fix: 409252967
Test: presubmit and ABTD
Flag: EXEMPT refactor
Change-Id: I024c76326a2deb1ecc035de8319976e31887486b
Previously snapToPageImmediately was used, but that was the wrong method.
Bug: 408227356
Test: Verified that the animation runs well locally on device.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Iedee458e61de2d3542137615d3ff86cb42bdfb02
setLaunchedFromA11y makes keyboard not to be shown when "swipe to start search" toggle is off and we do launcher.getStateManager().goToState(ALL_APPS)
"All Apps" was added to Menu as part of A11y requirement in b/386737601, so using setLaunchedFromA11y looks right.
Video : https://b.corp.google.com/issues/407947978#comment9
Bug: 407947978
Test: Manual
Flag: EXEMPT Bugfix
Change-Id: I84162940330a74b3433f7835753151adf55857e7
Bug: 407630150
Test: Manual testing, that's why the bug happen in the first place, working on adding tests, for now this fixes the issue.
Flag: EXEMPT bug fix
Change-Id: I98c9d4bb28a3f02ee6e54c66eadb54445c56aeec
Bug: 394355070
Test: Attached a screen recording of correct behavior to the bug.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I1e99c4eb9ae79b7d00dadf286689cceb2f0e706e
Also adding plugin support for IconProvider
Bug: 366237794
Flag: EXEMPT refactor and extra code behind plugin
Test: Manual
Change-Id: Id286f88b2683e0fabc48c57b7920024f06dd7539
Also, in Folder.java the DeviceProfile obtained using the activity,
in this case the Activity is TaskbarActivityContext is returning
a different DeviceProfile form the Launcher which causes the update.
So this triggers an update when is not needed but even if we make
a faulty update the workspace should be able to differentiate
between workspace item and folder items.
This issue was triggered by this flag
com.android.window.flags.enable_taskbar_recents_layout_transition .
Fix: 407630150
Test: NA
Flag: EXEMPT bug fix
Change-Id: I255052506e7d198b1384c15ebfe2f6f2753da1ed
- Moved HintState to quickstep to have access to BlurUtils
- Added a dummy HintState outside quickstep
Fix: 406308427
Test: manual
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I8aa2407d87b429584168ebb0601cfffcccad0cfa
- Provides a per-display instance of WindowContext to avoid creation of Context
- Inject WindowContext instead of ApplicaitonContext in RotationTouchHelper to have a display associated context required by ScreenDecorationsUtils, as well as being able to have updated Resources upon configuration changes
Bug: 407878199
Test: Verified mWindowContexxt.resources.configuration is updated upon fold/unfold/rotate,
Flag: EXEMPT refactor
Change-Id: Ic032ae3c8c818b150f5e6fca0d531a19ad38986b
- This avoids flags from being enabled in Trunkfood partrial unless the dependency is also enabled
Bug: 408178115
Test: build and smoke test
Flag: EXEMPT flag only
Change-Id: Iccf9a9368383ab14a9abf7a1198c8a0c372b103f
In the previous image tests, the page indicator placement within folders
was inconsistent depending on the number of pages in a folder. This change fixes that by removing the margin_End for the page indicator in folders, as well as fixing the onMeasure call in PageIndicatorDots to be the same as the legacy calculation, just with additional space for the arrows.
Previously, the touchboxes were very small, and difficult to use. To enlarge the touchbox, enlarged padding is used. This means when the indicator & arrows are visible, we need to remove the margin from the layout container and move it to padding for the indicator.
Bug: 394355070
Test: Tested folders with 2, 3, and 18 pages in both left to right
and right to left mode.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I3a5d9d6d77dec963865adede1c4bfe38890d608f
Ensure that the EnableMouseInteractionChanges feature only affects
desktop devices, by adding a check for the desktop_form_factor value.
Flag: com.android.launcher3.enable_mouse_interaction_changes
Bug: 388897603
Test: Manual
Change-Id: I483def8ca249a83e5d028e71db74ec85a700bfb4
- TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey was failing because RecentsWindowManager didn't dispatch key events at all.
- Also moving all LauncherRootView setup to a one-time execution
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 368610710
Bug: 377678992
Test: TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey
Change-Id: I9d8e0c91a549ed08398b2c89b1e4d23561f95c62
Theme icons are generated and stored in cache, but only loaded if requested in lookup flags
This allows to keep the memory usage low, but not loading theme icons for all the apps
Bug: 381897614
Flag: com.android.launcher3.extendible_theme_manager
Test: Updated tests
Change-Id: I494eab9c4f70670e6f5aeb864ed5287f6b9f1b9e
I had previously hidden workspace with All Apps blur because the
approaches I had tried looked poor. However, I found that this
approach is both simple and relatively performant! Essentially,
wallpaper is still pushed back and blurred by the DepthController.
When the DepthController applies blur, we also apply it to the
Workspace and Hotseat. In addition, we scale these at the same
rate as the depth when swiping to all apps. Perhaps we can have
the DepthController control this scale too, but for now we just
use the same Interpolator. The result looks pretty cohesive.
Demo: https://drive.google.com/file/d/1KyKc0c5BsAEOrT3K4buOW3U9-Gk0e7vE/view?usp=sharing&resourcekey=0-MI1gdQMul0cro9IEkQDEng
App exit demo (slightly outdated): https://drive.google.com/file/d/1r-VhzGhlI0300_6IUXthty3Tm1cgw9aI/view?usp=sharing&resourcekey=0-nxZ2BHW2UN34lr567I0RdA
Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I5dc66619a001ccd32f37272cf77966cbe1bf8ef6
There is extra work needed from the Wallpaper picker side to support
showing the FixedLandscape view on the Launcher. They are already
working on it but in the meantime we will disable the preview and show
the portrait view instead.
Fix: 402353157
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I12942a8f4edb7eff537d8431880cfe108e161ed2
The psApp icon will have an original title "Private Space" but should
only be "Add" in the container.
bug: 360313403
Test: manually:
Before: https://hsv.googleplex.com/6348079987949568
After: https://hsv.googleplex.com/6126091247812608
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: Ifcb599cdb5f4a97e2da68cafa81f23b387a2beb6
Stefan Andonian
Alex Chau
Treehugger Robot
Sebastián Franco
Brian Isganitis
Anushree Ganjam
Sunny Goyal
Charlie Anderson
Jordan Silva
Matthew Mourgos
Andy Wickham
Schneider Victor-Tulias
Brandon Dayauon
Federico Baron
Will Osborn
Shamali Patwa