Commit Graph

78507 Commits

Author SHA1 Message Date
Tracy Zhou ab6ce8c7e2 Merge "Fix NavButtonLayoutFactoryTest setup to turn on enableTaskbarNavbarUnification" into main 2024-02-14 03:03:56 +00:00
Andy Wickham 0ae51bcdb9 Extract TaskbarViewCallbacks to a separate class + factory.
Also log long presses on the taskbar all apps button.

Test: Manual
Flag: NA
Change-Id: Id2bf194f09007bfccff9f83162e4bcfb6562580f
2024-02-13 18:51:48 -08:00
Vinit Nayak 5a9d4af170 Log split metrics through individual sessions
* Now we log the original source of the first selected app
as soon as the user selects it (previously we only did when user
selected second app)
* We log the item info for the second app to determine second
surface.
* Added new metrics to log after user has started a split session
and ended a split session
* We log different cancellation reasons (cancel button,
home gesture, general other app interruptions, etc).
* One KI/Bug: When the second app is selected via taskbar in
overview, the container will say hotseat because we are using
Launcher's logger and not Taskbar's. Taskbar's logger manually
overwrites the container in TaskbarActivityContext, we may be
able to make something hacky that can allow us to overwrite, but
that'll have to be a separate change

Bug: 322551862
Test: Logged metrics manually with event and itemInfo
Change-Id: I177623fd00ce62acf2d4ee983b58561d8c946d59
2024-02-13 17:55:08 -08:00
Brandon Dayauon c2ec07da51 Merge "Fix FastScroller jumping in recyclerView" into main 2024-02-14 00:32:26 +00:00
Sunny Goyal dc7cdd8b0c Sending original motion events to launcher overlay along with inferred values
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: Manual
Change-Id: I23cd72a964a647a0fd830befa096f3328e12ff8a
2024-02-13 16:26:37 -08:00
Android Build Coastguard Worker b071d2f269 Snap for 11444858 from fda1b4b0d0 to 24Q2-release
Change-Id: Ia195bc0028b0a6fcc7ee03aa452f8ae9a5c7349b
2024-02-14 00:21:26 +00:00
Android Build Coastguard Worker c58ee19c27 Snap for 11444718 from 00538c2a5a to 24Q3-release
Change-Id: Ia1a039925dddbd88edb6a2bf761ced0dfe437f2f
2024-02-14 00:21:25 +00:00
Federico Baron 33c719622f Merge "Add screenrecord for testAllAppsFromHome()" into main 2024-02-14 00:14:55 +00:00
Andrew Cole 1f36803a6d Merge "Sort Apps During setApps" into main 2024-02-14 00:05:31 +00:00
Schneider Victor-tulias bd5ffee884 Show scrim immediately when animating to overview from app through KQS
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324888882
Test: opened overview from app/home with finger swipe/KQS/overview button
Change-Id: Ia4a15f5a64956ec56fc9aae3511173219616245e
2024-02-13 19:00:04 -05:00
Schneider Victor-tulias 322410712a Update the KQS overflow icon
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324886878
Test: opened KQS with 0 and 7+ recent apps
Change-Id: I2496841c6d8bb24d1c90d58eecc18726827ae993
2024-02-13 23:49:25 +00:00
Schneider Victor-tulias 4a9ffb021f Merge "Update KQS empty message text/icon colors" into main 2024-02-13 23:46:31 +00:00
Saumya Prakash bb3af5d904 Add insets for taskbar when a camera cutout interrupts it
Certain devices have camera cutouts that taskbar's insets did not account for previously. This change adds in the cutout's height as a bottom inset (if it is present) to avoid a black bar being drawn in the taskbar area.

Fix: 322954760
Test: Open a full screen app on a large screen device and ensure that a black bar doesn't show up when rotating the screen to 90 degrees and 180 degrees.
Flag: N/A
Change-Id: I876274b561c7f0101554654ce758fc9c08180de7
2024-02-13 23:00:21 +00:00
Saumya Prakash e1c6312800 Merge "Update back gesture tutorial strings to align with UX" into main 2024-02-13 22:48:17 +00:00
Vadim Tryshev dbaa758854 Doubling the wait time for activity creation in PortraitLandscapeRunner
Apparently, 10 sec is not sufficient, let's try 20.

Bug: 321772674
Test: presubmit
Flag: N/A
Change-Id: Iec67e4d0cf782d7d966566c305e8b73ee67d0f67
2024-02-13 13:50:15 -08:00
Willie Koomson fda1b4b0d0 Merge "Use generated RemoteViews preview for widget picker if available" into main 2024-02-13 21:18:45 +00:00
Brandon Dayauon 6bebf0bb80 Fix FastScroller jumping in recyclerView
FastScrolling is jumping crazily when VerticalSnapPreference is set SNAP_TO_START, rather SNAP_TO_ANY may be better.

bug:321835976
Test manual video:
before: https://drive.google.com/file/d/1OOWESXjclndNgDklPq1BXR5HDehqJuPe/view?usp=sharing
after: https://drive.google.com/file/d/1O6wRx4H9R-Di-lPTOY7SwrsxrBPhXHo-/view?usp=sharing
Flag: n/a

Change-Id: I6974c842aa88f6bc7df1011c05eecfde7dad766c
2024-02-13 13:16:49 -08:00
Vadim Tryshev 00538c2a5a Merge "Allowing the test to set additional anomaly checker for TAPL" into main 2024-02-13 21:16:41 +00:00
Tracy Zhou 91546d401d Do not add jank monitor for stash state change when the drag layer is not attached to the window
An alternative here is to use the root layer when NO_RECREATE flag is on. However, we do not have a reference to it here (shall we consider passing it in?)

Fixes: 325096498
Test: Need to verify
Change-Id: I1709bc88753a90547f7a61dc6e24cdaf489d19e0
2024-02-13 20:57:16 +00:00
Tracy Zhou d6bd6ae769 Fix NavButtonLayoutFactoryTest setup to turn on enableTaskbarNavbarUnification
Fixes: 325084350
Test: run the unit test without guarding the flag, make sure it passes
Change-Id: If902aeb7e9f06bfa4fa2876995cb67e350839a91
2024-02-13 11:18:46 -08:00
Jakob Schneider 38e4471794 Merge "Version-2: Prioritize the session-provided icon & label for archived apps during unarchival in the iconCache." into main 2024-02-13 19:09:52 +00:00
Willie Koomson fedc18e9a8 Use generated RemoteViews preview for widget picker if available
WidgetCell will use the generated RemoteViews preview to display
previews in the widget picker. It will fallback to current preview
methods if not available.

Introduces WidgetManagerHelper.loadGeneratedPreviews as a utility
function. WidgetManagerHelper is passed into the constructor of
WidgetItem to avoid calling
context.getSystemService(AppWidgetManager.class) for each widget.

Bug: 308041327
Test: atest Launcher3Tests:GeneratedPreviewTest
Flag: ACONFIG com.android.launcher3.enable_generated_previews DEVELOPMENT
Change-Id: I37429057cda83a5321884ace2537038e050b9a58
2024-02-13 18:49:44 +00:00
Anna Zhuravleva f843af4084 Merge "Update icon for install to private shortcut" into main 2024-02-13 18:00:29 +00:00
Mady Mellor 9a1fb27508 Merge "Follow changes for MagneticTarget.Listener to pass the dragged object" into main 2024-02-13 17:47:30 +00:00
Anna Zhuravleva 0190ea3ea7 Merge "Grant access hidden profile permission to Launcher3" into main 2024-02-13 17:07:43 +00:00
Charlie Anderson e5b1215a2a Merge "Add additional unit tests for WorkspaceItemProcessor to cover shortcuts and folders. Also cleanup the test suite." into main 2024-02-13 16:51:45 +00:00
Schneider Victor-tulias 7bfd3ef9a0 Update KQS empty message text/icon colors
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324902935
Test: opened KQS with 0 recent apps
Change-Id: I1aed3293d76c0f3abbf6e5e0d646531739eac3f8
2024-02-13 10:40:16 -05:00
Alex Chau 4e6e1555c4 Refactored StateManager logs
- Make the log permanaent behind a DEBUG flag
- Logs are currently enabled with b/279059025 marked as the related bug

Bug: 279059025
Flag: None
Test: Manual
Change-Id: I60a75d73d40d00e7d42292f3d42cc9dd8c9b0825
2024-02-13 15:35:15 +00:00
Charlie Anderson 887f49e231 Add additional unit tests for WorkspaceItemProcessor to cover shortcuts and folders. Also cleanup the test suite.
Bug: 294386159
Test: unit tests and presubmit
Flag: N/A

Change-Id: I33370f2a060d1e07fc7dbd37cc9a883501344551
2024-02-13 10:05:32 -05:00
Jordan Silva 3a42f0e0eb Merge "Log split button visibility to debug spacing issue" into main 2024-02-13 11:44:11 +00:00
Alex Chau fba34d89e4 Merge "In bindAllApplications, only switch to NORMAL while in ALL_APPS" into main 2024-02-13 11:37:50 +00:00
Vinit Nayak 8ca8368730 Merge "Set debug logging flag for ClockDrawableWrapper" into main 2024-02-13 06:08:57 +00:00
Tracy Zhou 92f9d10cea Merge "Hide task bar when folding before the new config renders the correct task bar" into main 2024-02-13 03:52:03 +00:00
Tracy Zhou dfb334f1e1 Hide task bar when folding before the new config renders the correct task bar
Currently on folding, onConfigurationChange doesn't return about 0.5sec after the small screen turns on. The old bar is visible on the new screen before a visual jump from rendering the new bar.

While the ideal solution is to figure out what causes the delay, we can mitigate the visual jump by dimming the old bar when folded listener returns folded

Test: repeatedly fold and unfold, observe that there is no glare task bar change in task bar area after folding
Bug: 291562764
Change-Id: Ic6834d2d3b7df01a8ef841dde601cdb6a3e481b0
2024-02-12 17:06:04 -08:00
fbaron 0c12987627 Add screenrecord for testAllAppsFromHome()
Bug: 322228038
Test: TaplOpenCloseAllAppsTest
Flag: NONE
Change-Id: I3bcb13c1256df8d0029dfe32d21e95d6b4183037
2024-02-12 16:35:49 -08:00
Saumya Prakash 96ce6873dd Update back gesture tutorial strings to align with UX
This change updates the feedback shown to users to align with the
strings in figma for the back gesture tutorial.

Fix: 300919987
Test: Went through both the redesigned and previous gesture tutorial and
ensured the updated strings show up in the redesigned tutorial.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I057af6e8631b86ffaec8093ffbfbeae01c9d917c
2024-02-13 00:35:37 +00:00
Shamali Patwa 028482609c Merge "Set accessibility pane title for right pane on updating content." into main 2024-02-13 00:33:11 +00:00
Android Build Coastguard Worker ac1adf98c0 Snap for 11438798 from 88b89d68fb to 24Q3-release
Change-Id: I0b8a6ecd561b8fcf130b2153e0e5360291a6b693
2024-02-13 00:22:33 +00:00
Android Build Coastguard Worker b43c644797 Snap for 11438811 from 88b89d68fb to 24Q2-release
Change-Id: I112cf98406de00840dd223fe594007931b602603
2024-02-13 00:21:25 +00:00
Vinit Nayak 84c7e4e84d Set debug logging flag for ClockDrawableWrapper
Bug: 319168409
Change-Id: Id154287a12e1b51a0aeabacebcd32bc695bdcc0b
2024-02-12 16:11:31 -08:00
Brandon Dayauon 5faed49eaf Merge "Fix color contrast in All Apps text by setting the color to onSurfaceVariant" into main 2024-02-12 23:15:05 +00:00
Schneider Victor-tulias 11e19c139b Merge "Add debug logs to MotionPauseDetector" into main 2024-02-12 22:28:28 +00:00
fbaron 88b89d68fb Restore state of widget picker on fold/unfold
Specifically:
-keep selected tab (personal/work)
-keep search results

Fix: 323406345
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker TRUNKFOOD
Change-Id: I919e59484f3af7a2b3b007f5c234055a0f7276b3
2024-02-12 21:13:46 +00:00
Schneider Victor-tulias 49bdc5d7ea Add debug logs to MotionPauseDetector
Flag: NONE
Bug: 321123090
Test: checked TIS logs
Change-Id: If389226c60b5115fcf90e76733383c74ceb7fbcd
2024-02-12 15:09:34 -05:00
Shamali P 13c6727601 Set accessibility pane title for right pane on updating content.
This will let users know that content appeared on right when they
selected an option on left.

Note: This is announced _only_ when content changes.

Bug: 324073588
Test: Manual with talkback
Flag: N/A
Change-Id: Icec3242d8f250f6d19e082a39927165c7b8fc86a
2024-02-12 19:48:41 +00:00
Tony Wickham e5451b10e4 Merge "Add CUJ annotations for going to Recents from Home" into main 2024-02-12 19:13:11 +00:00
Alex Chau 61d193821e In bindAllApplications, only switch to NORMAL while in ALL_APPS
- Otherwise, it can unexpectedly switch to NORMAL during a swipe up to Overview, causing issues with live tiles

Fix: 288557298
Test: Go to settings, change display size, immediately swipe up to Overview
Flag: None
Change-Id: I1eaf988d488c6662fd291f46a7cc0861664d8d38
2024-02-12 17:37:18 +00:00
William Leshner 2d30ff33e0 Merge "Add widget category filter to WidgetPickerActivity." into main 2024-02-12 17:30:46 +00:00
Brandon Dayauon 5787a2710c Add home settings toggle featureflag for enablingTwoLineText
- Have shouldUseTwoLine() be decided with the home settings toggle value

bug:316027081
spec: https://www.figma.com/file/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?type=design&node-id=405-384593&mode=design&t=UBkdeuNlAdRh2FGU-0
Test:
Video: https://drive.google.com/file/d/15VUhNVro2fiwv3SzMda1StiPb3PV1eMT/view?usp=sharing
before searchPreferenceScreen: https://screenshot.googleplex.com/3uqdMsZoGSBYb6c
after searchPreferenceScreen: https://drive.google.com/file/d/15dswiHRTnafyhgQA_tL2tRc7vHFWdHbZ/view?usp=sharing
before homeSettingsPage: https://screenshot.googleplex.com/7wsNevxGun2KCCB
after homeSettingsPage: https://drive.google.com/file/d/15m5bjEyewlNHI_h26aygHa7zrgZ5qDF6/view?usp=sharing
AppListSettingsPage: https://drive.google.com/file/d/15hl4ScHBOLgKv3M38HtatMxQw85pgl7t/view?usp=sharing
Flag: enableTwolineToggle DEVELOPMENT

Change-Id: I3ad133dd51dcb97e14ccded730e7737c5049261a
2024-02-12 09:24:48 -08:00
Jordan Silva 2d55c9c679 Log split button visibility to debug spacing issue
Bug: 321291049
Flag: N/A
Test: N/A
Change-Id: Id998be1c8337dfc3617893726dcb5d96fb6a35b8
2024-02-12 16:46:43 +00:00