Commit Graph

78507 Commits

Author SHA1 Message Date
Alina Zaidi a9a5ecf3dc [dev_option][More flags 4/n] Update all usages of Taskbar-show running
apps flag to use DesktopModeFlags.

Test: Current tests pass
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: Id63de7c9630fcc5ab2185829b42883e51774cfcf
2024-07-31 15:34:46 +00:00
Luca Zuccarini 3cdabb8864 Move some Shell utils to the Shared package.
Bug: 322791067
Flag: EXEMPT move only
Test: NA
Change-Id: I8a827a200340fd1ee0168ed16c4f5223150a1795
2024-07-31 14:10:54 +00:00
Charlie Anderson 00fb1adab4 Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 114e84908f.

Reason for revert: b/356166053

Change-Id: I30dfbc5da1caecd89b4b23aafe4de8e9efede6a0
2024-07-31 14:08:16 +00:00
Alina Zaidi 00614eae0e Use DesktopModeStatus#canEnterDesktopMode instead of just Flag check.
Test: Existing tests pass
Bug: 349544589
Flag: EXEMPT minor refactoring
Change-Id: Idf572d48d35b8eeedd7fd1b8c608834d27a818e7
2024-07-31 10:47:16 +00:00
Sebastian Franco e356978869 Adding logging for backup and restore
Bug: 353505773
Test: compiles
Flag: EXEMPT bugfix
Change-Id: I4c1e56365332557fa95a11526498505bf2063e12
2024-07-30 18:47:37 -07:00
mpodolian 484ff0fe9c Integrated new BubbleStashControllers into the existing code.
Integrated the PersistentTaskbarStashController and the
TransientTaskbarStashController into the launcher code. Made changes to
the TaskbarInsetsController to set appropriate touchable zones. Updated
the TaskbarUIController to not start the overview transition on clicks
for the collapsed bubble bar.

Bug: 346391377
Fixes: 350065038
Fixes: 355664783
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar
Test: com.android.launcher3.taskbar package tests

persistent taskbar and transient taskbar manual testing:
- on launcher home screen expand bubble bar, switch between bubbles,
remove bubble via bubble menu, add bubble, remove bubble with the drug
gesture, add bubble, collapse bubble bar
- repeat previous test on launcher overview screen and inside any
application
- after last test drag expanded bubble view to the opposite side of the
screen

Change-Id: I50f2c510854c4895fdfc9bd453a261c2103286fd
2024-07-30 18:36:05 -07:00
Vadim Tryshev 9fc3734030 Clearing package data as recommended by owners of the "pm clear" command
Bug: 353541583
Test: running on abtd
Flag: NONE test change
Change-Id: I227eb145f5c2fa5c07972bae15fb66e69e623dd8
2024-07-31 00:50:00 +00:00
Jagrut Desai f35cb42732 Merge "Initialize TaskbarFeatureEvaluator and SpecsEvaluator onlyu if customization is on" into main 2024-07-30 22:19:10 +00:00
Treehugger Robot 779c79129b Merge "Fix grid migration item copy bug" into main 2024-07-30 20:19:19 +00:00
Brandon Dayauon dfb1722afc Merge "Make a dummy view at the bottom of all apps" into main 2024-07-30 20:15:26 +00:00
Vinit Nayak 0e5e564557 Merge "Call FallbackRecentsView#init() before setContentView()" into main 2024-07-30 20:05:11 +00:00
Bill Yi 1cb02701b7 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 13d42e03c8 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28540078

Change-Id: I7bb9903128995f40e4806ccfe1aa636cb3c31e63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-30 19:41:34 +00:00
Mykola Podolian bd8b839e0d Merge "Added scrim visibility check." into main 2024-07-30 18:19:01 +00:00
Bill Yi fb7028c054 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-30 18:13:51 +00:00
Bill Yi e240b1c2f5 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-30 18:13:51 +00:00
Vinit Nayak aeecb1e8a5 Call FallbackRecentsView#init() before setContentView()
* Init sets mSplitSelectStateController which RecentsView
then uses in onAttachedToWindow(). That needs to be set
before it gets attached to the window, which happens in
RecentsActivity#setContentView()

Fixes: 332643607
Test: Only presubmit, issue not reproducible
Flag: EXEMPT bugfix
Change-Id: Icc555cad17b734e2a9c035991c19bbdc6b02de5d
2024-07-30 10:48:40 -07:00
Mykola Podolian 0211d2e168 Merge "Change shadow drawing for bubble bar icons." into main 2024-07-30 17:16:51 +00:00
fbaron 5ff84328f0 Fix grid migration item copy bug
When migrating from a grid with 2+ copies of the same item to a grid that has less copies of that item, but more than 0, the extra copies don't migrate to the new grid.

Bug: 354946925
Test: ValidGridMigrationUnitTest
Flag: EXEMPT bugfix
Change-Id: I76ad0cb0f5abe9b5bf895c07467fc05986e9fea4
2024-07-30 10:11:58 -07:00
Treehugger Robot 6a8f5ecced Merge "Revert "Add debug logs to BaseOverview#isActionsViewVisible"" into main 2024-07-30 17:07:14 +00:00
Treehugger Robot afc2f976e3 Merge "Revert "Initial view screenshot tests for BubbleView"" into main 2024-07-30 16:55:41 +00:00
Tracy Zhou 06483e97fd Merge "Fix tapl test failures from enabling task bar on the phones" into main 2024-07-30 16:36:03 +00:00
Jon Miranda e8b47c540f Merge "Add support for taskbar background to wrap around hotseat" into main 2024-07-30 15:59:48 +00:00
Liran Binyamin 3795d3782b Revert "Initial view screenshot tests for BubbleView"
Revert submission 28447963-launcher-view-screenshot-tests

Reason for revert: breaks the build -- conflicts with another cl

Reverted changes: /q/submissionid:28447963-launcher-view-screenshot-tests

Change-Id: If40903403d72e8b1bf776feccaa34dbc3e3e8ae2
2024-07-30 15:04:21 +00:00
Schneider Victor-tulias 533e1d2753 Revert "Add debug logs to BaseOverview#isActionsViewVisible"
This reverts commit 11eaec69f4.

Reason for revert: debug logs no longer needed

Change-Id: If0b2f33c63c86483e4d28df79086e80103fdb001
2024-07-30 14:44:46 +00:00
Liran Binyamin 419b917e74 Merge "Initial view screenshot tests for BubbleView" into main 2024-07-30 14:38:15 +00:00
Liran Binyamin 6c2e466edd Merge "Animate the bubble badge" into main 2024-07-30 12:35:32 +00:00
Alex Chau e7a87f3fa8 Merge "Don't show splash when thumbnail is null in SplashAlphaUseCaseTest" into main 2024-07-30 10:44:50 +00:00
Tracy Zhou 2293967dba Merge "Do not synchronizeNextDraw in phone mode" into main 2024-07-30 05:23:59 +00:00
Bill Yi 8c56588443 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2a55e6f10c3fe8d9b0cb69af89ef29446b8019dd
2024-07-29 18:57:40 -07:00
Bill Yi 13d42e03c8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I08c637e0cf765ffd4fdfc94f222a18854458c43e
2024-07-29 18:56:34 -07:00
Bill Yi e9f8e217aa Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I14929284692b154b650a199ae93fb7e7abc36dc4
2024-07-29 18:56:08 -07:00
Tracy Zhou 2003bc8dd8 Do not synchronizeNextDraw in phone mode
Bug: 355973871
Test: Needs to verify with perfetto traces
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: I84c258020951274915792d75d67c263135bbf2a9
2024-07-29 18:27:09 -07:00
Android Build Coastguard Worker c9091b8c51 Merge cherrypicks of ['googleplex-android-review.googlesource.com/28497164'] into 24Q3-release.
Change-Id: Iba1da3b5f49278b8a762194f0181d353cfb0d4d6
2024-07-30 00:02:54 +00:00
Alex Chau db1da412b8 Revert "Handle uiMode changes in QuickstepLauncher"
Revert submission 27627108-b/339747262

Reason for revert: b/353914086
Fix: 353450667
Fix: 353914086
Bug: 339747262

Reverted changes: /q/submissionid:27627108-b/339747262
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2676385eb81b7048c8f169ebf3b80b695103e952)
Merged-In: I9a71ee0fa4062b15e68eff41951f42d46ace19d3
Change-Id: I9a71ee0fa4062b15e68eff41951f42d46ace19d3
2024-07-29 23:56:09 +00:00
mpodolian c10de368a2 Change shadow drawing for bubble bar icons.
Removed an outline provider for the BubbleView, so framework shadows are
not drawn. Use BubbleBarBubbleIconsFactory to generate icon with the
shadow so it looks consistent with the taskbar and the hotseat bar.

Fixes: 345490679
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, screenshot before fix:
https://screenshot.googleplex.com/86ZhQENANboZK87
screenshot after fix:
https://screenshot.googleplex.com/3hNboaSaS9tZ9DS

Change-Id: I9ae3624e652e4f609b29ae0f57a47d4a6d01e94b
2024-07-29 16:25:54 -07:00
Jagrut Desai 5e8b535af6 Initialize TaskbarFeatureEvaluator and SpecsEvaluator onlyu if customization is on
Test: presubmit
Bug: 353841430
Flag: com.android.launcher3.enable_taskbar_customization
Change-Id: I5699e99eee0817327ca66598bfccb622801762ab
2024-07-29 15:14:55 -07:00
Brandon Dayauon 4a024c0834 Make a dummy view at the bottom of all apps
This is so that user can scroll all the way to bottom of all apps.
- updated tests to account for this new view

bug:340936636
Test manually:
before:https://drive.google.com/file/d/18mKMAedQh2uUOR2G4U_ZORIKP2tkRmEk/view?usp=sharing
after:https://drive.google.com/file/d/1UEl3kBfeInqxsgF2HwCfzOBEcsEqdbJ4/view?usp=sharing
Flag: NONE addingViewToBottomOfAllApps

Change-Id: Ib4b67a66cfc7ec2ba0dbbe211a241f244d204aaf
2024-07-29 14:58:25 -07:00
Charlie Anderson 6f699d23ea Merge "Handles Bold Text setting for inline icon by providing bolded cloud icon" into main 2024-07-29 16:15:58 +00:00
Liran Binyamin 612263104b Animate the bubble badge
The bubble badge now scales together with the expand and collapse
animation of the bubble bar. The badge for the selected bubble is
always kept at full scale.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349826874
Test: manual
       - create some bubbles in the bubble bar
       - expand and collapse the bar
       - observe badge icons scale accordingly
Change-Id: I04e9174f4a921e404cb3162337f594c16478b16c
2024-07-29 08:06:55 -04:00
Alex Chau 2a640c61a7 Don't show splash when thumbnail is null in SplashAlphaUseCaseTest
- thumbnail is always null to begin with, and we don't want the splash icon to ever shown in Overview, so it should default to hidden

Fix: 356079562
Test: SplashAlphaUseCaseTestTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I2a010f911814fda2bbcf0ca7ebc7192580772076
2024-07-29 11:28:19 +01:00
Liran Binyamin 4b4122d02e Initial view screenshot tests for BubbleView
Flag: EXEMPT test only
Bug: 355454021
Test: atest NexusLauncherViewScreenshotTests

Change-Id: I32c2a190333143c1ec2fe977efef43b4c04fd469
2024-07-29 04:39:28 -04:00
Tracy Zhou 8a4213b786 Fix tapl test failures from enabling task bar on the phones
https://android-build.corp.google.com/test_investigate/?invocationId=I33800010300127205&testResultId=TR49729385401905444

Bug: 355971327
Test: run tapl tests
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Iab463b0a439efd3e707384ca4c6588a1de28d7b9
2024-07-28 10:18:19 -07:00
Treehugger Robot 453734f09e Merge "Support switch to screenshot for TTV" into main 2024-07-27 00:14:26 +00:00
Jagrut Desai 65b5eb472e Merge "Unit Testing for TaskbarEduTooltipController" into main 2024-07-26 22:44:16 +00:00
Alex Chau 378622c907 Support switch to screenshot for TTV
- Moved live tile decision to TaskThumbnailViewModel, and added RecentsViewData for runningTask information
- Implemented a ThumbnailData override mechanism to override screenshot from TaskThunmbnailCache, the override will be added during switchToScreenshot and cleared when user exit recents (RecentsView.reset)
- During the thumbnail override, we wait until the new ThumbnailData propagates, before finsihing Recents animation to avoid a frame of flash

Bug: 343364498
Test: TaskThumbnailViewModelTest, TaskRepositoryTest, RecentsViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I776943ecdfa0d65d94b054692297b42686f59f8a
2024-07-26 21:25:58 +01:00
Andy Wickham 369a5e749b Merge "Add 2 stage LPNH tests." into main 2024-07-26 19:38:27 +00:00
Schneider Victor-tulias c8a533d542 Revert "Add debug logs to TopTaskTracker"
This reverts commit 86b9ad4ff7.

Reason for revert: debug logs no longer needed

Change-Id: Ia64f9e50934ac685f75f5109fc694720a07f17ac
2024-07-26 19:25:36 +00:00
Jagrut Desai 5af1bfbf52 Unit Testing for TaskbarEduTooltipController
This CL includes
	- TaskbarEduTooltipController Unit Test for all edu logic and hide tooltip
	- Test util class for taskbar controller test to run the test on main thread.
	- Refactored other controller test to use the new util function to run test on main thread.
	- Ability to disable running test in test harness mode.

Test: Presubmit
Bug: 346394824
Flag: TEST_ONLY
Change-Id: Ic623df8e7a58ac48d260e592ffab61d1f0658aef
2024-07-26 12:14:50 -07:00
Mykola Podolian 550927be44 Merge "Added TransientTaskbarStashController implementation." into main 2024-07-26 16:59:46 +00:00
Perry Wu f1e7136cce Merge "Fix launcher KCA updates when entering -1 screen" into main 2024-07-26 16:14:42 +00:00