Commit Graph

78507 Commits

Author SHA1 Message Date
Treehugger Robot 9b0164c832 Merge "Log UserManager users and cached users each time users accessed" into udc-dev am: ffdcac46b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23604024

Change-Id: Ia646635db407a3e81b909431b2259568e223a179
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 22:41:27 +00:00
Fengjiang Li d29db8ea4d Fix NPE where CellLayout is null when removing item out of folder
Fix: 282249989
Test: create a folder of 2 app icons, remove one icon out of folder, no crash
Change-Id: I3c132ec8833c7cb14066cc403c0641d089bab8ab
2023-06-07 15:36:54 -07:00
Brian Isganitis fd896ed6bd Make sure FLAG_IN_APP is set when launching apps from keyguard.
This flag was not being set in the case where you lock from launcher and
then unlock by tapping on launcheable items from keyguard such as home
controls, notifications, smartspace, etc. This change makes sure we
double check if we are unlocking to launcher or not and then setting
FLAG_IN_APP accordingly.

Test: manual
Fix: 284314711
Change-Id: If46697566d252c649a00a7b3d728a14789dc6aed
2023-06-07 18:28:30 -04:00
Brian Isganitis 63582a0a00 Report unstashed content insets for notification panel.
Test: FlickerTests, manual
Bug: 284314711
Flag: no
Change-Id: Ide7027454f8b447f82778c8e24dbc39c5ade0248
2023-06-07 18:26:58 -04:00
Sunny Goyal 67d7f3789c Merge "Removing all usage of LauncherProvider" into udc-qpr-dev am: cda1842e7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23305873

Change-Id: Id3f5c9bb9fdefaea5e93658710cc44bd66e91b45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 22:25:54 +00:00
Vadim Tryshev a6f2e01135 Merge "Switch ScrimView to use view alpha" into udc-qpr-dev am: 544dff52af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23354115

Change-Id: I65088abc845003a3afa65efa1478bc88a7871146
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 22:25:36 +00:00
Treehugger Robot 936722a71f Merge "Adds an overflow bubble to the bubble bar." into udc-qpr-dev 2023-06-07 22:09:31 +00:00
Treehugger Robot ffdcac46b6 Merge "Log UserManager users and cached users each time users accessed" into udc-dev 2023-06-07 22:08:03 +00:00
Sunny Goyal cda1842e7a Merge "Removing all usage of LauncherProvider" into udc-qpr-dev 2023-06-07 22:03:48 +00:00
Vadim Tryshev 544dff52af Merge "Switch ScrimView to use view alpha" into udc-qpr-dev 2023-06-07 21:47:59 +00:00
Vadim Tryshev 9d8c7871fc Revert "Re-enabling a couple of tests"
This reverts commit 816ee74a2b.

Reason for revert: b/286278723

Change-Id: I3c4a5756c87a952f52947d2a8d3387396cd0637e
2023-06-07 21:31:44 +00:00
Treehugger Robot f66c96aeee Merge "Moved TISBinder lifecycle handling to TISBinderHelper" into udc-qpr-dev am: 9c9764c28b am: ff4ce150fb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23588722

Change-Id: I5b3dec3b7dcb6506cfb315b34356e9a5e534144a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 20:13:55 +00:00
Schneider Victor-tulias 8d67532823 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262 am: 19d085107a am: 2b3b42d1e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ib9553f08c4429855daf179ed1b10192bceda1c85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 20:12:39 +00:00
Schneider Victor-tulias 71ae1a4752 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: dbcfd79f7e am: 8d7b8bbf97 am: 3a003e6685
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I5ba86943da172b9b24e2cc43615bcd3437c29a61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 20:11:50 +00:00
Treehugger Robot ff4ce150fb Merge "Moved TISBinder lifecycle handling to TISBinderHelper" into udc-qpr-dev am: 9c9764c28b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23588722

Change-Id: I6e9d2af467c915b50ed2974958d06d2e7fefb969
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 20:09:07 +00:00
Schneider Victor-tulias 208c161123 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262 am: dd876d36a7 am: e36cccaa23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ic0c10a08c03ad9bdbeaffcb10fc948a3b9d1686f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 20:08:11 +00:00
Sunny Goyal 7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
Treehugger Robot 9c9764c28b Merge "Moved TISBinder lifecycle handling to TISBinderHelper" into udc-qpr-dev 2023-06-07 19:37:13 +00:00
Vinit Nayak 5fa247fd43 Include assistant in RemoteTargetGluer
* The UI isn't terribly great, but this fixes the crashes

Bug: 285781761
Change-Id: Ie3376a98b16c19bbdb4e39e7a0a436ddae200c4a
2023-06-07 12:05:00 -07:00
Schneider Victor-tulias 2b3b42d1e3 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262 am: 19d085107a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifab096d1325bc25da403d048c29bb6b9f1b1db86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 19:04:51 +00:00
Schneider Victor-tulias 3a003e6685 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: dbcfd79f7e am: 8d7b8bbf97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ie18dfd44c3b43a60f82ac001ab927135a08f79b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 19:02:28 +00:00
Schneider Victor-tulias e36cccaa23 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262 am: dd876d36a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I9ed195e418e4a715a1fb41a2a28cb795131a0b1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 19:01:56 +00:00
Ats Jenk 71a25230b2 Merge "Dismiss all task ids from TaskView" into udc-qpr-dev am: 71f6dbece4 am: 6b6bb0ac9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23593729

Change-Id: I6294ee02014aa3f52b15c48bd8f52e28fe8e4393
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:45:48 +00:00
Vinit Nayak 9377e56f47 Log UserManager users and cached users each time users accessed
Bug: 243688989
Change-Id: Ifa6eec39f9fc90a4871ac2ff010588c3a5cac531
2023-06-07 11:32:01 -07:00
Schneider Victor-tulias 8d7b8bbf97 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: dbcfd79f7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I94af5f610dd173a38567251de20790032e62af55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:22:14 +00:00
Schneider Victor-tulias 19d085107a Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifd444206ac34ba591bf2f6033bf6961fadb5425f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:21:17 +00:00
Jon Miranda 95f4472ba9 Update taskbar paddings/sizes to match spec.
Bug: 282798528
Test: manual with screenshots
Change-Id: I00c646d9cd11a9015e14f8311ba2ff233d8321ac
2023-06-07 11:19:50 -07:00
Schneider Victor-tulias 7943441e13 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: e233e26296
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I4fd7760a106872f614ad262b484967ac825c6733
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:17:11 +00:00
Schneider Victor-tulias dd876d36a7 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I0f7cec81ed479ff2d000d986a9213c7ae4b3c2ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:17:10 +00:00
Ats Jenk 6b6bb0ac9e Merge "Dismiss all task ids from TaskView" into udc-qpr-dev am: 71f6dbece4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23593729

Change-Id: I59bae223ea8f86e453ef44ad2a31d6ca4c92e549
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:01:39 +00:00
Jagrut Desai d94017474f Remove Hotseat Education from Large Screens
Currently there is an taskbar icon unstashing animation that happens on top of hotseat education. Hotseat education is redudunt for large screens(Tablets, Foldable-unfolded). To solve this we will remove this reduntdant feature for large screens

Test: Manual
Bug: 282617747
Flag: not needed
Change-Id: Ia5e2c51f7ef927a59cb6efa195c1cdfc627205d9
2023-06-07 10:52:39 -07:00
Schneider Victor-tulias e233e26296 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I9a903e043eaec37528fc03cbd4d3b852d4d8ef96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 17:39:29 +00:00
Schneider Victor-tulias 396bb7c262 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I42b6d61dccc32614de8d7c83f6e8da7e5fad5e46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 17:39:27 +00:00
Schneider Victor-tulias 1834581bc0 Fix null-pointer in AbsSwipeUpHandler.buildAnimationController
Flag: not needed
Fixes: 271248485
Test: ran launcher
Change-Id: Ia9e0e68b9ee9273d82ed791b421a10ccb1fcdef2
2023-06-07 10:39:25 -07:00
Schneider Victor-tulias 533eeac02e Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: I016a3737596adebc723343dc62a0930464cd8acb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 17:39:14 +00:00
Schneider Victor-tulias dbcfd79f7e Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ie46aaae7828fad968ef00bac8d3069da651b0f91
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 17:35:14 +00:00
Ats Jenk 71f6dbece4 Merge "Dismiss all task ids from TaskView" into udc-qpr-dev 2023-06-07 17:17:42 +00:00
Schneider Victor-tulias 871d7fc351 Moved TISBinder lifecycle handling to TISBinderHelper
- All instances where we used TISBinder will now use TISBinderHelper#getBinder. This will allow TISBinderHelper to handle its lifecycle
- Moved all instance of TaskbarManager and OverviewCommandHelper as well since TIS and TISBinder handle their lifecycles
- Cleaning up launcher instance from TaskbarManager when TISBinder is being destroyed

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:248794e698417b1156bf911adb31682186fe2e34)
Change-Id: I8415a6b2c1dba0776e7c0e1ee32ad3c683100bde
2023-06-07 17:15:18 +00:00
Schneider Victor-tulias bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Liran Binyamin 2f1b547a4b Crash fix in BubbleStachedHandleViewController.
Switching between gesture nav and 3 button nav may lead to a state where
the RegionSamplingHelper is unexpectedly null.

Bug: 269670598
Test: In Settings switch navigation modes until launcher crashes.
Change-Id: I56d6eea81070f367db292c1ded9866452f6e2650
2023-06-07 11:55:02 -04:00
Android Build Coastguard Worker 0de1abee31 Snap for 10268796 from 826b28d703 to udc-qpr1-release
Change-Id: I51f8572175980db8968a7befea2cb5fe4a68cb9e
2023-06-07 03:18:48 +00:00
Andy Wickham adce95394e Enable returning to the previous app after Overview -> All Apps.
Back gesture from All Apps (history for state):
If previous state was background, use quick switch state to return
to the previous app.

Swipe down from All Apps:
Return to previous state (which will be Normal or Quick Switch).

This animates from All Apps overview scale/translation to full
screen of the previous task. In this case we are animating from
0.5x Overview scale and 0 translation (centered).

Video: https://drive.google.com/file/d/1cpQjtFemtJ4zu9aWu7IiUftWWVGFrbtM/view?usp=drive_link&resourcekey=0-1zuMEvYNsk81YBxv8o10hA

Note: This is mostly for the gesture/state handling but it would
be nice to polish this transition in the future.

Bug: 283336332
Test: Manual
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: Iec92df933ce6522f181d3d5ca889b6a6469f4cc6
2023-06-06 17:13:59 -07:00
Treehugger Robot 46b958eb35 Merge "Re-enabling a couple of tests" into udc-qpr-dev am: fb261c428b am: ee34e8ca3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23567994

Change-Id: I84e7ec73b2f4bb1985610ce9e233979c95a55497
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 23:37:19 +00:00
Android Build Coastguard Worker 596de595f4 Snap for 10269577 from 3dca7b3c6a to udc-release
Change-Id: I16c5f134e23c287220f604acab3718c616098ca0
2023-06-06 23:19:39 +00:00
Treehugger Robot ee34e8ca3b Merge "Re-enabling a couple of tests" into udc-qpr-dev am: fb261c428b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23567994

Change-Id: Ib74170ca9d8b69846cfb4aa16f3ef23e26052e66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 22:58:39 +00:00
Ats Jenk 7a48f57043 Dismiss all task ids from TaskView
In recents we were hardcoding that only two task ids can be dismissed
when dismissing a TaskView. Update the logic to dismiss arbitrary
number of task ids that are returned from TaskView.

Fixes task dismissal logic for desktop where there can be more than 2
tasks represented by one taskview.

Flag: not needed, trivial change
Bug: 280830106
Test: Add chrome, files and calculator to desktop. Dismiss the desktop
  tile with 3 apps from overview. Open youtube and move it to desktop.
  Observe that desktop only contains youtube. None of the 3 previous
  apps are added back.
Test: Move 2 apps to split screen, dismiss the split tile from overview.
  Observe both apps are dismissed.
Test: Dismiss a single app from overview.
Change-Id: I139943f5d678d63f449116de26debae9be122b21
2023-06-06 22:38:39 +00:00
Treehugger Robot fb261c428b Merge "Re-enabling a couple of tests" into udc-qpr-dev 2023-06-06 22:03:26 +00:00
Fengjiang Li b478dc94b2 Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52 am: 7d6a8b1c3a am: a4e31638c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: I31ea9b853db435501266ff9775010e46564223a4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 21:11:33 +00:00
Fengjiang Li e4b13cd4fb Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 829a3c5a0d am: 2d6399025a am: 3ba64c3332
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: Ibbd455c5e1d2e74c21213d09ad5336a92809a9d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 21:11:17 +00:00
Fengjiang Li 9eef219772 Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52 am: 01f105cf7a am: 2940fd75cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: Idf14855c0714185030abc8845263eebb4cd37808
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 21:09:46 +00:00