Federico Baron
2bf9ebdcf1
Merge "Add logs for widget picker image test" into udc-qpr-dev am: ff1428ab1e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24421525
Change-Id: I29a347e374b71cfd627aa923fae0d7768092fd2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 19:01:44 +00:00
Colin Cross
ae14bc26e2
Fix kotlin nullable errors in Launcher3 am: 4cc251e6c1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24406718
Change-Id: Id52bac704d54d31eafda8c8b648a576ab56617c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 19:00:56 +00:00
Colin Cross
ec5a8a5e6e
Merge "Fix kotlin nullable errors in Launcher3" into udc-qpr-dev-plus-aosp am: efada45adf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24406717
Change-Id: Id7075119e7ad6610c7976d588da489bd51dd0a27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 18:18:29 +00:00
Federico Baron
ff1428ab1e
Merge "Add logs for widget picker image test" into udc-qpr-dev
2023-08-14 18:14:43 +00:00
Colin Cross
efada45adf
Merge "Fix kotlin nullable errors in Launcher3" into udc-qpr-dev-plus-aosp
2023-08-14 17:55:18 +00:00
Treehugger Robot
ef99081c53
Merge "Ignoring alpha jumps in ArrowTipView" into udc-qpr-dev am: 14e0cc55d9 am: 9aad6c5da4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24410254
Change-Id: Ifeefed144bc8b29938b775e8f290c8eefb947448
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 17:54:44 +00:00
Vadim Tryshev
9082ba31d7
Skipping view capture analyzer in presubmit
...
The checks are not sufficient stable yet to be presubmit blockers.
Bug: 286251603
Flag: N/A
Test: presubmit
Change-Id: I3f5466a51018ff4e8de8c00ef7e0ca3fc0ec5436
2023-08-14 10:20:35 -07:00
Treehugger Robot
9aad6c5da4
Merge "Ignoring alpha jumps in ArrowTipView" into udc-qpr-dev am: 14e0cc55d9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24410254
Change-Id: I5aea9d698ea0c890f537b0f86f54e6227a9fc1fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 17:11:39 +00:00
Treehugger Robot
14e0cc55d9
Merge "Ignoring alpha jumps in ArrowTipView" into udc-qpr-dev
2023-08-14 16:42:30 +00:00
fbaron
575a6ef5f8
Add logs for widget picker image test
...
The screenshot test is failing in udc-qpr because the search bar is smaller when the screenshot is taken than what the reference image is. Adding logs to figure out what might be causing the search bar to be differently sized in udc-qpr tests (in main WidgetPickerImageTest passes, as well as udc-qpr locally)
Bug: b/294050472
Test: atest WidgetPickerImageTest
Flag: no flag
Change-Id: Ib94773bc411ff97d373af490ca920f6d6ae6cb2d
2023-08-14 09:30:59 -07:00
Treehugger Robot
d73a58a08c
Merge "Add relayout debug support in Launcher" into udc-qpr-dev am: 1c4cb11662 am: 8da7427ba5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24403823
Change-Id: I4a5025ce17930fe899cd91358bc86d440ee39178
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 11:20:53 +00:00
Treehugger Robot
8da7427ba5
Merge "Add relayout debug support in Launcher" into udc-qpr-dev am: 1c4cb11662
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24403823
Change-Id: I8459cb1d828d1f27454f25cebc0c90f1a8165ce5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 10:40:59 +00:00
Treehugger Robot
1c4cb11662
Merge "Add relayout debug support in Launcher" into udc-qpr-dev
2023-08-14 09:43:51 +00:00
Nicolo' Mazzucato
93e7e4b1c0
Add relayout debug support in Launcher
...
This adds support for measure/layout tracing in Launcher (in sysui it has already been enabled in T)
When enabled, traces for each class measure and layout are output in
a perfetto trace. This adds some overhead, so it's disabled by default, but extremely useful for testing and debugging long doFrames.
To enable request layout tracing for a specific class X, the following helper can be used:
trace_class_layouts() {
adb shell setprop persist.debug.trace_request_layout 1
adb shell setprop persist.debug.trace_request_layout_class $1
adb shell am force-stop com.google.android.apps.nexuslauncher
adb shell am force-stop com.android.systemui
}
Then, use `trace_class_layouts X` and record a perfetto trace
e.g. `trace_class_layout BubbleTextView`
To just see class breakdown of measure/layout setting `persist.debug.trace_request_layout` is sufficient.
Test: record a trace after enabling options
Bug: 266090955
Change-Id: I4f621ebaaec6a07cd7c0693aa8876158cc60e208
2023-08-14 08:18:27 +00:00
Vadim Tryshev
d08d2b1008
Moving stress tests to postsubmit am: 053f476376 am: 95c9e86b34
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24409978
Change-Id: Ib80d7978e743a264878620fc9dfa5cfa6832841a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 05:36:37 +00:00
Vadim Tryshev
95c9e86b34
Moving stress tests to postsubmit am: 053f476376
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24409978
Change-Id: I79790bd4e3f62794f6dca9bf583d6c4c100b4934
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-14 04:54:49 +00:00
Android Build Coastguard Worker
741caf4b5f
Snap for 10649958 from 8c764a0870 to udc-qpr1-release
...
Change-Id: Ia449a69e3593223009ed1e9dfc7e3d74f3483761
2023-08-12 03:19:08 +00:00
Vadim Tryshev
b2bb9802b8
Merge "Revert "Revert "Re-enabling a couple of tests""" into udc-qpr-dev am: 8c764a0870 am: e598bc71bc
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23681107
Change-Id: Ib5eb7a82c0e95c5747c3f0b5f3ee663082a818fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-12 03:13:04 +00:00
Vadim Tryshev
e598bc71bc
Merge "Revert "Revert "Re-enabling a couple of tests""" into udc-qpr-dev am: 8c764a0870
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23681107
Change-Id: I7636d8cd9bad4beed904f9d0f85125680d06b318
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-12 02:29:51 +00:00
Vadim Tryshev
053f476376
Moving stress tests to postsubmit
...
They don't consistently fail, but have flakes.
Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I07db69259d86093d81ab65a52a8e839269a3dd80
2023-08-12 02:14:55 +00:00
Vadim Tryshev
d21fed8f62
Ignoring alpha jumps in ArrowTipView
...
Bug: 24331680
Flag: N/A
Test: presubmit
Change-Id: I0de76bc2fd8791e03e7722700c72567ef6b913b5
2023-08-11 19:07:00 -07:00
Treehugger Robot
217f1067bc
Merge "Update usage of ExtendedEditText.showSoftInput()." into udc-qpr-dev am: e8f4a6bbaf am: d4ebc947d6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24314277
Change-Id: I5417eec4e11701be63bacf232618a8c88f19bd5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-12 02:06:16 +00:00
Vadim Tryshev
8c764a0870
Merge "Revert "Revert "Re-enabling a couple of tests""" into udc-qpr-dev
2023-08-12 01:51:46 +00:00
Vadim Tryshev
401cde8d99
Adding TaplTestsSplitscreen to OOP tests
...
It's a nice addition to our OOP tests, which serve as a kind-of ssmoke check for the system, as well a a test for a proguarded Launcher.
Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I196cf0047f0df6cf843615e48252035f216597a0
2023-08-11 18:34:01 -07:00
Treehugger Robot
d4ebc947d6
Merge "Update usage of ExtendedEditText.showSoftInput()." into udc-qpr-dev am: e8f4a6bbaf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24314277
Change-Id: Ia9d2f57f11137e1972020ef505be5bd385bd3a86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-12 01:23:16 +00:00
Treehugger Robot
e8f4a6bbaf
Merge "Update usage of ExtendedEditText.showSoftInput()." into udc-qpr-dev
2023-08-12 00:57:41 +00:00
Android Build Coastguard Worker
a9e806be33
[coastguard skipped] Merge sparse cherrypicks from sparse-10644925-L16700000962543246 into udc-release.
...
COASTGUARD_SKIP: Ic437ff4d19cbd5764635f3007d99880622150f5b
COASTGUARD_SKIP: I858cb023d2e533c56209e724e603d8a310931074
Change-Id: I5e41aebfd66b525d4ee67daa5e8c4ab4cc6886ac
2023-08-12 00:33:09 +00:00
Android Build Coastguard Worker
7252b77998
Merge cherrypicks of ['googleplex-android-review.googlesource.com/23447960'] into sparse-10644925-L16700000962543246.
...
SPARSE_CHANGE: Ic437ff4d19cbd5764635f3007d99880622150f5b
Change-Id: I858cb023d2e533c56209e724e603d8a310931074
2023-08-12 00:28:18 +00:00
Nick Chameyev
0effcbca84
[Unfold animation] Do not preemptively start the animation if it has run already
...
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.
This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.
This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.
Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
check that icons are not squished
Test: fold/unfold when launcher is open
(cherry picked from commit 6d756970e7 )
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2e53f5ef97a02d25f508774e82985e24dc2f4d2d )
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
2023-08-12 00:26:39 +00:00
Andy Wickham
5a70c4567d
Merge "Enable Toast launch animations flags by default" into udc-qpr-dev am: c928369894 am: ff489b30ac
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24308821
Change-Id: Ic39b037542a2172e6170bdd68072341f88b0d69b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-12 00:16:00 +00:00
Vinit Nayak
9c159e3861
Merge "Animate Split invocation with shell transitions" into udc-qpr-dev am: 8488a7e757 am: 050cfbeb10
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24392742
Change-Id: Ie7e14f26ed21ca5a0dafeca186126c622f004e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-12 00:14:26 +00:00
Andy Wickham
ff489b30ac
Merge "Enable Toast launch animations flags by default" into udc-qpr-dev am: c928369894
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24308821
Change-Id: I2729d867dd92578fadc07df669ca2a405b65344f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-11 23:34:05 +00:00
Vinit Nayak
050cfbeb10
Merge "Animate Split invocation with shell transitions" into udc-qpr-dev am: 8488a7e757
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24392742
Change-Id: I2834012cb573bfc031d02be80c382916c583362b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-11 23:32:23 +00:00
Andy Wickham
c928369894
Merge "Enable Toast launch animations flags by default" into udc-qpr-dev
2023-08-11 23:21:31 +00:00
Vinit Nayak
8488a7e757
Merge "Animate Split invocation with shell transitions" into udc-qpr-dev
2023-08-11 22:29:59 +00:00
Vinit Nayak
9cf30a3e85
Merge "Prevent setting mIsStashed in TaskbarStashController" into udc-qpr-dev am: f49367cd96 am: 9304143cd1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24374676
Change-Id: If7f5ba3c4bf46b08ee5d4ed7bba4f0c42947e373
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-11 20:08:04 +00:00
Vinit Nayak
6458c11699
Animate Split invocation with shell transitions
...
* SplitRoot1/2 and the split left/right roots, but
they also have a parent that's the top-most split root.
* We have to explicitly set the alpha on top most parent
for animations on children to be visible
* This path wasn't being used even w/ shell transitions
enabled but became active after ag/24346391
Test: Launch split from overview and workspace
Flag: None
Bug: 276361926
Change-Id: I267dccbf3402af9b0972371b856a79b7785f986c
2023-08-11 12:59:18 -07:00
Sunny Goyal
c1d1e68a82
Removing some unused overrides in Launcher
...
> Changing AddItemActivity to use RemoteAnimation directly
to avoidTransitionManager override
Bug: 273828110
Test: Manual
Flag: N/A
Change-Id: I49777e7eeba00319476b0a239bc1cdac37833457
2023-08-11 12:31:49 -07:00
Vinit Nayak
9304143cd1
Merge "Prevent setting mIsStashed in TaskbarStashController" into udc-qpr-dev am: f49367cd96
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24374676
Change-Id: I5fa6f41a3f0fc16fa104706aa5591a0872f5bbcd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-11 19:19:36 +00:00
Luca Zuccarini
c3c75c28b0
Enable Toast launch animations flags by default
...
Bug: 270394041
Bug: 270394392
Bug: 262778448
Bug: 293863913
Flag: ENABLE_SEARCH_RESULT_BACKGROUND_DRAWABLES
Flag: ENABLE_SEARCH_RESULT_LAUNCH_TRANSITION
Test: manual
Change-Id: I9019d76045e3f6d931c99c0fc14435b52d8671bf
2023-08-11 18:36:40 +00:00
Vinit Nayak
f49367cd96
Merge "Prevent setting mIsStashed in TaskbarStashController" into udc-qpr-dev
2023-08-11 18:32:43 +00:00
Colin Cross
4cc251e6c1
Fix kotlin nullable errors in Launcher3
...
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.
This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.
Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
Merged-In: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
2023-08-11 11:29:10 -07:00
Colin Cross
abf18e9c03
Fix kotlin nullable errors in Launcher3
...
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.
This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.
Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
2023-08-11 11:28:54 -07:00
Sam Dubey
c398b3e32f
Merge "Revert "Fix kotlin nullable errors in Launcher3"" into udc-qpr-dev-plus-aosp am: cfee307359
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24403814
Change-Id: If33d41368f045fecc5ef86432db4d48517c32d20
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-11 13:48:48 +00:00
Sam Dubey
cfee307359
Merge "Revert "Fix kotlin nullable errors in Launcher3"" into udc-qpr-dev-plus-aosp
2023-08-11 13:21:59 +00:00
Sam Dubey
1b481e1973
Revert "Fix kotlin nullable errors in Launcher3"
...
This reverts commit 7943b35a71 .
Reason for revert: Seems to be breaking flicker tests b/295447665, will verify before submitting. This change could be WAI (or surfacing issues)
Change-Id: Ic240c29539f41490cf7232bd6a7a944a868f3870
2023-08-11 11:52:38 +00:00
Colin Cross
960d91142e
[automerger skipped] Merge "Fix kotlin nullable errors in Launcher3" into main am: fc786807ad am: 9f7fab352b -s ours am: 5589b9bd39 -s ours am: 86c3fd002c -s ours am: 1cfb810394 -s ours
...
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 2608381792 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2702133
Change-Id: I3db478eb2541f31c3f1a7f153ccb211a2fe6f13d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-11 08:19:06 +00:00
Colin Cross
1cfb810394
[automerger skipped] Merge "Fix kotlin nullable errors in Launcher3" into main am: fc786807ad am: 9f7fab352b -s ours am: 5589b9bd39 -s ours am: 86c3fd002c -s ours
...
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 2608381792 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2702133
Change-Id: I622c1f1de83bf10260ebbfffa2e314de699d6c86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-08-11 07:30:05 +00:00
Android Build Coastguard Worker
57f15d7f80
[coastguard skipped] Merge sparse cherrypicks from sparse-10644925-L75300000962528215 into udc-release.
...
COASTGUARD_SKIP: If54a4f4d8ed5e882b38ab475b68f6e312c9423f1
COASTGUARD_SKIP: Ic437ff4d19cbd5764635f3007d99880622150f5b
Change-Id: I008d32f49cac005501b6c0e2e512d03a952156ac
2023-08-11 07:20:05 +00:00
Android Build Coastguard Worker
61f3140a20
Merge cherrypicks of ['googleplex-android-review.googlesource.com/23447960'] into sparse-10644925-L75300000962528215.
...
SPARSE_CHANGE: Ic437ff4d19cbd5764635f3007d99880622150f5b
Change-Id: If54a4f4d8ed5e882b38ab475b68f6e312c9423f1
2023-08-11 07:16:14 +00:00