Commit Graph

78507 Commits

Author SHA1 Message Date
Luca Zuccarini 8837e66a7e Avoid sending an IME close request if the IME is already closed.
Bug: 277738379
Fix: 296986528
Flag: N/A
Test: manual
Change-Id: I0a3419f17ee569020c9de673b9507337661bd002
2023-08-22 16:47:55 +00:00
helencheuk a66a121bec Add test to long press icon on home screen
Fix: 292083404
Test: TaplTestsLauncher3#testLaunchHomeScreenMenuItem
Change-Id: I301ac719aeda744e8b8dca9a405208625eff89e7
2023-08-22 16:33:06 +00:00
Vinit Nayak 0989216160 Merge "Null out Activity in split controller" into udc-qpr-dev 2023-08-22 16:21:45 +00:00
Adrian Roos f45ebad9be Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR
With ENABLE_HIDE_IME_CAPTION_BAR, we no longer need to update the navigation bar override. This was already applied for the navigation bar, but not the task bar. Mirrors the NavigationBar.java change in
I8793db69fb846046300d5a56b3b0060138ef4cd5.

Bug: 289748734
Change-Id: I86079cb6670a2ae3b6fa883694f8af81df212408
Test: presubmit
2023-08-22 16:07:37 +00:00
Fengjiang Li 2474a8c1fb Merge "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch" into udc-qpr-dev 2023-08-22 15:09:20 +00:00
Liran Binyamin 80f20a2183 Handle touches on the bubble bar in Overview
If the bubble bar is visible and we're in Overview, set the touchable region
of the Taskbar to include the bubble bar bounds.

Fixes: 290197298
Test: Manual
      - Add multiple bubbles to the bubble bar
      - Go to Overview
      - Tap on the bubble bar
      -- Observe that the bubble bar expands
      - Tap on different bubbles
      -- Observe that the bubble bar updates correctly
      - Tap outside the bubble bar
      -- Observe that the bubble bar collapses
      - Tap outside of the bubble bar again
      -- Observe that the launcher state changed and we are in Home
Change-Id: I722778ee41b50ebca57431bb303da89104d25090
2023-08-22 09:13:15 -04:00
Pat Manning c7087e8f9f Do not consume hover events not coming from cursor for a11y.
Fix: 283041221
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I95e9ded6873173ea001c82d6319716a2d48b3bad
2023-08-22 09:17:04 +00:00
Treehugger Robot a5f24d709e Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev 2023-08-22 09:09:51 +00:00
Tracy Zhou b038bac666 Merge "Init nav mode in TaskbarActivityContext between fold/unfold" into udc-qpr-dev 2023-08-22 06:48:01 +00:00
Sunny Goyal 5442cbc300 Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag
Bug: b/270397209
Test: Presubmit
Flag: RECEIVE_UNFOLD_EVENTS_FROM_SYSUI
Change-Id: I4f87777fd27b5489557742b58e25dc5488b7d32b
2023-08-22 04:31:09 +00:00
Android Build Coastguard Worker 5e0122d13a Merge cherrypicks of ['googleplex-android-review.googlesource.com/23447960', 'googleplex-android-review.googlesource.com/24314473', 'googleplex-android-review.googlesource.com/24224609'] into udc-release.
Change-Id: I2f33858065e7f76bc8964949e323eb411700aa04
2023-08-22 02:19:47 +00:00
Luca Zuccarini b38e61a339 Animate depth from the right value on Taskbar All Apps launches.
`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

(cherry picked from commit 627d67549f)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3e91646d123abbe58ccc0544746145ce5024b923)
Merged-In: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
2023-08-22 02:15:08 +00:00
Alex Chau c02dabfb59 Fix return condition in getWorkspacePageTranslationProvider
- When EDIT_MODE was introduced, it added a wrong condition to make it always return DEFAULT_PAGE_TRANSLATION_PROVIDER

Bug: 294228521
Test: manual
(cherry picked from commit c325c686c7)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4bfc0ee720e4ee80035c7ef59cf2d8d095cf9d72)
Merged-In: If970949c8ab55bc67f98f987a7654ec2db89cdfb
Change-Id: If970949c8ab55bc67f98f987a7654ec2db89cdfb
2023-08-22 02:14:58 +00:00
Nick Chameyev 14b4f9edcc [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
(cherry picked from commit 6d756970e7)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2e53f5ef97a02d25f508774e82985e24dc2f4d2d)
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
2023-08-22 02:14:49 +00:00
Vinit Nayak b620af4612 Null out Activity in split controller
Bug: 295225524
Change-Id: I59aaed3fca07d611088cec0a4bfafc658a151bb2
2023-08-21 23:40:51 +00:00
Treehugger Robot 0bf390490a Merge "Pass extras Bundle in onRecentsAnimationStart" into main 2023-08-21 23:25:16 +00:00
Android Build Coastguard Worker 335a1f24ed Snap for 10690357 from 4dc9893028 to udc-qpr1-release
Change-Id: Ia81aa6f0cbe1e931424c0b31b28b627f084e577b
2023-08-21 23:19:05 +00:00
Treehugger Robot eabb5bbe7e Merge "Prevent some leaks from leaking to the next test" into udc-qpr-dev am: 1e709c2a95 am: c5c3c2590b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24487871

Change-Id: I72f0de405cddcc29100a0d696b2def2f55a19521
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:55:56 +00:00
Treehugger Robot 15f1370c45 Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev am: 2a1df8879f am: 0dbd72188b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24499166

Change-Id: I1ebeef38e8001379a7d0b4b1c4a9ae8bc4cf9698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:53:41 +00:00
Stefan Andonian bd3a62fe30 Merge "Move WallpaperColorHints RPC calls to a background thread." into udc-qpr-dev am: 0487d8ee9b am: 28c69acdfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24087102

Change-Id: I66833830e2e20dcb23ed9abd80b72bec8cefe378
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:53:18 +00:00
Kevin Lim 2fea004ac9 Merge "[Tiger] Add screen record to debug flaky test" into udc-qpr-dev am: c7aeced342 am: a73c072f39
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486156

Change-Id: I46a6e0ff77046cee60d8e38e068ea993f1a576d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:51:59 +00:00
Treehugger Robot c5c3c2590b Merge "Prevent some leaks from leaking to the next test" into udc-qpr-dev am: 1e709c2a95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24487871

Change-Id: I4a227c9f2060835efb7aaaa1ff4ad96576345e2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:47:36 +00:00
Tracy Zhou d9d17ce133 Init nav mode in TaskbarActivityContext between fold/unfold
In RotationButtonController, we show the floating rotation button either when the bar is visible, or when the device is in gesture nav mode, even in an immersive app. The issue here is that mNavMode is not correctly initialized after the device is unfolded.

Fixes: 272164624
Test: Open townhall. Fold and then unfold. Tilt the device and make sure the floating rotation button shows.
Change-Id: I09025132fdca5c764e66d9ac21f29b853741d257
2023-08-21 22:38:13 +00:00
Treehugger Robot 1e709c2a95 Merge "Prevent some leaks from leaking to the next test" into udc-qpr-dev 2023-08-21 22:23:21 +00:00
Treehugger Robot 0dbd72188b Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev am: 2a1df8879f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24499166

Change-Id: I47fae5b187a2bb2a50e0ff78ce9672cdd50ba6b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:14:42 +00:00
Stefan Andonian 28c69acdfe Merge "Move WallpaperColorHints RPC calls to a background thread." into udc-qpr-dev am: 0487d8ee9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24087102

Change-Id: I2e1652b293d3fb49017d2062e08c2d2352f339d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:14:05 +00:00
Kevin Lim a73c072f39 Merge "[Tiger] Add screen record to debug flaky test" into udc-qpr-dev am: c7aeced342
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486156

Change-Id: I6ba70bbfa9c4f0b21f8d76ac33db54818ef5b0ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:13:18 +00:00
Treehugger Robot 2a1df8879f Merge "Add null check for mRecentsView when recents animation is canceled" into udc-qpr-dev 2023-08-21 21:50:54 +00:00
randypfohl ecffb20ba8 Adding some logging to track test failure in post submit
Test: not needed

Bug: 295069071

Change-Id: I3394267dbbd808544e2759737c7d139c5ba4121f
2023-08-21 14:49:25 -07:00
Stefan Andonian 0487d8ee9b Merge "Move WallpaperColorHints RPC calls to a background thread." into udc-qpr-dev 2023-08-21 21:47:58 +00:00
Vadim Tryshev 3c880e2601 Merge "Demoting testSplitAppFromHomeWithItself from presubmit" into udc-qpr-dev am: 72731c4bda am: c4d207ea41
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486323

Change-Id: Id15e1266db1aa353a8bf18bdbd675973b21bddfe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 21:44:02 +00:00
Vinit Nayak b23cdf1f93 Pass extras Bundle in onRecentsAnimationStart
* Bundle will contain SplitBounds if recents
animation contains splitscreen targets
* Key to use is SplitBounds#KEY_RECENTS_BUNDLE

Test: Swiping up with single + split tasks
Bug: 254378592
Change-Id: I51f4063aa62ae22a43ffb3712ae6a837156f32d8
2023-08-21 21:32:54 +00:00
Kevin Lim c7aeced342 Merge "[Tiger] Add screen record to debug flaky test" into udc-qpr-dev 2023-08-21 21:27:20 +00:00
Vadim Tryshev c4d207ea41 Merge "Demoting testSplitAppFromHomeWithItself from presubmit" into udc-qpr-dev am: 72731c4bda
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24486323

Change-Id: I1cb596ba63312b9562d49b9e0b3b36131b1ea692
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 21:04:02 +00:00
Treehugger Robot 0c02883565 [automerger skipped] Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev am: 4dc9893028 -s ours am: dec57bad69 -s ours
am skip reason: Merged-In I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea with SHA-1 a26500b145 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24470201

Change-Id: I5316ad67b212a7db082eea4ff869ae09fb93e1f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 20:33:39 +00:00
Jagrut Desai 5183772bdb [automerger skipped] Remove Change Navigation Mode option for Taskbar Divider Popup Menu am: 8d326473a6 -s ours am: fd8ebd4864 -s ours
am skip reason: Merged-In I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea with SHA-1 a26500b145 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24470201

Change-Id: I0f817a3e7a72cf687b7f19605920196ded7ba3a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 20:33:35 +00:00
Vadim Tryshev 72731c4bda Merge "Demoting testSplitAppFromHomeWithItself from presubmit" into udc-qpr-dev 2023-08-21 20:19:27 +00:00
Stefan Andonian 24a963b268 Move WallpaperColorHints RPC calls to a background thread.
Bug: 251502424
Test: Theme behavior still works fine. Compilation worked well.
Change-Id: I18d0b2094f3ba841846ff98567acc7327a7bd220
2023-08-21 20:10:41 +00:00
Treehugger Robot dec57bad69 [automerger skipped] Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev am: 4dc9893028 -s ours
am skip reason: Merged-In I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea with SHA-1 a26500b145 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24470201

Change-Id: Ifb90d0ddf947bb43e421c7f41ba9365a1580541c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:56:51 +00:00
Jagrut Desai fd8ebd4864 [automerger skipped] Remove Change Navigation Mode option for Taskbar Divider Popup Menu am: 8d326473a6 -s ours
am skip reason: Merged-In I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea with SHA-1 a26500b145 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24470201

Change-Id: I7f6da6d9f33c64227710a6677278444311cb2ceb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:56:48 +00:00
Sunny Goyal 0ee66478c6 Adding CannedAnimationCoordinator to enable running a predefined animation in Launcher
> The coordinator takes care of recreating animations on layout changes and
   linking it with state animation
> This also ensures that there is only one animation playing at a time

Bug: 293464892
Test: Verified that calling with multiple animations cancels previos call
Flag: None
Change-Id: Iab161720c94843b5834734da78167344c17539c8
2023-08-21 12:55:42 -07:00
Treehugger Robot 4dc9893028 Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev 2023-08-21 19:41:19 +00:00
Treehugger Robot f59f95247d Merge "Demoting testQuickSwitchToPreviousAppForTablet from presubmit" into udc-qpr-dev am: e207075bdc am: 589bc3f092
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24472691

Change-Id: I76c0b825cc80a641d7d1ef387be9857014e493a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:29:08 +00:00
Tony Wickham 8b91868c9d [automerger skipped] Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev-plus-aosp am: 0c91338815 -s ours
am skip reason: Merged-In I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea with SHA-1 8923830f74 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24484572

Change-Id: I236862d0a55db253e082e1775c20179b9e787afe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:27:49 +00:00
Jagrut Desai 5d97ab3f98 [automerger skipped] Remove Change Navigation Mode option for Taskbar Divider Popup Menu am: a26500b145 -s ours
am skip reason: Merged-In I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea with SHA-1 8923830f74 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24484572

Change-Id: I5191ffb2e37bae5cb2a1619ab425fc391b33efa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:27:46 +00:00
Pat Manning 6784e09204 Merge "Check taskbar stash state for hover only on hover events." into udc-qpr-dev am: bd4e77ccf7 am: 9180b92d8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24420598

Change-Id: I528c980856b8dcb6c02593893da7bb7846eb503c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:25:31 +00:00
Treehugger Robot 589bc3f092 Merge "Demoting testQuickSwitchToPreviousAppForTablet from presubmit" into udc-qpr-dev am: e207075bdc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24472691

Change-Id: I9ab48540ad3684e6de0e0c96ba3aaaabde1b863e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 19:21:50 +00:00
Tony Wickham 0c91338815 Merge "Remove Change Navigation Mode option for Taskbar Divider Popup Menu" into udc-qpr-dev-plus-aosp 2023-08-21 19:01:15 +00:00
Treehugger Robot e207075bdc Merge "Demoting testQuickSwitchToPreviousAppForTablet from presubmit" into udc-qpr-dev 2023-08-21 18:56:40 +00:00
Kevin Lim 9028f583a6 [Tiger] Add screen record to debug flaky test
Bug: b/293944634
Test: No test needed. Simply adding screen record for flakiness
debugging
Change-Id: If8ca3a7088778fd229d66697b9197969e3803486
2023-08-21 18:49:17 +00:00