It looks like from the stack trace that there is an NPE during the setApps() call. So adding nullable and null checking
to make sure mApps is not null.
bug: 296920692
test: presubmit
flag: n/a
Change-Id: If402c0b68db159f7a698e8e2e139d9bd5041b1c1
More consistent with other Taskbar and Home API naming conventions.
Test: Compiles
Bug: 295366997
Flag: No
Change-Id: I5de7297cc73522f557a6a916e2c645ffb0473f78
We scroll to top when rotating device, which is a behavior that aligns with other AbstractSlideInView's like allApps
Fix: 293203839
Test: verify that when rotating in widget sheet that the suggested widget no longer overlaps with widget list
Flag: no-flag
Change-Id: Icf021a46ae2c2b85b4c55e40cbd2f7e70f83c248
We should also avoid using non-static inner class that extends IOnBackInvokedCallback.Stub and IRemoteAnimationRunner.Stub inside LauncherBackAnimationController, which references the entire LauncherBackAnimationController object.
1. When launcher is created, a Runnable is posted to ShellExecutor to call BackAnimationController#registerAnimation
2. When launcher is later destroyed, another Runnable is posted to same ShellExecturo to call BackAnimationController#unregisterAnimation
3. If the execturo queued the 1st runnable, then we have leaked LauncherBackAnimationController object, including Launcher activity.
This CL fixes the leak by making the Stub static inner classes, and use weak reference hold reference to launcher activity.
Bug: 297806573
Test: Grab a heap dump and this reference no longer exist
Flag: N/A
Change-Id: I78853e900a98399b02682ba2d9179e544a4030d5
The name doesn't make clear what the test is doing and
it doesn't follow our naming conventions. Also, adding
comment to explain what the test is doing.
Bug: 298234173
Test: atest UninstallWorkspaceIcon
Change-Id: Icdc42e891a94d159fc07e69931ea8444d882ad56
Also getting rid of part of the logic that updates the frame size in multi-window mode since multi-window is no longer supported
Test: N/A
Bug: 268553314
Flag: ENABLE_WIDGET_TRANSITION_FOR_RESIZING. OFF
Change-Id: I081b11441b562fccec7feb12cec0b28b9a0ea3a2
zhidou@ from ACE team is working on AConfigFakelib which will be useful
to set fake flag values in both unit tests and UI automator tests.
Meanwhile, we will mock the flag values for unit tests and UI automator
tests will have all flags values defaulted to false.
testAConfigLib with "test:true" doesn't generate fake flags values and
forces us to set the flag values using "SetFlagsRule". "SetFlagsRule"
doesn't work with Out Of Proc tests and hence doesn't serve the purpose
for us. AConfigFakelib and FakeFlagTargetPreparer should use for Out Of
Proc tests.
testAConfigLib with "test:true" is suitable for java host tests where
there is no device involved. Launcher tests are instrumentation tests and tests run on actual
devices. So we can use the production version of the AConfig lib and device
config flag values will be fetched for UI Automator tests.
Also migrating "enable_twoline_allapps" to trunk stable. Unit tests is
using mockito to mock the flag value as false. The owner of
"enable_twoline_allapps" can mock the value to true in unit tests as
next step.
Bug: 294913042
Test: Local studio build and soong build
Flag: enable_twoline_allapps
Change-Id: Iea42bf18197832a9ecbddc1c3aaa8c9e36169131
When swiping up to overview, we need to calculate a target position for
the desktop tasks. They need to be scaled down and positioned within the
desktop tile.
After recents animation finishes, the tasks will be replaced by
screenshots. To make the replace less flickery, the position of the
tasks should match the position of the screenshots.
TODO: there is a flicker when the task is replaced with recents entry.
Task is hidden and then, half a second later, the recents tile is
shown. Enabling live tiles should help with this.
Bug: 298252273
Test: swipe up to recents from desktop
Change-Id: I0c7fba40dc2511c17d0011d0516456de07cfa004
Previously, users used to be able to swipe down near the
bottom of the screen to leave overview. This was causing the taskbar to
animate to home while still in overview (and causing jank). Since this isn't expected behavior for
how to leave overview, this change removes that method.
Flag: N/A
Fix: 284416178
Test: Completed multiple transitions (ex. Overview to home) with 3
button nav and gesture nav. Ensured swiping down from below the recents
task does not go to the home screen while not affecting other
transitions.
Change-Id: I8cdfde71117dd947174d9c3c3a7f834fbeaddcca
Bill Yi
Andy Wickham
Brandon Dayauon
Treehugger Robot
Brian Isganitis
Federico Baron
Sebastián Franco
Schneider Victor-tulias
Xin Li
Anushree Ganjam
Alex Chau
Fengjiang Li
Charlie Anderson
Vadim Tryshev
Jeremy Sim
Saumya Prakash
Android Build Coastguard Worker
Sihua Ma
Ats Jenk