Commit Graph

78507 Commits

Author SHA1 Message Date
fbaron 2553ec02b7 Cleanup LARGE_SCREEN_WIDGET_PICKER flag
Fix: 270395809
Flag: no flag
Test: WidgetPickerImageTest
Change-Id: I99734ae7f87b4c2c7b4e798d14cd12f473daac6e
2023-09-27 15:43:07 -07:00
Pinyao Ting 7446209d60 Fix permission bypass in legacy shortcut am: b7b192bd7f am: a30a52e708
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24751391

Change-Id: I2681538508aaef6fb27cad282d7ceead016bfec6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 22:38:16 +00:00
Sebastian Franco 1be772df1d Make sure to not call DragOver when the drag is still under PreDrag
Adding a flag so we can turn off this behavior if it break a drag functionallity

Fix: 299748096
Test: most of dragging test will test this
Change-Id: I4f45faea4f19bd99a946a28372546e18ca5f6a2f
2023-09-27 15:05:47 -07:00
Brandon Dayauon fb607d67b2 Merge "Add maxWidth to pause work app button and ellipsize at the end" into main 2023-09-27 21:46:07 +00:00
Vinit Nayak 80d274e041 Unignore splitscreen tapl tests
* Previous they were failling locally, now they've magically
started working, let's see if the same happen in TH.

Bug: 297135374
Test: Passes/gets ignored correctly locally
Change-Id: I580afa43011237ca167bb763c65ef1974586a0fa
2023-09-27 14:45:13 -07:00
Stefan Andonian 939d5f876b Make exception for TASKBAR_PINNING so it is boot aware.
Bug: 251502424
Test: No launcher exceptions where thrown when TASKBAR_PINNING feature
is enabled.

Change-Id: I7e71d37547af1951938c6d5e77325d5e8e6b9fbd
2023-09-27 21:42:45 +00:00
Mark Fasheh f547a7f608 Add tracepoint to track Launcher cold startup latency
We want this for the post-boot performance analysis as an
rough but easy to understand metric for time spent in post-boot.

Bug: 299342732
Test: Reboot phone, before lock screen start a trace
Test: Run the following SQL against the trace: select * from slice where name="LauncherColdStartup"
Change-Id: I8956368338b13cb059ba7086e74b4c7f25849be2
2023-09-27 20:53:24 +00:00
Pinyao Ting a30a52e708 Fix permission bypass in legacy shortcut am: b7b192bd7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24751391

Change-Id: I9989130b7225de16297dadb0ab70febf3139ba28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 20:41:00 +00:00
Fengjiang Li 39133c38bc Lower thread priority to pre-inflate BubbleTextView for all apps
During sys health review it was called out that we could lower the thread priority to pre-inflate BubbleTextView so that ui thread and loader task thread has better chance to run on big core.

Bug: 297352492
Test: Grabbed perfetto trace and observed preinflation is run on "preinflate-allapps-icons" thread
Change-Id: I9330d4fbe5a98cdb793e8bfa970dfd84ae1f6c39
2023-09-27 13:29:17 -07:00
Helen Cheuk 5ab9a57ec0 Merge "Fixed delay of thumbnail loading when going to overview from home" into main 2023-09-27 20:29:00 +00:00
Jagrut Desai 883ea7c72b Gesture Error Detection - Improvements Part 2
- Adding gesture error detection for ON_START_RECENTS_ANIMATION for to be getting callabck within time limit.

Bug: 293379641
Bug: 290266108
Test: Presubmit
Flag: not needed
Change-Id: I7d0f70c55dc44749218ff8d8427e71cd512d083c
2023-09-27 13:24:09 -07:00
Bill Yi 5986dfe2d5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6f49d0428e6d8fcb22ac648dbe81c039b1a80013
2023-09-27 13:17:02 -07:00
Holly Jiuyu Sun 01088a4001 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092 am: 564a0acda7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: I0ec7ee12bf09f7b7902915c28e22b5e923f5ac55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 19:44:28 +00:00
Vinit Nayak 909fe37472 Merge "Revert "Verifying that workspace looks correct at the end of the test."" into main 2023-09-27 18:42:25 +00:00
Holly Jiuyu Sun 564a0acda7 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: If4a73bc64242feec4786705603c5c128fc2cecba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 17:49:29 +00:00
Schneider Victor-tulias f055c25ec1 Merge "Clean up FeatureFlags.java" into main 2023-09-27 17:28:16 +00:00
Brandon Dayauon 602c43e90b Add maxWidth to pause work app button and ellipsize at the end
Width of text given by UX is 214dp so we can set the maxWidth and ellipsize at the end.

Bug: 298447370
Test: Manual photo: https://screenshot.googleplex.com/98Jnuh3TmLCtd24
Flag: n/a
Change-Id: I750a1669f94f22f60f4fb22db7d6b0ed7678c506
2023-09-27 16:23:07 +00:00
Holly Jiuyu Sun 6c3cd3c092 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev 2023-09-27 16:05:41 +00:00
helencheuk 9e142d3998 Fixed delay of thumbnail loading when going to overview from home
Some thumbnail snapshots show up slowly when GRID_ONLY_OVERVIEW is enabled because more thumbnails are displayed than before and some cache related code needs to be changed. This issue should be fixed for smooth user experience so all thumbnails could be shown quickly and at the same time.
Root causes and corresponding solution are as below:
1. No high resolution thumbnails are in cache when entering overview. It is either no cache at all or just low resolution cache
Solution: Preload when high resolution is enabled
2. The cache size is 3 which is not enough for tablet
Solution: Update cache size to 8 when it is tablet, and preload more if cache size increases. Remove least recent ones when cache size decreases

Fix: 271570416
Test: RecentsModelTest
Test: TaskKeyByLastActiveTimeCache
Test: TaskThumbnailCacheTest
Change-Id: I60003ca20942c256a0a1047678ea4368cd2520eb
2023-09-27 16:57:27 +01:00
Liran Binyamin 44bd688301 Merge "Let the bubble bar handle gestures over the bubble bar." into main 2023-09-27 15:39:16 +00:00
Winson Chung 1004399028 Merge "Reset the frozen recents list state prior to test runs" into main 2023-09-27 07:22:01 +00:00
Anushree Ganjam a338890357 Merge "Use SetFlagsRule instead of StaticMockitoRule for aconfigFlag." into main 2023-09-27 05:55:26 +00:00
Tracy Zhou a9194c54ef Repostion contextual buttons upon layout changes
Also make sure the contextual buttons are centered in its respective orientation

Fixes: 300849078
Test: Rotate around, and make sure the rotation button stays in the same corner
Change-Id: Ibc40739eff050f258b938ccf94c2056ed1ee596b
2023-09-26 19:09:59 -07:00
Anushree Ganjam 02c2bd3dcb Use SetFlagsRule instead of StaticMockitoRule for aconfigFlag.
Bug: 294913042
Test: Unit tests
Flag: ENABLE_TWOLINE_ALLAPPS
Change-Id: I04e9a95aff609a3ba8eefadc1dd247592f4419b9
2023-09-26 17:08:27 -07:00
Tracy Zhou aa366d03cd Merge "Fix wrong 3 button order in landscape mode sometimes" into main 2023-09-26 23:58:47 +00:00
Ats Jenk a54772832b Merge "Animate launching desktop from overview" into main 2023-09-26 23:20:46 +00:00
Android Build Coastguard Worker c966872075 Snap for 10865315 from 66072ca559 to udc-qpr1-release
Change-Id: Id5e2393821095a2d96bc45081f3752ef25e8498e
2023-09-26 23:19:15 +00:00
Vinit Nayak df751430bc Revert "Verifying that workspace looks correct at the end of the test."
This reverts commit 62e3b162ba.

Reason for revert: Possible culprit for b/301966780

Change-Id: Ice6babe404feeddf9f8b13ce2a6288005402c9cd
2023-09-26 15:19:20 -07:00
Brandon Dayauon cd460094ba Merge "Do a vertical check for two line text, if it clips dont show two line." into main 2023-09-26 22:16:37 +00:00
Schneider Victor-tulias 8d3d623bc7 Clean up FeatureFlags.java
Flag: not needed
Bug: 291651514
Test: not needed
Change-Id: I37d7ac39f5feddab303ccb3c3305e2e2b3b6bd3e
2023-09-26 17:25:33 -04:00
Charlie Anderson eb247042fc Merge "Clear Launcher workspace after ReorderWidgets test finishes." into main 2023-09-26 21:16:48 +00:00
Treehugger Robot 7e863a1284 Merge "Remove string concatenation uses with ActiveGestureLog" into main 2023-09-26 19:18:21 +00:00
Thales Lima 2efa84d5a5 Merge "Enable TEAMFOOD for ENABLE_RESPONSIVE_WORKSPACE flag" into main 2023-09-26 18:10:04 +00:00
Thales Lima f6cca37152 Merge "Migrate ENABLE_RESPONSIVE_WORKSPACE to aconfig" into main 2023-09-26 18:09:45 +00:00
Ats Jenk a24b63d644 Animate launching desktop from overview
Create a new controller that handles launching desktop from recents. It
creates a remote transition runner. Then notifies wmshell to show
desktop apps and use this remote runner to run the animation.

TODO:
- there are flickers in the animation

Bug: 297590571
Test: open an app on desktop, swipe up to overview, click on desktop
      tile
      open multiple apps on desktop, swipe up to overview, click on
      desktop tile

Change-Id: Ie8c9189bace77ba80e6be90222b3f786dfe5bb15
2023-09-26 10:39:49 -07:00
Winson Chung e5d9cc8855 Reset the frozen recents list state prior to test runs
- A quickswitch will freeze the spatial order of the recents list
  (to allow quickswitching back) for up to 5s, but this can affect
  runs of other tests due to the list being in the wrong order

Bug: 298544839
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep
Change-Id: I5d01991821c6b79ceac47fefffed60ef4a18b248
2023-09-26 17:33:09 +00:00
Charlie Anderson a8e277145d Clear Launcher workspace after ReorderWidgets test finishes.
This is to help prevent test crashes with workspace items out of place when using TestWorkspaceBuilder.
Adds ModelTestExtensions to move common methods for clearing Launcher DB.

Bug: 296620387
Test: running ReorderWidgets test
Flag: none
Change-Id: I677b1b8fa09aa13aee43651bf66d28ced410a681
2023-09-26 13:26:58 -04:00
Schneider Victor-tulias eaa495a864 Remove string concatenation uses with ActiveGestureLog
Flag: ENABLE_LONG_PRESS_NAV_HANDLE
Bug: 301953713
Test: checked logs
Change-Id: Id5c3bdf170fdb56305c585f1c34ec9a5310256b8
2023-09-26 16:12:32 +00:00
Liran Binyamin d7f1942d4a Let the bubble bar handle gestures over the bubble bar.
This change introduces a motion event flag to signal that the gesture
is being originated over the bubble bar (similar to the nav bar gesture flag). Downstream consumers use this flag to ignore the event in order
to allow the bubble bar to handle it.

The black screen in b/293348900 seemed to be related to the recents
shell transition closing the app that was in the foreground before
swiping on the bubble bar handle. Not sure why it ended up with a black
screen, but this change avoids starting the recents transition entirely.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/BSxLROoflr1i2yy0v6Y4G

Fixes: 294421126
Bug: 293348900
Test: Manual:
      - Add bubble to the bubble bar
      - Swipe up over the bubble bar
      - Observe that the bubble bar expands

      - Launch application
      - Swipe up on the bubble bar handle
      - Observe that the bubble bar expands

Change-Id: Iea15829de97edb6bfbfb7007388865230faaf736
2023-09-26 12:02:27 -04:00
Brandon Dayauon 3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Andy Wickham 136bdf80b3 Merge "Add some gesture logs" into udc-qpr-dev am: 66072ca559 am: c18764fce1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755061

Change-Id: I02949308dda86a905029fdcc21dcfb80dd91e3b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 01:27:39 +00:00
Holly Sun e292642489 Log toggle status for LPNH and LPH in Settings.
Bug: 295039461
Test: manual
Flag: PRESS_HOLD_NAV_HANDLE_TO_SEARCH. LONG_PRESS_HOME_BUTTON_TO_SEARCH
Change-Id: I380dd6f62378098edf063f29d10305b8c404f38d
2023-09-26 00:36:44 +00:00
Andy Wickham c18764fce1 Merge "Add some gesture logs" into udc-qpr-dev am: 66072ca559
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755061

Change-Id: Iabb40a2aaf81ac23121ec356b55c012da92348a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 00:31:56 +00:00
Automerger Merge Worker 27142036ca Merge changes from topic "am-44edb64d50f3467493dc6c418b2e5553" into udc-d1-dev-plus-aosp am: 9f12a840b5 am: d1b338b28c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24836996

Change-Id: I9e6fdd174a1b1722efefc57e36a846d200c8dec9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 00:01:04 +00:00
Bill Yi 538d5440e8 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: a9ca289869 -s ours am: d8ba8bbb23 -s ours am: e55bc38fa4 -s ours am: 58ed9686e7 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24836996

Change-Id: If20d90aeaf16cb3c05bd525a3fb5f821692ccbf1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 00:00:55 +00:00
Automerger Merge Worker 9c38789043 Merge changes from topic "am-87bc6609ac824e55ab12cde27de16be6" into udc-qpr-dev-plus-aosp am: a19ec25c87
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24836996

Change-Id: I2316441fdf7ae47e60d71f48ee1238bd1aed5f94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-25 23:57:59 +00:00
Bill Yi 9d1ac0b9e7 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: a9ca289869 -s ours am: 1e653ead9b -s ours am: 06017b537d -s ours am: fe2349706a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24836996

Change-Id: Ie97fe153f4aacc45e1823dc107032d861331dbdd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-25 23:57:49 +00:00
Andy Wickham 66072ca559 Merge "Add some gesture logs" into udc-qpr-dev 2023-09-25 23:54:20 +00:00
Automerger Merge Worker 35e4cefadc Merge changes from topic "am-4fd26709498342da93912fba9cfb0331" into udc-qpr-dev-plus-aosp am: e69a4e8934
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24836996

Change-Id: I7b67c03ccff4dcbc88cbcf95abe985223b705254
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-25 23:53:07 +00:00
Bill Yi b87333ff6b [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: a9ca289869 -s ours am: d8ba8bbb23 -s ours am: ec4b1a5de8 -s ours am: fc25180848 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24836996

Change-Id: I0995aceb7e8f687f668ba3ef0633e75588900600
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-25 23:52:56 +00:00