PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
78,507 Commits 1 Branch 0 Tags
eedc7ab8fdb94de05201fa87537991558accbe8a
Commit Graph

78507 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Hyunyoung Song 0a9c092c89 Fixing two critical bugs in all apps transition controller 
bug#1: if long press from page indicator region, you can pull up all apps
even though the workspace is in overview state.

bug#2: all apps should not intercept touch not only in overview mode
but also in any modal state.

Change-Id: I91c0a181f037f6c2465a983825da3a2da7e2920f
 2016-09-20 22:50:06 -07:00
Tony Wickham dbf08b4aee Stop jumping to workspace from hotseat on quick drop. 
Regression occurred in ag/1315317.

In that change, Launcher#enterSpringLoadedDragMode() was moved from
the end of startDrag() to the end of onDragStart(). This changed the
sequence of events from:

beginDragShared() --> DragController#startDrag() --> onDragStart -->
dropTarget.onDragOver() --> Launcher#enterSpringLoadedDragMode()

to:

beginDragShared() --> DragController#startDrag() --> onDragStart -->
Launcher#enterSpringLoadedDragMode() --> onDragOver()

Basically, the key difference is that onDragOver() is called after
enterSpringLoadedDragMode(). This matters, because onDragOver()
returns early if Workspace#transitionStateShouldAllowDrop() returns
false, which it does during the spring loaded transition. This meant
that onDragOver() didn't update the layout to be Hotseat, and thus
the current workspace page was used as default, since that is what
was set in onDragEnter(). To fix it, I've copied the logic in
onDragOver() that checks to see if the drag is over the hotseat first
to a new method that onDragEnter() now calls as well.

Bug: 31245181
Change-Id: Ie758921b25fc96516a09c32bdc9706da941522df
 2016-09-20 16:48:42 -07:00
Hyunyoung Song f09bfab404 Merge "Fix ExtendedEditText not handling touch correctly b/31555902" into ub-launcher3-calgary-polish 
am: 13c14c8f8c

Change-Id: I6dfc939480c54909e34e5ae6747bd22e86fa5368
 2016-09-20 21:50:27 +00:00
Hyunyoung Song c7be9c576e Fix ExtendedEditText not handling touch correctly b/31555902 
am: 3f9d647de6

Change-Id: I8222f4f386f3322d167bce070070bf473685d789
 2016-09-20 21:50:26 +00:00
Hyunyoung Song 13c14c8f8c Merge "Fix ExtendedEditText not handling touch correctly b/31555902" into ub-launcher3-calgary-polish 2016-09-20 21:10:35 +00:00
Tony Wickham a2757345fe Merge "When shortcuts close, only set text visible if not in hotseat." into ub-launcher3-calgary-polish 
am: 4125386687

Change-Id: I10a7cdd6b8eb49633afa4e07e0e1a184760786e5
 2016-09-20 21:05:18 +00:00
Tony Wickham daf30c1505 When shortcuts close, only set text visible if not in hotseat. 
am: 12624a5a17

Change-Id: I0c6fedcb89d626e3bddca98610ec3da808cdc68e
 2016-09-20 21:05:17 +00:00
Tony Wickham 4125386687 Merge "When shortcuts close, only set text visible if not in hotseat." into ub-launcher3-calgary-polish 2016-09-20 20:49:37 +00:00
Hyunyoung Song 3f9d647de6 Fix ExtendedEditText not handling touch correctly 
b/31555902

Change-Id: Ife23cf6af29ac47315aee4abc0ffe2dbcde352f9
 2016-09-20 12:37:41 -07:00
Shankhoneer Chakrovarty 687c345f9e Created include filters for jacoco 
Go to for report: https://cnsviewer.corp.google.com/ear/cns/on-d/home/android-test/kharon/shankh/world/test_logs/ub-launcher3-calgary/0/CodeCoverage/inv_5368912399306607305/coverage_8663315225010526892.ear/index.html
go to https://x20web.corp.google.com/users/sh/shankh/coverage/index.html for source code level code coverage statistics

Bug: 29882934

Change-Id: I397537f45ac4611e8a97d4656d0e7d2b694688fc
 2016-09-20 12:14:48 -07:00
Jonathan Miranda 62891bca45 Merge "Only reset search field when back key is hit if there is no query." into ub-launcher3-calgary-polish 
am: 6a7ca92f72

Change-Id: Ib3212c0a393d6e4ccf8e56a456b8642d10e65287
 2016-09-19 23:19:31 +00:00
Jon Miranda d450161a2e Only reset search field when back key is hit if there is no query. 
am: bb918b3532

Change-Id: Icc66e5fcd8686b4280f4e21be8e1e6464cf9d874
 2016-09-19 23:19:29 +00:00
Jonathan Miranda 1fd8f378a9 Merge "Add context to widget dimensions for accessibility." into ub-launcher3-calgary-polish 
am: 41be5cdea5

Change-Id: Ib40c4281cfa97daa006ee3a8e782f166cfcbeb00
 2016-09-19 23:19:14 +00:00
Jon Miranda f944860db6 Add context to widget dimensions for accessibility. 
am: 6c61323998

Change-Id: I5cd9cce4d842a17bafc68b31a09dcf0a62949c1e
 2016-09-19 23:19:13 +00:00
Jonathan Miranda 6a7ca92f72 Merge "Only reset search field when back key is hit if there is no query." into ub-launcher3-calgary-polish 2016-09-19 23:08:42 +00:00
Jonathan Miranda 41be5cdea5 Merge "Add context to widget dimensions for accessibility." into ub-launcher3-calgary-polish 2016-09-19 23:04:11 +00:00
Jon Miranda 018530c41e Uses a TransformingTouchDelegate to extend touch target for widgets list. am: 0ef81fdc22 
am: 48542731c5

Change-Id: Ia2bd1b6e5203f40ce3ef75a05712ee63ccfbf3e3
 2016-09-19 21:49:27 +00:00
Jon Miranda 48542731c5 Uses a TransformingTouchDelegate to extend touch target for widgets list. 
am: 0ef81fdc22

Change-Id: I33962020ff1cf75e46254c24687a53fd5b2088fa
 2016-09-19 21:43:54 +00:00
Jon Miranda 0ef81fdc22 Uses a TransformingTouchDelegate to extend touch target for widgets list. 
The widget row contents were being clipped, which made it seem like
the horizontal scroll was broken.

Bug: 30023607
Change-Id: I00b0c334bbb0faf166d4cd168392cc494ed732e0
 2016-09-19 13:08:43 -07:00
Jon Miranda 6c61323998 Add context to widget dimensions for accessibility. 
Bug: 19085860
Change-Id: Ia28c2c14b93945d796226eea3de040e971fd42f0
 2016-09-19 11:25:39 -07:00
Sunny Goyal 024cda77cc Merge "Updating the paddings in folder cell" into ub-launcher3-calgary-polish 
am: d1e5b5ceaa

Change-Id: I23ffc16834bab24d3874c204ea4131e95cf7d20e
 2016-09-19 16:39:23 +00:00
Sunny Goyal 290e9e2807 Updating the paddings in folder cell 
am: baec6ffae2

Change-Id: I4bfa78ade93639d3864baeeb5028b9caa3935c29
 2016-09-19 16:39:23 +00:00
Sunny Goyal d1e5b5ceaa Merge "Updating the paddings in folder cell" into ub-launcher3-calgary-polish 2016-09-19 16:33:40 +00:00
Jon Miranda bb918b3532 Only reset search field when back key is hit if there is no query. 
Bug: 31432372
Change-Id: I93c7ee661597f934402f464c4f0182a8fad38d39
 2016-09-19 09:31:56 -07:00
Hyunyoung Song 8260e0da8b Merge "Fixing issue where overview->normal workspace mode cannot be done by tapping b/31458165" into ub-launcher3-calgary-polish 
am: 80e6aa4b01

Change-Id: I07d8700dd8683100c59c8ecd5efedbb6465056c5
 2016-09-16 19:47:02 +00:00
Hyunyoung Song cbf371cddc Fixing issue where overview->normal workspace mode cannot be done by tapping b/31458165 
am: f99370c2a9

Change-Id: Id5c7b068fae21a2c4941390bf99db413581ede44
 2016-09-16 19:45:06 +00:00
Hyunyoung Song 80e6aa4b01 Merge "Fixing issue where overview->normal workspace mode cannot be done by tapping b/31458165" into ub-launcher3-calgary-polish 2016-09-16 19:34:40 +00:00
Sunny Goyal baec6ffae2 Updating the paddings in folder cell 
> Updating overall padding for the cell and adding drawable padding
> Ensuring that the folder cell is always rendered properly based
  on available vertical space

Bug: 30605958
Change-Id: I8ceb9fea5a25052b0d7461f52edca0e6a33fa085
 2016-09-16 12:05:02 -07:00
Hyunyoung Song f99370c2a9 Fixing issue where overview->normal workspace mode cannot be done by tapping 
b/31458165

Because workspaceInModalState makes the VerticalFlingDetector
to consume the touch input, click is not detected in Overview mode.

Placed pulldown to search behind a feature flag.

Change-Id: I31ab69f57944a18e6b264c4f2ed2d0c1175cd940
 2016-09-16 12:03:27 -07:00
Tony Wickham 5e4d87bec2 Merge "Don't close all apps when touching deep shortcuts container." into ub-launcher3-calgary-polish 
am: f595f3de0f

Change-Id: I46ea15877619d6a179e8a79401367e4f13873028
 2016-09-16 18:52:22 +00:00
Tony Wickham c145b55afa Don't close all apps when touching deep shortcuts container. 
am: 946f85060a

Change-Id: I5966cc024c9ac1e60ebb4ded18df8430dbc68513
 2016-09-16 18:52:21 +00:00
Tony Wickham f595f3de0f Merge "Don't close all apps when touching deep shortcuts container." into ub-launcher3-calgary-polish 2016-09-16 18:47:48 +00:00
Jonathan Miranda d9a7f8cc9d Merge "Fixed NumberFormatException when trying to display vector drawable." into ub-launcher3-calgary-polish 
am: 2fdd8f75c3

Change-Id: I5a7e48c6611f079813e83f2e2dfb95f6053f3e37
 2016-09-16 17:59:25 +00:00
Jon Miranda de70b2d5fd Fixed NumberFormatException when trying to display vector drawable. 
am: a802a62c47

Change-Id: Ibbcf9ad0160f299a661cd9429071738ae8f7a325
 2016-09-16 17:59:24 +00:00
Jonathan Miranda 2fdd8f75c3 Merge "Fixed NumberFormatException when trying to display vector drawable." into ub-launcher3-calgary-polish 2016-09-16 17:47:28 +00:00
Hyunyoung Song e7b437ed64 Merge "Set contentDescription on caret" into ub-launcher3-calgary-polish 
am: c1c6126745

Change-Id: I2893e95ee3d494ba5e19fb9ad02a1400f1d0f283
 2016-09-15 23:35:31 +00:00
Hyunyoung Song 859634d763 Set contentDescription on caret 
am: c5afad6eb9

Change-Id: Ibea35c8fe58d7db0bcbddb41ae6e24ef7804dde0
 2016-09-15 23:35:30 +00:00
Hyunyoung Song c1c6126745 Merge "Set contentDescription on caret" into ub-launcher3-calgary-polish 2016-09-15 23:31:37 +00:00
Hyunyoung Song c5afad6eb9 Set contentDescription on caret 
Change-Id: I1f66b96b3f94649d85857b0107144bb4070ef448
 2016-09-15 16:19:14 -07:00
Jon Miranda 51cf50acb6 Use ContextCompat.getColor to support API levels below 23. 
am: 488d8adeb8

Change-Id: I153c4d57effecf1a59bc92884e0da48660f84870
 2016-09-15 22:21:16 +00:00
Jon Miranda a802a62c47 Fixed NumberFormatException when trying to display vector drawable. 
Found while debugging on Lollipop.

Change-Id: Idb098d3a8f7f1fa608fd8a32225cdefa41ba47a7
 2016-09-15 15:07:44 -07:00
Jon Miranda 488d8adeb8 Use ContextCompat.getColor to support API levels below 23. 
Found while debugging on Lollipop.

Change-Id: Ibe97fd30c4ee8cd0c1735a41802b859345f9e931
 2016-09-15 15:05:12 -07:00
Sunny Goyal 590b54c017 Adding support for extending the touch target in the touchDelegate am: 1cc48e1d0c 
am: 9784572c47

Change-Id: I0ec99d77913f1c5d3d6da0ba6b667c830b2e8ce2
 2016-09-15 21:35:37 +00:00
Sunny Goyal 9784572c47 Adding support for extending the touch target in the touchDelegate 
am: 1cc48e1d0c

Change-Id: I29ce4b52a2b687f73b2db4ddb633210e905aad69
 2016-09-15 21:33:10 +00:00
Jon Miranda e0cfe60ecd Fix bug where page indicator animation repeats itself. 
am: 3f9d6278e3

Change-Id: Icb431b7c6cc1ea05c8d3e2e09a75f28956a9c15b
 2016-09-15 20:58:00 +00:00
Sunny Goyal 1cc48e1d0c Adding support for extending the touch target in the touchDelegate 
Bug: 31458312
Change-Id: Ic819bdede2776ff63ec17053cc1326415edc1ca0
 2016-09-15 13:37:13 -07:00
Jon Miranda 3f9d6278e3 Fix bug where page indicator animation repeats itself. 
Bug: 31501865
Change-Id: I0df77859b82b60fd0e50023e0f5690961850cf6c
 2016-09-15 12:40:18 -07:00
Hyunyoung Song ae02616a17 Pull down should start search. b/31458165 
am: 46133612b4

Change-Id: I1147a69e6dd9fbfb614b8740a30e6c840948435a
 2016-09-15 17:58:47 +00:00
Hyunyoung Song 46133612b4 Pull down should start search. 
b/31458165

Change-Id: If4821e3d89a05a00551af6a5209ebc1693a1389b
 2016-09-15 10:48:25 -07:00
Sunny Goyal 703bad8a26 Simplifying the startSearch call in launcher callbacks 
am: 6f28e71e94

Change-Id: I1f450940d01acc479b8363b3bd10eb7fe70ae249
 2016-09-13 22:03:06 +00:00