Commit Graph

78507 Commits

Author SHA1 Message Date
Brandon Dayauon 6c345f4d4c Fix text jumping from one line -> two line when scrolling
The issue this happens is because the paint letter spacing can change during checkForEllipsis()
so during vertical calculation for two line, set the paint letter spacing to the MIN_LETTER_SPACING that is used
in checkForELlipsis()

bug: 303319642
Test: After: https://drive.google.com/file/d/14YfmEWNpmllSAdLeUamUpewa8ljbqXAU/view?usp=sharing
before: https://drive.google.com/file/d/14Y_I-iuyOGHCr809AlqNL8o1IdFjk3_8/view?usp=sharing
Flag: disabled
Change-Id: I1f56a9e9d22ab45b0491e5fa65b5bfc5b10fc720
2023-10-04 16:44:03 -07:00
Sebastian Franco 547ddd4830 Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking
Removing testGetAppIconName since that behaviour is already tested.

I'm also using this change to remove the TISBinder rule since it's not
needed.

Bug: 302869930
Test: atest TaplTestsAllAppsIconsWorking
Change-Id: Ie6b4f801254ca69b2485fe574914a73f947fc434
2023-10-04 16:43:19 -07:00
Stefan Andonian 54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
Android Build Coastguard Worker 99922846b6 Snap for 10902624 from 6105891d36 to udc-qpr1-release
Change-Id: I37d8275d45d81575d913254de862956c0882c80d
2023-10-04 23:20:53 +00:00
Vinit Nayak ae3c5749ef Support fullscreen split selection launch for contextual
* Migrate animating split placeholder to fullscreen into
SplitAnimationController from RecentsView to consolidate
* Reset state from RecentsView via a callback

Fixes: 295457117
Test: Tapping on placeholder in overview and home works
as expected

Change-Id: Id9a74eddc134a0470110845b90729c05193a1f93
2023-10-04 16:05:03 -07:00
Vinit Nayak a6bf642d5a Add icon when launching widgets in split
* Load the icon in the BG (though it should be
cached), then run the animation in the FG

Test: Initiating split contextually with a widget
shows icon
Bug: 293935354
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Iab1f1e9965479b0f84c74c2a5ae6e272b9a5db3a
2023-10-04 16:05:02 -07:00
Holly Sun 1341610a8b [DMA] Add withFeature API in StatsLogManager.
Bug: 297405016
Test: manual
Flag: ENABLE_OSE_CUSTOMIZATIONS
Change-Id: I4b36f7ce98ad0370bc1e73f60d8d7f98a50e1ea3
2023-10-04 15:51:56 -07:00
Vadim Tryshev e8f7dd5a51 Merge "Further tightening leak detector checks" into main 2023-10-04 22:18:18 +00:00
Vadim Tryshev c116cee748 Further tightening leak detector checks
Some checks see 2 activities for some reason: Launcher and Overview.
Both active.
I'll have to decide what to do with these cases, but for now, I simply don't pass 'true' from places where this can happen.

When we have 2 activities:
Either Overview is present (and I guess we have to close it before the check) or the screenshot shows that there is no Overview, but internally, apparently, Overview activity is active and therefore, technically, is not leaked.
For the latter case, I may need to do some kind of investigation.
But for now, I'm tightening the check where there is no Overview.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1f1619093e0948b8112f29fd7e94facbf7093983
2023-10-04 22:18:12 +00:00
Sebastián Franco bd4776b095 Merge "Making sure window inset controller is not null" into main 2023-10-04 22:16:58 +00:00
Vadim Tryshev 174db38f34 Merge "Ignoring the whole fallback TaskView" into main 2023-10-04 22:15:17 +00:00
Anushree Ganjam 9a809d9121 Merge "Developer options should reflect the correct DeviceConfig value for ReleaseFlag." into main 2023-10-04 22:14:41 +00:00
Sebastián Franco de846f3d76 Merge "Moving testWidgets from TaplTestsLauncher3 to TaplWorkspaceTest" into main 2023-10-04 21:42:05 +00:00
Tony Wickham 94a0a58b37 Fix gestures for exclude-from-recents + translucent tasks
- If task is translucent and excluded, fade out as swipe up
  - Fade back in when re-launching live tile
- Ignore excluded tasks if there is another visible task,
  and use that underlying task during gesture instead.

Fixes: 299351175
Fixes: 300297333
Fixes: 302672319

Test: Invoke translucent + excluded app (e.g. expanded Volume
dialog) over another app, swipe to overview, quick switch, home

Change-Id: I5740afc4bf561d1a264bd132863ffc15f27d2b20
2023-10-04 20:23:07 +00:00
Sebastian Franco 2023b359b7 Making sure window inset controller is not null
In some cases the controller can be null if the view is no longer
connected to the window.

Also, this issue seems to only happen in cuttlefish instances so there
might be a weird behaviour going on there but in any case is good to check
for nulls.

Test: No testing require is only null checkin, just making sure it compiles.
Bug: 302869930
Change-Id: I88d6091b57293e9493385185bfeb3e470c9bad84
2023-10-04 13:18:18 -07:00
Brian Isganitis 8f3342967c Prevent NPE from changing all apps visibility in shared state.
Also setting to false in onCloseBegin since this is an earlier signal
than onClosed.

Test: Manual (regular + recreate by toggling dark theme)
Fix: 301705545
Flag: No
Change-Id: Ifb356d4f1346f7af15a375ad7b88d2d8be227328
2023-10-04 15:32:37 -04:00
fbaron f96f7fef4b Add flag for smartspace removal toggle
cherry-picked from udc-qpr CL

Bug: 303471576
Flag: no flag
Test: none
Change-Id: I0eefb229f0c9544b92d8e8db564129990ab7d65b
2023-10-04 19:27:31 +00:00
Bill Yi a1ea984654 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6105891d36 -s ours am: 33ed0d9421 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24934922

Change-Id: I13abe6aa62cfcb905d2e04a95efe12df55a2c85e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-04 19:23:56 +00:00
Federico Baron fe60ac4f26 Merge "Add flag check for SMARTSPACE_AS_A_WIDGET to loadertask.java" into main 2023-10-04 19:14:13 +00:00
Bill Yi 33ed0d9421 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6105891d36 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24934922

Change-Id: I97348c628a64dca66df635d453d77d6f425fb9c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-04 19:09:22 +00:00
Brian Isganitis d5684000f9 Have dragged search items return to All Apps icon if cancelled.
Test: Manual
Fix: 303302706
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: Id2a06b38a987566b8e334125a050196a2845921e
2023-10-04 15:03:59 -04:00
Anushree Ganjam 9eb68bb7cf Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
2023-10-04 11:43:58 -07:00
Schneider Victor-tulias 3dd2c1732c Merge "Fix flaky key event expectation in KeyboardQuickSwitch" into main 2023-10-04 18:16:35 +00:00
Sebastian Franco fd96b78d14 Moving testWidgets from TaplTestsLauncher3 to TaplWorkspaceTest
Also, I'm taking advange of this change to update the name of
OopTaplOpenCloseAllApps to follow the standard TaplOpenCloseAllApps
and I'm also moving testPressBack to TaplOpenCloseAllApps since is
similar to the other methods in that class.

Bug: 298234173
Test: atest TaplWorkspaceTest

Change-Id: Ie933828baedf48b45e55f20853e238ecc6a594bd
2023-10-04 10:21:43 -07:00
fbaron 22a9c3cb7f Add flag check for SMARTSPACE_AS_A_WIDGET to loadertask.java
Missing a flag check that is necessary in LoaderTask.java to prevent the code from running when the flag is off.

Bug: 300140279
Flag: SMARTSPACE_AS_A_WIDGET
Test: no test
Change-Id: Iaa89e8542475eb01f679f70734a61c13a3cde89f
2023-10-04 10:19:46 -07:00
Federico Baron 48a9a3d198 Merge "Cleanup SHOW_DOT_PAGINATION flag" into main 2023-10-04 17:00:45 +00:00
Schneider Victor-tulias 0da65fa7a4 Fix flaky key event expectation in KeyboardQuickSwitch
- Add some missing event checks
- Wait until the device has fully settled before unpressing the key code

Flag: not needed
Fixes: 303252187
Test: TaplTestsKeyboardQuickSwitch
Change-Id: Iecc27d6f603d76b5d7c906ec6f703df13c275073
2023-10-04 16:15:59 +00:00
Brandon Dayauon 39276d643b Merge "Make DISPLAY_SEARCH_RESULT_SMALL not badged" into main 2023-10-04 16:13:10 +00:00
Uwais Ashraf e61ad56098 Align empty recents message+icon to center of View.
Seems like it was previously aligned to center of task which doesn't always look good.

Screenshots:
Handheld before - https://screenshot.googleplex.com/6GmqhTjUhUpwwBs
Handheld after - https://screenshot.googleplex.com/3QMYCQaS6USMQYy

Tablet before - https://screenshot.googleplex.com/7tsERFGVsa6QSNY
Tablet after - https://screenshot.googleplex.com/8itDgQ2jDTHk463

Unfolded before - https://screenshot.googleplex.com/AJaqC9LqP2Dwfz2
Unfolded after - https://screenshot.googleplex.com/8aaa7ZhemqHXHRh

Fix: 299100892
Test: OverviewEmptyMessageImageTest and observed on tablet, handheld and unfolded.
Change-Id: I538d25e5a98e25351e71718de3ca572fd00438ad
2023-10-04 14:57:11 +00:00
Bill Yi 6105891d36 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If4ad039f050e4561270ff10218401060c3f94362
2023-10-03 22:14:28 -07:00
Tracy Zhou b1122a4ad3 Merge "Fix some merge issues in repositioning contextual buttons for taskbar/navbar unification" into main 2023-10-04 04:00:24 +00:00
Vadim Tryshev 980769a857 Ignoring the whole fallback TaskView
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I9f8dad8ab2beebfcf37d0035096a5747a314c20a
2023-10-03 18:45:58 -07:00
Jeremy Sim 4986aa85e5 Merge "App Pairs: App pairs now save with automatic default name and custom split ratios" into main 2023-10-04 00:06:57 +00:00
Jagrut Desai 0dce287a6c Change Taskbar Window height logic for taskbar pinning.
- Breakout CL part 6
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl makes default taskbar window height to be transient when the taskbar pinning flag is on, so we don't see taskbar window cutoff during animation.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I37e8ad0f2c4d144476828f101019dcacdea7acb2
2023-10-03 16:53:32 -07:00
Android Build Coastguard Worker 110ffbd34d Snap for 10896666 from bcac59d6ea to udc-qpr1-release
Change-Id: I304b3c605e4559fe4e9cf4438df5bee3c69b9e0e
2023-10-03 23:19:25 +00:00
Brian Isganitis a9928faea8 Merge "Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to droidfood." into main 2023-10-03 22:05:15 +00:00
fbaron 80b0ce819c Cleanup SHOW_DOT_PAGINATION flag
Fix: 270395278
Flag: no flag
Test: verify everything still works the same
Change-Id: I803d9c22ac4c7040c47410b97cbdb2b11e33e8c9
2023-10-03 21:59:02 +00:00
Federico Baron 80c138f293 Merge "Add smartspace as a widget to first page (implementation 2)" into main 2023-10-03 21:57:54 +00:00
Fengjiang Li d31f9080aa Merge "Fix All Apps Icons Count estimation" into main 2023-10-03 21:57:36 +00:00
Fengjiang Li 0c740c774e Merge "[Launcher] Fix launcher startup logging" into main 2023-10-03 21:26:39 +00:00
Vadim Tryshev 23825e84a8 Merge "Tearing down the test safely." into main 2023-10-03 21:02:51 +00:00
Ats Jenk eb143041fa Enable live tile for desktop
Remove logic to always screenshot desktop tasks.

Bug: 297590571
Test: swipe up to recents when on desktop
Change-Id: Ie6e95f711e1721f66a2ed6081fe99d941c18b393
2023-10-03 13:52:46 -07:00
Brian Isganitis 06139e079c Migrate Kotlin tests to use mockito-kotlin2.
Test: atest
Bug: 300509464
Flag: No
Change-Id: I5e0d0f1f29d51cdbfacd51f7229afddf8bd66f7e
2023-10-03 16:04:19 -04:00
Brian Isganitis 26e1ff58ca Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to droidfood.
Test: Manual
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I02a492af320775404603d939b405764eff61d8a1
2023-10-03 14:12:19 -04:00
Liran Binyamin 5bec1164b9 Merge "Make the bubble bar flag dynamic in Launcher." into main 2023-10-03 17:47:11 +00:00
Jeremy Sim 6ac8949fc4 App Pairs: App pairs now save with automatic default name and custom split ratios
[App Pairs 4/?]

This patch includes:
- Ability to save and launch app pairs with custom 0.3, 0.7, or 0.5 split ratios
- App pairs now save with default name "App1 | App2"
- Grid migration, prediction, and other misc. flows should now work with app pairs

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: AppPairsControllerTest.java
Change-Id: I46dd3e30f8de03dd3e6d086c8ff9fc52e7e7fd2b
2023-10-03 10:38:03 -07:00
Federico Baron 769fa53481 Merge "Cleanup LARGE_SCREEN_WIDGET_PICKER flag" into main 2023-10-03 17:26:53 +00:00
Federico Baron bf5757c334 Merge "Cleanup ENABLE_DOWNLOAD_APP_UX_V3 and ENABLE_DOWNLOAD_APP_UX_V2" into main 2023-10-03 17:25:55 +00:00
Sunny Goyal 81039b2d73 Removing unused interfaces from Launcher
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: Ia042805080bd314efff5a9bb4877f4f830fb3998
2023-10-03 10:19:39 -07:00
Fengjiang Li 6c59082697 Fix All Apps Icons Count estimation
We used to estiamte more all apps icons to pre-inflate than needed. This would reduce the post boot memory useage.

Test: Grab heap dump after device boot to verify number of BubbleTextView is reduced
Bug: 297352492
Change-Id: Ice3950b781fe7b5d7df2c0c5c7b7a316b5851bc7
2023-10-03 10:16:30 -07:00