PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
78,507 Commits 1 Branch 0 Tags
eedc7ab8fdb94de05201fa87537991558accbe8a
Commit Graph

78507 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Schneider Victor-tulias 1066c74f0f Clean up NPEs in AbsSwipeUpHandler 
AbsSwipeUphandler has many potential and common NPEs. Added null checks to AbsSwipeUpHandler

Flag: NONE
Fixes: 307708536
Fixes: 307624168
Test: ran and restarted launcher
Change-Id: I0536612bfb36b4d912155158237fdb2e4fa33126
 2023-10-27 11:27:21 -04:00
Luca Zuccarini 8209517c2c Revert "Reuse the main depth controller for launch animations." 
This reverts commit ff2b38e366.

Reason for revert: Caused jank regressions: b/307779813, b/307766171.

Change-Id: I3d513196f9fd8f0768affdda73c0ab8924790037
 2023-10-27 12:24:08 +00:00
Anushree Ganjam cb571daa0b Read LPNH touch slop percentage and timeout ms from DeviceConfig. 
Make CUSTOM_LPNH_THRESHOLDS as a ReleaseFlag so this can be enabled from
server for experiments since touch slop percentage and timeout are
applied only when CUSTOM_LPNH_THRESHOLDS is enabled.

Add FeatureFlags for LPNH slop multiplier is "lpnh_slop_percentage" and LPNH timeout is "lpnh_timeout_ms"

Bug: 301680992
Flag: Legacy CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual

Change-Id: Ifd066b8cb8521dceb7aa12d9e46f5b7cfce1ec7f
 2023-10-26 19:03:40 -07:00
Jagrut Desai b10f2a3d03 Refactor TaskbarActivityContext#applyDeviceProfile 
Test: presubmit
Bug: 308024141
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Ic0ecc80f9b61910a917b93cbe62139e2c5d0d9d2
 2023-10-26 16:12:12 -07:00
Jagrut Desai 24231d9994 Merge "Taskbar pinning animation with no recreate" into main 2023-10-26 21:33:41 +00:00
Stefan Andonian 634bb805bb Do DbMigration if coming from a DB w/ version < 31 
This was the issue that is causing the launcher to crash when changing a
grid layout. The migration is not happening, causing there to be 21
columns in the database. When the grid size changes, and the db from
grid size X is migrated to a db of grid size Y, the column count isn't
matching.

Bug: 304687723
Test: Verified behavior through unit test.
Change-Id: I2ee1f2fe09db432715b22c41581a77f6b0ac8320
 2023-10-26 20:29:22 +00:00
Jeremy Sim 3303704c70 Fix bug with TAPL tests not recognizing full height/width of split tasks 
Previously, OverviewTask was only using one task tile to calculate its visible bounds. In the case of split tasks, this sometimes returned a wrong value.

Fixed by changing getVisibleHeight() to calculate height differently if the task is split.

Bug: 307853547
Test: Tests still pass, upcoming changes (ag/25143701) are unblocked.
Flag: N/A
Change-Id: I78221bafd8069275987c310ab05e0ed9e9cd4aa7
 2023-10-26 12:43:15 -07:00
Weng Ng dd16853be4 Add attribute for NO_FULFILLMENT. 
Bug: 305752409
Test: Manual
Flag: Not needed (proto extension).
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3846935101f653fc848653f224c4c35a27d29083)
Merged-In: Ibb6bf11e42f59f22f625f00f7f085279a41d961c
Change-Id: Ibb6bf11e42f59f22f625f00f7f085279a41d961c
 2023-10-26 18:20:19 +00:00
Jagrut Desai 631b284836 Taskbar pinning animation with no recreate 
Test: Manual, Visual
Bug: 265436799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED

Change-Id: I84a4d1efdb0bd4a0f856fa1f46b6489ef54a3841
 2023-10-26 10:36:48 -07:00
Pat Manning 821bc0d034 Merge "Clean up overview icon menu flag after tests and refresh device profile." into main 2023-10-26 16:00:48 +00:00
Alex Chau 9f2bc12884 Update feature bug for responsive grid 
Bug: 302189128
Test: None
Flag: None
Change-Id: Id07a500225d6f105d35c339cbdbd662f0fbf9512
 2023-10-26 13:59:24 +01:00
Pat Manning 999af9cab9 Clean up overview icon menu flag after tests and refresh device profile. 
Fix: 306089019
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Change-Id: I04335967e6bfa52d143a399859e2e745d428ab30
 2023-10-26 12:02:40 +01:00
Tracy Zhou 0f7a74a219 Merge "Add task bar window of TYPE_NAVIGATION_BAR when FLAG_HIDE_NAVBAR_WINDOW is on" into main 2023-10-25 23:45:33 +00:00
Vinit Nayak 0fcd231173 Merge "Use aconfig flag enable_split_contextual" into main 2023-10-25 23:19:27 +00:00
Tracy Zhou f767c86896 Add task bar window of TYPE_NAVIGATION_BAR when FLAG_HIDE_NAVBAR_WINDOW is on 
Bug: 304426019
Test: manual
Change-Id: I0c09e57db5a9bf6391605d5ec667cf12c96a2042
 2023-10-25 14:54:01 -07:00
Andy Wickham 49ae8bd240 Merge "Synchonizes touch slop across input consumers" into main 2023-10-25 21:01:01 +00:00
Tracy Zhou 867f7f8360 Merge "Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig" into main 2023-10-25 17:45:09 +00:00
Schneider Victor-tulias 927c78f2c6 Merge "Fix NPE in overview action buttons" into main 2023-10-25 14:10:45 +00:00
Uwais Ashraf 6eb006ed90 Merge "Add margins to top and bottom when grid only overview enabled" into main 2023-10-25 13:53:24 +00:00
Pat Manning 93f8778da2 Merge "Go home before getting overview in test to ensure overview will exist." into main 2023-10-25 10:37:01 +00:00
Thales Lima 7275322cf0 Merge changes from topic "handheld_landscape" into main 
* changes:
  Remove app labels in isVerticalBar
  Decrease text size if it doesn't fit the cell
 2023-10-25 10:13:58 +00:00
Tracy Zhou d313ee0c35 Do not animate icon alignment in phone mode 
With the existing code, there is a rare case that mIconAlignControllerLazy is
set from unfolded state, and then go to small screen, and we will reuse mIconAlignControllerLazy to animate, only to find out that scaleX for the icon view is infinity. Instead, we should unset mIconAlignControllerLazy in phone mode.

Fixes: 274517647
Test: manual
Change-Id: I3200761e5f4c6df0d89744f22e38bfe7fc7846cc
 2023-10-24 21:50:22 -07:00
Tracy Zhou 00f9e52575 Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig 
Bug: 274517647
Test: manual
Change-Id: I29fe58691440ee757c9f391bd574ef80eefb5ae6
 2023-10-24 18:42:15 -07:00
Vinit Nayak a1be4c1123 Use aconfig flag enable_split_contextual 
Bug: 276361926
Test: Basic split contextual operations work
as expected

Change-Id: I7202654f8452a0c57e5e728c9baaadf85fa22a96
 2023-10-25 01:37:17 +00:00
Jeremy Sim 001a0f1cc0 Merge "Prevent app pairs rank from resetting on Launcher model reload" into main 2023-10-25 00:12:20 +00:00
Anushree Ganjam b582e480c0 Merge "Add launcher_search.aconfig in launcher3." into main 2023-10-24 21:21:29 +00:00
Sunny Goyal 7955bd97df Merge "Simplifying settings activity" into main 2023-10-24 20:13:17 +00:00
Charlie Anderson c8ac1b41f7 Merge "Adds unit tests for AppWidgetsRestoredReceiver" into main 2023-10-24 19:39:18 +00:00
Sunny Goyal 6eb256d794 Simplifying settings activity 
> Removing multiple fragments
> Exposing support to select preference root
> Adding support for recreating preferences
> Moving Developer options to same fragment

Bug: 305084752
Flag: N/A
Test: Manual
Change-Id: I499be1938ef8ed58cbc7f9b0f4ad3510d4b306c8
 2023-10-24 11:40:12 -07:00
Uwais Ashraf aa7fa886d6 Add margins to top and bottom when grid only overview enabled 
Fix: 299100244
Test: OverviewImageTest and dump tests
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I22ebced5bf1e27974036d6e2ef72d2b8d63df824
 2023-10-24 16:15:39 +00:00
Luca Zuccarini d2a74bad68 Merge "Clean up ENABLE_KEYBOARD_TRANSITION_SYNC flag." into main 2023-10-24 14:58:37 +00:00
Pat Manning 3a2fde4db4 Go home before getting overview in test to ensure overview will exist. 
Also when opening settings, do not wait for A11Y event which never fires. (added in ag/24777489, but seems to fail as mentioned here b/303329286#comment2 and tracked here b/298114205)

Fix: 307379525
Fix: 307397957
Bug: 298114205
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Test: TaplOverviewIconTest
Change-Id: Icd8a47b47d22ddb32db7df6882ec655f0e6f54c1
 2023-10-24 14:43:11 +00:00
Luca Zuccarini d7e3d8ab90 Merge "Reuse the main depth controller for launch animations." into main 2023-10-24 14:31:20 +00:00
Schneider Victor-tulias a028cd11ba Fix NPE in overview action buttons 
Flag: N/A
Fixes: 305894735
Test: pressed screenshot overview action button shortly before/after dismissing the current task
Change-Id: Ife93fa9af5416af60cf8ae24275f14bd6857901a
 2023-10-24 14:13:39 +00:00
Luca Zuccarini 2bb6abadd7 Clean up ENABLE_KEYBOARD_TRANSITION_SYNC flag. 
Fix: 297592348
Flag: NA
Test: manual
Change-Id: I995acd511a3c7ebc630aaac977f8c380ddfa445f
 2023-10-24 13:12:38 +00:00
Thales Lima bba07729b2 Remove app labels in isVerticalBar 
Bug: 296400197
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Ia508c1b909df3fff5768b39e90275bf914b6f1c4
 2023-10-24 13:07:22 +00:00
Thales Lima 24ceca6993 Decrease text size if it doesn't fit the cell 
Bug: 293467738
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: Ic0b2d3cde1d4b8b9089f93b96c9bb386247603ce
 2023-10-24 13:07:22 +00:00
Tracy Zhou fbc8b715c3 Merge "Null check on RecentsView for endLiveTile" into main 2023-10-24 04:26:35 +00:00
Jeremy Sim 5ff90cd057 Prevent app pairs rank from resetting on Launcher model reload 
This fixes a bug where app pairs rank was mistakenly reset upon Launcher reload, causing app pairs to launch with the wrong ratio.

Bug: 274835596
Test: App pairs restore properly even after Launcher restart
Flag: ENABLE_APP_PAIRS
Change-Id: I5d37190cd994628886f77e089c71fc5e5dddc03e
 2023-10-24 00:37:52 +00:00
Tracy Zhou 7cf1884d92 Null check on RecentsView for endLiveTile 
Fixes: 304914019
manual: N/A
Change-Id: I6c6e3f0f52e57589f71b3c63debac21734fc88bf
 2023-10-23 17:17:42 -07:00
Jordan Silva 4d95f79db5 Merge "Create a new test suite for screenshot tests" into main 2023-10-23 22:46:11 +00:00
Anushree Ganjam b4be116782 Merge "Add arguments for flag_check.py." into main 2023-10-23 21:43:50 +00:00
Anushree Ganjam e1e71191dc Add launcher_search.aconfig in launcher3. 
Add enable_private_space in launcher_search.aconfig.

Bug: 306187906
Flag: Aconfig enable_private_space Development
Test: NA
Change-Id: Icaddc2d8f746618ff645e968b400afc971c31e59
 2023-10-23 14:39:46 -07:00
Saumya Prakash c14d48c214 Merge "Check status of mEdgeBackGestureHandler to prevent NPE" into main 2023-10-23 20:22:54 +00:00
Bill Yi cddae354db [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e98d49f10b -s ours am: ff04b9a5ff -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25121533

Change-Id: Ifcbc6d794ab32caae150fc6cc4a157676e781e02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-10-23 19:57:15 +00:00
Bill Yi ff04b9a5ff [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e98d49f10b -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25121533

Change-Id: Ie4c61e455a4044cbcbc3ce5898456d99087fef6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-10-23 19:36:20 +00:00
Bill Yi 895262a992 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-23 19:08:18 +00:00
Tracy Zhou 9070b93f40 Merge "Do not show task bar edu in folded state with task bar / nav bar unification" into main 2023-10-23 18:34:30 +00:00
Brandon Dayauon f2b2202bd8 Fix the badge in badge (triple badging), by simply removing the user badge (FLAG_SKIP_USER_BADGE). 
This is used in the bigIconRow where we remove the workBadge in the icon and put the icon after the title in BIG_ICON_ROW.

bug:276957152
Flag: n/a
Test: manual -
before: https://screenshot.googleplex.com/BXShenE2kGrZXtF
after: https://screenshot.googleplex.com/AVYxpDyJ7JGet8h

Change-Id: Icefb9c8192d9841c95c8f6d628026f336e0b7195
 2023-10-23 11:33:31 -07:00
Pat Manning 1f5d5be70d Merge "Move overview tests to quickstep package." into main 2023-10-23 18:26:38 +00:00